5:42 p.m.
Order files loaded by the SARDeployer
-------------------------------------
Key: JBAS-5467
URL: http://jira.jboss.com/jira/browse/JBAS-5467
Project: JBoss Application Server
Issue Type: Feature Request
Security Level: Public (Everyone can see)
Components: System service
Reporter: Brian Egge
Assigned To: Dimitris Andreadis
Priority: Optional
Java's File.listFiles returns files in a not always consistent order. This can be
seen by listing a large directory on different platforms, or even on the same platform.
Specifically, on Solaris we had copied the deploy directory, and found the behavior of our
app changed. This was due to two jar files having different versions of the same class.
Always loading files in the same order would reduce the chance of the order randomly
changing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:44 p.m.
New subject: [JBoss JIRA] Updated: (JBAS-5467) Order files loaded by the SARDeployer
[ http://jira.jboss.com/jira/browse/JBAS-5467?page=all ]
Brian Egge updated JBAS-5467:
-----------------------------
Attachment: sardeployer-sorting.diff
Patch to sort the files to be loaded.
Order files loaded by the SARDeployer
-------------------------------------
Key: JBAS-5467
URL: http://jira.jboss.com/jira/browse/JBAS-5467
Project: JBoss Application Server
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: System service
Reporter: Brian Egge
Assigned To: Dimitris Andreadis
Priority: Optional
Attachments: sardeployer-sorting.diff
Original Estimate: 15 minutes
Remaining Estimate: 15 minutes
Java's File.listFiles returns files in a not always consistent order. This can be
seen by listing a large directory on different platforms, or even on the same platform.
Specifically, on Solaris we had copied the deploy directory, and found the behavior of our
app changed. This was due to two jar files having different versions of the same class.
Always loading files in the same order would reduce the chance of the order randomly
changing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:50 a.m.
New subject: [JBoss JIRA] Commented: (JBAS-5467) Order files loaded by the SARDeployer
[ http://jira.jboss.com/jira/browse/JBAS-5467?page=comments#action_12409732 ]
Dimitris Andreadis commented on JBAS-5467:
------------------------------------------
I don't think it's the SARDeployer to decide to file order. Have you looked at the
DeploymentSorter used by the deployment scanner?
Order files loaded by the SARDeployer
-------------------------------------
Key: JBAS-5467
URL: http://jira.jboss.com/jira/browse/JBAS-5467
Project: JBoss Application Server
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: System service
Reporter: Brian Egge
Assigned To: Dimitris Andreadis
Priority: Optional
Attachments: sardeployer-sorting.diff
Original Estimate: 15 minutes
Remaining Estimate: 15 minutes
Java's File.listFiles returns files in a not always consistent order. This can be
seen by listing a large directory on different platforms, or even on the same platform.
Specifically, on Solaris we had copied the deploy directory, and found the behavior of our
app changed. This was due to two jar files having different versions of the same class.
Always loading files in the same order would reduce the chance of the order randomly
changing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:53 a.m.
New subject: [JBoss JIRA] Commented: (JBAS-5467) Order files loaded by the SARDeployer
[ http://jira.jboss.com/jira/browse/JBAS-5467?page=comments#action_12409757 ]
Brian Egge commented on JBAS-5467:
----------------------------------
This isn't for deployments, but rather when the micro-kernel loads the jars in the lib
directory. The deployment order once the micro-kernel is loaded is well defined and easy
to customize, however, the lib directory isn't. Obviously, one should be filling up
the JBoss lib directory with dependencies, but rather include those with the war/ear
file.
Regardless, if you look at the code, it returns a list of files. The order which they are
returned is system dependent. Sorting them will help ensure JBoss runs the same on
multiple platforms. Other functions like FileUtils.listDirectory would become more
stable.
Order files loaded by the SARDeployer
-------------------------------------
Key: JBAS-5467
URL: http://jira.jboss.com/jira/browse/JBAS-5467
Project: JBoss Application Server
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: System service
Reporter: Brian Egge
Assigned To: Dimitris Andreadis
Priority: Optional
Attachments: sardeployer-sorting.diff
Original Estimate: 15 minutes
Remaining Estimate: 15 minutes
Java's File.listFiles returns files in a not always consistent order. This can be
seen by listing a large directory on different platforms, or even on the same platform.
Specifically, on Solaris we had copied the deploy directory, and found the behavior of our
app changed. This was due to two jar files having different versions of the same class.
Always loading files in the same order would reduce the chance of the order randomly
changing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:28 p.m.
New subject: [JBoss JIRA] Commented: (JBAS-5467) Order files loaded by the SARDeployer
[
https://jira.jboss.org/jira/browse/JBAS-5467?page=com.atlassian.jira.plug...
]
Brian Egge commented on JBAS-5467:
----------------------------------
This issue caused us a problem again.
We have a deployer script which instead of replacing files, renames them
".backup...". JBoss had been loading both the new file and the .backup file in
the lib directory. I.e., lib/hibernate.jar; lib/.backup-hibernate.jar. This problem
remained hidden until the JBoss server was copied to another directory. After being
moved, it started loading the older files first.
Should we have multiple copies of jars in our lib directory? No, obviously this is a
problem on our part. Should moving the directory cause a working deployment to stop
working? In my opinion, no, the app server should function in a consistant manner
regardless of hardware or the physical ordering of the files.
Unfortunately, we don't build our JBoss servers, but instead insist on running a
version for which a support contact is available. As such, we can't just patch our
own copy and ignore the issue.
I might be wrong about the class, but I'm pretty sure the micro-kernel uses it when it
load the jars in the server's lib directory. Files in the deploy directory do get
loaded in a defined order, but not those in the lib directory.
Here's the specific method, for which the patch applies.
protected File[] listFiles(final String urlspec) throws Exception
{
URL url = Strings.toURL(urlspec);
// url is already canonical thanks to Strings.toURL
File dir = new File(url.getFile());
File[] files = dir.listFiles(new java.io.FileFilter()
{
public boolean accept(File pathname)
{
String name = pathname.getName().toLowerCase();
return (name.endsWith(".jar") ||
name.endsWith(".zip"));
}
});
return files;
}
Order files loaded by the SARDeployer
-------------------------------------
Key: JBAS-5467
URL: https://jira.jboss.org/jira/browse/JBAS-5467
Project: JBoss Application Server
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: System service
Reporter: Brian Egge
Assignee: Dimitris Andreadis
Priority: Optional
Attachments: sardeployer-sorting.diff
Original Estimate: 15 minutes
Remaining Estimate: 15 minutes
Java's File.listFiles returns files in a not always consistent order. This can be
seen by listing a large directory on different platforms, or even on the same platform.
Specifically, on Solaris we had copied the deploy directory, and found the behavior of our
app changed. This was due to two jar files having different versions of the same class.
Always loading files in the same order would reduce the chance of the order randomly
changing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6523
days inactive
6671
days old
4 comments
2 participants
participants (2)
-
Brian Egge (JIRA) -
Dimitris Andreadis (JIRA)