[JBoss JIRA] Created: (JBRULES-2522) JPAVariablePersister will not work when @Id is declared on a superclass
5:45 p.m.
JPAVariablePersister will not work when @Id is declared on a superclass
-----------------------------------------------------------------------
Key: JBRULES-2522
URL: https://jira.jboss.org/browse/JBRULES-2522
Project: Drools
Issue Type: Bug
Security Level: Public (Everyone can see)
Affects Versions: 5.1.0.M1
Reporter: Julien Serdaru
Assignee: Mark Proctor
Given A and B:
@MappedSuperclass
public class A {
@Id
@GeneratedValue(strategy = GenerationType.AUTO)
private Long id = null;
}
@Entity
public class B extends A {
// Some other fields
}
In JPAVariablePersister:getClassIdValue, a lookup is done on the entity fields to
autodetect the @Id annotation, which fails in this case since the method uses
getDeclaredFields() instead of getFields():
private Long getClassIdValue(Object o) throws NoSuchMethodException,
SecurityException, IllegalAccessException,
InvocationTargetException, IllegalArgumentException {
Field[] fields = o.getClass().getDeclaredFields(); <-- THIS ONLY RETURNS THE LOCAL
FIELDS, NOT THE SUPERCLASS.
...
return idValue;
}
Replacing getDeclaredFields() by getFields() should fix the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:45 a.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2522) JPAVariablePersister will not work when @Id is declared on a superclass
[
https://jira.jboss.org/browse/JBRULES-2522?page=com.atlassian.jira.plugin...
]
Julien Serdaru updated JBRULES-2522:
------------------------------------
Description:
Given A and B:
@MappedSuperclass
public class A {
@Id
@GeneratedValue(strategy = GenerationType.AUTO)
private Long id = null;
}
@Entity
public class B extends A {
// Some other fields
}
In JPAVariablePersister:getClassIdValue, the code introspects the entity class to
autodetect the @Id annotation. The code fails in this case since the annotation is
declared on the superclass, and the current implementation only loops on the local fields
of class B.
I tested the following implementation of getClassIdValue to work (loop on parent class
objects)
private Long getClassIdValue(Object o)
throws NoSuchMethodException, SecurityException,
IllegalAccessException, InvocationTargetException,
IllegalArgumentException {
Class<?> c = o.getClass();
Long idValue = null;
do {
Field fields[] = c.getDeclaredFields();
for (int i = 0; i < fields.length; i++) {
Id id = fields[i].getAnnotation(Id.class);
if (id != null) {
idValue = (Long) o.getClass().getMethod(
"get"
+ Character.toUpperCase(fields[i]
.getName().charAt(0))
+ fields[i].getName().substring(1),
new Class<?>[] {}).invoke(o,
new Object[] {});
break;
}
}
} while ((c = c.getSuperclass()) != null && idValue == null);
return idValue;
}
was:
Given A and B:
@MappedSuperclass
public class A {
@Id
@GeneratedValue(strategy = GenerationType.AUTO)
private Long id = null;
}
@Entity
public class B extends A {
// Some other fields
}
In JPAVariablePersister:getClassIdValue, a lookup is done on the entity fields to
autodetect the @Id annotation, which fails in this case since the annotation is declared
on the superclass.
I tested the following implementation of getClassIdValue to work:
private Long getClassIdValue(Object o)
throws NoSuchMethodException, SecurityException,
IllegalAccessException, InvocationTargetException,
IllegalArgumentException {
Class<?> c = o.getClass();
Long idValue = null;
do {
Field fields[] = c.getDeclaredFields();
for (int i = 0; i < fields.length; i++) {
Id id = fields[i].getAnnotation(Id.class);
if (id != null) {
idValue = (Long) o.getClass().getMethod(
"get"
+ Character.toUpperCase(fields[i]
.getName().charAt(0))
+ fields[i].getName().substring(1),
new Class<?>[] {}).invoke(o,
new Object[] {});
break;
}
}
} while ((c = c.getSuperclass()) != null && idValue == null);
return idValue;
}
JPAVariablePersister will not work when @Id is declared on a
superclass
-----------------------------------------------------------------------
Key: JBRULES-2522
URL: https://jira.jboss.org/browse/JBRULES-2522
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 5.1.0.M1
Reporter: Julien Serdaru
Assignee: Mark Proctor
Given A and B:
@MappedSuperclass
public class A {
@Id
@GeneratedValue(strategy = GenerationType.AUTO)
private Long id = null;
}
@Entity
public class B extends A {
// Some other fields
}
In JPAVariablePersister:getClassIdValue, the code introspects the entity class to
autodetect the @Id annotation. The code fails in this case since the annotation is
declared on the superclass, and the current implementation only loops on the local fields
of class B.
I tested the following implementation of getClassIdValue to work (loop on parent class
objects)
private Long getClassIdValue(Object o)
throws NoSuchMethodException, SecurityException,
IllegalAccessException, InvocationTargetException,
IllegalArgumentException {
Class<?> c = o.getClass();
Long idValue = null;
do {
Field fields[] = c.getDeclaredFields();
for (int i = 0; i < fields.length; i++) {
Id id = fields[i].getAnnotation(Id.class);
if (id != null) {
idValue = (Long) o.getClass().getMethod(
"get"
+ Character.toUpperCase(fields[i]
.getName().charAt(0))
+ fields[i].getName().substring(1),
new Class<?>[] {}).invoke(o,
new Object[] {});
break;
}
}
} while ((c = c.getSuperclass()) != null && idValue == null);
return idValue;
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:45 a.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2522) JPAVariablePersister will not work when @Id is declared on a superclass
[
https://jira.jboss.org/browse/JBRULES-2522?page=com.atlassian.jira.plugin...
]
Julien Serdaru updated JBRULES-2522:
------------------------------------
Description:
Given A and B:
@MappedSuperclass
public class A {
@Id
@GeneratedValue(strategy = GenerationType.AUTO)
private Long id = null;
}
@Entity
public class B extends A {
// Some other fields
}
In JPAVariablePersister:getClassIdValue, a lookup is done on the entity fields to
autodetect the @Id annotation, which fails in this case since the annotation is declared
on the superclass.
I tested the following implementation of getClassIdValue to work:
private Long getClassIdValue(Object o)
throws NoSuchMethodException, SecurityException,
IllegalAccessException, InvocationTargetException,
IllegalArgumentException {
Class<?> c = o.getClass();
Long idValue = null;
do {
Field fields[] = c.getDeclaredFields();
for (int i = 0; i < fields.length; i++) {
Id id = fields[i].getAnnotation(Id.class);
if (id != null) {
idValue = (Long) o.getClass().getMethod(
"get"
+ Character.toUpperCase(fields[i]
.getName().charAt(0))
+ fields[i].getName().substring(1),
new Class<?>[] {}).invoke(o,
new Object[] {});
break;
}
}
} while ((c = c.getSuperclass()) != null && idValue == null);
return idValue;
}
was:
Given A and B:
@MappedSuperclass
public class A {
@Id
@GeneratedValue(strategy = GenerationType.AUTO)
private Long id = null;
}
@Entity
public class B extends A {
// Some other fields
}
In JPAVariablePersister:getClassIdValue, a lookup is done on the entity fields to
autodetect the @Id annotation, which fails in this case since the method uses
getDeclaredFields() instead of getFields():
private Long getClassIdValue(Object o) throws NoSuchMethodException,
SecurityException, IllegalAccessException,
InvocationTargetException, IllegalArgumentException {
Field[] fields = o.getClass().getDeclaredFields(); <-- THIS ONLY RETURNS THE LOCAL
FIELDS, NOT THE SUPERCLASS.
...
return idValue;
}
Replacing getDeclaredFields() by getFields() should fix the problem.
JPAVariablePersister will not work when @Id is declared on a
superclass
-----------------------------------------------------------------------
Key: JBRULES-2522
URL: https://jira.jboss.org/browse/JBRULES-2522
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 5.1.0.M1
Reporter: Julien Serdaru
Assignee: Mark Proctor
Given A and B:
@MappedSuperclass
public class A {
@Id
@GeneratedValue(strategy = GenerationType.AUTO)
private Long id = null;
}
@Entity
public class B extends A {
// Some other fields
}
In JPAVariablePersister:getClassIdValue, a lookup is done on the entity fields to
autodetect the @Id annotation, which fails in this case since the annotation is declared
on the superclass.
I tested the following implementation of getClassIdValue to work:
private Long getClassIdValue(Object o)
throws NoSuchMethodException, SecurityException,
IllegalAccessException, InvocationTargetException,
IllegalArgumentException {
Class<?> c = o.getClass();
Long idValue = null;
do {
Field fields[] = c.getDeclaredFields();
for (int i = 0; i < fields.length; i++) {
Id id = fields[i].getAnnotation(Id.class);
if (id != null) {
idValue = (Long) o.getClass().getMethod(
"get"
+ Character.toUpperCase(fields[i]
.getName().charAt(0))
+ fields[i].getName().substring(1),
new Class<?>[] {}).invoke(o,
new Object[] {});
break;
}
}
} while ((c = c.getSuperclass()) != null && idValue == null);
return idValue;
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:47 a.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2522) JPAVariablePersister will not work when @Id is declared on a superclass
[
https://jira.jboss.org/browse/JBRULES-2522?page=com.atlassian.jira.plugin...
]
Julien Serdaru updated JBRULES-2522:
------------------------------------
Description:
Given A and B:
@MappedSuperclass
public class A {
@Id
@GeneratedValue(strategy = GenerationType.AUTO)
private Long id = null;
}
@Entity
public class B extends A {
// Some other fields
}
In JPAVariablePersister:getClassIdValue, the code introspects the entity class to
autodetect the @Id annotation. The code fails in this case since the annotation is
declared on the superclass, and the current implementation only loops on the local fields
of class B.
I tested the following implementation of getClassIdValue to work (loop on parent class
objects)
private Long getClassIdValue(Object o)
throws NoSuchMethodException, SecurityException,
IllegalAccessException, InvocationTargetException,
IllegalArgumentException {
Class<?> c = o.getClass();
Long idValue = null;
do {
Field fields[] = c.getDeclaredFields();
for (int i = 0; i < fields.length; i++) {
Id id = fields[i].getAnnotation(Id.class);
if (id != null) {
idValue = (Long) o.getClass().getMethod(
"get"
+ Character.toUpperCase(fields[i]
.getName().charAt(0))
+ fields[i].getName().substring(1),
new Class<?>[] {}).invoke(o,
new Object[] {});
break;
}
}
} while ((c = c.getSuperclass()) != null && idValue == null);
return idValue;
}
Actually this type of code should probably deserve a service function somewhere...
was:
Given A and B:
@MappedSuperclass
public class A {
@Id
@GeneratedValue(strategy = GenerationType.AUTO)
private Long id = null;
}
@Entity
public class B extends A {
// Some other fields
}
In JPAVariablePersister:getClassIdValue, the code introspects the entity class to
autodetect the @Id annotation. The code fails in this case since the annotation is
declared on the superclass, and the current implementation only loops on the local fields
of class B.
I tested the following implementation of getClassIdValue to work (loop on parent class
objects)
private Long getClassIdValue(Object o)
throws NoSuchMethodException, SecurityException,
IllegalAccessException, InvocationTargetException,
IllegalArgumentException {
Class<?> c = o.getClass();
Long idValue = null;
do {
Field fields[] = c.getDeclaredFields();
for (int i = 0; i < fields.length; i++) {
Id id = fields[i].getAnnotation(Id.class);
if (id != null) {
idValue = (Long) o.getClass().getMethod(
"get"
+ Character.toUpperCase(fields[i]
.getName().charAt(0))
+ fields[i].getName().substring(1),
new Class<?>[] {}).invoke(o,
new Object[] {});
break;
}
}
} while ((c = c.getSuperclass()) != null && idValue == null);
return idValue;
}
JPAVariablePersister will not work when @Id is declared on a
superclass
-----------------------------------------------------------------------
Key: JBRULES-2522
URL: https://jira.jboss.org/browse/JBRULES-2522
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 5.1.0.M1
Reporter: Julien Serdaru
Assignee: Mark Proctor
Given A and B:
@MappedSuperclass
public class A {
@Id
@GeneratedValue(strategy = GenerationType.AUTO)
private Long id = null;
}
@Entity
public class B extends A {
// Some other fields
}
In JPAVariablePersister:getClassIdValue, the code introspects the entity class to
autodetect the @Id annotation. The code fails in this case since the annotation is
declared on the superclass, and the current implementation only loops on the local fields
of class B.
I tested the following implementation of getClassIdValue to work (loop on parent class
objects)
private Long getClassIdValue(Object o)
throws NoSuchMethodException, SecurityException,
IllegalAccessException, InvocationTargetException,
IllegalArgumentException {
Class<?> c = o.getClass();
Long idValue = null;
do {
Field fields[] = c.getDeclaredFields();
for (int i = 0; i < fields.length; i++) {
Id id = fields[i].getAnnotation(Id.class);
if (id != null) {
idValue = (Long) o.getClass().getMethod(
"get"
+ Character.toUpperCase(fields[i]
.getName().charAt(0))
+ fields[i].getName().substring(1),
new Class<?>[] {}).invoke(o,
new Object[] {});
break;
}
}
} while ((c = c.getSuperclass()) != null && idValue == null);
return idValue;
}
Actually this type of code should probably deserve a service function somewhere...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:51 a.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2522) JPAVariablePersister will not work when @Id is declared on a superclass
[
https://jira.jboss.org/browse/JBRULES-2522?page=com.atlassian.jira.plugin...
]
Julien Serdaru updated JBRULES-2522:
------------------------------------
Component/s: drools-process
JPAVariablePersister will not work when @Id is declared on a
superclass
-----------------------------------------------------------------------
Key: JBRULES-2522
URL: https://jira.jboss.org/browse/JBRULES-2522
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-process
Affects Versions: 5.1.0.M1
Reporter: Julien Serdaru
Assignee: Mark Proctor
Given A and B:
@MappedSuperclass
public class A {
@Id
@GeneratedValue(strategy = GenerationType.AUTO)
private Long id = null;
}
@Entity
public class B extends A {
// Some other fields
}
In JPAVariablePersister:getClassIdValue, the code introspects the entity class to
autodetect the @Id annotation. The code fails in this case since the annotation is
declared on the superclass, and the current implementation only loops on the local fields
of class B.
I tested the following implementation of getClassIdValue to work (loop on parent class
objects)
private Long getClassIdValue(Object o)
throws NoSuchMethodException, SecurityException,
IllegalAccessException, InvocationTargetException,
IllegalArgumentException {
Class<?> c = o.getClass();
Long idValue = null;
do {
Field fields[] = c.getDeclaredFields();
for (int i = 0; i < fields.length; i++) {
Id id = fields[i].getAnnotation(Id.class);
if (id != null) {
idValue = (Long) o.getClass().getMethod(
"get"
+ Character.toUpperCase(fields[i]
.getName().charAt(0))
+ fields[i].getName().substring(1),
new Class<?>[] {}).invoke(o,
new Object[] {});
break;
}
}
} while ((c = c.getSuperclass()) != null && idValue == null);
return idValue;
}
Actually this type of code should probably deserve a service function somewhere...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:08 p.m.
New subject: [JBoss JIRA] Resolved: (JBRULES-2522) JPAVariablePersister will not work when @Id is declared on a superclass
[
https://jira.jboss.org/browse/JBRULES-2522?page=com.atlassian.jira.plugin...
]
Kris Verlaenen resolved JBRULES-2522.
-------------------------------------
Assignee: Kris Verlaenen (was: Mark Proctor)
Fix Version/s: 5.1.0.CR1
Resolution: Done
Made sure that @Id on superclass method or field is also detected
JPAVariablePersister will not work when @Id is declared on a
superclass
-----------------------------------------------------------------------
Key: JBRULES-2522
URL: https://jira.jboss.org/browse/JBRULES-2522
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-process
Affects Versions: 5.1.0.M1
Reporter: Julien Serdaru
Assignee: Kris Verlaenen
Fix For: 5.1.0.CR1
Given A and B:
@MappedSuperclass
public class A {
@Id
@GeneratedValue(strategy = GenerationType.AUTO)
private Long id = null;
}
@Entity
public class B extends A {
// Some other fields
}
In JPAVariablePersister:getClassIdValue, the code introspects the entity class to
autodetect the @Id annotation. The code fails in this case since the annotation is
declared on the superclass, and the current implementation only loops on the local fields
of class B.
I tested the following implementation of getClassIdValue to work (loop on parent class
objects)
private Long getClassIdValue(Object o)
throws NoSuchMethodException, SecurityException,
IllegalAccessException, InvocationTargetException,
IllegalArgumentException {
Class<?> c = o.getClass();
Long idValue = null;
do {
Field fields[] = c.getDeclaredFields();
for (int i = 0; i < fields.length; i++) {
Id id = fields[i].getAnnotation(Id.class);
if (id != null) {
idValue = (Long) o.getClass().getMethod(
"get"
+ Character.toUpperCase(fields[i]
.getName().charAt(0))
+ fields[i].getName().substring(1),
new Class<?>[] {}).invoke(o,
new Object[] {});
break;
}
}
} while ((c = c.getSuperclass()) != null && idValue == null);
return idValue;
}
Actually this type of code should probably deserve a service function somewhere...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5899
days inactive
5904
days old
5 comments
2 participants
participants (2)
-
Julien Serdaru (JIRA) -
Kris Verlaenen (JIRA)