[JBoss JIRA] Created: (JBMESSAGING-864) Memory leak when using JCA layer and creating consumer on each send
6:47 p.m.
Memory leak when using JCA layer and creating consumer on each send
-------------------------------------------------------------------
Key: JBMESSAGING-864
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-864
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.0.1.SP4
Reporter: Tim Fox
Assigned To: Tim Fox
If using the JCA adapter and performing the following anti-pattern:
create connection
create session
create consumer
message = consumer.receive(..)
in order to recieve a single message (this is what the spring jms template apparently does
- yikes)
Then the JCA layer will cache the connection and session, but the consumer will get
created anew on the server each time. This in itself means the operation will be very slow
- hence I consider this an antipattern.
Since the JCA layer re-uses the session, it never gets closed. In the 1_0 branch
deliveries are maintained in the consumer, not the session, so consumer.close() does not
actually close the consumers - this happens on session.close(). Hence the leak.
This does not affect the 1.2 branch where deliveries are stored on the session level.
My recommendation to people would be not to use this antipattern in the first place. This
may mean not using the Spring jms template which unfortunatelt seems to be poorly coded to
work this way.
Also see
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4019590#...
http://www.jboss.com/index.html?module=bb&op=viewtopic&t=102169
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:17 a.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-864) Memory leak when using JCA layer and creating consumer on each send
[ http://jira.jboss.com/jira/browse/JBMESSAGING-864?page=comments#action_12... ]
Tim Fox commented on JBMESSAGING-864:
-------------------------------------
After some thought, actually I don't think this would be too hard to fix in the 1.0.sp
branch.
When a consumer is closed currently we don't actually get rid of it since it might
have unacked deliveries.
But when doing the close we can check whether it has unacked deliveries and if so remove
it there and then. In this way it should work with the JCA ant-pattern if people want to
do that.
Memory leak when using JCA layer and creating consumer on each send
-------------------------------------------------------------------
Key: JBMESSAGING-864
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-864
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.0.1.SP4
Reporter: Tim Fox
Assigned To: Tim Fox
If using the JCA adapter and performing the following anti-pattern:
create connection
create session
create consumer
message = consumer.receive(..)
in order to recieve a single message (this is what the spring jms template apparently
does - yikes)
Then the JCA layer will cache the connection and session, but the consumer will get
created anew on the server each time. This in itself means the operation will be very slow
- hence I consider this an antipattern.
Since the JCA layer re-uses the session, it never gets closed. In the 1_0 branch
deliveries are maintained in the consumer, not the session, so consumer.close() does not
actually close the consumers - this happens on session.close(). Hence the leak.
This does not affect the 1.2 branch where deliveries are stored on the session level.
My recommendation to people would be not to use this antipattern in the first place. This
may mean not using the Spring jms template which unfortunatelt seems to be poorly coded to
work this way.
Also see
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4019590#...
http://www.jboss.com/index.html?module=bb&op=viewtopic&t=102169
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:01 a.m.
New subject: [JBoss JIRA] Updated: (JBMESSAGING-864) Memory leak when using JCA layer and creating consumer on each send
[ http://jira.jboss.com/jira/browse/JBMESSAGING-864?page=all ]
Tim Fox updated JBMESSAGING-864:
--------------------------------
Fix Version/s: 1.0.1.SP5
Memory leak when using JCA layer and creating consumer on each send
-------------------------------------------------------------------
Key: JBMESSAGING-864
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-864
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.0.1.SP4
Reporter: Tim Fox
Assigned To: Tim Fox
Fix For: 1.0.1.SP5
If using the JCA adapter and performing the following anti-pattern:
create connection
create session
create consumer
message = consumer.receive(..)
in order to recieve a single message (this is what the spring jms template apparently
does - yikes)
Then the JCA layer will cache the connection and session, but the consumer will get
created anew on the server each time. This in itself means the operation will be very slow
- hence I consider this an antipattern.
Since the JCA layer re-uses the session, it never gets closed. In the 1_0 branch
deliveries are maintained in the consumer, not the session, so consumer.close() does not
actually close the consumers - this happens on session.close(). Hence the leak.
This does not affect the 1.2 branch where deliveries are stored on the session level.
My recommendation to people would be not to use this antipattern in the first place. This
may mean not using the Spring jms template which unfortunatelt seems to be poorly coded to
work this way.
Also see
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4019590#...
http://www.jboss.com/index.html?module=bb&op=viewtopic&t=102169
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:12 p.m.
New subject: [JBoss JIRA] Updated: (JBMESSAGING-864) Memory leak when using JCA layer and creating consumer on each send
[ http://jira.jboss.com/jira/browse/JBMESSAGING-864?page=all ]
Tim Fox updated JBMESSAGING-864:
--------------------------------
Fix Version/s: 1.2.0.GA
Affects Version/s: 1.2.0.CR1
Memory leak when using JCA layer and creating consumer on each send
-------------------------------------------------------------------
Key: JBMESSAGING-864
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-864
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.CR1, 1.0.1.SP4
Reporter: Tim Fox
Assigned To: Tim Fox
Fix For: 1.2.0.GA, 1.0.1.SP5
If using the JCA adapter and performing the following anti-pattern:
create connection
create session
create consumer
message = consumer.receive(..)
in order to recieve a single message (this is what the spring jms template apparently
does - yikes)
Then the JCA layer will cache the connection and session, but the consumer will get
created anew on the server each time. This in itself means the operation will be very slow
- hence I consider this an antipattern.
Since the JCA layer re-uses the session, it never gets closed. In the 1_0 branch
deliveries are maintained in the consumer, not the session, so consumer.close() does not
actually close the consumers - this happens on session.close(). Hence the leak.
This does not affect the 1.2 branch where deliveries are stored on the session level.
My recommendation to people would be not to use this antipattern in the first place. This
may mean not using the Spring jms template which unfortunatelt seems to be poorly coded to
work this way.
Also see
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4019590#...
http://www.jboss.com/index.html?module=bb&op=viewtopic&t=102169
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:12 p.m.
New subject: [JBoss JIRA] Updated: (JBMESSAGING-864) Memory leak when using JCA layer and creating consumer on each send
[ http://jira.jboss.com/jira/browse/JBMESSAGING-864?page=all ]
Tim Fox updated JBMESSAGING-864:
--------------------------------
Priority: Blocker (was: Major)
Memory leak when using JCA layer and creating consumer on each send
-------------------------------------------------------------------
Key: JBMESSAGING-864
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-864
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.CR1, 1.0.1.SP4
Reporter: Tim Fox
Assigned To: Tim Fox
Priority: Blocker
Fix For: 1.2.0.GA, 1.0.1.SP5
If using the JCA adapter and performing the following anti-pattern:
create connection
create session
create consumer
message = consumer.receive(..)
in order to recieve a single message (this is what the spring jms template apparently
does - yikes)
Then the JCA layer will cache the connection and session, but the consumer will get
created anew on the server each time. This in itself means the operation will be very slow
- hence I consider this an antipattern.
Since the JCA layer re-uses the session, it never gets closed. In the 1_0 branch
deliveries are maintained in the consumer, not the session, so consumer.close() does not
actually close the consumers - this happens on session.close(). Hence the leak.
This does not affect the 1.2 branch where deliveries are stored on the session level.
My recommendation to people would be not to use this antipattern in the first place. This
may mean not using the Spring jms template which unfortunatelt seems to be poorly coded to
work this way.
Also see
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4019590#...
http://www.jboss.com/index.html?module=bb&op=viewtopic&t=102169
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:31 p.m.
New subject: [JBoss JIRA] Assigned: (JBMESSAGING-864) Memory leak when using JCA layer and creating consumer on each send
[ http://jira.jboss.com/jira/browse/JBMESSAGING-864?page=all ]
Clebert Suconic reassigned JBMESSAGING-864:
-------------------------------------------
Assignee: Clebert Suconic (was: Tim Fox)
Memory leak when using JCA layer and creating consumer on each send
-------------------------------------------------------------------
Key: JBMESSAGING-864
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-864
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.CR1, 1.0.1.SP4
Reporter: Tim Fox
Assigned To: Clebert Suconic
Priority: Blocker
Fix For: 1.2.0.GA, 1.0.1.SP5
If using the JCA adapter and performing the following anti-pattern:
create connection
create session
create consumer
message = consumer.receive(..)
in order to recieve a single message (this is what the spring jms template apparently
does - yikes)
Then the JCA layer will cache the connection and session, but the consumer will get
created anew on the server each time. This in itself means the operation will be very slow
- hence I consider this an antipattern.
Since the JCA layer re-uses the session, it never gets closed. In the 1_0 branch
deliveries are maintained in the consumer, not the session, so consumer.close() does not
actually close the consumers - this happens on session.close(). Hence the leak.
This does not affect the 1.2 branch where deliveries are stored on the session level.
My recommendation to people would be not to use this antipattern in the first place. This
may mean not using the Spring jms template which unfortunatelt seems to be poorly coded to
work this way.
Also see
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4019590#...
http://www.jboss.com/index.html?module=bb&op=viewtopic&t=102169
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:46 p.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-864) Memory leak when using JCA layer and creating consumer on each send
[ http://jira.jboss.com/jira/browse/JBMESSAGING-864?page=comments#action_12... ]
Clebert Suconic commented on JBMESSAGING-864:
---------------------------------------------
I thought is the Consumer is only removed from the Session when Session is closed... but
it looks like the Session is never closed on JCA (as JCA will reuse Sessions)
From what I looked on code, this code changed between 1.0.1 and 1.2
due to postOffice. It looks like this wouldn't leak on 1.2 but I will confirm that by
testing it
Memory leak when using JCA layer and creating consumer on each send
-------------------------------------------------------------------
Key: JBMESSAGING-864
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-864
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.CR1, 1.0.1.SP4
Reporter: Tim Fox
Assigned To: Clebert Suconic
Priority: Blocker
Fix For: 1.2.0.GA, 1.0.1.SP5
If using the JCA adapter and performing the following anti-pattern:
create connection
create session
create consumer
message = consumer.receive(..)
in order to recieve a single message (this is what the spring jms template apparently
does - yikes)
Then the JCA layer will cache the connection and session, but the consumer will get
created anew on the server each time. This in itself means the operation will be very slow
- hence I consider this an antipattern.
Since the JCA layer re-uses the session, it never gets closed. In the 1_0 branch
deliveries are maintained in the consumer, not the session, so consumer.close() does not
actually close the consumers - this happens on session.close(). Hence the leak.
This does not affect the 1.2 branch where deliveries are stored on the session level.
My recommendation to people would be not to use this antipattern in the first place. This
may mean not using the Spring jms template which unfortunatelt seems to be poorly coded to
work this way.
Also see
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4019590#...
http://www.jboss.com/index.html?module=bb&op=viewtopic&t=102169
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:46 p.m.
New subject: [JBoss JIRA] Updated: (JBMESSAGING-864) Memory leak when using JCA layer and creating consumer on each send
[ http://jira.jboss.com/jira/browse/JBMESSAGING-864?page=all ]
Clebert Suconic updated JBMESSAGING-864:
----------------------------------------
Comment: was deleted
Memory leak when using JCA layer and creating consumer on each send
-------------------------------------------------------------------
Key: JBMESSAGING-864
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-864
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.CR1, 1.0.1.SP4
Reporter: Tim Fox
Assigned To: Clebert Suconic
Priority: Blocker
Fix For: 1.2.0.GA, 1.0.1.SP5
If using the JCA adapter and performing the following anti-pattern:
create connection
create session
create consumer
message = consumer.receive(..)
in order to recieve a single message (this is what the spring jms template apparently
does - yikes)
Then the JCA layer will cache the connection and session, but the consumer will get
created anew on the server each time. This in itself means the operation will be very slow
- hence I consider this an antipattern.
Since the JCA layer re-uses the session, it never gets closed. In the 1_0 branch
deliveries are maintained in the consumer, not the session, so consumer.close() does not
actually close the consumers - this happens on session.close(). Hence the leak.
This does not affect the 1.2 branch where deliveries are stored on the session level.
My recommendation to people would be not to use this antipattern in the first place. This
may mean not using the Spring jms template which unfortunatelt seems to be poorly coded to
work this way.
Also see
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4019590#...
http://www.jboss.com/index.html?module=bb&op=viewtopic&t=102169
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:46 p.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-864) Memory leak when using JCA layer and creating consumer on each send
[ http://jira.jboss.com/jira/browse/JBMESSAGING-864?page=comments#action_12... ]
Clebert Suconic commented on JBMESSAGING-864:
---------------------------------------------
I thought the problem here was the JCA, but the real problem is the Consumer is only
removed from the Session when Session is closed... but the Session is never closed on JCA
(as JCA will reuse them)
From what I looked on code, this code changed between 1.0.1 and 1.2
due to postOffice. It looks like this wouldn't leak on 1.2 but I will confirm that by
testing it
Memory leak when using JCA layer and creating consumer on each send
-------------------------------------------------------------------
Key: JBMESSAGING-864
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-864
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.CR1, 1.0.1.SP4
Reporter: Tim Fox
Assigned To: Clebert Suconic
Priority: Blocker
Fix For: 1.2.0.GA, 1.0.1.SP5
If using the JCA adapter and performing the following anti-pattern:
create connection
create session
create consumer
message = consumer.receive(..)
in order to recieve a single message (this is what the spring jms template apparently
does - yikes)
Then the JCA layer will cache the connection and session, but the consumer will get
created anew on the server each time. This in itself means the operation will be very slow
- hence I consider this an antipattern.
Since the JCA layer re-uses the session, it never gets closed. In the 1_0 branch
deliveries are maintained in the consumer, not the session, so consumer.close() does not
actually close the consumers - this happens on session.close(). Hence the leak.
This does not affect the 1.2 branch where deliveries are stored on the session level.
My recommendation to people would be not to use this antipattern in the first place. This
may mean not using the Spring jms template which unfortunatelt seems to be poorly coded to
work this way.
Also see
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4019590#...
http://www.jboss.com/index.html?module=bb&op=viewtopic&t=102169
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:48 p.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-864) Memory leak when using JCA layer and creating consumer on each send
[ http://jira.jboss.com/jira/browse/JBMESSAGING-864?page=comments#action_12... ]
Clebert Suconic commented on JBMESSAGING-864:
---------------------------------------------
what is leaking is the SererConsumerEndpoint... connected to ServerSessionEndpoint through
a HashMap.
Memory leak when using JCA layer and creating consumer on each send
-------------------------------------------------------------------
Key: JBMESSAGING-864
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-864
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.CR1, 1.0.1.SP4
Reporter: Tim Fox
Assigned To: Clebert Suconic
Priority: Blocker
Fix For: 1.2.0.GA, 1.0.1.SP5
If using the JCA adapter and performing the following anti-pattern:
create connection
create session
create consumer
message = consumer.receive(..)
in order to recieve a single message (this is what the spring jms template apparently
does - yikes)
Then the JCA layer will cache the connection and session, but the consumer will get
created anew on the server each time. This in itself means the operation will be very slow
- hence I consider this an antipattern.
Since the JCA layer re-uses the session, it never gets closed. In the 1_0 branch
deliveries are maintained in the consumer, not the session, so consumer.close() does not
actually close the consumers - this happens on session.close(). Hence the leak.
This does not affect the 1.2 branch where deliveries are stored on the session level.
My recommendation to people would be not to use this antipattern in the first place. This
may mean not using the Spring jms template which unfortunatelt seems to be poorly coded to
work this way.
Also see
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4019590#...
http://www.jboss.com/index.html?module=bb&op=viewtopic&t=102169
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:30 p.m.
New subject: [JBoss JIRA] Updated: (JBMESSAGING-864) Memory leak when using JCA layer and creating consumer on each send
[ http://jira.jboss.com/jira/browse/JBMESSAGING-864?page=all ]
Clebert Suconic updated JBMESSAGING-864:
----------------------------------------
Fix Version/s: (was: 1.2.0.GA)
Affects Version/s: (was: 1.2.0.CR1)
Memory leak when using JCA layer and creating consumer on each send
-------------------------------------------------------------------
Key: JBMESSAGING-864
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-864
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.0.1.SP4
Reporter: Tim Fox
Assigned To: Clebert Suconic
Priority: Blocker
Fix For: 1.0.1.SP5
If using the JCA adapter and performing the following anti-pattern:
create connection
create session
create consumer
message = consumer.receive(..)
in order to recieve a single message (this is what the spring jms template apparently
does - yikes)
Then the JCA layer will cache the connection and session, but the consumer will get
created anew on the server each time. This in itself means the operation will be very slow
- hence I consider this an antipattern.
Since the JCA layer re-uses the session, it never gets closed. In the 1_0 branch
deliveries are maintained in the consumer, not the session, so consumer.close() does not
actually close the consumers - this happens on session.close(). Hence the leak.
This does not affect the 1.2 branch where deliveries are stored on the session level.
My recommendation to people would be not to use this antipattern in the first place. This
may mean not using the Spring jms template which unfortunatelt seems to be poorly coded to
work this way.
Also see
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4019590#...
http://www.jboss.com/index.html?module=bb&op=viewtopic&t=102169
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:52 p.m.
New subject: [JBoss JIRA] Closed: (JBMESSAGING-864) Memory leak when using JCA layer and creating consumer on each send
[ http://jira.jboss.com/jira/browse/JBMESSAGING-864?page=all ]
Clebert Suconic closed JBMESSAGING-864.
---------------------------------------
Resolution: Done
Memory leak when using JCA layer and creating consumer on each send
-------------------------------------------------------------------
Key: JBMESSAGING-864
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-864
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.0.1.SP4
Reporter: Tim Fox
Assigned To: Clebert Suconic
Priority: Blocker
Fix For: 1.0.1.SP5
If using the JCA adapter and performing the following anti-pattern:
create connection
create session
create consumer
message = consumer.receive(..)
in order to recieve a single message (this is what the spring jms template apparently
does - yikes)
Then the JCA layer will cache the connection and session, but the consumer will get
created anew on the server each time. This in itself means the operation will be very slow
- hence I consider this an antipattern.
Since the JCA layer re-uses the session, it never gets closed. In the 1_0 branch
deliveries are maintained in the consumer, not the session, so consumer.close() does not
actually close the consumers - this happens on session.close(). Hence the leak.
This does not affect the 1.2 branch where deliveries are stored on the session level.
My recommendation to people would be not to use this antipattern in the first place. This
may mean not using the Spring jms template which unfortunatelt seems to be poorly coded to
work this way.
Also see
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4019590#...
http://www.jboss.com/index.html?module=bb&op=viewtopic&t=102169
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:50 a.m.
New subject: [JBoss JIRA] Reopened: (JBMESSAGING-864) Memory leak when using JCA layer and creating consumer on each send
[ http://jira.jboss.com/jira/browse/JBMESSAGING-864?page=all ]
Tim Fox reopened JBMESSAGING-864:
---------------------------------
Clebert-
I know what the problem is in 1.0.1. - if you read my earlier comment, I explain how to
fix it. This was straightforward.
The fix you applied is along the right lines, but is not correct. So I am re-opening.
The user has reported the leak in 1.2, and this is what you were investigating (not 1.0.1)
- what is the status with that?
Also, BTW JCA does hold onto sessions, one of the main features of the JCA JMS adaptor is
it caches sessions, so of course it will do this. It is perfectly normal.
Memory leak when using JCA layer and creating consumer on each send
-------------------------------------------------------------------
Key: JBMESSAGING-864
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-864
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.0.1.SP4
Reporter: Tim Fox
Assigned To: Clebert Suconic
Priority: Blocker
Fix For: 1.0.1.SP5
If using the JCA adapter and performing the following anti-pattern:
create connection
create session
create consumer
message = consumer.receive(..)
in order to recieve a single message (this is what the spring jms template apparently
does - yikes)
Then the JCA layer will cache the connection and session, but the consumer will get
created anew on the server each time. This in itself means the operation will be very slow
- hence I consider this an antipattern.
Since the JCA layer re-uses the session, it never gets closed. In the 1_0 branch
deliveries are maintained in the consumer, not the session, so consumer.close() does not
actually close the consumers - this happens on session.close(). Hence the leak.
This does not affect the 1.2 branch where deliveries are stored on the session level.
My recommendation to people would be not to use this antipattern in the first place. This
may mean not using the Spring jms template which unfortunatelt seems to be poorly coded to
work this way.
Also see
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4019590#...
http://www.jboss.com/index.html?module=bb&op=viewtopic&t=102169
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:10 a.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-864) Memory leak when using JCA layer and creating consumer on each send
[ http://jira.jboss.com/jira/browse/JBMESSAGING-864?page=comments#action_12... ]
Tim Fox commented on JBMESSAGING-864:
-------------------------------------
Ok, I have refixed on 1.0_sp branch
Memory leak when using JCA layer and creating consumer on each send
-------------------------------------------------------------------
Key: JBMESSAGING-864
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-864
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.0.1.SP4
Reporter: Tim Fox
Assigned To: Clebert Suconic
Priority: Blocker
Fix For: 1.0.1.SP5
If using the JCA adapter and performing the following anti-pattern:
create connection
create session
create consumer
message = consumer.receive(..)
in order to recieve a single message (this is what the spring jms template apparently
does - yikes)
Then the JCA layer will cache the connection and session, but the consumer will get
created anew on the server each time. This in itself means the operation will be very slow
- hence I consider this an antipattern.
Since the JCA layer re-uses the session, it never gets closed. In the 1_0 branch
deliveries are maintained in the consumer, not the session, so consumer.close() does not
actually close the consumers - this happens on session.close(). Hence the leak.
This does not affect the 1.2 branch where deliveries are stored on the session level.
My recommendation to people would be not to use this antipattern in the first place. This
may mean not using the Spring jms template which unfortunatelt seems to be poorly coded to
work this way.
Also see
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4019590#...
http://www.jboss.com/index.html?module=bb&op=viewtopic&t=102169
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:35 a.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-864) Memory leak when using JCA layer and creating consumer on each send
[ http://jira.jboss.com/jira/browse/JBMESSAGING-864?page=comments#action_12... ]
Clebert Suconic commented on JBMESSAGING-864:
---------------------------------------------
I profiled this on 1.2, the problem doesn't happen on 1.2 (that's why I have
changed the fix version)
Memory leak when using JCA layer and creating consumer on each send
-------------------------------------------------------------------
Key: JBMESSAGING-864
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-864
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.0.1.SP4
Reporter: Tim Fox
Assigned To: Clebert Suconic
Priority: Blocker
Fix For: 1.0.1.SP5
If using the JCA adapter and performing the following anti-pattern:
create connection
create session
create consumer
message = consumer.receive(..)
in order to recieve a single message (this is what the spring jms template apparently
does - yikes)
Then the JCA layer will cache the connection and session, but the consumer will get
created anew on the server each time. This in itself means the operation will be very slow
- hence I consider this an antipattern.
Since the JCA layer re-uses the session, it never gets closed. In the 1_0 branch
deliveries are maintained in the consumer, not the session, so consumer.close() does not
actually close the consumers - this happens on session.close(). Hence the leak.
This does not affect the 1.2 branch where deliveries are stored on the session level.
My recommendation to people would be not to use this antipattern in the first place. This
may mean not using the Spring jms template which unfortunatelt seems to be poorly coded to
work this way.
Also see
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4019590#...
http://www.jboss.com/index.html?module=bb&op=viewtopic&t=102169
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:47 a.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-864) Memory leak when using JCA layer and creating consumer on each send
[ http://jira.jboss.com/jira/browse/JBMESSAGING-864?page=comments#action_12... ]
Tim Fox commented on JBMESSAGING-864:
-------------------------------------
Yes, I didn't see the leak on 1.2 either.
But the user said they did, so I wanted you to confirm whether or not there is a leak.
If you are absolutley sure there is no leak this can be closed.
Memory leak when using JCA layer and creating consumer on each send
-------------------------------------------------------------------
Key: JBMESSAGING-864
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-864
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.0.1.SP4
Reporter: Tim Fox
Assigned To: Clebert Suconic
Priority: Blocker
Fix For: 1.0.1.SP5
If using the JCA adapter and performing the following anti-pattern:
create connection
create session
create consumer
message = consumer.receive(..)
in order to recieve a single message (this is what the spring jms template apparently
does - yikes)
Then the JCA layer will cache the connection and session, but the consumer will get
created anew on the server each time. This in itself means the operation will be very slow
- hence I consider this an antipattern.
Since the JCA layer re-uses the session, it never gets closed. In the 1_0 branch
deliveries are maintained in the consumer, not the session, so consumer.close() does not
actually close the consumers - this happens on session.close(). Hence the leak.
This does not affect the 1.2 branch where deliveries are stored on the session level.
My recommendation to people would be not to use this antipattern in the first place. This
may mean not using the Spring jms template which unfortunatelt seems to be poorly coded to
work this way.
Also see
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4019590#...
http://www.jboss.com/index.html?module=bb&op=viewtopic&t=102169
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:43 a.m.
New subject: [JBoss JIRA] Closed: (JBMESSAGING-864) Memory leak when using JCA layer and creating consumer on each send
[ http://jira.jboss.com/jira/browse/JBMESSAGING-864?page=all ]
Clebert Suconic closed JBMESSAGING-864.
---------------------------------------
Resolution: Done
Memory leak when using JCA layer and creating consumer on each send
-------------------------------------------------------------------
Key: JBMESSAGING-864
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-864
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.0.1.SP4
Reporter: Tim Fox
Assigned To: Clebert Suconic
Priority: Blocker
Fix For: 1.0.1.SP5
If using the JCA adapter and performing the following anti-pattern:
create connection
create session
create consumer
message = consumer.receive(..)
in order to recieve a single message (this is what the spring jms template apparently
does - yikes)
Then the JCA layer will cache the connection and session, but the consumer will get
created anew on the server each time. This in itself means the operation will be very slow
- hence I consider this an antipattern.
Since the JCA layer re-uses the session, it never gets closed. In the 1_0 branch
deliveries are maintained in the consumer, not the session, so consumer.close() does not
actually close the consumers - this happens on session.close(). Hence the leak.
This does not affect the 1.2 branch where deliveries are stored on the session level.
My recommendation to people would be not to use this antipattern in the first place. This
may mean not using the Spring jms template which unfortunatelt seems to be poorly coded to
work this way.
Also see
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4019590#...
http://www.jboss.com/index.html?module=bb&op=viewtopic&t=102169
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7031
days inactive
7034
days old
16 comments
2 participants
participants (2)
-
Clebert Suconic (JIRA) -
Tim Fox (JIRA)