Author: vyemialyanchyk
Date: 2009-03-17 15:33:42 -0400 (Tue, 17 Mar 2009)
New Revision: 14246
Modified:
trunk/hibernatetools/tests/org.hibernate.eclipse.jdt.ui.test/src/org/hibernate/eclipse/jdt/ui/test/JDTuiAllTests.java
trunk/hibernatetools/tests/org.hibernate.eclipse.jdt.ui.test/src/org/hibernate/eclipse/jdt/ui/test/JPAMapTest.java
Log:
code review
Modified:
trunk/hibernatetools/tests/org.hibernate.eclipse.jdt.ui.test/src/org/hibernate/eclipse/jdt/ui/test/JDTuiAllTests.java
===================================================================
---
trunk/hibernatetools/tests/org.hibernate.eclipse.jdt.ui.test/src/org/hibernate/eclipse/jdt/ui/test/JDTuiAllTests.java 2009-03-17
19:23:23 UTC (rev 14245)
+++
trunk/hibernatetools/tests/org.hibernate.eclipse.jdt.ui.test/src/org/hibernate/eclipse/jdt/ui/test/JDTuiAllTests.java 2009-03-17
19:33:42 UTC (rev 14246)
@@ -7,7 +7,7 @@
public static Test suite() {
TestSuite suite = new TestSuite(
- "Test for org.hibernate.eclipse.jdt.ui.test");
+ "Test for org.hibernate.eclipse.jdt.ui.test"); //$NON-NLS-1$
//$JUnit-BEGIN$
//suite.addTestSuite(HibernateErrorsTest.class);
//suite.addTestSuite(HibernateErrorsTest2.class);
Modified:
trunk/hibernatetools/tests/org.hibernate.eclipse.jdt.ui.test/src/org/hibernate/eclipse/jdt/ui/test/JPAMapTest.java
===================================================================
---
trunk/hibernatetools/tests/org.hibernate.eclipse.jdt.ui.test/src/org/hibernate/eclipse/jdt/ui/test/JPAMapTest.java 2009-03-17
19:23:23 UTC (rev 14245)
+++
trunk/hibernatetools/tests/org.hibernate.eclipse.jdt.ui.test/src/org/hibernate/eclipse/jdt/ui/test/JPAMapTest.java 2009-03-17
19:33:42 UTC (rev 14246)
@@ -44,20 +44,16 @@
/**
*
*
- * @author Vitali
+ * @author Vitali Yemialyanchyk
*/
public class JPAMapTest extends TestCase {
- public static String PROJECT_NAME = "TestProject"; //$NON-NLS-1$
- public static String RESOURCE_PATH = "res/project/"; //$NON-NLS-1$
- public static String SPECIMEN_PATH = "res/specimen/"; //$NON-NLS-1$
- public static String TESTRESOURCE_PATH = "testresources"; //$NON-NLS-1$
- public static String TEST_FIELDS = "fields"; //$NON-NLS-1$
- public static String TEST_GETTERS = "getters"; //$NON-NLS-1$
- static {
- RESOURCE_PATH.replaceAll("//", File.separator); //$NON-NLS-1$
- SPECIMEN_PATH.replaceAll("//", File.separator); //$NON-NLS-1$
- }
+ public static final String PROJECT_NAME = "TestProject"; //$NON-NLS-1$
+ public static final String RESOURCE_PATH =
"res/project/".replaceAll("//", File.separator); //$NON-NLS-1$
//$NON-NLS-2$
+ public static final String SPECIMEN_PATH =
"res/specimen/".replaceAll("//", File.separator); //$NON-NLS-1$
//$NON-NLS-2$
+ public static final String TESTRESOURCE_PATH = "testresources"; //$NON-NLS-1$
+ public static final String TEST_FIELDS = "fields"; //$NON-NLS-1$
+ public static final String TEST_GETTERS = "getters"; //$NON-NLS-1$
protected AllEntitiesInfoCollector collector = new AllEntitiesInfoCollector();
protected AllEntitiesProcessor processor = new AllEntitiesProcessor();
@@ -126,7 +122,7 @@
//ICompilationUnit icu2 = Utils.findCompilationUnit(javaProject,
// "test.annotated." + testSelection + ".Person"); //$NON-NLS-1$
//$NON-NLS-2$
ICompilationUnit icu4 = null;
- if (testSelection == TEST_GETTERS) {
+ if (testSelection.equals(TEST_GETTERS)) {
icu4 = Utils.findCompilationUnit(javaProject,
"test.annotated." + testSelection + ".FotoXPerson");
//$NON-NLS-1$ //$NON-NLS-2$
}
Show replies by date