Author: dgolovin
Date: 2011-08-23 18:42:11 -0400 (Tue, 23 Aug 2011)
New Revision: 34191
Modified:
trunk/cdi/plugins/org.jboss.tools.cdi.seam.core/src/org/jboss/tools/cdi/seam/core/international/el/CDIInternationalMessagesELResolver.java
trunk/common/plugins/org.jboss.tools.common.el.core/src/org/jboss/tools/common/el/core/ca/AbstractELCompletionEngine.java
trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/JSF2CCAttrsELCompletionEngine.java
trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/JSFMessageELCompletionEngine.java
Log:
Code cleanup: multiple instances are replaced with static final IRelevanceCheck
implementation which always return false
Modified:
trunk/cdi/plugins/org.jboss.tools.cdi.seam.core/src/org/jboss/tools/cdi/seam/core/international/el/CDIInternationalMessagesELResolver.java
===================================================================
---
trunk/cdi/plugins/org.jboss.tools.cdi.seam.core/src/org/jboss/tools/cdi/seam/core/international/el/CDIInternationalMessagesELResolver.java 2011-08-23
22:32:14 UTC (rev 34190)
+++
trunk/cdi/plugins/org.jboss.tools.cdi.seam.core/src/org/jboss/tools/cdi/seam/core/international/el/CDIInternationalMessagesELResolver.java 2011-08-23
22:42:11 UTC (rev 34191)
@@ -669,11 +669,7 @@
}
public IRelevanceCheck createRelevanceCheck(IJavaElement element) {
- return new IRelevanceCheck() {
- public boolean isRelevant(String content) {
- return false;
- }
- };
+ return IRRELEVANT;
}
IResourceBundle[] findResourceBundles (IBundleModel model) {
Modified:
trunk/common/plugins/org.jboss.tools.common.el.core/src/org/jboss/tools/common/el/core/ca/AbstractELCompletionEngine.java
===================================================================
---
trunk/common/plugins/org.jboss.tools.common.el.core/src/org/jboss/tools/common/el/core/ca/AbstractELCompletionEngine.java 2011-08-23
22:32:14 UTC (rev 34190)
+++
trunk/common/plugins/org.jboss.tools.common.el.core/src/org/jboss/tools/common/el/core/ca/AbstractELCompletionEngine.java 2011-08-23
22:42:11 UTC (rev 34191)
@@ -60,6 +60,13 @@
import org.jboss.tools.common.text.TextProposal;
public abstract class AbstractELCompletionEngine<V extends IVariable> implements
ELResolver, ELCompletionEngine {
+
+ public static final IRelevanceCheck IRRELEVANT = new IRelevanceCheck() {
+ public boolean isRelevant(String content) {
+ return false;
+ }
+ };
+
public AbstractELCompletionEngine() {}
public abstract Image getELProposalImage();
Modified:
trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/JSF2CCAttrsELCompletionEngine.java
===================================================================
---
trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/JSF2CCAttrsELCompletionEngine.java 2011-08-23
22:32:14 UTC (rev 34190)
+++
trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/JSF2CCAttrsELCompletionEngine.java 2011-08-23
22:42:11 UTC (rev 34191)
@@ -639,13 +639,8 @@
public IRelevanceCheck createRelevanceCheck(IJavaElement element) {
- return new IRelevanceCheck() {
- public boolean isRelevant(String content) {
- return false;
- }
- };
+ return IRRELEVANT;
}
-
}
class JSF2CCAttrELSegmentImpl extends ELSegmentImpl {
Modified:
trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/JSFMessageELCompletionEngine.java
===================================================================
---
trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/JSFMessageELCompletionEngine.java 2011-08-23
22:32:14 UTC (rev 34190)
+++
trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/JSFMessageELCompletionEngine.java 2011-08-23
22:42:11 UTC (rev 34191)
@@ -702,11 +702,7 @@
}
public IRelevanceCheck createRelevanceCheck(IJavaElement element) {
- return new IRelevanceCheck() {
- public boolean isRelevant(String content) {
- return false;
- }
- };
+ return IRRELEVANT;
}
}
\ No newline at end of file