Author: rob.stryker(a)jboss.com Date: 2008-02-22 18:58:09 -0500 (Fri, 22 Feb 2008) New Revision: 6550 Modified: trunk/core/plugins/org.jboss.ide.eclipse.archives.core/src/eclipse/org/jboss/ide/eclipse/archives/core/WorkspaceArchivesCore.java trunk/core/plugins/org.jboss.ide.eclipse.archives.core/src/main/org/jboss/ide/eclipse/archives/core/ArchivesCore.java trunk/core/plugins/org.jboss.ide.eclipse.archives.core/src/main/org/jboss/ide/eclipse/archives/core/ant/AntArchivesCore.java trunk/core/plugins/org.jboss.ide.eclipse.archives.core/src/main/org/jboss/ide/eclipse/archives/core/model/ArchivesModel.java Log: Archives API refactor (code review) Modified: trunk/core/plugins/org.jboss.ide.eclipse.archives.core/src/eclipse/org/jboss/ide/eclipse/archives/core/WorkspaceArchivesCore.java =================================================================== --- trunk/core/plugins/org.jboss.ide.eclipse.archives.core/src/eclipse/org/jboss/ide/eclipse/archives/core/WorkspaceArchivesCore.java 2008-02-22 23:47:28 UTC (rev 6549) +++ trunk/core/plugins/org.jboss.ide.eclipse.archives.core/src/eclipse/org/jboss/ide/eclipse/archives/core/WorkspaceArchivesCore.java 2008-02-22 23:58:09 UTC (rev 6550) @@ -35,7 +35,7 @@ return new WorkspaceVariables(); } - public void preRegister(IPath project) { + public void preRegisterProject(IPath project) { ProjectUtils.addProjectNature(project); } Modified: trunk/core/plugins/org.jboss.ide.eclipse.archives.core/src/main/org/jboss/ide/eclipse/archives/core/ArchivesCore.java =================================================================== --- trunk/core/plugins/org.jboss.ide.eclipse.archives.core/src/main/org/jboss/ide/eclipse/archives/core/ArchivesCore.java 2008-02-22 23:47:28 UTC (rev 6549) +++ trunk/core/plugins/org.jboss.ide.eclipse.archives.core/src/main/org/jboss/ide/eclipse/archives/core/ArchivesCore.java 2008-02-22 23:58:09 UTC (rev 6550) @@ -66,10 +66,9 @@ protected abstract IPreferenceManager createPreferenceManager(); protected abstract IArchivesLogger createLogger(); - public boolean isWorkspaceRuntype() { - return runType == WORKSPACE; + public int getRunType() { + return runType; } - public IRuntimeVariables getVariables() { return variables; } @@ -83,5 +82,5 @@ return logger; } - public abstract void preRegister(IPath project); + public abstract void preRegisterProject(IPath project); } Modified: trunk/core/plugins/org.jboss.ide.eclipse.archives.core/src/main/org/jboss/ide/eclipse/archives/core/ant/AntArchivesCore.java =================================================================== --- trunk/core/plugins/org.jboss.ide.eclipse.archives.core/src/main/org/jboss/ide/eclipse/archives/core/ant/AntArchivesCore.java 2008-02-22 23:47:28 UTC (rev 6549) +++ trunk/core/plugins/org.jboss.ide.eclipse.archives.core/src/main/org/jboss/ide/eclipse/archives/core/ant/AntArchivesCore.java 2008-02-22 23:58:09 UTC (rev 6550) @@ -33,7 +33,7 @@ return new AntVariables(); } - public void preRegister(IPath project) { + public void preRegisterProject(IPath project) { } Modified: trunk/core/plugins/org.jboss.ide.eclipse.archives.core/src/main/org/jboss/ide/eclipse/archives/core/model/ArchivesModel.java =================================================================== --- trunk/core/plugins/org.jboss.ide.eclipse.archives.core/src/main/org/jboss/ide/eclipse/archives/core/model/ArchivesModel.java 2008-02-22 23:47:28 UTC (rev 6549) +++ trunk/core/plugins/org.jboss.ide.eclipse.archives.core/src/main/org/jboss/ide/eclipse/archives/core/model/ArchivesModel.java 2008-02-22 23:58:09 UTC (rev 6550) @@ -224,7 +224,7 @@ if( monitor == null ) monitor = new NullProgressMonitor(); monitor.beginTask("Loading configuration...", XMLBinding.NUM_UNMARSHAL_MONITOR_STEPS + 2); - ArchivesCore.getInstance().preRegister(project); + ArchivesCore.getInstance().preRegisterProject(project); ArchiveModelNode root; IPath packagesFile = project.append(PROJECT_PACKAGES_FILE);