Author: adietish Date: 2010-11-15 07:12:15 -0500 (Mon, 15 Nov 2010) New Revision: 26555 Modified: trunk/deltacloud/plugins/org.jboss.tools.deltacloud.ui/src/org/jboss/tools/internal/deltacloud/ui/wizards/NewInstanceModel.java Log: [JBIDE-7581] minor cleanup and documentation Modified: trunk/deltacloud/plugins/org.jboss.tools.deltacloud.ui/src/org/jboss/tools/internal/deltacloud/ui/wizards/NewInstanceModel.java =================================================================== --- trunk/deltacloud/plugins/org.jboss.tools.deltacloud.ui/src/org/jboss/tools/internal/deltacloud/ui/wizards/NewInstanceModel.java 2010-11-15 12:03:53 UTC (rev 26554) +++ trunk/deltacloud/plugins/org.jboss.tools.deltacloud.ui/src/org/jboss/tools/internal/deltacloud/ui/wizards/NewInstanceModel.java 2010-11-15 12:12:15 UTC (rev 26555) @@ -73,19 +73,25 @@ private String getArch(String id) { String arch = ""; if (id != null && id.length() > 0) { - DeltaCloudImage[] images = cloud.getCurrImages(); - for (int i = 0; i < images.length; ++i) { - DeltaCloudImage image = images[i]; - if (image.getId().equals(id)) { - imageContainer.setImage(image); - arch = image.getArchitecture(); - break; - } + DeltaCloudImage image = getImage(id, arch, cloud.getCurrImages()); + if (image != null) { + imageContainer.setImage(image); + arch = image.getArchitecture(); } } return arch; } + private DeltaCloudImage getImage(String id, String arch, DeltaCloudImage[] images) { + for (int i = 0; i < images.length; ++i) { + DeltaCloudImage image = images[i]; + if (image.getId().equals(id)) { + return image; + } + } + return null; + } + } public static class ArchValidator implements IValidator {