Author: mareshkau
Date: 2011-02-24 10:11:49 -0500 (Thu, 24 Feb 2011)
New Revision: 29310
Modified:
trunk/jsf/tests/org.jboss.tools.jsf.test/src/org/jboss/tools/jsf/test/validation/I18nValidatorTest.java
trunk/jst/plugins/org.jboss.tools.jst.web.kb/src/org/jboss/tools/jst/web/kb/preferences/ELPreferenceInitializer.java
trunk/jst/plugins/org.jboss.tools.jst.web.ui/src/org/jboss/tools/jst/web/ui/internal/preferences/ELSeverityPreferencesMessages.java
trunk/jst/plugins/org.jboss.tools.jst.web.ui/src/org/jboss/tools/jst/web/ui/internal/preferences/ELSeverityPreferencesMessages.properties
trunk/jst/plugins/org.jboss.tools.jst.web.ui/src/org/jboss/tools/jst/web/ui/internal/preferences/ELValidatorConfigurationBlock.java
Log:
https://issues.jboss.org/browse/JBIDE-7003, preferences has been added to validator
Modified:
trunk/jsf/tests/org.jboss.tools.jsf.test/src/org/jboss/tools/jsf/test/validation/I18nValidatorTest.java
===================================================================
---
trunk/jsf/tests/org.jboss.tools.jsf.test/src/org/jboss/tools/jsf/test/validation/I18nValidatorTest.java 2011-02-24
12:25:40 UTC (rev 29309)
+++
trunk/jsf/tests/org.jboss.tools.jsf.test/src/org/jboss/tools/jsf/test/validation/I18nValidatorTest.java 2011-02-24
15:11:49 UTC (rev 29310)
@@ -16,8 +16,11 @@
import org.eclipse.core.resources.ResourcesPlugin;
import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.NullProgressMonitor;
+import org.eclipse.jface.preference.IPreferenceStore;
import org.eclipse.wst.validation.ValidationFramework;
import org.jboss.tools.jsf.web.validation.i18n.I18nValidationComponent;
+import org.jboss.tools.jst.web.kb.WebKbPlugin;
+import org.jboss.tools.jst.web.kb.preferences.ELSeverityPreferences;
import org.jboss.tools.tests.AbstractResourceMarkerTest;
/**
@@ -44,4 +47,8 @@
assertEquals("Should be 2 Markers", 2,elMarkers.length); //$NON-NLS-1$
}
+ public void testDefaultStateI19nValidator(){
+ IPreferenceStore store = WebKbPlugin.getDefault().getPreferenceStore();
+ assertEquals("By Default I18nValidator should be
ignored",ELSeverityPreferences.IGNORE,store.getDefaultString(ELSeverityPreferences.NON_EXTERNALIZED_STRINGS));
//$NON-NLS-1$
+ }
}
Modified:
trunk/jst/plugins/org.jboss.tools.jst.web.kb/src/org/jboss/tools/jst/web/kb/preferences/ELPreferenceInitializer.java
===================================================================
---
trunk/jst/plugins/org.jboss.tools.jst.web.kb/src/org/jboss/tools/jst/web/kb/preferences/ELPreferenceInitializer.java 2011-02-24
12:25:40 UTC (rev 29309)
+++
trunk/jst/plugins/org.jboss.tools.jst.web.kb/src/org/jboss/tools/jst/web/kb/preferences/ELPreferenceInitializer.java 2011-02-24
15:11:49 UTC (rev 29310)
@@ -39,5 +39,6 @@
defaultPreferences.put(ELSeverityPreferences.CHECK_VARS,
ELSeverityPreferences.ENABLE);
defaultPreferences.put(ELSeverityPreferences.RE_VALIDATE_UNRESOLVED_EL,
ELSeverityPreferences.ENABLE);
defaultPreferences.putInt(SeverityPreferences.MAX_NUMBER_OF_MARKERS_PREFERENCE_NAME,
SeverityPreferences.DEFAULT_MAX_NUMBER_OF_MARKERS_PER_FILE);
+ defaultPreferences.put(ELSeverityPreferences.NON_EXTERNALIZED_STRINGS,
ELSeverityPreferences.IGNORE);
}
}
\ No newline at end of file
Modified:
trunk/jst/plugins/org.jboss.tools.jst.web.ui/src/org/jboss/tools/jst/web/ui/internal/preferences/ELSeverityPreferencesMessages.java
===================================================================
---
trunk/jst/plugins/org.jboss.tools.jst.web.ui/src/org/jboss/tools/jst/web/ui/internal/preferences/ELSeverityPreferencesMessages.java 2011-02-24
12:25:40 UTC (rev 29309)
+++
trunk/jst/plugins/org.jboss.tools.jst.web.ui/src/org/jboss/tools/jst/web/ui/internal/preferences/ELSeverityPreferencesMessages.java 2011-02-24
15:11:49 UTC (rev 29310)
@@ -34,6 +34,7 @@
public static String JSFValidatorConfigurationBlock_pb_revalidateUnresolvedEl_label;
public static String
JSFValidatorConfigurationBlock_pb_unknownElVariablePropertyName_label;
public static String JSFValidatorConfigurationBlock_pb_unpairedGetterOrSetter_label;
+ public static String JSFValidatorConfigurationBlock_pb_non_externalizedStrings_label;
static {
NLS.initializeMessages(BUNDLE_NAME, ELSeverityPreferencesMessages.class);
Modified:
trunk/jst/plugins/org.jboss.tools.jst.web.ui/src/org/jboss/tools/jst/web/ui/internal/preferences/ELSeverityPreferencesMessages.properties
===================================================================
---
trunk/jst/plugins/org.jboss.tools.jst.web.ui/src/org/jboss/tools/jst/web/ui/internal/preferences/ELSeverityPreferencesMessages.properties 2011-02-24
12:25:40 UTC (rev 29309)
+++
trunk/jst/plugins/org.jboss.tools.jst.web.ui/src/org/jboss/tools/jst/web/ui/internal/preferences/ELSeverityPreferencesMessages.properties 2011-02-24
15:11:49 UTC (rev 29310)
@@ -20,6 +20,7 @@
JSFValidatorConfigurationBlock_pb_revalidateUnresolvedEl_label=Revalidate unresolved ELs
automatically.
JSFValidatorConfigurationBlock_pb_unknownElVariablePropertyName_label=Property cannot be
resolved:
JSFValidatorConfigurationBlock_pb_unpairedGetterOrSetter_label=Unpaired Getter/Setter:
+JSFValidatorConfigurationBlock_pb_non_externalizedStrings_label=Non-externalized
strings:
JSF_VALIDATOR_CONFIGURATION_BLOCK_JSF_VALIDATOR_CONFIGURATION_BLOCK=JSFValidatorConfigurationBlock
JSF_VALIDATOR_PREFERENCE_PAGE_JSF_VALIDATOR=Expression Language Validator
\ No newline at end of file
Modified:
trunk/jst/plugins/org.jboss.tools.jst.web.ui/src/org/jboss/tools/jst/web/ui/internal/preferences/ELValidatorConfigurationBlock.java
===================================================================
---
trunk/jst/plugins/org.jboss.tools.jst.web.ui/src/org/jboss/tools/jst/web/ui/internal/preferences/ELValidatorConfigurationBlock.java 2011-02-24
12:25:40 UTC (rev 29309)
+++
trunk/jst/plugins/org.jboss.tools.jst.web.ui/src/org/jboss/tools/jst/web/ui/internal/preferences/ELValidatorConfigurationBlock.java 2011-02-24
15:11:49 UTC (rev 29310)
@@ -53,6 +53,7 @@
{ELSeverityPreferences.UNKNOWN_EL_VARIABLE_NAME,
ELSeverityPreferencesMessages.JSFValidatorConfigurationBlock_pb_unknownElVariableName_label},
{ELSeverityPreferences.UNKNOWN_EL_VARIABLE_PROPERTY_NAME,
ELSeverityPreferencesMessages.JSFValidatorConfigurationBlock_pb_unknownElVariablePropertyName_label},
{ELSeverityPreferences.UNPAIRED_GETTER_OR_SETTER,
ELSeverityPreferencesMessages.JSFValidatorConfigurationBlock_pb_unpairedGetterOrSetter_label},
+ {ELSeverityPreferences.NON_EXTERNALIZED_STRINGS,
ELSeverityPreferencesMessages.JSFValidatorConfigurationBlock_pb_non_externalizedStrings_label}
},
WebKbPlugin.PLUGIN_ID
);