Author: tfennelly
Date: 2011-06-20 12:54:51 -0400 (Mon, 20 Jun 2011)
New Revision: 32227
Modified:
trunk/smooks/plugins/org.jboss.tools.smooks.ui/src/org/jboss/tools/smooks/configuration/editors/uitls/ProjectClassLoader.java
trunk/smooks/plugins/org.jboss.tools.smooks.ui/src/org/jboss/tools/smooks/graphical/wizards/JavaBeanCreationWizardPage.java
trunk/smooks/plugins/org.jboss.tools.smooks.ui/src/org/jboss/tools/smooks/graphical/wizards/Messages.java
trunk/smooks/plugins/org.jboss.tools.smooks.ui/src/org/jboss/tools/smooks/graphical/wizards/messages.properties
Log:
JBIDE-9197: No user error message for UnsupportedClassVersionError
https://issues.jboss.org/browse/JBIDE-9197
Modified:
trunk/smooks/plugins/org.jboss.tools.smooks.ui/src/org/jboss/tools/smooks/configuration/editors/uitls/ProjectClassLoader.java
===================================================================
---
trunk/smooks/plugins/org.jboss.tools.smooks.ui/src/org/jboss/tools/smooks/configuration/editors/uitls/ProjectClassLoader.java 2011-06-20
16:46:47 UTC (rev 32226)
+++
trunk/smooks/plugins/org.jboss.tools.smooks.ui/src/org/jboss/tools/smooks/configuration/editors/uitls/ProjectClassLoader.java 2011-06-20
16:54:51 UTC (rev 32227)
@@ -77,17 +77,18 @@
.getLocation();
for (int i = 0; i < roots.length; i++) {
try {
- if (roots[i].isArchive()) {
+ IPackageFragmentRoot iPackageFragmentRoot = roots[i];
+ if (iPackageFragmentRoot.isArchive()) {
File f = new File(FileLocator.resolve(
- installPath.append(roots[i].getPath()).toFile()
+ installPath.append(iPackageFragmentRoot.getPath()).toFile()
.toURL()).getFile());
if (!f.exists()) {
f = new File(FileLocator.resolve(
- roots[i].getPath().makeAbsolute().toFile()
+ iPackageFragmentRoot.getPath().makeAbsolute().toFile()
.toURL()).getFile());
}
if (!f.exists()) {
- IJavaElement javaElement = roots[i].getPrimaryElement();
+ IJavaElement javaElement = iPackageFragmentRoot.getPrimaryElement();
String jarName = javaElement.getElementName();
IResource jarResource = project.getProject().findMember(jarName);
@@ -98,14 +99,14 @@
list.add(f.toURL());
} else {
- IPath path = roots[i].getJavaProject().getOutputLocation();
+ IPath path = iPackageFragmentRoot.getJavaProject().getOutputLocation();
if (path.segmentCount() > 1) {
IWorkspaceRoot root = ResourcesPlugin.getWorkspace()
.getRoot();
path = root.getFolder(path).getLocation();
list.add(path.toFile().toURL());
} else {
- path = roots[i].getJavaProject().getProject()
+ path = iPackageFragmentRoot.getJavaProject().getProject()
.getLocation();
list.add(path.toFile().toURL());
}
Modified:
trunk/smooks/plugins/org.jboss.tools.smooks.ui/src/org/jboss/tools/smooks/graphical/wizards/JavaBeanCreationWizardPage.java
===================================================================
---
trunk/smooks/plugins/org.jboss.tools.smooks.ui/src/org/jboss/tools/smooks/graphical/wizards/JavaBeanCreationWizardPage.java 2011-06-20
16:46:47 UTC (rev 32226)
+++
trunk/smooks/plugins/org.jboss.tools.smooks.ui/src/org/jboss/tools/smooks/graphical/wizards/JavaBeanCreationWizardPage.java 2011-06-20
16:54:51 UTC (rev 32227)
@@ -439,6 +439,8 @@
}
protected void refreshJavaBeanModel() {
+ String error = null;
+
if (beanClass == null || "".equals(beanClass.trim())) { //$NON-NLS-1$
viewer.setInput(""); //$NON-NLS-1$
} else {
@@ -471,8 +473,13 @@
viewer.setInput(""); //$NON-NLS-1$
} catch (ClassNotFoundException e1) {
viewer.setInput(""); //$NON-NLS-1$
+ error = Messages.JavaBeanCreationWizardPage_ClassNotFoundException;
+ } catch (UnsupportedClassVersionError classVersion) {
+ error = Messages.JavaBeanCreationWizardPage_UnsupportedClassVersionError;
}
}
+ this.setErrorMessage(error);
+ this.setPageComplete(error == null);
}
private void createBeanClassControls(Composite mainComposite) {
Modified:
trunk/smooks/plugins/org.jboss.tools.smooks.ui/src/org/jboss/tools/smooks/graphical/wizards/Messages.java
===================================================================
---
trunk/smooks/plugins/org.jboss.tools.smooks.ui/src/org/jboss/tools/smooks/graphical/wizards/Messages.java 2011-06-20
16:46:47 UTC (rev 32226)
+++
trunk/smooks/plugins/org.jboss.tools.smooks.ui/src/org/jboss/tools/smooks/graphical/wizards/Messages.java 2011-06-20
16:54:51 UTC (rev 32227)
@@ -8,6 +8,8 @@
public static String JavaBeanCreationWizardPage_27;
public static String JavaBeanCreationWizardPage_ArrayButtonText;
public static String JavaBeanCreationWizardPage_BeanClassEmptyErrorMessage;
+ public static String JavaBeanCreationWizardPage_UnsupportedClassVersionError;
+ public static String JavaBeanCreationWizardPage_ClassNotFoundException;
public static String JavaBeanCreationWizardPage_BeanClassLabel;
public static String JavaBeanCreationWizardPage_BeanIDDuplicateErrorMessage1;
public static String JavaBeanCreationWizardPage_BeanIDDuplicateErrorMessage2;
Modified:
trunk/smooks/plugins/org.jboss.tools.smooks.ui/src/org/jboss/tools/smooks/graphical/wizards/messages.properties
===================================================================
---
trunk/smooks/plugins/org.jboss.tools.smooks.ui/src/org/jboss/tools/smooks/graphical/wizards/messages.properties 2011-06-20
16:46:47 UTC (rev 32226)
+++
trunk/smooks/plugins/org.jboss.tools.smooks.ui/src/org/jboss/tools/smooks/graphical/wizards/messages.properties 2011-06-20
16:54:51 UTC (rev 32227)
@@ -2,6 +2,8 @@
JavaBeanCreationWizardPage_27="
JavaBeanCreationWizardPage_ArrayButtonText=Array
JavaBeanCreationWizardPage_BeanClassEmptyErrorMessage=Java Class must be configured
+JavaBeanCreationWizardPage_UnsupportedClassVersionError=Class compile version not
supported by Java Environment
+JavaBeanCreationWizardPage_ClassNotFoundException=Class not found on project Classpath
JavaBeanCreationWizardPage_BeanClassLabel=Java Class :
JavaBeanCreationWizardPage_BeanIDDuplicateErrorMessage1=Bean ID '
JavaBeanCreationWizardPage_BeanIDDuplicateErrorMessage2=' is duplicate