Author: adietish Date: 2012-02-14 11:20:57 -0500 (Tue, 14 Feb 2012) New Revision: 38711 Modified: trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/action/DeleteApplicationAction.java Log: cleanup for better readability Modified: trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/action/DeleteApplicationAction.java =================================================================== --- trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/action/DeleteApplicationAction.java 2012-02-14 16:16:44 UTC (rev 38710) +++ trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/action/DeleteApplicationAction.java 2012-02-14 16:20:57 UTC (rev 38711) @@ -5,6 +5,7 @@ import org.eclipse.core.runtime.Status; import org.eclipse.core.runtime.jobs.Job; import org.eclipse.jface.dialogs.MessageDialog; +import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.ITreeSelection; import org.eclipse.swt.widgets.Display; import org.eclipse.ui.ISharedImages; @@ -32,7 +33,7 @@ */ @Override public void run() { - if (selection != null && selection instanceof ITreeSelection && ((ITreeSelection)selection).getFirstElement() instanceof IApplication) { + if (isApplication(selection)) { final IApplication application = (IApplication) ((ITreeSelection)selection).getFirstElement(); final String appName = application.getName(); final boolean confirm = MessageDialog @@ -60,4 +61,10 @@ } } + private boolean isApplication(ISelection selection) { + return selection != null + && selection instanceof ITreeSelection + && ((ITreeSelection)selection).getFirstElement() instanceof IApplication; + } + }