Author: max.andersen(a)jboss.com
Date: 2007-08-25 07:43:20 -0400 (Sat, 25 Aug 2007)
New Revision: 3334
Modified:
trunk/as/plugins/org.jboss.ide.eclipse.as.core/jbosscore/org/jboss/ide/eclipse/as/core/server/JBossServer.java
Log:
avoid NPE and more specific exception
Modified:
trunk/as/plugins/org.jboss.ide.eclipse.as.core/jbosscore/org/jboss/ide/eclipse/as/core/server/JBossServer.java
===================================================================
---
trunk/as/plugins/org.jboss.ide.eclipse.as.core/jbosscore/org/jboss/ide/eclipse/as/core/server/JBossServer.java 2007-08-25
11:40:48 UTC (rev 3333)
+++
trunk/as/plugins/org.jboss.ide.eclipse.as.core/jbosscore/org/jboss/ide/eclipse/as/core/server/JBossServer.java 2007-08-25
11:43:20 UTC (rev 3334)
@@ -198,13 +198,18 @@
}
protected int findPort(IPath path) {
- try {
+
XPathQuery query = XPathModel.getDefault().getQuery(getServer(), path);
- String result = query.getFirstResult();
- if( result != null ) {
- return Integer.parseInt(result);
- }
- } catch( Exception e ) {}
+ if(query!=null) {
+ String result = query.getFirstResult();
+ if( result != null ) {
+ try {
+ return Integer.parseInt(result);
+ } catch(NumberFormatException nfe) {
+ return -1;
+ }
+ }
+ }
return -1;
}
Show replies by date