Author: rob.stryker(a)jboss.com Date: 2007-11-07 21:06:54 -0500 (Wed, 07 Nov 2007) New Revision: 4766 Modified: trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/views/server/providers/jmx/JMXPropertySheetPage.java trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/views/server/providers/jmx/OperationGroup.java Log: Operations enhanced ;) Modified: trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/views/server/providers/jmx/JMXPropertySheetPage.java =================================================================== --- trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/views/server/providers/jmx/JMXPropertySheetPage.java 2007-11-08 01:03:08 UTC (rev 4765) +++ trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/views/server/providers/jmx/JMXPropertySheetPage.java 2007-11-08 02:06:54 UTC (rev 4766) @@ -21,6 +21,8 @@ */ package org.jboss.ide.eclipse.as.ui.views.server.providers.jmx; +import java.util.ArrayList; + import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.swt.SWT; @@ -281,4 +283,28 @@ return null; } + + public static Object box(String type, String text) { + Object val = null; + try { + if( type.equals("java.lang.String")) val = text; + else if( type.equals("boolean")) val = new Boolean(text); + else if( type.equals("int")) val = new Integer(text); + else if( type.equals("long")) val = new Long(text); + } catch( Exception e ) {} + return val; + } + + protected static ArrayList<String> simpleTypeList = null; + public static boolean isSimpleType(String fullClassName) { + if( simpleTypeList == null ) { + simpleTypeList = new ArrayList<String>(); + simpleTypeList.add("java.lang.String"); + simpleTypeList.add("boolean"); + simpleTypeList.add("int"); + simpleTypeList.add("long"); + } + return simpleTypeList.contains(fullClassName); + } + } Modified: trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/views/server/providers/jmx/OperationGroup.java =================================================================== --- trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/views/server/providers/jmx/OperationGroup.java 2007-11-08 01:03:08 UTC (rev 4765) +++ trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/views/server/providers/jmx/OperationGroup.java 2007-11-08 02:06:54 UTC (rev 4766) @@ -44,13 +44,16 @@ import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Display; +import org.eclipse.swt.widgets.Text; import org.eclipse.swt.widgets.Tree; import org.eclipse.swt.widgets.TreeColumn; +import org.eclipse.swt.widgets.TreeItem; import org.jboss.ide.eclipse.as.core.extensions.jmx.JMXModel.JMXRunnable; import org.jboss.ide.eclipse.as.core.extensions.jmx.JMXModel.JMXSafeRunner; import org.jboss.ide.eclipse.as.core.extensions.jmx.JMXModel.WrappedMBeanOperationInfo; import org.jboss.ide.eclipse.as.core.extensions.jmx.JMXModel.WrappedMBeanOperationParameter; import org.jboss.ide.eclipse.as.ui.JBossServerUIPlugin; +import org.jboss.ide.eclipse.as.ui.views.server.providers.jmx.TreeEditorSelectionListener.SelectionCallbackHandler; /** * @@ -122,8 +125,32 @@ executePressed(); } }); + + SelectionCallbackHandler handler = new SelectionCallbackHandler() { + public boolean canModify(TreeItem item) { + return true; + } + public void cannotModify(TreeItem item) { + } + public void handleChange(TreeItem item, Text text) { + saveParam(item, text); + } + }; + TreeEditorSelectionListener listener = new TreeEditorSelectionListener(tree, 2, handler); + tree.addListener(SWT.MouseDoubleClick, listener); } + protected void saveParam(TreeItem item, Text text) { + Object o = item.getData(); + if( o instanceof MBeanParameterInfo ) { + MBeanParameterInfo o2 = (MBeanParameterInfo)o; + opParams.put((MBeanParameterInfo)o, + JMXPropertySheetPage.box(o2.getType(), text.getText())); + treeViewer.refresh(); + } + System.out.println(text.getText()); + } + protected void executePressed() { final Boolean[] errorBool = new Boolean[1]; final JMXRunnable run = new JMXRunnable() { @@ -131,7 +158,7 @@ try { ObjectName on = selectedOperation.getBean().getObjectName(); String opName = selectedOperation.getInfo().getName(); - connection.invoke(on, opName, getParams(), getSignatures()); + Object ret = connection.invoke(on, opName, getParams(), getSignatures()); } catch (final Exception e) { Display.getDefault().asyncExec(new Runnable() { public void run() { IStatus status = new Status(IStatus.ERROR, JBossServerUIPlugin.PLUGIN_ID, e.getMessage(), e);