Author: adietish Date: 2011-09-27 14:04:55 -0400 (Tue, 27 Sep 2011) New Revision: 35078 Modified: trunk/as/plugins/org.jboss.ide.eclipse.as.openshift.core/src/org/jboss/ide/eclipse/as/openshift/core/ApplicationLogReader.java trunk/as/tests/org.jboss.ide.eclipse.as.openshift.test/src/org/jboss/ide/eclipse/as/openshift/test/internal/core/ApplicationLogReaderIntegrationTest.java trunk/as/tests/org.jboss.ide.eclipse.as.openshift.test/src/org/jboss/ide/eclipse/as/openshift/test/internal/core/ApplicationLogReaderTest.java Log: [JBIDE-9773] correcting ApplicationLogReader implementation and adding new tests Modified: trunk/as/plugins/org.jboss.ide.eclipse.as.openshift.core/src/org/jboss/ide/eclipse/as/openshift/core/ApplicationLogReader.java =================================================================== --- trunk/as/plugins/org.jboss.ide.eclipse.as.openshift.core/src/org/jboss/ide/eclipse/as/openshift/core/ApplicationLogReader.java 2011-09-27 18:03:33 UTC (rev 35077) +++ trunk/as/plugins/org.jboss.ide.eclipse.as.openshift.core/src/org/jboss/ide/eclipse/as/openshift/core/ApplicationLogReader.java 2011-09-27 18:04:55 UTC (rev 35078) @@ -53,7 +53,6 @@ if (charactersRead == -1) { this.logReader = null; } - System.err.println("charactersRead = " + charactersRead); } return charactersRead; } catch (OpenshiftException e) { Modified: trunk/as/tests/org.jboss.ide.eclipse.as.openshift.test/src/org/jboss/ide/eclipse/as/openshift/test/internal/core/ApplicationLogReaderIntegrationTest.java =================================================================== --- trunk/as/tests/org.jboss.ide.eclipse.as.openshift.test/src/org/jboss/ide/eclipse/as/openshift/test/internal/core/ApplicationLogReaderIntegrationTest.java 2011-09-27 18:03:33 UTC (rev 35077) +++ trunk/as/tests/org.jboss.ide.eclipse.as.openshift.test/src/org/jboss/ide/eclipse/as/openshift/test/internal/core/ApplicationLogReaderIntegrationTest.java 2011-09-27 18:04:55 UTC (rev 35078) @@ -35,6 +35,7 @@ */ public class ApplicationLogReaderIntegrationTest { + private static final int LOGREADER_TIMEOUT = 10 * 1024; private IOpenshiftService service; private TestUser user; @@ -90,7 +91,7 @@ try { application = user.createTestApplication(); ApplicationLogReader logReader = application.getLogReader(); - LogReaderRunnable logReaderRunnable = new LogReaderRunnable(logReader, 10 * 1024); + LogReaderRunnable logReaderRunnable = new LogReaderRunnable(logReader, LOGREADER_TIMEOUT); executor = Executors.newSingleThreadExecutor(); executor.submit(logReaderRunnable); Modified: trunk/as/tests/org.jboss.ide.eclipse.as.openshift.test/src/org/jboss/ide/eclipse/as/openshift/test/internal/core/ApplicationLogReaderTest.java =================================================================== --- trunk/as/tests/org.jboss.ide.eclipse.as.openshift.test/src/org/jboss/ide/eclipse/as/openshift/test/internal/core/ApplicationLogReaderTest.java 2011-09-27 18:03:33 UTC (rev 35077) +++ trunk/as/tests/org.jboss.ide.eclipse.as.openshift.test/src/org/jboss/ide/eclipse/as/openshift/test/internal/core/ApplicationLogReaderTest.java 2011-09-27 18:04:55 UTC (rev 35078) @@ -31,6 +31,7 @@ */ public class ApplicationLogReaderTest { + private static final int LOGREADER_TIMEOUT = 1 * 1024; private Application application; @Before @@ -43,7 +44,7 @@ ExecutorService executor = null; try { ApplicationLogReader logReader = application.getLogReader(); - LogReaderRunnable logReaderRunnable = new LogReaderRunnable(logReader, 1 * 1024); + LogReaderRunnable logReaderRunnable = new LogReaderRunnable(logReader, LOGREADER_TIMEOUT); executor = Executors.newSingleThreadExecutor(); executor.submit(logReaderRunnable);