Author: dgolovin Date: 2007-12-19 19:11:44 -0500 (Wed, 19 Dec 2007) New Revision: 5382 Modified: trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/handlers/DeleteFacesConfigHandler.java trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/handlers/DeleteGroupHandler.java trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/handlers/DeleteManagedBeanHandler.java trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/handlers/DeleteRuleHandler.java trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/handlers/bean/DeleteManagedPropertyHandler.java Log: Cleanup the code: 1. new Long(value) replaced for Long.valueOf(value) 2. new String() removed 3. new Boolean(true/false) replaced to Boolean.TRUE/FALSE 4. Unused packages were removed from seam.plugins 5. Throwing of NullPointerException replaced to IllegalArgument Exception 6. catch Exception replaced to particular Exception types in several places Modified: trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/handlers/DeleteFacesConfigHandler.java =================================================================== --- trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/handlers/DeleteFacesConfigHandler.java 2007-12-20 00:11:39 UTC (rev 5381) +++ trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/handlers/DeleteFacesConfigHandler.java 2007-12-20 00:11:44 UTC (rev 5382) @@ -30,7 +30,7 @@ String message = "Delete faces-config " + FileAnyImpl.toFileName(object); pd.setProperty(ServiceDialog.DIALOG_MESSAGE, message); pd.setProperty(ServiceDialog.CHECKBOX_MESSAGE, "Delete reference from web.xml"); - pd.put(ServiceDialog.CHECKED, new Boolean(true)); + pd.put(ServiceDialog.CHECKED, Boolean.TRUE); if(!d.openConfirm(pd)) return; Boolean b = (Boolean)pd.get(ServiceDialog.CHECKED); unregister = b.booleanValue(); Modified: trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/handlers/DeleteGroupHandler.java =================================================================== --- trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/handlers/DeleteGroupHandler.java 2007-12-20 00:11:39 UTC (rev 5381) +++ trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/handlers/DeleteGroupHandler.java 2007-12-20 00:11:44 UTC (rev 5382) @@ -50,7 +50,7 @@ int q = confirmPageDelete(object.getModel(), message); if(q < 0) return; deletePage = (q == 0); - if(p != null) p.put("deletePage", new Boolean(q == 0)); + if(p != null) p.put("deletePage", Boolean.valueOf(q == 0)); } g.getModel().changeObjectAttribute(g, "persistent", "false"); XModelObject[] cs = g.getReferences(); @@ -70,7 +70,7 @@ ServiceDialog d = model.getService(); Properties dp = new Properties(); dp.setProperty(ServiceDialog.DIALOG_MESSAGE, message); - dp.put(ServiceDialog.CHECKED, new Boolean(false)); + dp.put(ServiceDialog.CHECKED, Boolean.FALSE); dp.setProperty(ServiceDialog.CHECKBOX_MESSAGE, "Delete file from disk"); if(!d.openConfirm(dp)) return -1; Boolean b = (Boolean)dp.get(ServiceDialog.CHECKED); Modified: trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/handlers/DeleteManagedBeanHandler.java =================================================================== --- trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/handlers/DeleteManagedBeanHandler.java 2007-12-20 00:11:39 UTC (rev 5381) +++ trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/handlers/DeleteManagedBeanHandler.java 2007-12-20 00:11:44 UTC (rev 5382) @@ -34,7 +34,7 @@ String message = SignificanceMessageFactory.getInstance().getMessage(action, object, null) + "?"; pd.setProperty(ServiceDialog.DIALOG_MESSAGE, message); pd.setProperty(ServiceDialog.CHECKBOX_MESSAGE, JSFUIMessages.DELETE_JAVA_SOURCE); - pd.put(ServiceDialog.CHECKED, new Boolean(false)); + pd.put(ServiceDialog.CHECKED, Boolean.FALSE); if(!d.openConfirm(pd)) return; Boolean b = (Boolean)pd.get(ServiceDialog.CHECKED); unregister = b.booleanValue(); Modified: trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/handlers/DeleteRuleHandler.java =================================================================== --- trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/handlers/DeleteRuleHandler.java 2007-12-20 00:11:39 UTC (rev 5381) +++ trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/handlers/DeleteRuleHandler.java 2007-12-20 00:11:44 UTC (rev 5382) @@ -39,7 +39,7 @@ ServiceDialog d = object.getModel().getService(); Properties dp = new Properties(); dp.setProperty(ServiceDialog.DIALOG_MESSAGE, JSFUIMessages.DELETE + DefaultCreateHandler.title(object, false) + "?"); - dp.put(ServiceDialog.CHECKED, new Boolean(false)); + dp.put(ServiceDialog.CHECKED, Boolean.FALSE); dp.setProperty(ServiceDialog.CHECKBOX_MESSAGE, JSFUIMessages.DELETE_FILE_FROM_DISK); if(!d.openConfirm(dp)) return; Boolean b = (Boolean)dp.get(ServiceDialog.CHECKED); Modified: trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/handlers/bean/DeleteManagedPropertyHandler.java =================================================================== --- trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/handlers/bean/DeleteManagedPropertyHandler.java 2007-12-20 00:11:39 UTC (rev 5381) +++ trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/model/handlers/bean/DeleteManagedPropertyHandler.java 2007-12-20 00:11:44 UTC (rev 5382) @@ -38,7 +38,7 @@ p = new Properties(); p.setProperty(ServiceDialog.DIALOG_MESSAGE, message); p.setProperty(ServiceDialog.CHECKBOX_MESSAGE, "Delete java property"); - p.put(ServiceDialog.CHECKED, new Boolean(false)); + p.put(ServiceDialog.CHECKED, Boolean.FALSE); if(!d.openConfirm(p)) return; Boolean b = (Boolean)p.get(ServiceDialog.CHECKED); deleteField = (b != null) && b.booleanValue();