Author: vrubezhny Date: 2008-05-20 14:28:59 -0400 (Tue, 20 May 2008) New Revision: 8239 Modified: trunk/jsf/plugins/org.jboss.tools.jsf.text.ext/src/org/jboss/tools/jsf/text/ext/hyperlink/ForwardHyperlink.java Log: http://jira.jboss.com/jira/browse/JBIDE-2226 NPE if user openon non-existent "image" attribute link of h:commandButton. Issue is fixed Modified: trunk/jsf/plugins/org.jboss.tools.jsf.text.ext/src/org/jboss/tools/jsf/text/ext/hyperlink/ForwardHyperlink.java =================================================================== --- trunk/jsf/plugins/org.jboss.tools.jsf.text.ext/src/org/jboss/tools/jsf/text/ext/hyperlink/ForwardHyperlink.java 2008-05-20 18:08:42 UTC (rev 8238) +++ trunk/jsf/plugins/org.jboss.tools.jsf.text.ext/src/org/jboss/tools/jsf/text/ext/hyperlink/ForwardHyperlink.java 2008-05-20 18:28:59 UTC (rev 8239) @@ -34,7 +34,7 @@ protected void doHyperlink(IRegion region) { String fileName = getFilePath(region); IFile fileToOpen = getFileToOpen(fileName); - if (fileToOpen.exists()) { + if (fileToOpen != null && fileToOpen.exists()) { IWorkbenchPage workbenchPage = JSFExtensionsPlugin.getDefault().getWorkbench().getActiveWorkbenchWindow().getActivePage(); try { IDE.openEditor(workbenchPage,fileToOpen,true); @@ -52,9 +52,8 @@ return getDocument().get(region.getOffset(), region.getLength()); } catch (BadLocationException x) { JSFExtensionsPlugin.log("", x); - return null; - } finally { } + return null; } private IFile getFileToOpen(String fileName) {