Author: dmaliarevich Date: 2008-02-18 12:48:59 -0500 (Mon, 18 Feb 2008) New Revision: 6408 Modified: trunk/vpe/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/VpeVisualDomBuilder.java trunk/vpe/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/template/VpeDataTableCreator.java Log: http://jira.jboss.com/jira/browse/JBIDE-1744, layout fixed, attributes changing fixed Modified: trunk/vpe/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/VpeVisualDomBuilder.java =================================================================== --- trunk/vpe/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/VpeVisualDomBuilder.java 2008-02-18 17:11:37 UTC (rev 6407) +++ trunk/vpe/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/VpeVisualDomBuilder.java 2008-02-18 17:48:59 UTC (rev 6408) @@ -957,7 +957,15 @@ } else if (HTML.TAG_INPUT .equalsIgnoreCase(visualElementName)) { updateElement(sourceElement); + // Fixes JBIDE-1744 author dmaliarevich + // unified h:dataTable border lookup + // after attribute change and + // after visual editor refresh + } else if (HTML.TAG_TABLE + .equalsIgnoreCase(visualElementName)) { + updateElement(sourceElement); } + // End of fix } // setXmlnsAttribute(elementMapping, name, value); template.setAttribute(pageContext, sourceElement, Modified: trunk/vpe/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/template/VpeDataTableCreator.java =================================================================== --- trunk/vpe/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/template/VpeDataTableCreator.java 2008-02-18 17:11:37 UTC (rev 6407) +++ trunk/vpe/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/template/VpeDataTableCreator.java 2008-02-18 17:48:59 UTC (rev 6408) @@ -201,7 +201,7 @@ nsIDOMElement outterTBODY = visualDocument.createElement(HTML.TAG_TBODY); nsIDOMElement outterTR = visualDocument.createElement(HTML.TAG_TR); - nsIDOMElement outterTD = visualDocument.createElement(HTML.TAG_TR); + nsIDOMElement outterTD = visualDocument.createElement(HTML.TAG_TD); outterTD.appendChild(visualTable); outterTR.appendChild(outterTD); @@ -223,10 +223,10 @@ if (info1 != null && info1.getVisualNode() != null) { nsIDOMAttr attr = (nsIDOMAttr) info1.getVisualNode(); // Fixes creation 'border="1"' - // when setting border attribute to the table - if (VpeTemplateManager.ATTR_ANY_BORDER.equalsIgnoreCase(attr.getNodeName()) - && (null == attr.getNodeValue() || "".equalsIgnoreCase(attr.getNodeValue()))) { - attr.setNodeValue("0"); + // when setting border attribute to the table. + // Also skips empty attributes to fix layout problems. + if (null == attr.getNodeValue() || "".equalsIgnoreCase(attr.getNodeValue())) { + continue; } outterTable.setAttributeNode(attr); }