Author: dgolovin Date: 2008-08-20 12:48:39 -0400 (Wed, 20 Aug 2008) New Revision: 9836 Modified: trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common/editor/ObjectMultiPageEditor.java Log: PMD violations fix. catch(Exception ex) blocks changed to catching particular exceptions. Modified: trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common/editor/ObjectMultiPageEditor.java =================================================================== --- trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common/editor/ObjectMultiPageEditor.java 2008-08-20 16:21:32 UTC (rev 9835) +++ trunk/common/plugins/org.jboss.tools.common.model.ui/src/org/jboss/tools/common/editor/ObjectMultiPageEditor.java 2008-08-20 16:48:39 UTC (rev 9836) @@ -466,8 +466,8 @@ } else if(object.getParent() instanceof FolderImpl) { ((FolderImpl)object.getParent()).discardChildFile(object); } - } catch (Exception e) { - //ignore + } catch (XModelException e) { + ModelPlugin.getPluginLog().logError(e); } } if (outline!=null) outline.dispose(); @@ -508,10 +508,9 @@ while(needsUpdate()) { update0(); } - } catch (Exception t) { - ModelUIPlugin.getPluginLog().logError("Error in updating editor", t); + } finally { + lock2 = false; } - lock2 = false; } } @@ -774,7 +773,7 @@ this.fModificationStamp = ((IFileEditorInput)input).getFile() .getLocation().toFile().lastModified(); } - } catch (Exception ex) { + } finally { this.fModificationStamp = -1; } } @@ -879,7 +878,7 @@ selectionProvider.addHost("treeEditor", formPage.getSelectionProvider()); //Activate key binding service here formPage.getEditorSite().getKeyBindingService(); - } catch (Exception ex) { + } catch (PartInitException ex) { ModelUIPlugin.getPluginLog().logError(ex); } //getSite().setSelectionProvider(formPage.getSelectionProvider());