[JBoss JIRA] (JBTM-1293) ATBridgeTest#testSimple counter isn't incremented
by Gytis Trikleris (JIRA)
[ https://issues.jboss.org/browse/JBTM-1293?page=com.atlassian.jira.plugin.... ]
Gytis Trikleris commented on JBTM-1293:
---------------------------------------
http://172.17.131.2/job/jbossts-narayana-java7/106
> ATBridgeTest#testSimple counter isn't incremented
> -------------------------------------------------
>
> Key: JBTM-1293
> URL: https://issues.jboss.org/browse/JBTM-1293
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Testing, TXFramework
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Fix For: 5.0.0.M2
>
> Original Estimate: 3 days
> Remaining Estimate: 3 days
>
> See:
> http://172.17.131.2/view/Narayana+BlackTie/job/jbossts-narayana-java7/21/...
> {code}
> @Test
> public void testSimple() throws Exception
> {
> ut.begin();
> client.incrementCounter(1);
> ut.commit();
> ut.begin();
> int counter = client.getCounter();
> ut.commit();
> Assert.assertEquals(1, counter);
> }
> {code}
> Even though the first transaction should have committed an update to the counter, it is still set to zero in the second transaction.
> This happens intermittently (once so far). It also happened on Beacon which is notorious for test failures caused by things going slowly. I would suspect that the bridged JTA transaction in the first transaction hasn't quite finished the commit when the second transaction is begun.
> If the WS-AT coordinator sends an async commit to the participants and an async committed to the client, then this problem could happen if the client's 'committed' is received before the participant's 'commit' message.
> To verify this we need to check that the coordinator sends an async (@OneWay) commit message to the participant. In which case the simplest solution is to add a 3sec delay between the two transactions. We should also look for other tests that may be affected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 4 months
[JBoss JIRA] (JBTM-1145) TXFramework Code Tidy Part 2
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1145?page=com.atlassian.jira.plugin.... ]
Paul Robinson updated JBTM-1145:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> TXFramework Code Tidy Part 2
> ----------------------------
>
> Key: JBTM-1145
> URL: https://issues.jboss.org/browse/JBTM-1145
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: TXFramework
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Fix For: 5.0.0.M2
>
> Original Estimate: 1 day
> Time Spent: 5 hours
> Remaining Estimate: 0 minutes
>
> Remove annotations and properties that are not used.
> Remove System.out and System.err. For example:
> {code}
> 15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
> 15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
> {code}
> Add logging
> Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
> Remove Statefull tests
> Consider making handlers statefull
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 4 months
[JBoss JIRA] (JBTM-1289) XTS participant completion tests should use a rendezvous to delay close until participant has completed
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1289?page=com.atlassian.jira.plugin.... ]
Paul Robinson commented on JBTM-1289:
-------------------------------------
Needs applying to 4.16.7. Merged in 4.17 and 5 branches.
> XTS participant completion tests should use a rendezvous to delay close until participant has completed
> -------------------------------------------------------------------------------------------------------
>
> Key: JBTM-1289
> URL: https://issues.jboss.org/browse/JBTM-1289
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: Testing, XTS
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Priority: Minor
> Fix For: 4.16.7, 4.17.4, 5.0.0.M2
>
>
> The problem is that the participant's notification of completion (sent to the coord) is asynchronous. This can be overtaken by the client's "close" message, resulting in the coordinator cancelling the activity, due to not all participants being completed.
> The hack is to add a delay before the client calls 'close'. We have that on the tests in TS, as a stop gap. I am reluctant to apply this hack to the AS test suite as it's embarrassing and likely to be rejected ;-)
> This issue is to resolve the problem properly. Maybe by using a Byteman Rendezvous. Alternatively there may be some XTS feature that we can use to poll the coordinator. Or maybe we can add it, as the client API is not standardized.
> This issue is not urgent for the TS tests as the hack seems to be holding out at present. However, we do occasionally see this issue on the XTS AS integration testsuite, which increases the priority.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 4 months
[JBoss JIRA] (JBTM-1145) TXFramework Code Tidy Part 2
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1145?page=com.atlassian.jira.plugin.... ]
Paul Robinson updated JBTM-1145:
--------------------------------
Status: Pull Request Sent (was: Coding In Progress)
Git Pull Request: https://github.com/jbosstm/narayana/pull/183
> TXFramework Code Tidy Part 2
> ----------------------------
>
> Key: JBTM-1145
> URL: https://issues.jboss.org/browse/JBTM-1145
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: TXFramework
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Fix For: 5.0.0.M2
>
> Original Estimate: 1 day
> Remaining Estimate: 1 day
>
> Remove annotations and properties that are not used.
> Remove System.out and System.err. For example:
> {code}
> 15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
> 15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
> {code}
> Add logging
> Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
> Remove Statefull tests
> Consider making handlers statefull
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 4 months
[JBoss JIRA] (JBTM-1145) TXFramework Code Tidy Part 2
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1145?page=com.atlassian.jira.plugin.... ]
Paul Robinson logged work on JBTM-1145:
---------------------------------------
Author: Paul Robinson
Created on: 18/Dec/12 11:44 AM
Start Date: 18/Dec/12 11:44 AM
Worklog Time Spent: 5 hours
Issue Time Tracking
-------------------
Remaining Estimate: 0 minutes (was: 1 day)
Time Spent: 5 hours
Worklog Id: (was: 12428297)
> TXFramework Code Tidy Part 2
> ----------------------------
>
> Key: JBTM-1145
> URL: https://issues.jboss.org/browse/JBTM-1145
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: TXFramework
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Fix For: 5.0.0.M2
>
> Original Estimate: 1 day
> Time Spent: 5 hours
> Remaining Estimate: 0 minutes
>
> Remove annotations and properties that are not used.
> Remove System.out and System.err. For example:
> {code}
> 15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
> 15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
> {code}
> Add logging
> Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
> Remove Statefull tests
> Consider making handlers statefull
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 4 months
[JBoss JIRA] (JBTM-1145) TXFramework Code Tidy Part 2
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1145?page=com.atlassian.jira.plugin.... ]
Paul Robinson updated JBTM-1145:
--------------------------------
Description:
Test restructuring
Try using annotations in subsystem
Remove annotations and properties that are not used.
Remove System.out and System.err. For example:
{code}
15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
{code}
Add logging
Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
Remove Statefull tests
Consider making handlers statefull
was:
Test restructuring
Try using annotations in subsystem
Remove annotations and properties that are not used.
Remove System.out and System.err. For example:
{code}
15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
{code}
Add logging
Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
@Required to something that matched EJB TX annotation
Remove Statefull tests
Consider making handlers statefull
> TXFramework Code Tidy Part 2
> ----------------------------
>
> Key: JBTM-1145
> URL: https://issues.jboss.org/browse/JBTM-1145
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: TXFramework
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Fix For: 5.0.0.M2
>
> Original Estimate: 1 day
> Remaining Estimate: 1 day
>
> Test restructuring
> Try using annotations in subsystem
> Remove annotations and properties that are not used.
> Remove System.out and System.err. For example:
> {code}
> 15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
> 15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
> {code}
> Add logging
> Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
> Remove Statefull tests
> Consider making handlers statefull
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 4 months
[JBoss JIRA] (JBTM-1145) TXFramework Code Tidy Part 2
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1145?page=com.atlassian.jira.plugin.... ]
Paul Robinson updated JBTM-1145:
--------------------------------
Description:
Remove annotations and properties that are not used.
Remove System.out and System.err. For example:
{code}
15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
{code}
Add logging
Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
Remove Statefull tests
Consider making handlers statefull
was:
Test restructuring
Try using annotations in subsystem
Remove annotations and properties that are not used.
Remove System.out and System.err. For example:
{code}
15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
{code}
Add logging
Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
Remove Statefull tests
Consider making handlers statefull
> TXFramework Code Tidy Part 2
> ----------------------------
>
> Key: JBTM-1145
> URL: https://issues.jboss.org/browse/JBTM-1145
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: TXFramework
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Fix For: 5.0.0.M2
>
> Original Estimate: 1 day
> Remaining Estimate: 1 day
>
> Remove annotations and properties that are not used.
> Remove System.out and System.err. For example:
> {code}
> 15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
> 15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
> {code}
> Add logging
> Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
> Remove Statefull tests
> Consider making handlers statefull
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 4 months
[JBoss JIRA] (JBTM-1401) TXFramework Code Tidy Part 3
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1401?page=com.atlassian.jira.plugin.... ]
Paul Robinson updated JBTM-1401:
--------------------------------
Description:
Test restructuring
Try using annotations in subsystem
was:
Remove annotations and properties that are not used.
Remove System.out and System.err. For example:
{code}
15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
{code}
Add logging
Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
Remove Statefull tests
Consider making handlers statefull
> TXFramework Code Tidy Part 3
> ----------------------------
>
> Key: JBTM-1401
> URL: https://issues.jboss.org/browse/JBTM-1401
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: TXFramework
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Fix For: 5.0.0.M2
>
> Original Estimate: 1 day
> Remaining Estimate: 1 day
>
> Test restructuring
> Try using annotations in subsystem
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 4 months
[JBoss JIRA] (JBTM-1401) TXFramework Code Tidy Part 3
by Paul Robinson (JIRA)
Paul Robinson created JBTM-1401:
-----------------------------------
Summary: TXFramework Code Tidy Part 3
Key: JBTM-1401
URL: https://issues.jboss.org/browse/JBTM-1401
Project: JBoss Transaction Manager
Issue Type: Task
Security Level: Public (Everyone can see)
Components: TXFramework
Reporter: Paul Robinson
Assignee: Paul Robinson
Fix For: 5.0.0.M2
Remove annotations and properties that are not used.
Remove System.out and System.err. For example:
{code}
15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
{code}
Add logging
Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
Remove Statefull tests
Consider making handlers statefull
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 4 months