[JBoss JIRA] (JBTM-1145) TXFramework Code Tidy Part 2
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1145?page=com.atlassian.jira.plugin.... ]
Paul Robinson updated JBTM-1145:
--------------------------------
Description:
Test restructuring
Try using annotations in subsystem
Remove annotations and properties that are not used.
Remove System.out and System.err. For example:
{code}
15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
{code}
Add logging
Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
@Required to something that matched EJB TX annotation
Remove Statefull tests
Consider making handlers statefull
was:
Test restructuring
Try using annotations in subsystem
Remove annotations and properties that are not used.
Remove System.out and System.err. For example:
{code}
15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
{code}
Add logging
Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
@Required to something that matched EJB TX annotation
Remove Statefull tests
> TXFramework Code Tidy Part 2
> ----------------------------
>
> Key: JBTM-1145
> URL: https://issues.jboss.org/browse/JBTM-1145
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: TXFramework
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Fix For: 5.0.0.M2
>
> Original Estimate: 1 day
> Remaining Estimate: 1 day
>
> Test restructuring
> Try using annotations in subsystem
> Remove annotations and properties that are not used.
> Remove System.out and System.err. For example:
> {code}
> 15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
> 15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
> {code}
> Add logging
> Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
> @Required to something that matched EJB TX annotation
> Remove Statefull tests
> Consider making handlers statefull
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (JBTM-1145) TXFramework Code Tidy Part 2
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1145?page=com.atlassian.jira.plugin.... ]
Work on JBTM-1145 started by Paul Robinson.
> TXFramework Code Tidy Part 2
> ----------------------------
>
> Key: JBTM-1145
> URL: https://issues.jboss.org/browse/JBTM-1145
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: TXFramework
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Fix For: 5.0.0.M2
>
> Original Estimate: 1 day
> Remaining Estimate: 1 day
>
> Test restructuring
> Try using annotations in subsystem
> Remove annotations and properties that are not used.
> Remove System.out and System.err. For example:
> {code}
> 15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
> 15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
> {code}
> Add logging
> Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
> @Required to something that matched EJB TX annotation
> Remove Statefull tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (JBTM-1145) TXFramework Code Tidy Part 2
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1145?page=com.atlassian.jira.plugin.... ]
Paul Robinson updated JBTM-1145:
--------------------------------
Description:
Test restructuring
Try using annotations in subsystem
Remove annotations and properties that are not used.
Remove System.out and System.err. For example:
{code}
15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
{code}
Add logging
Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
@Required to something that matched EJB TX annotation
Remove Statefull tests
was:
Test restructuring
Try using annotations in subsystem
Remove annotations and properties that are not used.
Remove System.out and System.err. For example:
{code}
15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
{code}
Add logging
Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
@Required to something that matched EJB TX annotation
> TXFramework Code Tidy Part 2
> ----------------------------
>
> Key: JBTM-1145
> URL: https://issues.jboss.org/browse/JBTM-1145
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: TXFramework
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Fix For: 5.0.0.M2
>
> Original Estimate: 1 day
> Remaining Estimate: 1 day
>
> Test restructuring
> Try using annotations in subsystem
> Remove annotations and properties that are not used.
> Remove System.out and System.err. For example:
> {code}
> 15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
> 15:08:58,561 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleInboundMessage()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.getHeaders()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.handleOutboundMessage()
> 15:08:58,562 INFO [stdout] (http-localhost-127.0.0.1-8080-1) ServiceRequestSoapHandler.close()
> {code}
> Add logging
> Refactor WSBA Handlers into one (Wrap the registration and completion into an object that switches based on participant type)
> @Required to something that matched EJB TX annotation
> Remove Statefull tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (JBTM-1293) ATBridgeTest#testSimple counter isn't incremented
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1293?page=com.atlassian.jira.plugin.... ]
Paul Robinson updated JBTM-1293:
--------------------------------
Issue Type: Bug (was: Feature Request)
> ATBridgeTest#testSimple counter isn't incremented
> -------------------------------------------------
>
> Key: JBTM-1293
> URL: https://issues.jboss.org/browse/JBTM-1293
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Testing, TXFramework
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Fix For: 5.0.0.M2
>
> Original Estimate: 3 days
> Remaining Estimate: 3 days
>
> See:
> http://172.17.131.2/view/Narayana+BlackTie/job/jbossts-narayana-java7/21/...
> {code}
> @Test
> public void testSimple() throws Exception
> {
> ut.begin();
> client.incrementCounter(1);
> ut.commit();
> ut.begin();
> int counter = client.getCounter();
> ut.commit();
> Assert.assertEquals(1, counter);
> }
> {code}
> Even though the first transaction should have committed an update to the counter, it is still set to zero in the second transaction.
> This happens intermittently (once so far). It also happened on Beacon which is notorious for test failures caused by things going slowly. I would suspect that the bridged JTA transaction in the first transaction hasn't quite finished the commit when the second transaction is begun.
> If the WS-AT coordinator sends an async commit to the participants and an async committed to the client, then this problem could happen if the client's 'committed' is received before the participant's 'commit' message.
> To verify this we need to check that the coordinator sends an async (@OneWay) commit message to the participant. In which case the simplest solution is to add a 3sec delay between the two transactions. We should also look for other tests that may be affected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (JBTM-1398) Review TXFramework's subsystem usage (and change if required)
by Paul Robinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1398?page=com.atlassian.jira.plugin.... ]
Paul Robinson updated JBTM-1398:
--------------------------------
Issue Type: Task (was: Bug)
> Review TXFramework's subsystem usage (and change if required)
> -------------------------------------------------------------
>
> Key: JBTM-1398
> URL: https://issues.jboss.org/browse/JBTM-1398
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: TXFramework
> Reporter: Paul Robinson
> Assignee: Paul Robinson
> Fix For: 5.0.0.M2
>
> Original Estimate: 2 days
> Remaining Estimate: 2 days
>
> We need to review the various options for including TXFramework subsytem code in AS7.
> 1. Create a new Subsytem
> 2. Leave it in the XTS one
> Also do we want all the subsytem code to live in the narayana codebase, rather than the AS7 one?
> Pros: don't need to rebuild AS7 when changing it. Don't need to raise a pull req on AS7 when we want to change it.
> Cons: We have to maintain it. In the past AS7 developers have made changes as the internals of AS7 change. We don't want to have to do this ourselves.
> I suggest we look at how other projects are doing this before committing to a particular method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years