[JBoss JIRA] (JBTM-2040) Remove some noisy logging that adds no value
by Michael Musgrove (JIRA)
[ https://issues.jboss.org/browse/JBTM-2040?page=com.atlassian.jira.plugin.... ]
Michael Musgrove updated JBTM-2040:
-----------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
See attached forum thread for the full discussion. But basically the decision was to leave logging in suspend, keep only the final trace message in getStatus and remove trace logging from the two calls in TransactionSynchronizationRegistryImple
> Remove some noisy logging that adds no value
> --------------------------------------------
>
> Key: JBTM-2040
> URL: https://issues.jboss.org/browse/JBTM-2040
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: JTA
> Reporter: Paul Robinson
> Assignee: Michael Musgrove
> Fix For: 5.0.0.CR2, 4.17.17
>
> Attachments: server.log
>
>
> The following log lines appear _a lot_ when TRACE is enabled for 'com.arjuna'
> ||Count||Message
> |656|2013-11-29 08:08:14,893 TRACE [com.arjuna.ats.jta] (EJB default - 1) BaseTransaction.getStatus
> |66|2013-11-28 11:42:00,005 TRACE [com.arjuna.ats.jta] (EJB default - 5) TransactionSynchronizationRegistryImple.getTransactionKey
> |66|2013-11-28 11:35:17,532 TRACE [com.arjuna.ats.jta] (ServerService Thread Pool -- 56) TransactionImpleManager.suspend
> |544|2013-11-28 11:35:15,926 TRACE [com.arjuna.ats.jta] (ServerService Thread Pool -- 52) TransactionSynchronizationRegistryImple.getTransactionStatus
> A total of almost 1,200 lines combined for those three messages after running a single transaction. This makes it a pain to read through the logs as you need to fight through pages of these statements.
> I don't think they provide any value in their current form. Can they either be removed or improved?
> See the attached log for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months
[JBoss JIRA] (JBTM-2040) Remove some noisy logging that adds no value
by Michael Musgrove (JIRA)
[ https://issues.jboss.org/browse/JBTM-2040?page=com.atlassian.jira.plugin.... ]
Michael Musgrove updated JBTM-2040:
-----------------------------------
Git Pull Request: https://github.com/jbosstm/narayana/pull/562, https://github.com/jbosstm/narayana/pull/563, https://github.com/jbosstm/narayana/pull/564 (was: https://github.com/jbosstm/narayana/pull/562, https://github.com/jbosstm/narayana/pull/563)
> Remove some noisy logging that adds no value
> --------------------------------------------
>
> Key: JBTM-2040
> URL: https://issues.jboss.org/browse/JBTM-2040
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: JTA
> Reporter: Paul Robinson
> Assignee: Michael Musgrove
> Fix For: 5.0.0.CR2, 4.17.17
>
> Attachments: server.log
>
>
> The following log lines appear _a lot_ when TRACE is enabled for 'com.arjuna'
> ||Count||Message
> |656|2013-11-29 08:08:14,893 TRACE [com.arjuna.ats.jta] (EJB default - 1) BaseTransaction.getStatus
> |66|2013-11-28 11:42:00,005 TRACE [com.arjuna.ats.jta] (EJB default - 5) TransactionSynchronizationRegistryImple.getTransactionKey
> |66|2013-11-28 11:35:17,532 TRACE [com.arjuna.ats.jta] (ServerService Thread Pool -- 56) TransactionImpleManager.suspend
> |544|2013-11-28 11:35:15,926 TRACE [com.arjuna.ats.jta] (ServerService Thread Pool -- 52) TransactionSynchronizationRegistryImple.getTransactionStatus
> A total of almost 1,200 lines combined for those three messages after running a single transaction. This makes it a pain to read through the logs as you need to fight through pages of these statements.
> I don't think they provide any value in their current form. Can they either be removed or improved?
> See the attached log for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months
[JBoss JIRA] (JBTM-2040) Remove some noisy logging that adds no value
by Michael Musgrove (JIRA)
[ https://issues.jboss.org/browse/JBTM-2040?page=com.atlassian.jira.plugin.... ]
Michael Musgrove updated JBTM-2040:
-----------------------------------
Forum Reference: https://community.jboss.org/message/847709#847709
> Remove some noisy logging that adds no value
> --------------------------------------------
>
> Key: JBTM-2040
> URL: https://issues.jboss.org/browse/JBTM-2040
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: JTA
> Reporter: Paul Robinson
> Assignee: Michael Musgrove
> Fix For: 5.0.0.CR2, 4.17.17
>
> Attachments: server.log
>
>
> The following log lines appear _a lot_ when TRACE is enabled for 'com.arjuna'
> ||Count||Message
> |656|2013-11-29 08:08:14,893 TRACE [com.arjuna.ats.jta] (EJB default - 1) BaseTransaction.getStatus
> |66|2013-11-28 11:42:00,005 TRACE [com.arjuna.ats.jta] (EJB default - 5) TransactionSynchronizationRegistryImple.getTransactionKey
> |66|2013-11-28 11:35:17,532 TRACE [com.arjuna.ats.jta] (ServerService Thread Pool -- 56) TransactionImpleManager.suspend
> |544|2013-11-28 11:35:15,926 TRACE [com.arjuna.ats.jta] (ServerService Thread Pool -- 52) TransactionSynchronizationRegistryImple.getTransactionStatus
> A total of almost 1,200 lines combined for those three messages after running a single transaction. This makes it a pain to read through the logs as you need to fight through pages of these statements.
> I don't think they provide any value in their current form. Can they either be removed or improved?
> See the attached log for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months
[JBoss JIRA] (JBTM-2040) Remove some noisy logging that adds no value
by Michael Musgrove (JIRA)
[ https://issues.jboss.org/browse/JBTM-2040?page=com.atlassian.jira.plugin.... ]
Michael Musgrove edited comment on JBTM-2040 at 12/9/13 5:34 PM:
-----------------------------------------------------------------
I have only modified getStatus trace logging (and left the final trace log in TransactionImple#getStatus) on the two branches:
https://github.com/jbosstm/narayana/commit/d54697d604296acff1c96f880343c3...
https://github.com/jbosstm/narayana/commit/9eea9b12ddc590c1e430b8365513d1...
was (Author: mmusgrov):
I have only modified getStatus trace logging (and left the final trace log in TransactionImple#getStatus)
> Remove some noisy logging that adds no value
> --------------------------------------------
>
> Key: JBTM-2040
> URL: https://issues.jboss.org/browse/JBTM-2040
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: JTA
> Reporter: Paul Robinson
> Assignee: Michael Musgrove
> Fix For: 5.0.0.CR2, 4.17.17
>
> Attachments: server.log
>
>
> The following log lines appear _a lot_ when TRACE is enabled for 'com.arjuna'
> ||Count||Message
> |656|2013-11-29 08:08:14,893 TRACE [com.arjuna.ats.jta] (EJB default - 1) BaseTransaction.getStatus
> |66|2013-11-28 11:42:00,005 TRACE [com.arjuna.ats.jta] (EJB default - 5) TransactionSynchronizationRegistryImple.getTransactionKey
> |66|2013-11-28 11:35:17,532 TRACE [com.arjuna.ats.jta] (ServerService Thread Pool -- 56) TransactionImpleManager.suspend
> |544|2013-11-28 11:35:15,926 TRACE [com.arjuna.ats.jta] (ServerService Thread Pool -- 52) TransactionSynchronizationRegistryImple.getTransactionStatus
> A total of almost 1,200 lines combined for those three messages after running a single transaction. This makes it a pain to read through the logs as you need to fight through pages of these statements.
> I don't think they provide any value in their current form. Can they either be removed or improved?
> See the attached log for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months
[JBoss JIRA] (JBTM-2040) Remove some noisy logging that adds no value
by Michael Musgrove (JIRA)
[ https://issues.jboss.org/browse/JBTM-2040?page=com.atlassian.jira.plugin.... ]
Michael Musgrove updated JBTM-2040:
-----------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/jbosstm/narayana/pull/562, https://github.com/jbosstm/narayana/pull/563
I have only modified getStatus trace logging (and left the final trace log in TransactionImple#getStatus)
> Remove some noisy logging that adds no value
> --------------------------------------------
>
> Key: JBTM-2040
> URL: https://issues.jboss.org/browse/JBTM-2040
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: JTA
> Reporter: Paul Robinson
> Assignee: Michael Musgrove
> Fix For: 5.0.0.CR2, 4.17.17
>
> Attachments: server.log
>
>
> The following log lines appear _a lot_ when TRACE is enabled for 'com.arjuna'
> ||Count||Message
> |656|2013-11-29 08:08:14,893 TRACE [com.arjuna.ats.jta] (EJB default - 1) BaseTransaction.getStatus
> |66|2013-11-28 11:42:00,005 TRACE [com.arjuna.ats.jta] (EJB default - 5) TransactionSynchronizationRegistryImple.getTransactionKey
> |66|2013-11-28 11:35:17,532 TRACE [com.arjuna.ats.jta] (ServerService Thread Pool -- 56) TransactionImpleManager.suspend
> |544|2013-11-28 11:35:15,926 TRACE [com.arjuna.ats.jta] (ServerService Thread Pool -- 52) TransactionSynchronizationRegistryImple.getTransactionStatus
> A total of almost 1,200 lines combined for those three messages after running a single transaction. This makes it a pain to read through the logs as you need to fight through pages of these statements.
> I don't think they provide any value in their current form. Can they either be removed or improved?
> See the attached log for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months
[JBoss JIRA] (JBTM-2040) Remove some noisy logging that adds no value
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-2040?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson updated JBTM-2040:
--------------------------------
Assignee: Michael Musgrove (was: Tom Jenkinson)
> Remove some noisy logging that adds no value
> --------------------------------------------
>
> Key: JBTM-2040
> URL: https://issues.jboss.org/browse/JBTM-2040
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: JTA
> Reporter: Paul Robinson
> Assignee: Michael Musgrove
> Fix For: 5.0.0.CR2, 4.17.17
>
> Attachments: server.log
>
>
> The following log lines appear _a lot_ when TRACE is enabled for 'com.arjuna'
> ||Count||Message
> |656|2013-11-29 08:08:14,893 TRACE [com.arjuna.ats.jta] (EJB default - 1) BaseTransaction.getStatus
> |66|2013-11-28 11:42:00,005 TRACE [com.arjuna.ats.jta] (EJB default - 5) TransactionSynchronizationRegistryImple.getTransactionKey
> |66|2013-11-28 11:35:17,532 TRACE [com.arjuna.ats.jta] (ServerService Thread Pool -- 56) TransactionImpleManager.suspend
> |544|2013-11-28 11:35:15,926 TRACE [com.arjuna.ats.jta] (ServerService Thread Pool -- 52) TransactionSynchronizationRegistryImple.getTransactionStatus
> A total of almost 1,200 lines combined for those three messages after running a single transaction. This makes it a pain to read through the logs as you need to fight through pages of these statements.
> I don't think they provide any value in their current form. Can they either be removed or improved?
> See the attached log for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months