Hi, Here's the source code of the rule I am trying to add: public void testDynamicRules() { //Create a rule dynamically and check if it fired from log statements RuleBase ruleBase = wm.getRuleBase(); Package[] pkg = ruleBase.getPackages(); if(pkg[0] != null) { logger.warn("Package size before adding the rule : "+pkg[0].getRules().length); //Building a new package final PackageDescr packageDescr = new PackageDescr(pkg[0].getName() ); //Building ruleDescriptor RuleDescr ruleDescr = null; String consequence = "mediator.addedNewRule();\n"; //String consequence = "logger.warn(\"New rule just got fired\");"; ruleDescr = new RuleDescr( "Added new Rule"); AndDescr lhs = new AndDescr(); ruleDescr.setLhs( lhs ); final PatternDescr pattern = new PatternDescr( ApplicationEvent.class.getName(), "newAppEvent"); lhs.addDescr( pattern ); final LiteralRestrictionDescr restrictionMessage = new LiteralRestrictionDescr("==", "Test2", LiteralRestrictionDescr.TYPE_STRING ); final FieldConstraintDescr returnValue = new FieldConstraintDescr( "messageId" ); returnValue.addRestriction(restrictionMessage); pattern.addConstraint(returnValue); ruleDescr.setConsequence( consequence ); List attributes = new ArrayList<AttributeDescr>(); attributes.add(new AttributeDescr("salience", "98")); attributes.add(new AttributeDescr("enabled", "true")); ruleDescr.addAttribute( new AttributeDescr("dialect", "java") ); ruleDescr.setAttributes(attributes); Package defaultPackage = pkg[0]; PackageBuilderConfiguration conf = new PackageBuilderConfiguration(); PackageBuilder builder = new PackageBuilder( defaultPackage, conf ); //Adding rule to the package packageDescr.addRule( ruleDescr ); builder.addPackage(packageDescr); int errors = builder.getErrors().getErrors().length; if(errors > 0) { //TODO remove the recently added rule or reload all the rules from the DRL file logger.warn("Error while adding a rule"); } else { Rule newRule = builder.getPackage().getRule( ruleDescr.getName()); //String ruleFlowName = newRule.getRuleFlowGroup() //newRule.get //Check is the rule got added logger.warn("Package size after adding the rule : "+pkg[0].getRules().length); } } else { logger.warn("Error getting default package for adding rules"); } } public void addedNewRule() { //Just testing addition of new rules. logger.warn("New rule just got fired"); } I cant seem to get the consequence to get fired. I have a similar rule in my drl file where the messageID == "Test" and it works fine. Any help is really helpful here cause I am stuck at this point and might have to go to creating xml files for the rules and parsing that. Thanks Samir -- View this message in context: http://www.nabble.com/Cant-seem-to-fire-a-dynamically-added-rule-tp158101... Sent from the drools - user mailing list archive at Nabble.com. _______________________________________________ rules-users mailing list rules-users(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/rules-users

I did try the DRLDumper and everything seems to be correct. Also just to let users know i am using 4.0.4 which is almost the lastest release. Thanks for any help Regards Samir

Samir, As Mark mentioned, we added several fixes to the 4.0.x branch (to be released as 4.0.5) related to dynamic rules. Can you please try it out? If it is still a problem, please open a JIRA attaching your test case. I will look into it and fix it. Thanks, Edson 2008/3/3, samirsss <samirsavla(a)gmail.com&gt;: > > > I did try the DRLDumper and everything seems to be correct. Also just to > let > users know i am using 4.0.4 which is almost the lastest release. > > Thanks for any help > Regards > Samir > > > > -- > View this message in context: > http://www.nabble.com/Cant-seem-to-fire-a-dynamically-added-rule-tp158101... > > Sent from the drools - user mailing list archive at Nabble.com. > > _______________________________________________ > rules-users mailing list > rules-users(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/rules-users > -- Edson Tirelli JBoss Drools Core Development Office: +55 11 3529-6000 Mobile: +55 11 9287-5646 JBoss, a division of Red Hat @ www.jboss.com _______________________________________________ rules-users mailing list rules-users(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/rules-users

I tried using the jars from the 4.0.x branch after building them and that still doesnt seem to change the outcome. I see that the package builder has the rule added to it and the count of the rules from it is incremented. public void testDynamicRules() { //Create a rule dynamically and check if it fired from log statements RuleBase ruleBase = wm.getRuleBase(); Package[] pkg = ruleBase.getPackages(); if(pkg[0] != null) { logger.warn("Package size before adding the rule : "+pkg[0].getRules().length); //Building a new package final PackageDescr packageDescr = new PackageDescr(pkg[0].getName() ); //Building ruleDescriptor RuleDescr ruleDescr = null; String consequence = "\t\t mediator.addedNewRule();\n"; ruleDescr = new RuleDescr( "Added new Rule"); AndDescr lhs = new AndDescr(); ruleDescr.setLhs( lhs ); final PatternDescr pattern = new PatternDescr( "ApplicationEvent", //.class.getName(), "newAppEvent"); lhs.addDescr( pattern ); final FieldConstraintDescr insertedValue = new FieldConstraintDescr( "inserted" ); final LiteralRestrictionDescr insertedFieldRes = new LiteralRestrictionDescr("==", "false", LiteralRestrictionDescr.TYPE_BOOLEAN); insertedValue.addRestriction(insertedFieldRes); pattern.addConstraint(insertedValue); final LiteralRestrictionDescr restrictionMessage = new LiteralRestrictionDescr("==", "Test2", LiteralRestrictionDescr.TYPE_STRING ); final FieldConstraintDescr returnValue = new FieldConstraintDescr( "messageId" ); returnValue.addRestriction(restrictionMessage); pattern.addConstraint(returnValue); ruleDescr.setConsequence( consequence ); List attributes = new ArrayList<AttributeDescr>(); attributes.add(new AttributeDescr("salience", "101")); ruleDescr.addAttribute( new AttributeDescr("dialect", "java") ); ruleDescr.setAttributes(attributes); Package defaultPackage = pkg[0]; PackageBuilderConfiguration conf = new PackageBuilderConfiguration(); PackageBuilder builder = new PackageBuilder( defaultPackage, conf ); packageDescr.addRule( ruleDescr ); builder.addPackage(packageDescr); DrlDumper drlDumper = new DrlDumper(); logger.warn("Dumping Package Descriptor for all rules: "+ drlDumper.dump(packageDescr)); int errors = builder.getErrors().getErrors().length; if(errors > 0) { //TODO remove the recently added rule or reload all the rules from the DRL file logger.warn("Error while adding a rule"); } else { Rule newRule = builder.getPackage().getRule( ruleDescr.getName()); logger.warn("Package after adding the rule : "+newRule.toString()+": contains: "+pkg[0].getRules().length+" rules"); } } else { logger.warn("Error getting default package for adding rules"); } } I am trying to figure out if I am doing something wrong or its an issue with Drools. -- View this message in context: http://www.nabble.com/Cant-seem-to-fire-a-dynamically-added-rule-tp158101... Sent from the drools - user mailing list archive at Nabble.com. _______________________________________________ rules-users mailing list rules-users(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/rules-users

Hi Edson, I did send you an email with the sample of how to recreate this issue and hopefully you can also find the issue and get a fix out. Meanwhile I am planning to write the new rule back to the rule file and re-initialize the Rulebase with the updated drl file, which works fine. -Samir Edson Tirelli-3 wrote: > > Can you please provide an executable, self contained test case? I will > take a look. > > []s > Edson >

samirsss wrote: Hi Edson, I just saw Mark Proctor's message about filing bugs so that they get addressed in 4.0.5 and was wondering if the fix for this issue is also going to be in the same release? Thanks for being so proactive about the issues and having a quick turnaround time. yes it is, please try 4.0.x to be sure your bug is fixed. regards Samir samirsss wrote: Hi Edson, I did send you an email with the sample of how to recreate this issue and hopefully you can also find the issue and get a fix out. Meanwhile I am planning to write the new rule back to the rule file and re-initialize the Rulebase with the updated drl file, which works fine. -Samir Edson Tirelli-3 wrote: Can you please provide an executable, self contained test case? I will take a look. []s Edson _______________________________________________ rules-users mailing list rules-users(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/rules-users

Hi Edson, I tried the exact method you asked me to and seems like now i am getting an error while I add the rule. Also the rules still dont get fired. I'm going to send you the code again and maybe you can fix it and send it back to me after testing that all 3 scenarios for the messageId = Test, Test2 and Test3 pass. thanks Samir http://www.nabble.com/file/p15950841/TestDynamicRules.zip TestDynamicRules.zip Edson Tirelli-3 wrote: > > Samir, > > I had a look at the code you sent me and the problem is that you are > not > adding the rule to the rulebase. In your > ConnectionHandler.testDynamicRules() > method, you need to do: > > ruleBase.addPackage( builder.getPackage() ); > > You probably incurred in this error because you are misusing the > Package > objects. You should either remove the whole package from the rule base > before doing your merge or, what I think is best, create a package with > the > "delta" rules you want to add. > So, instead of doing: > > Package defaultPackage = pkg[0]; > > Do: > > Package defaultPackage = new Package( pkg[0].getName() ); > > So, you are effectively creating a new Package object, but when you add > it to the rule base, it will be correctly merged into the existing one. > This also allows you to AVOID the lock you are doing here: > > ruleBase.lock(); // no need for that if you use a new > package > with the same name > packageDescr.addRule( ruleDescr ); > builder.addPackage(packageDescr); > ruleBase.unlock(); // no need for that if you use a new > package with the same name > > Hope it helps. > > Edson > -- View this message in context: http://www.nabble.com/Cant-seem-to-fire-a-dynamically-added-rule-tp158101... Sent from the drools - user mailing list archive at Nabble.com. _______________________________________________ rules-users mailing list rules-users(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/rules-users