1:03 p.m.
Hello,
I developed a system where dynamic salience for some particular rules
doesn't rules. However, it is very hard for me to create a simple test case
unless I publish the entire rule files. In the system, some rules using
dynamic salience work and some don't, but I don't know why.
I debugged into the drools-core source code, and found out the following
code in branch 6.0.x.
(https://github.com/droolsjbpm/drools/blob/6.0.x/drools-core/src/main/java...)
Line 98 - org.drools.core.reteoo.PathMemory::doLinkRule
int salience = ( rtn.getRule().getSalience() instanceof
MVELSalienceExpression)
? 0
: rtn.getRule().getSalience().getValue(null,
rtn.getRule(), wm);
Line 113 - org.drools.core.reteoo.PathMemory::doUnlinkRule
int salience = ( rtn.getRule().getSalience() instanceof
MVELSalienceExpression)
? 0
: rtn.getRule().getSalience().getValue(null,
rtn.getRule(), wm);
I wonder if this is a bug that put the first value and the second value
reversed. At least I fixed my problem after reversing them.
Thanks.
Jinghai
--
View this message in context:
http://drools.46999.n3.nabble.com/Possible-problem-in-PathMemory-tp403002...
Sent from the Drools: User forum mailing list archive at Nabble.com.
7:54 p.m.
Hi,
I recall this email. After trying with more examples, I notice if I reverse
the order, the non-dynamic salience will not work.
Thanks.
Jinghai
On Thu, Jun 12, 2014 at 11:03 AM, rjh <raojinghai(a)gmail.com> wrote:
Hello,
I developed a system where dynamic salience for some particular rules
doesn't rules. However, it is very hard for me to create a simple test case
unless I publish the entire rule files. In the system, some rules using
dynamic salience work and some don't, but I don't know why.
I debugged into the drools-core source code, and found out the following
code in branch 6.0.x.
(
https://github.com/droolsjbpm/drools/blob/6.0.x/drools-core/src/main/java...
)
Line 98 - org.drools.core.reteoo.PathMemory::doLinkRule
int salience = ( rtn.getRule().getSalience() instanceof
MVELSalienceExpression)
? 0
: rtn.getRule().getSalience().getValue(null,
rtn.getRule(), wm);
Line 113 - org.drools.core.reteoo.PathMemory::doUnlinkRule
int salience = ( rtn.getRule().getSalience() instanceof
MVELSalienceExpression)
? 0
: rtn.getRule().getSalience().getValue(null,
rtn.getRule(), wm);
I wonder if this is a bug that put the first value and the second value
reversed. At least I fixed my problem after reversing them.
Thanks.
Jinghai
--
View this message in context:
http://drools.46999.n3.nabble.com/Possible-problem-in-PathMemory-tp403002...
Sent from the Drools: User forum mailing list archive at Nabble.com.
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
7:09 a.m.
Hi,
I don't think your problem is caused by that. More likely this is caused by
the issue reported here https://issues.jboss.org/browse/DROOLS-335 that I
fixed with this commit
https://github.com/droolsjbpm/drools/commit/f8f721056e36f8e0370c2783875ff...
Can you check if your code base already has that fix? If so please open a
new ticket on jira attaching there a reproducer or at least some more
detailed instructions on how to reproduce your problem. Otherwise try to get
one of the latest builds already including that fix and check if this is
enough to solve your problem.
Thanks,
Mario
--
View this message in context:
http://drools.46999.n3.nabble.com/Possible-problem-in-PathMemory-tp403002...
Sent from the Drools: User forum mailing list archive at Nabble.com.
1:07 p.m.
Hi Mario,
Thanks for your prompt reply. My code base already has the fix and it
doesn't fix my problem.
I will try to narrow down the problem before submitting a ticket.
Thanks.
Jinghai
On Fri, Jun 13, 2014 at 5:09 AM, Mario Fusco <mario.fusco(a)gmail.com> wrote:
Hi,
I don't think your problem is caused by that. More likely this is caused by
the issue reported here https://issues.jboss.org/browse/DROOLS-335 that I
fixed with this commit
https://github.com/droolsjbpm/drools/commit/f8f721056e36f8e0370c2783875ff...
Can you check if your code base already has that fix? If so please open a
new ticket on jira attaching there a reproducer or at least some more
detailed instructions on how to reproduce your problem. Otherwise try to
get
one of the latest builds already including that fix and check if this is
enough to solve your problem.
Thanks,
Mario
--
View this message in context:
http://drools.46999.n3.nabble.com/Possible-problem-in-PathMemory-tp403002...
Sent from the Drools: User forum mailing list archive at Nabble.com.
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
6 p.m.
Hi Mario,
I figured out this is a problem with Event and dynamic salience. Suppose we
have the following declarations and rules:
declare Message
@role(event)
end
rule "rule1"
salience RuleSalience.RULE1
when
$m : Message()
then
System.out.println("====================> rule1");
retract($m);
RuleSalience.RULE1 = RuleSalience.RULE2 - 1;
end
rule "rule2"
salience RuleSalience.RULE2
when
$m : Message()
then
System.out.println("=====================> rule2");
retract($m);
RuleSalience.RULE2 = RuleSalience.RULE1 - 1;
end
I want when a Message is inserted, either rule1 or rule2 is fired. I also
want two rules can fire alternatively. So when one rule is fired, its
salience becomes lower.
The result is, if I don't declare Message as an Event, it works fine.
Otherwise, only rule1 is fired.
The problem seems to be at
org.drools.core.reteoo.LeftInputAdapterNode::doInsertSegmentMemory().
Because of stream mode, both rules are not inserted StagedLeftTuples. So
rule1 and rule2 are not compared based on salience. Because rule1 has a
smaller act#, it is always fired first.
The attached zip is a test case. If you want mvn clean test, it will fail.
However, if you remove the following lines from Sample.drl, the test will
succeed.
"declare Message
@role(event)
end"
Thanks.
Jinghai
6:22 p.m.
I could be wrong but I thought dynamic salience used facts in working
memory and hence your RHS would need to signal changes to the salience
variables.
Sent on the move
On 14 Jun 2014 00:01, <raojinghai(a)gmail.com> wrote:
Hi Mario,
I figured out this is a problem with Event and dynamic salience. Suppose
we have the following declarations and rules:
declare Message
@role(event)
end
rule "rule1"
salience RuleSalience.RULE1
when
$m : Message()
then
System.out.println("====================> rule1");
retract($m);
RuleSalience.RULE1 = RuleSalience.RULE2 - 1;
end
rule "rule2"
salience RuleSalience.RULE2
when
$m : Message()
then
System.out.println("=====================> rule2");
retract($m);
RuleSalience.RULE2 = RuleSalience.RULE1 - 1;
end
I want when a Message is inserted, either rule1 or rule2 is fired. I also
want two rules can fire alternatively. So when one rule is fired, its
salience becomes lower.
The result is, if I don't declare Message as an Event, it works fine.
Otherwise, only rule1 is fired.
The problem seems to be at
org.drools.core.reteoo.LeftInputAdapterNode::doInsertSegmentMemory().
Because of stream mode, both rules are not inserted StagedLeftTuples. So
rule1 and rule2 are not compared based on salience. Because rule1 has a
smaller act#, it is always fired first.
The attached zip is a test case. If you want mvn clean test, it will fail.
However, if you remove the following lines from Sample.drl, the test will
succeed.
"declare Message
@role(event)
end"
Thanks.
Jinghai
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
9 p.m.
Hi Michael,
Here I use global static variables to store the dynamic salience values. I
tried with facts and the results are all the same.
Thanks.
Jinghai
On Fri, Jun 13, 2014 at 4:22 PM, Michael Anstis <michael.anstis(a)gmail.com>
wrote:
I could be wrong but I thought dynamic salience used facts in
working
memory and hence your RHS would need to signal changes to the salience
variables.
Sent on the move
On 14 Jun 2014 00:01, <raojinghai(a)gmail.com> wrote:
> Hi Mario,
>
> I figured out this is a problem with Event and dynamic salience. Suppose
> we have the following declarations and rules:
>
> declare Message
> @role(event)
> end
>
> rule "rule1"
> salience RuleSalience.RULE1
> when
> $m : Message()
> then
> System.out.println("====================> rule1");
> retract($m);
> RuleSalience.RULE1 = RuleSalience.RULE2 - 1;
> end
>
> rule "rule2"
> salience RuleSalience.RULE2
> when
> $m : Message()
> then
> System.out.println("=====================> rule2");
> retract($m);
> RuleSalience.RULE2 = RuleSalience.RULE1 - 1;
> end
>
> I want when a Message is inserted, either rule1 or rule2 is fired. I also
> want two rules can fire alternatively. So when one rule is fired, its
> salience becomes lower.
>
> The result is, if I don't declare Message as an Event, it works fine.
> Otherwise, only rule1 is fired.
>
> The problem seems to be at
> org.drools.core.reteoo.LeftInputAdapterNode::doInsertSegmentMemory().
> Because of stream mode, both rules are not inserted StagedLeftTuples. So
> rule1 and rule2 are not compared based on salience. Because rule1 has a
> smaller act#, it is always fired first.
>
> The attached zip is a test case. If you want mvn clean test, it will
> fail. However, if you remove the following lines from Sample.drl, the test
> will succeed.
>
> "declare Message
> @role(event)
> end"
>
> Thanks.
>
> Jinghai
>
> _______________________________________________
> rules-users mailing list
> rules-users(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/rules-users
>
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
8:42 a.m.
Hi Jinghai,
I reproduced the problem you reported and pushed a fix for it:
https://github.com/droolsjbpm/drools/commit/83f80c83f
Your reproducer have been very very helpful.
Thanks a lot,
Mario
--
View this message in context:
http://drools.46999.n3.nabble.com/Possible-problem-in-PathMemory-tp403002...
Sent from the Drools: User forum mailing list archive at Nabble.com.
12:11 p.m.
Hi Mario,
Awesome. Thank you so much for fixing it promptly.
Thanks.
Jinghai
On Mon, Jun 16, 2014 at 6:42 AM, Mario Fusco <mario.fusco(a)gmail.com> wrote:
Hi Jinghai,
I reproduced the problem you reported and pushed a fix for it:
https://github.com/droolsjbpm/drools/commit/83f80c83f
Your reproducer have been very very helpful.
Thanks a lot,
Mario
--
View this message in context:
http://drools.46999.n3.nabble.com/Possible-problem-in-PathMemory-tp403002...
Sent from the Drools: User forum mailing list archive at Nabble.com.
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
10:23 a.m.
New subject: Problems compiling huge rule base with kie-maven-plugin
Hi all,
at work we have a huge rule base (>2k rules with an average size of ~2Mib).
I've found the building this RB with the latest kie-maven-plugin
troublesome at best.
I want to share my experience hoping that some Drools developer could
help me.
I'm using the latest Drools 6.x from the master branch.
The first problem I encounterd was that the compilation process retain
in memory all the compilation caches until the end.
This would lead to a OOM very soon and we can't increase the heap size
indefinitely. So the first thing I do was to extract
the code from KieModuleMetaInfoBuilder and create a custom builder that
would populate a guava cache for every KnowledgeBase compiled.
The aforementioned cache would write the bytestreams when the objects
get evicted.
That worked well and leaded finally to a full compilation. The only
problem was the long time one has to wait until completion.
Some few rules take up to 30 min. to complete but the majority takes
from 5 to 20 secs.
So I extended the custom compiler to be multithreaded and finally the
compilation time is acceptable again.
I also extended the compiler to perform incremental compilations.
Now my problem is that the generated kjar is rather huge and when I load
it I get an OOM again.
Peeking at the code again confirm (if I get this correctly) that all the
caches gets loaded altogether, moving the problem to compile time to run
time.
Is it possible to force the KieContainer to load the caches lazily,
based on calls to getKieBase? If not, would it be usefull?
I understand that my case is rather on the edge but any help would be
appreciated.
Thank you very much :)
Federico.
10:48 a.m.
New subject: Problems compiling huge rule base with kie-maven-plugin
Hi Federico,
so we have 2 problems here. For what regards the compilation one I'd be
curious to see your solution. Could you please open a ticket on our jira and
attach it there, or maybe send a pull request on github? As for the runtime,
yes probably loading stuff lazier in the KieContainer could alleviate also
that problem, but first I'd like to give a look at what you're doing to
better understand your use case. Could you also attach a reproducer to that
jira ticket?
Thanks,
Mario
--
View this message in context:
http://drools.46999.n3.nabble.com/Possible-problem-in-PathMemory-tp403002...
Sent from the Drools: User forum mailing list archive at Nabble.com.
5:31 p.m.
New subject: Problems compiling huge rule base with kie-maven-plugin
Hi Mario, thanks for the quick reply.
Yes I could definitely open a jira and a pull request, just be patient
though, as I've to isolate the code from our own.
Reproducing the slowdown I experienced would be a little problematic
because it depends, I think, entirely on the size (and "shape") of our RB.
Thanks again,
Federico.
On 06/18/2014 05:48 PM, Mario Fusco wrote:
Hi Federico,
so we have 2 problems here. For what regards the compilation one I'd be
curious to see your solution. Could you please open a ticket on our jira and
attach it there, or maybe send a pull request on github? As for the runtime,
yes probably loading stuff lazier in the KieContainer could alleviate also
that problem, but first I'd like to give a look at what you're doing to
better understand your use case. Could you also attach a reproducer to that
jira ticket?
Thanks,
Mario
--
View this message in context:
http://drools.46999.n3.nabble.com/Possible-problem-in-PathMemory-tp403002...
Sent from the Drools: User forum mailing list archive at Nabble.com.
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
3814
days inactive
3820
days old
11 comments
5 participants
participants (5)
-
Federico Bertola -
Mario Fusco -
Michael Anstis -
raojinghai＠gmail.com -
rjh