8:01 a.m.
Hello everybody,
I use Drools to create rules from an external source and create an artifact from those
rule strings, putting it into a local repository.
A minimalistic working example can be found at
https://github.com/dadadom/MavenMemoryLeakMinimalExample
The code, taken from that example, is basically like this:
ReleaseId releaseId = new
ReleaseIdImpl("some:releaseid:1.0.0-SNAPSHOT");
String rules = "rule \"testrule\ ... ";
KieServices kServices = KieServices.Factory.get();
KieFileSystem kfs = kServices.newKieFileSystem();
kfs.write("src/main/resources/someBase/testrule", rules);
kfs.generateAndWritePomXML(releaseId);
String kmoduleXmlString = "<kmodule ... </kmodule>";
kfs.writeKModuleXML(kmoduleXmlString.getBytes());
KieModule kieModule = kServices.newKieBuilder(kfs).getKieModule();
try {
File pomFile = new File(System.getProperty("java.io.tmpdir"),
"pom.xml");
try (FileOutputStream fos = new FileOutputStream(pomFile)) {
fos.write(KieBuilderImpl.generatePomXml(releaseId).getBytes());
fos.flush();
} catch (IOException e) {
e.printStackTrace();
}
final MavenRepository mavenRepository = MavenRepository.getMavenRepository();
mavenRepository.deployArtifact(releaseId, (InternalKieModule) kieModule,
pomFile);
When I call this method in a ServletContextListener in a Tomcat Server (version 7 or 8)
and undeploy the application afterwards, I get a memory leak.
Tomcat tells me that the application has a memory leak:
The following web applications were stopped (reloaded, undeployed), but their
classes from previous runs are still loaded in memory, thus causing a memory
leak (use a profiler to confirm):
/mvntest
Looking at the memory dump with e.g. JProfiler, I can trace the dangling instances back to
an object
static INSTANCE of class org.drools.compiler.kie.builder.impl.KieRepositoryImpl
So it seems like there is something which I am either missing or which is a bug. I cannot
find any .close() or .release() method or something alike on any of the involved objects
...
If anyone could give me a hint how to solve this problem, I'd be happy not to litter
my memory no more :)
Regards and thanks
Dominik
...........................................................................
mit freundlichen Gr??en / kind regards
Dominik Sandjaja
Fon: +49 (0) 203 60878 183
Fax: +49 (0) 203 60878 222
e-mail: dominik.sandjaja(a)it-motive.de
it-motive AG
Zum Walkm?ller 6
47269 Duisburg
info(a)it-motive.de
http://www.it-motive.de
..............................................................................
Vorsitzender des Aufsichtsrats: Dr.-Ing. J?rgen Sturm
Vorstand: Horst-Dieter Deelmann (Vors.), Matthias Heming, Christoph Tim Klose
HRB 9207, Amtsgericht Duisburg
10:05 a.m.
Hi Dominik,
I'm honestly not understanding why you're creating a kieModule and most
important why you're deploying it on maven in a ServletContextListener, but
I am guessing you're doing this only to demonstrate the problem. Also be
aware that for doing so you're using some drools internal API and these API
aren't guaranteed to be stable.
However every time you build a kieModule or you load it from a maven repo,
it is stored in the KieRepository. If you need to remove it from there you
can do this explicitly by using the KieRepository.removeKieModule(ReleaseId)
method.
I hope this helps,
Mario
--
View this message in context:
http://drools.46999.n3.nabble.com/rules-users-Memory-leak-when-deploying-...
Sent from the Drools: User forum mailing list archive at Nabble.com.
3:46 a.m.
Hello,
our scenario is like this:
From our customer, we get an Excel file which contains something
rule-like which we convert into actual Drools rule strings. Those, we want to deploy in
our local Maven repository (the one being used by Drools/KIE/Maven) as an actual artifact.
This allows us later, to create new rules with KIE-WB, which are then deployed into the
same repository, but with a higher artifact version. The actual application can then
initially, when it doesn't have a connection to KIE-WB, use the rules created from the
Excel sheet. In a second step, it can later get a more current rule artifact from the
KIE-WB repository.
This is why we create an actual artifact out of the Excel sheet. That process takes a
while, so we do it in the startup listener.
As far as I understand it and as far as I could see it on the filesystem, when I build a
KieModule programmatically, it is not persisted anywhere and it is lost on restart of the
system. That is why I wanted to explicitly persist it with the Aether facilities, as
depicted in my previous post. If I do not do that and if I then check at startup if the
artifact version does exist, I get back a "false" and it is created again -
which takes quite some time. This is the reason why I want to store my created artifact in
the local, persistent repository.
Am I getting something wrong? Is the artifact already stored somewhere?
I hope my intentions are a bit clearer now ...
Thanks in advance!
Dominik
-----Ursprüngliche Nachricht-----
Von: rules-users-bounces(a)lists.jboss.org [mailto:rules-users-bounces@lists.jboss.org] Im
Auftrag von Mario Fusco
Gesendet: Dienstag, 10. Juni 2014 17:06
An: rules-users(a)lists.jboss.org
Betreff: Re: [rules-users] Memory leak when deploying to Maven repository?
Hi Dominik,
I'm honestly not understanding why you're creating a kieModule and most important
why you're deploying it on maven in a ServletContextListener, but I am guessing
you're doing this only to demonstrate the problem. Also be aware that for doing so
you're using some drools internal API and these API aren't guaranteed to be
stable.
However every time you build a kieModule or you load it from a maven repo, it is stored in
the KieRepository. If you need to remove it from there you can do this explicitly by using
the KieRepository.removeKieModule(ReleaseId)
method.
I hope this helps,
Mario
--
View this message in context:
http://drools.46999.n3.nabble.com/rules-users-Memory-leak-when-deploying-...
Sent from the Drools: User forum mailing list archive at Nabble.com.
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
…………………………………………………………………
mit freundlichen Grüßen / kind regards
Dominik Sandjaja
Fon: +49 (0) 203 60878 183
Fax: +49 (0) 203 60878 222
e-mail: dominik.sandjaja(a)it-motive.de
it-motive AG
Zum Walkmüller 6
47269 Duisburg
info(a)it-motive.de
http://www.it-motive.de
……………………………………………………………………
Vorsitzender des Aufsichtsrats: Dr.-Ing. Jürgen Sturm
Vorstand: Horst-Dieter Deelmann (Vors.), Matthias Heming, Christoph Tim Klose
HRB 9207, Amtsgericht Duisburg
3825
days inactive
3826
days old
2 comments
2 participants
participants (2)
-
Mario Fusco -
Sandjaja, Dominik