2:54 p.m.
In Drools 6, when org.kie.scanner.KieModuleMetaDataImpl is
initialized, it scans all classes in all dependencies. At my point of view,
it's a too aggressive.
In many situations, scanner catches not only needed modules, but many
modules with testing and provided scopes.
In other side, in run-time, testing modules don't needed at all. Provided
modules may be valid, but if don't filtered it out then it don't have other
ways to have ability to controlling a Maven dependencies.
In other word, provided scoped modules could be included, but not his
transitive dependencies.
Otherwise scanner will be scan a many unneeded modules, that can brake
Drools compilation at all. For example: my project have transitive
dependency on library, that use an com.ibm.icu. And Drools compiler is
braking on com.ibm.icu because com.ibm.icu have a class with invalid
bytecode:
--
View this message in context:
http://drools.46999.n3.nabble.com/Too-agressive-scanning-of-classes-in-Ki...
Sent from the Drools: User forum mailing list archive at Nabble.com.
6:41 p.m.
Hi,
I am not sure I completely agree with what you wrote.
In general all the classes defined in all transitive dependencies could
potentially be used in your domain and then should be indexed by the
KieModuleMetaDataImpl. I'd say that something like: "provided scoped modules
could be included, but not his transitive dependencies" sounds a quite
arbitrary criteria tailored on your current use case and I could probably
find other equally valid criteria.
That said I agree that KieModuleMetaDataImpl could be more robust and
eventually just silently skip (or just emit a warning) when it finds a
malformed class as in your case. At this purpose could you please send the
complete stack of the error you reported?
Thanks,
Mario
--
View this message in context:
http://drools.46999.n3.nabble.com/Too-agressive-scanning-of-classes-in-Ki...
Sent from the Drools: User forum mailing list archive at Nabble.com.
9:36 a.m.
I'm attach some files with errors, that generated during build:
error-exceptions.txt - is a stack traces for error message only
all-exceptions.txt - is a stack traces for all exceptions, generated in
org.guvnor.common.services.builder.Builder.build()
all-messages.txt - bonus . This is a all messages, shown to user in WEB IDE
As you can see, it's a lot of messages shown. But no one have relation to
the real rules compiled.
I think, that it needs some ability to tuning the project, to avoid
unnecessary messages. In Maven it's achieved by using excludes and fine
grained use of dependency scopes. But kie-ci don't take it into account...
error-exceptions.txt
<http://drools.46999.n3.nabble.com/file/n4028719/error-exceptions.txt>
all-messages.txt
<http://drools.46999.n3.nabble.com/file/n4028719/all-messages.txt>
all-exceptions.txt
<http://drools.46999.n3.nabble.com/file/n4028719/all-exceptions.txt>
--
View this message in context:
http://drools.46999.n3.nabble.com/Too-agressive-scanning-of-classes-in-Ki...
Sent from the Drools: User forum mailing list archive at Nabble.com.
9:41 a.m.
Forgot to mention: messages, shown to user, hides the errors source. In my
opinion, messages should include at least an Exception.getMessage().
--
View this message in context:
http://drools.46999.n3.nabble.com/Too-agressive-scanning-of-classes-in-Ki...
Sent from the Drools: User forum mailing list archive at Nabble.com.
10:22 a.m.
The messages are produced as a consequence of your project's dependencies.
For example:
Verification of class
org.hibernate.metamodel.source.annotations.JandexHelper failed and
will not be available for authoring.
Please check the necessary external dependencies for this project are
configured correctly.
This is caused by failure to effectively instantiate JandexHelper (see
here
<https://github.com/droolsjbpm/guvnor/blob/master/guvnor-project/guvnor-pr...>).
If a class cannot be instantiated then it is not available for rule
authoring. We show the warning to alert the user.
The Project Editor only exposes course grained features for the
average user. You can edit the underlying pom.xml, adding whatever
fine-grained exclusions you may require, for your project using the
Administration Perspective.
There are some occasions when you receive an error popup. We are
currently working to address this (they'll become errors in the
Problems Panel).
With kind regards,
Mike
On 14 March 2014 08:36, vektory79 <vektory79(a)gmail.com> wrote:
I'm attach some files with errors, that generated during build:
error-exceptions.txt - is a stack traces for error message only
all-exceptions.txt - is a stack traces for all exceptions, generated in
org.guvnor.common.services.builder.Builder.build()
all-messages.txt - bonus . This is a all messages, shown to user in WEB IDE
As you can see, it's a lot of messages shown. But no one have relation to
the real rules compiled.
I think, that it needs some ability to tuning the project, to avoid
unnecessary messages. In Maven it's achieved by using excludes and fine
grained use of dependency scopes. But kie-ci don't take it into account...
error-exceptions.txt
<http://drools.46999.n3.nabble.com/file/n4028719/error-exceptions.txt>
all-messages.txt
<http://drools.46999.n3.nabble.com/file/n4028719/all-messages.txt>
all-exceptions.txt
<http://drools.46999.n3.nabble.com/file/n4028719/all-exceptions.txt>
--
View this message in context:
http://drools.46999.n3.nabble.com/Too-agressive-scanning-of-classes-in-Ki...
Sent from the Drools: User forum mailing list archive at Nabble.com.
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
1:35 p.m.
2014-03-14 13:23 GMT+04:00 manstis [via Drools] <
ml-node+s46999n4028723h58(a)n3.nabble.com>:
The messages are produced as a consequence of your project's
dependencies.
For example:
Verification of class org.hibernate.metamodel.source.annotations.JandexHelper failed and
will not be available for authoring.
Please check the necessary external dependencies for this project are configured
correctly.
This is caused by failure to effectively instantiate JandexHelper (see here
<https://github.com/droolsjbpm/guvnor/blob/master/guvnor-project/guvnor-pr...>).
You are right. But when I see, that
org.hibernate.metamodel.source.annotations.JandexHelper can't be validated,
how I can distinguish what exactly going wrong?
Now I can determine, that ClassLoader doesn't find class
org.jboss.jandex.AnnotationInstance in debug only.
If a class cannot be instantiated then it is not available for rule
authoring. We show the warning to alert the user.
The Project Editor only exposes course grained features for the average user. You can
edit the underlying pom.xml, adding whatever fine-grained exclusions you may require, for
your project using the Administration Perspective.
Yes. I tried exclusions. It's really work now. Thank you to point me it
feature.
I just missed the last changes.
There are some occasions when you receive an error popup. We are
currently working to address this (they'll become errors in the Problems Panel).
With kind regards,
Mike
--
View this message in context:
http://drools.46999.n3.nabble.com/Too-agressive-scanning-of-classes-in-Ki...
Sent from the Drools: User forum mailing list archive at Nabble.com.
5:58 p.m.
I agree, reporting could be improved.
The problem is how to programmatically determine why a
NoClassDefinitionFound exception was thrown.
On 14 March 2014 12:35, vektory79 <vektory79(a)gmail.com> wrote:
2014-03-14 13:23 GMT+04:00 manstis [via Drools] <[hidden
email]<http://user/SendEmail.jtp?type=node&node=4028730&i=0>
>:
The messages are produced as a consequence of your project's
> dependencies.
>
> For example:
>
> Verification of class org.hibernate.metamodel.source.annotations.JandexHelper failed
and will not be available for authoring.
> Please check the necessary external dependencies for this project are configured
correctly.
>
> This is caused by failure to effectively instantiate JandexHelper (see here
<https://github.com/droolsjbpm/guvnor/blob/master/guvnor-project/guvnor-pr...>).
>
> You are right. But when I see, that
org.hibernate.metamodel.source.annotations.JandexHelper can't be validated,
how I can distinguish what exactly going wrong?
Now I can determine, that ClassLoader doesn't find class
org.jboss.jandex.AnnotationInstance in debug only.
> If a class cannot be instantiated then it is not available for rule authoring. We
show the warning to alert the user.
>
> The Project Editor only exposes course grained features for the average user. You can
edit the underlying pom.xml, adding whatever fine-grained exclusions you may require, for
your project using the Administration Perspective.
>
> Yes. I tried exclusions. It's really work now. Thank you to point me it
feature.
I just missed the last changes.
> There are some occasions when you receive an error popup. We are currently working to
address this (they'll become errors in the Problems Panel).
>
> With kind regards,
>
> Mike
>
>
>
>
------------------------------
View this message in context: Re: [rules-users] Too agressive scanning of
classes in
KieModuleMetaDataImpl<http://drools.46999.n3.nabble.com/Too-agressive-...
Sent from the Drools: User forum mailing list
archive<http://drools.46999.n3.nabble.com/Drools-User-forum-f47000.htm...
Nabble.com.
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
3763
days inactive
3764
days old
6 comments
3 participants
participants (3)
-
Mario Fusco -
Michael Anstis -
vektory79