5:52 a.m.
brendanneff wrote
I read a few forum posts about updating to 5.4 CR1 (we're using 5.4
Final), but wanted to ask and see if that's really the cause before I
start changing the version. I also saw that casting as an Integer, which
we do, could solve the problem. Could someone take a look at this and let
me know if changing to CR1 would fix the issue or if there's a simpler
solution?
I am afraid you misread some former email. I think nobody wrote (or at least
I couldn't find it) that using the 5.4.CR1 release instead of the 5.4.Final
could fix this problem. Quite the opposite actually. I fixed some of these
jitting issues we had between the CR1 and the Final and some others
(including the one you found) remained even in the Final release.
I think I've fixed all the outstanding jitting issues and these fixes will
be available in the upcoming 5.5 release (we are deploying the beta1 in
these days). However it would be great if I could reproduce the bugs you
found, both because I could check if they are actually fixed in the 5.5 and
possibly give you some more informed suggestions to workaround them in the
5.4. In order to do that, the only info I miss is how the CMVNewLoanBean
class is made. Could you please send its source code (or at least the parts
relevant for the 2 failing rules you have) ?
brendanneff wrote
Here are the rules that seem to be causing the errors:
rule "Cashcure - Average Monthly Income Less Than 1251"
when
$loan : CMVNewLoanBean( new
Integer(getCustomer().getLatestEmployer().monthlySalary) < 1251)
then
$loan.setLenderError($loan.getCurrentLender().getName(), 20253);
end
Out of curiosity, why do you create the new Integer there instead of just
doing:
CMVNewLoanBean( getCustomer().getLatestEmployer().monthlySalary < 1251)
Thanks for reporting this,
Mario
--
View this message in context:
http://drools.46999.n3.nabble.com/exception-jitting-problem-tp4019763p401...
Sent from the Drools: User forum mailing list archive at Nabble.com.
11:55 a.m.
New subject: exception jitting problem
Mario Fusco wrote
I think I've fixed all the outstanding jitting issues and these fixes will
be available in the upcoming 5.5 release (we are deploying the beta1 in
these days). However it would be great if I could reproduce the bugs you
found, both because I could check if they are actually fixed in the 5.5
and possibly give you some more informed suggestions to workaround them in
the 5.4. In order to do that, the only info I miss is how the
CMVNewLoanBean class is made. Could you please send its source code (or at
least the parts relevant for the 2 failing rules you have) ?
I'm not sure how to answer that question, but hopefully this will be a
start. I can provide more if you have specifics or if I'm going in the
wrong direction.
public class CMVNewLoanBean extends CMVBaseRequestBean {
private CMVCustomerBean customer = null;
private Map<String,CMVLenderBean> activeLenders = new
HashMap<String,CMVLenderBean>();
public CMVCustomerBean getCustomer() {
if (customer == null) {
customer = new CMVCustomerBean();
}
return customer;
}
public void setCustomer(CMVCustomerBean customer) {
this.customer = customer;
}
public Map<String,CMVLenderBean> getActiveLenders() {
return activeLenders;
}
public void setActiveLenders(Map<String,CMVLenderBean> activeLenders) {
this.activeLenders = activeLenders;
}
public CMVLenderBean getActiveLender(String lenderName) {
return activeLenders.get(lenderName);
}
}
public class CMVEmployerBean {
public enum PERIODICITY {
BI_WEEKLY ("B"),
MONTHLY ("M"),
SEMI_MONTHLY ("S"),
WEEKLY ("W");
private final String periodicity;
PERIODICITY(String periodicity) {
this.periodicity = periodicity;
}
public String getPeriodicity() {
return periodicity;
}
}
private PERIODICITY periodicity = null;
private String averagePayCheck = ""; //amount per pay check
public String getAveragePayCheck() {
return averagePayCheck;
}
public void setAveragePayCheck(String averagePayCheck) {
this.averagePayCheck = averagePayCheck;
}
public Integer getMonthlySalary() {
Integer monthlySalary = 0;
if (!averagePayCheck.equals("") && !periodicity.equals(null)) {
monthlySalary = ((Double)
StringUtils.getNumber(averagePayCheck)).intValue();
if (periodicity.equals(PERIODICITY.SEMI_MONTHLY) ||
periodicity.equals(PERIODICITY.BI_WEEKLY)) {
monthlySalary = monthlySalary * 2;
} else if (periodicity.equals(PERIODICITY.WEEKLY)) {
monthlySalary = monthlySalary * 4;
}
} else {
throw new NumberFormatException("The monthly salary was requested but
either the periodicity (" + periodicity + ") or the average pay check (" +
averagePayCheck + ") is not valid.");
}
return monthlySalary;
}
}
public class CMVCustomerBean {
private List<CMVEmployerBean> employers = new ArrayList<CMVEmployerBean>();
public List<CMVEmployerBean> getEmployers() {
return employers;
}
public boolean addEmployer(CMVEmployerBean employer) {
employers.add(employer);
return true;
}
public CMVEmployerBean getEmployer(int index) {
CMVEmployerBean employer = null;
if (this.employers.size() <= index) {
employer = new CMVEmployerBean();
employers.add(employer);
} else {
employer = this.employers.get(index);
}
return employer;
}
public CMVEmployerBean getLatestEmployer() {
return getEmployer(0);
}
public void setEmployers(List<CMVEmployerBean> employers) {
this.employers = employers;
}
}
Mario Fusco wrote
brendanneff wrote
>
> Here are the rules that seem to be causing the errors:
>
> rule "Cashcure - Average Monthly Income Less Than 1251"
> when
> $loan : CMVNewLoanBean( new
> Integer(getCustomer().getLatestEmployer().monthlySalary) < 1251)
> then
> $loan.setLenderError($loan.getCurrentLender().getName(), 20253);
> end
>
Out of curiosity, why do you create the new Integer there instead of just
doing:
CMVNewLoanBean( getCustomer().getLatestEmployer().monthlySalary < 1251)
I don't have a good answer for that as it came that way, but I was wondering
the same thing. I'll try making that switch and see if it has any effect.
--
View this message in context:
http://drools.46999.n3.nabble.com/exception-jitting-problem-tp4019763p401...
Sent from the Drools: User forum mailing list archive at Nabble.com.
3:47 a.m.
New subject: exception jitting problem
I reproduced the problem you reported for the "Cashcure - Average Monthly
Income Less Than 1251" rule (I cannot reproduce the other because I miss the
CMVLenderBean class). I am working to fix it just now, thanks for reporting
this.
However I can confirm that (at least on the 5.5 release I am working on) the
problem disappears if you remove that useless new Integer( ... ) from the
constraint. Another suggestion I can give you (I know this problem could
arise in the 5.4 while it is already fixed in the 5.5) is to avoid, where
possible, to return class types instead of the corresponding primitive ones
like in the CMVEmployerBean.getMonthlySalary() method.
Please confirm that the "Cashcure - Average Monthly Income Less Than 1251"
rule works correctly if you remove the new Integer( ... ) from the
constraint (and if it doesn't also try to make the
CMVEmployerBean.getMonthlySalary() method returning an int as I suggested
above).
Thanks,
Mario
--
View this message in context:
http://drools.46999.n3.nabble.com/exception-jitting-problem-tp4019763p401...
Sent from the Drools: User forum mailing list archive at Nabble.com.
10:15 p.m.
New subject: exception jitting problem
I removed the Integer part from the rule and also changed the
getMonthlyIncome to an int instead of an Integer, and that fixed the
problem. I'm not sure if it was one or the other that did it since I did
both, but if you'd like me to test each separately, I'd be happy to try it
if that would help.
Here's the necessary code for the CMVLednerBean class:
public class CMVNewLoanBean extends CMVBaseRequestBean {
private Map<String,CMVLenderBean> activeLenders = new
HashMap<String,CMVLenderBean>();
public Map<String,CMVLenderBean> getActiveLenders() {
return activeLenders;
}
public void setActiveLenders(Map<String,CMVLenderBean> activeLenders) {
this.activeLenders = activeLenders;
}
public CMVLenderBean getActiveLender(String lenderName) {
return activeLenders.get(lenderName);
}
}
public class CMVLenderBean {
private Integer loanCap = 0;
private Integer loanCount = 0;
public Boolean getCanMakeLoan() {
boolean canMakeLoan = false;
if (loanCap == -1 || loanCount < loanCap) {
canMakeLoan = true;
}
return canMakeLoan;
}
public Integer getLoanCap() {
return loanCap;
}
public void setLoanCap(Integer loanCap) {
this.loanCap = loanCap;
}
public Integer getLoanCount() {
return loanCount;
}
public void setLoanCount(Integer loanCount) {
this.loanCount = loanCount;
}
}
Please let me know if I missed anything.
--
View this message in context:
http://drools.46999.n3.nabble.com/exception-jitting-problem-tp4019763p401...
Sent from the Drools: User forum mailing list archive at Nabble.com.
4448
days inactive
4453
days old
3 comments
2 participants
participants (2)
-
brendanneff -
Mario Fusco