5:55 p.m.
I have the application setup where the drl is generated from the database and
then written to the file system. So far i have been working with the drl's
without any problems but have run into issues while working with packages.
Any help is much appreciated. Thanks.
Here is what i am doing while serializing the package.
PackageBuilder builder = new PackageBuilder();
builder.addPackageFromDrl(new StringReader(drl));
Package pkg = builder.getPackage();
DroolsStreamUtils.streamOut(new ObjectOutputStream(new FileOutputStream(new
File(fileName+".pkg"))), pkg);
i also tried the writeExternal on package, this genereate the file but got a
class cast exception while trying to load it.
The pkg file is generated and i dont think it has a problem unless i am
missing something in the above code.
Now, on the other side i am using drools-spring which sets up the agent on
startup. I was doing some trial and error and found two configurations that
worked but needed
ResourceFactory.getResourceChangeScannerService().start();
ResourceFactory.getResourceChangeNotifierService().start();
to be in code, just the spring configuration didnt work (again if i am
missing something please let me know).
here are the spring configuration
First
<drools:kagent id="agent" kbase="base"
new-instance="true"/>
<drools:kbase id="base">
<drools:resources>
<!--drools:resource type="DRL" source="file:C:\file.drl"/-->
//this works
<drools:resource type="PKG" source="file:C:\file.pkg"/>
</drools:resources>
</drools:kbase-->
Second
<drools:kagent id="agent" kbase="base"
new-instance="true">
<drools:resources>
<drools:resource type="CHANGE_SET"
source="file:C:\change-set.xml"/>
</drools:resources>
</drools:kagent>
<drools:kbase id="base"></drools:kbase>
and the changeset
<change-set...>
<add>
<resource source='file:/C:/file.pkg' type='PKG'/>
</add>
</change-set>
--
View this message in context:
http://drools-java-rules-engine.46999.n3.nabble.com/OptionalDataException...
Sent from the Drools - User mailing list archive at Nabble.com.
9:15 p.m.
New subject: Drools Guvnor: DSL with multiple fact fields conditions using "-" and eval
Hi all,
I am using the latest Guvnor release (5.1), and I have the following DSL expression where
I use "-" to have conditions on multiple lines:
[when] There is an Asset=asset:Asset()
[when]- name is empty=eval(StringUtils.isBlank(name))
[when]- tag is empty=eval(StringUtils.isBlank(tag))
Having these DSL expressions, I wanted to create a rule, but I ran into some issues.
To summarize: There seems to be a parsing error, when conditions are added in DSL using
"-". Did anybody else run into this problem? I wonder if I do something wrong,
but, re-creating the DSL to have the 2 conditions into one expression, is all working
fine. It may be a combination of "-" and eval?
Below, is the description of rules created, and error I got.
First, I created a rule using the above DSL expressions in the BRL editor. While the rule
looked ok in the editor, and it validated fine, only when I checked the source I noticed
is wrong. So, the rule source looks like this:
rule "test_dsl"
dialect "mvel"
when
asset:Asset( eval(StringUtils.isBlank(name, eval(StringUtils.isBlank(tag)) ))
)
then
asset.setStatus("INVALID")
end
It looks that the conditions are parsed incorrectly, and the second eval condition is
added as a parameter to the StringUtils.isBlank from the first eval. Also, all the right
parenthesis are added at the end of the expression. If I add one condition at a time, it
all works fine. The error is when I have more than 1 condition.
So, I created a new DSL, that contains both conditions into one line, eliminating the
hyphen between conditions:
[when] There is an asset with name empty AND tag empty
=asset:Asset(eval(StringUtils.isBlank(name)),eval(StringUtils.isBlank(tag)))
Using BRL editor, I created a second rule using the DSL above. The rule validated ok, and
the rule source looks fine:
rule "test_dsl_1"
dialect "mvel"
when
asset:Asset(eval(StringUtils.isBlank(name)),eval(StringUtils.isBlank(tag)))
then
asset.setStatus("INVALID")
end
I created a test for this rule, that ran correctly.
Thanks,
Patricia
9:43 p.m.
New subject: Drools Guvnor: DSL with multiple fact fields conditions using "-" and eval
can you try with this:
[when] There is an Asset=asset:Asset()
[when] -name is empty=eval(StringUtils.isBlank(name))
[when] -tag is empty=eval(StringUtils.isBlank(tag))
2010/8/26 Patricia Bogoevici <patriciabogoevici(a)yahoo.com>
Hi all,
I am using the latest Guvnor release (5.1), and I have the following DSL
expression where I use "-" to have conditions on multiple lines:
[when] There is an Asset=asset:Asset()
[when]- name is empty=eval(StringUtils.isBlank(name))
[when]- tag is empty=eval(StringUtils.isBlank(tag))
Having these DSL expressions, I wanted to create a rule, but I ran into
some issues.
To summarize: There seems to be a parsing error, when conditions are added
in DSL using "-". Did anybody else run into this problem? I wonder if I do
something wrong, but, re-creating the DSL to have the 2 conditions into one
expression, is all working fine. It may be a combination of "-" and eval?
Below, is the description of rules created, and error I got.
First, I created a rule using the above DSL expressions in the BRL editor.
While the rule looked ok in the editor, and it validated fine, only when I
checked the source I noticed is wrong. So, the rule source looks like this:
rule "test_dsl"
dialect "mvel"
when
asset:Asset( eval(StringUtils.isBlank(name,
eval(StringUtils.isBlank(tag)) )) )
then
asset.setStatus("INVALID")
end
It looks that the conditions are parsed incorrectly, and the second eval
condition is added as a parameter to the StringUtils.isBlank from the first
eval. Also, all the right parenthesis are added at the end of the
expression. If I add one condition at a time, it all works fine. The error
is when I have more than 1 condition.
So, I created a new DSL, that contains both conditions into one line,
eliminating the hyphen between conditions:
[when] There is an asset with name empty AND tag empty
=asset:Asset(eval(StringUtils.isBlank(name)),eval(StringUtils.isBlank(tag)))
Using BRL editor, I created a second rule using the DSL above. The rule
validated ok, and the rule source looks fine:
rule "test_dsl_1"
dialect "mvel"
when
asset:Asset(eval(StringUtils.isBlank(name)),eval(StringUtils.isBlank(tag)))
then
asset.setStatus("INVALID")
end
I created a test for this rule, that ran correctly.
Thanks,
Patricia
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
--
- CTO @ http://www.plugtree.com
- MyJourney @ http://salaboy.wordpress.com
- Co-Founder @ http://www.jbug.com.ar
- Salatino "Salaboy" Mauricio -
10:35 p.m.
New subject: Drools Guvnor: Rule fires multiple times when using eval and OR
Hi all,
I am using Drools Guvnor 5.1. I created a rule that uses eval, and OR for conditions. When
I tested the rule, I noticed in the log, that actually the rule fired twice.
The error seemed to be caused by eval and or combination. When I re-wrote the rule to not
use eval, it fired only once. Also, I re-wrote the rule to use eval, but AND for
conditions, again, the rule fired once as expected.
I wonder if there is any other rule attribute besides no-loop, and lock-on-active that I
can use to not have the rule firing twice. Or if there is any way to make the rule not
firing twice.The main problem for me, is that after the rule is executed, there are 2
objects created.
Below is the rule test scenario, and audit log:
Rule with eval and OR, rule fires twice
rule "test_rule_1"
lock-on-active true
no-loop true
dialect "mvel"
when
Asset(eval(StringUtils.isBlank(name)))
or
Asset(eval(StringUtils.isBlank(tag)))
then
Assetfact0 = new Asset();
fact0.setStatus( "INVALID" );
insert(fact0 );
end
Audit log:
OBJECT ASSERTED value:Asset( model=MODEL, status=null, tag=null, classification=null,
name=null, serial=null ) factId: 1
FIRING rule: [test_rule_1] activationId:test_rule_1 [1] declarations:
OBJECT ASSERTED value:Asset( model=null, status=INVALID, tag=null, classification=null,
name=null, serial=null ) factId: 2
FIRING rule: [test_rule_1] activationId:test_rule_1 [1] declarations:
OBJECT ASSERTED value:Asset( model=null, status=INVALID, tag=null, classification=null,
name=null, serial=null ) factId: 3
Rule with eval and AND, rule fires only once:
rule "test_rule_2"
lock-on-active true
no-loop true
dialect "mvel"
when
Asset(eval(StringUtils.isBlank(name)))
Asset(eval(StringUtils.isBlank(tag)))
then
Assetfact0 = new Asset();
fact0.setStatus( "INVALID" );
insert(fact0 );
end
Audit log:
OBJECT ASSERTED value:Asset( model=MODEL, status=null, tag=null, classification=null,
name=null, serial=null ) factId: 1
FIRING rule: [test_rule_2] activationId:test_rule_2 [1] declarations:
OBJECT ASSERTED value:Asset( model=null, status=INVALID, tag=null, classification=null,
name=null, serial=null ) factId: 2
Rule with simple string validation instead of eval. The rule fires only once.
rule "test_rule_3"
lock-on-active true
no-loop true
dialect "mvel"
when
Asset(name=="''")
or
Asset(tag=="'''")
then
Assetfact0 = new Asset();
fact0.setStatus( "INVALID" );
insert(fact0 );
end
Audit log:
OBJECT ASSERTED value:Asset( model=MODEL, status=null, tag=null, classification=null,
name='', serial=null ) factId: 1
FIRING rule: [test_rule_3] activationId: test_rule_3 [1] declarations:
OBJECT ASSERTED value:Asset( model=null, status=INVALID, tag=null, classification=null,
name=null, serial=null ) factId: 2
Thanks,
Patricia
2:32 a.m.
New subject: Drools Guvnor: Rule fires multiple times when using eval and OR
My advice is: Try to avoid the Conditional Element "or". From the
"Expert" manual: "The engine actually has no understanding of the
Conditional Element 'or',..." So, if the engine doesn't
"understand"
it, how can we? ;-)
More seriously now, there is general consent that a CE "or" should
ultimately result in two (or more) disjunct (sub-)rules, firing
independently. But this clear strategy is apparently countered (you
could even say marred) by some Rete-level refactoring or optimization.
Anyway, in your case, a "healthy" solution is to write
rule "any blank"
when
Asset( eval( StringUtil.isBlank(name) || StringUtil.isBlank(tag) ))
then
//...
end
-W
2010/8/27 Patricia Bogoevici <patriciabogoevici(a)yahoo.com>
Hi all,
I am using Drools Guvnor 5.1. I created a rule that uses eval, and OR for conditions.
When I tested the rule, I noticed in the log, that actually the rule fired twice.
The error seemed to be caused by eval and or combination. When I re-wrote the rule to not
use eval, it fired only once. Also, I re-wrote the rule to use eval, but AND for
conditions, again, the rule fired once as expected.
I wonder if there is any other rule attribute besides no-loop, and lock-on-active that I
can use to not have the rule firing twice. Or if there is any way to make the rule not
firing twice.The main problem for me, is that after the rule is executed, there are 2
objects created.
Below is the rule test scenario, and audit log:
Rule with eval and OR, rule fires twice
rule "test_rule_1"
lock-on-active true
no-loop true
dialect "mvel"
when
Asset(eval(StringUtils.isBlank(name)))
or
Asset(eval(StringUtils.isBlank(tag)))
then
Assetfact0 = new Asset();
fact0.setStatus( "INVALID" );
insert(fact0 );
end
Audit log:
OBJECT ASSERTED value:Asset( model=MODEL, status=null, tag=null, classification=null,
name=null, serial=null ) factId: 1
FIRING rule: [test_rule_1] activationId:test_rule_1 [1] declarations:
OBJECT ASSERTED value:Asset( model=null, status=INVALID, tag=null, classification=null,
name=null, serial=null ) factId: 2
FIRING rule: [test_rule_1] activationId:test_rule_1 [1] declarations:
OBJECT ASSERTED value:Asset( model=null, status=INVALID, tag=null, classification=null,
name=null, serial=null ) factId: 3
Rule with eval and AND, rule fires only once:
rule "test_rule_2"
lock-on-active true
no-loop true
dialect "mvel"
when
Asset(eval(StringUtils.isBlank(name)))
Asset(eval(StringUtils.isBlank(tag)))
then
Assetfact0 = new Asset();
fact0.setStatus( "INVALID" );
insert(fact0 );
end
Audit log:
OBJECT ASSERTED value:Asset( model=MODEL, status=null, tag=null, classification=null,
name=null, serial=null ) factId: 1
FIRING rule: [test_rule_2] activationId:test_rule_2 [1] declarations:
OBJECT ASSERTED value:Asset( model=null, status=INVALID, tag=null, classification=null,
name=null, serial=null ) factId: 2
Rule with simple string validation instead of eval. The rule fires only once.
rule "test_rule_3"
lock-on-active true
no-loop true
dialect "mvel"
when
Asset(name=="''")
or
Asset(tag=="'''")
then
Assetfact0 = new Asset();
fact0.setStatus( "INVALID" );
insert(fact0 );
end
Audit log:
OBJECT ASSERTED value:Asset( model=MODEL, status=null, tag=null, classification=null,
name='', serial=null ) factId: 1
FIRING rule: [test_rule_3] activationId: test_rule_3 [1] declarations:
OBJECT ASSERTED value:Asset( model=null, status=INVALID, tag=null, classification=null,
name=null, serial=null ) factId: 2
Thanks,
Patricia
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
11:33 a.m.
New subject: Drools Guvnor: Rule fires multiple times when using eval and OR
Thx for your answer, Wolfgang.
While your advice makes sense, it does not help me. I cannot avoid using OR. I use Drools
for validation and I have some cases when I need to use OR between conditions for
evaluating an invalid state. Also, the solution you proposed works fine when the rule
works with one object type only. If there are more than 1, it does not work. A workaround
I see, would be to separate each of the condition from OR, into separate rule. But that
adds the overhead of managing multiple rules.
In Expert, 5.1 manual, there is an example of how to chain expressions in DSL, using OR.
They mention mapping OR being sensible, but I wish there were more details about that
sensible thing.
--quote from the manual:
"
Example 4.77. Chaining DSL Expressions
There is a person called Bob who is happy
Or
There is a person called Mike who is sad
Of course this assumes that "Or" is mapped to the "or" conditional
element (which is a sensible thing to do).
"
--end quote
So, my question was:
Is any solution to chain conditions using eval, without having the rule firing multiple
times? From your answer, it seems not, and it seems that will not be possible due to some
Rete-level refactoring or optimization (hope I got your message correct, I do not know how
RETE works). Is that true?
I believe, I can live with this limitation (rule fires multiple times). I only hope that
there is no other implication, that I am not aware of right now.
Thanks,
Patricia
--- On Fri, 8/27/10, Wolfgang Laun <wolfgang.laun(a)gmail.com> wrote:
From: Wolfgang Laun <wolfgang.laun(a)gmail.com>
Subject: Re: [rules-users] Drools Guvnor: Rule fires multiple times when using eval and
OR
To: "Rules Users List" <rules-users(a)lists.jboss.org>
Date: Friday, August 27, 2010, 3:32 AM
My advice is: Try to avoid the Conditional Element "or". From the
"Expert" manual: "The engine actually has no understanding of the
Conditional Element 'or',..." So, if the engine doesn't
"understand"
it, how can we? ;-)
More seriously now, there is general consent that a CE "or" should
ultimately result in two (or more) disjunct (sub-)rules, firing
independently. But this clear strategy is apparently countered (you
could even say marred) by some Rete-level refactoring or optimization.
Anyway, in your case, a "healthy" solution is to write
rule "any blank"
when
Asset( eval( StringUtil.isBlank(name) || StringUtil.isBlank(tag) ))
then
//...
end
-W
2010/8/27 Patricia Bogoevici <patriciabogoevici(a)yahoo.com>
Hi all,
I am using Drools Guvnor 5.1. I created a rule that uses eval, and OR for conditions.
When I tested the rule, I noticed in the log, that actually the rule fired twice.
The error seemed to be caused by eval and or combination. When I re-wrote the rule to not
use eval, it fired only once. Also, I re-wrote the rule to use eval, but AND for
conditions, again, the rule fired once as expected.
I wonder if there is any other rule attribute besides no-loop, and lock-on-active that I
can use to not have the rule firing twice. Or if there is any way to make the rule not
firing twice.The main problem for me, is that after the rule is executed, there are 2
objects created.
Below is the rule test scenario, and audit log:
Rule with eval and OR, rule fires twice
rule "test_rule_1"
lock-on-active true
no-loop true
dialect "mvel"
when
Asset(eval(StringUtils.isBlank(name)))
or
Asset(eval(StringUtils.isBlank(tag)))
then
Assetfact0 = new Asset();
fact0.setStatus( "INVALID" );
insert(fact0 );
end
Audit log:
OBJECT ASSERTED value:Asset( model=MODEL, status=null, tag=null, classification=null,
name=null, serial=null ) factId: 1
FIRING rule: [test_rule_1] activationId:test_rule_1 [1] declarations:
OBJECT ASSERTED value:Asset( model=null, status=INVALID, tag=null, classification=null,
name=null, serial=null ) factId: 2
FIRING rule: [test_rule_1] activationId:test_rule_1 [1] declarations:
OBJECT ASSERTED value:Asset( model=null, status=INVALID, tag=null, classification=null,
name=null, serial=null ) factId: 3
Rule with eval and AND, rule fires only once:
rule "test_rule_2"
lock-on-active true
no-loop true
dialect "mvel"
when
Asset(eval(StringUtils.isBlank(name)))
Asset(eval(StringUtils.isBlank(tag)))
then
Assetfact0 = new Asset();
fact0.setStatus( "INVALID" );
insert(fact0 );
end
Audit log:
OBJECT ASSERTED value:Asset( model=MODEL, status=null, tag=null, classification=null,
name=null, serial=null ) factId: 1
FIRING rule: [test_rule_2] activationId:test_rule_2 [1] declarations:
OBJECT ASSERTED value:Asset( model=null, status=INVALID, tag=null, classification=null,
name=null, serial=null ) factId: 2
Rule with simple string validation instead of eval. The rule fires only once.
rule "test_rule_3"
lock-on-active true
no-loop true
dialect "mvel"
when
Asset(name=="''")
or
Asset(tag=="'''")
then
Assetfact0 = new Asset();
fact0.setStatus( "INVALID" );
insert(fact0 );
end
Audit log:
OBJECT ASSERTED value:Asset( model=MODEL, status=null, tag=null, classification=null,
name='', serial=null ) factId: 1
FIRING rule: [test_rule_3] activationId: test_rule_3 [1] declarations:
OBJECT ASSERTED value:Asset( model=null, status=INVALID, tag=null, classification=null,
name=null, serial=null ) factId: 2
Thanks,
Patricia
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
1:17 p.m.
New subject: Drools Guvnor: Rule fires multiple times when using eval and OR
2010/8/27 Patricia Bogoevici <patriciabogoevici(a)yahoo.com>
Thx for your answer, Wolfgang.
While your advice makes sense, it does not help me. I cannot avoid using
OR. I use Drools for validation and I have some cases when I need to use OR
between conditions for evaluating an invalid state.
Well, I just wrote a substantial number of rules for data validation, and I
never felt the need to use "or". Care to post an example where you think you
can't avoid it?
Also, the solution you proposed works fine when the rule works with
one
object type only. If there are more than 1, it does not work.
Right, but or-ing two facts of entirely different types produces a rather
limited CE: you cannot, for instance, bind a LHS variable to such a CE. This
means that, later on and on the RHS, you don't know which of these actually
matched.
A workaround I see, would be to separate each of the condition from
OR,
into separate rule. But that adds the overhead of managing multiple rules.
True, and this is one (perhaps the only one) point in favour of "or".
In Expert, 5.1 manual, there is an example of how to chain expressions in
DSL, using OR. They mention mapping OR being sensible, but I wish there were
more details about that sensible thing.
--quote from the manual:
"
Example 4.77. Chaining DSL Expressions
There is a person called Bob who is happy
Or
There is a person called Mike who is sad
Of course this assumes that "Or" is mapped to the "or" conditional
element
(which is a sensible thing to do).
"
--end quote
Heh :)
What the author is trying to say here is that only a moron would map "Or" to
"and".
So, my question was:
Is any solution to chain conditions using eval, without having the rule
firing multiple times? From your answer, it seems not, and it seems that
will not be possible due to some Rete-level refactoring or optimization
(hope I got your message correct, I do not know how RETE works). Is that
true?
Yes. - As for Rete, you could read
this<http://www.jessrules.com/jess/docs/71/rete.html>;.
The syntax of the rules is a little different, but you should get an idea
about the general principle and where optimization kicks in.
I believe, I can live with this limitation (rule fires multiple times).
You could avoid this, technically, by adding additional CEs, but if you can
live with it, it may not be worth the effort.
I only hope that there is no other implication, that I am not aware
of
right now.
I don't think there is.
-W
Thanks,
Patricia
--- On *Fri, 8/27/10, Wolfgang Laun <wolfgang.laun(a)gmail.com>* wrote:
From: Wolfgang Laun <wolfgang.laun(a)gmail.com>
Subject: Re: [rules-users] Drools Guvnor: Rule fires multiple times when
using eval and OR
To: "Rules Users List" <rules-users(a)lists.jboss.org>
Date: Friday, August 27, 2010, 3:32 AM
My advice is: Try to avoid the Conditional Element "or". From the
"Expert" manual: "The engine actually has no understanding of the
Conditional Element 'or',..." So, if the engine doesn't
"understand"
it, how can we? ;-)
More seriously now, there is general consent that a CE "or" should
ultimately result in two (or more) disjunct (sub-)rules, firing
independently. But this clear strategy is apparently countered (you
could even say marred) by some Rete-level refactoring or optimization.
Anyway, in your case, a "healthy" solution is to write
rule "any blank"
when
Asset( eval( StringUtil.isBlank(name) || StringUtil.isBlank(tag) ))
then
//...
end
-W
2010/8/27 Patricia Bogoevici
<patriciabogoevici@yahoo.com<http://mc/compose?to=patriciabogoevici@yahoo.com>
>
>
> Hi all,
>
> I am using Drools Guvnor 5.1. I created a rule that uses eval, and OR for
conditions. When I tested the rule, I noticed in the log, that actually the
rule fired twice.
> The error seemed to be caused by eval and or combination. When I re-wrote
the rule to not use eval, it fired only once. Also, I re-wrote the rule to
use eval, but AND for conditions, again, the rule fired once as expected.
> I wonder if there is any other rule attribute besides no-loop, and
lock-on-active that I can use to not have the rule firing twice. Or if there
is any way to make the rule not firing twice.The main problem for me, is
that after the rule is executed, there are 2 objects created.
>
> Below is the rule test scenario, and audit log:
>
>
> Rule with eval and OR, rule fires twice
> rule "test_rule_1"
> lock-on-active true
> no-loop true
> dialect "mvel"
> when
> Asset(eval(StringUtils.isBlank(name)))
> or
> Asset(eval(StringUtils.isBlank(tag)))
> then
> Assetfact0 = new Asset();
> fact0.setStatus( "INVALID" );
> insert(fact0 );
> end
>
> Audit log:
> OBJECT ASSERTED value:Asset( model=MODEL, status=null, tag=null,
classification=null, name=null, serial=null ) factId: 1
> FIRING rule: [test_rule_1] activationId:test_rule_1 [1] declarations:
> OBJECT ASSERTED value:Asset( model=null, status=INVALID, tag=null,
classification=null, name=null, serial=null ) factId: 2
> FIRING rule: [test_rule_1] activationId:test_rule_1 [1] declarations:
> OBJECT ASSERTED value:Asset( model=null, status=INVALID, tag=null,
classification=null, name=null, serial=null ) factId: 3
>
> Rule with eval and AND, rule fires only once:
> rule "test_rule_2"
> lock-on-active true
> no-loop true
> dialect "mvel"
> when
> Asset(eval(StringUtils.isBlank(name)))
> Asset(eval(StringUtils.isBlank(tag)))
> then
> Assetfact0 = new Asset();
> fact0.setStatus( "INVALID" );
> insert(fact0 );
> end
>
> Audit log:
> OBJECT ASSERTED value:Asset( model=MODEL, status=null, tag=null,
classification=null, name=null, serial=null ) factId: 1
> FIRING rule: [test_rule_2] activationId:test_rule_2 [1] declarations:
> OBJECT ASSERTED value:Asset( model=null, status=INVALID, tag=null,
classification=null, name=null, serial=null ) factId: 2
>
> Rule with simple string validation instead of eval. The rule fires only
once.
>
> rule "test_rule_3"
> lock-on-active true
> no-loop true
> dialect "mvel"
> when
> Asset(name=="''")
> or
> Asset(tag=="'''")
> then
> Assetfact0 = new Asset();
> fact0.setStatus( "INVALID" );
> insert(fact0 );
> end
>
>
> Audit log:
> OBJECT ASSERTED value:Asset( model=MODEL, status=null, tag=null,
classification=null, name='', serial=null ) factId: 1
> FIRING rule: [test_rule_3] activationId: test_rule_3 [1] declarations:
> OBJECT ASSERTED value:Asset( model=null, status=INVALID, tag=null,
classification=null, name=null, serial=null ) factId: 2
>
>
> Thanks,
> Patricia
>
>
> _______________________________________________
> rules-users mailing list
> rules-users@lists.jboss.org<http://mc/compose?to=rules-users@lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/rules-users
>
_______________________________________________
rules-users mailing list
rules-users@lists.jboss.org<http://mc/compose?to=rules-users@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/rules-users
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
11:53 p.m.
New subject: Drools Guvnor: DSL with multiple fact fields conditions using "-" and eval
Thx for your answer.
I tried again the rule, removing the extra space after hyphen from DSL expresion. No luck.
So, I tried a few more cases, and the only one that worked correctly was #3.
It seems to me that is somehow related to the parenthesis, although it might be something
else. Hope this info helps.
1) only eval:
DSL:
[when] There is an Asset=asset:Asset()
[when]-name is empty=eval(name=="''")
[when]-tag is empty=eval(tag=="''")
Rule source:
rule "test_rule"
dialect "mvel"
when
asset:Asset( eval(name=="''",
eval(tag=="''") ) )
then
end
2) no eval, but with the parenthesis:
DSL:
[when] There is an Asset=asset:Asset()
[when]-name is empty=(name=="''")
[when]-tag is empty=(tag=="''")
Rule source
rule "test_rule"
dialect "mvel"
when
asset:Asset( (name=="''", (tag=="''") ) )
then
end
3) simple case
DSL
[when] There is an Asset=asset:Asset()
[when]-name empty=name=="''"
[when]-tag empty=tag=="''"
Rule Source:
rule "test_rule"
dialect "mvel"
when
asset:Asset( name=="''", tag=="''" )
then
end
Thanks,
--- On Thu, 8/26/10, Mauricio Salatino <salaboy(a)gmail.com> wrote:
From: Mauricio Salatino <salaboy(a)gmail.com>
Subject: Re: [rules-users] Drools Guvnor: DSL with multiple fact fields conditions using
"-" and eval
To: "Rules Users List" <rules-users(a)lists.jboss.org>
Date: Thursday, August 26, 2010, 10:43 PM
can you try with this:
[when] There is an Asset=asset:Asset()
[when] -name is
empty=eval(StringUtils.isBlank(name))
[when] -tag is
empty=eval(StringUtils.isBlank(tag))
2010/8/26 Patricia Bogoevici <patriciabogoevici(a)yahoo.com>
Hi all,
I am using the latest Guvnor release (5.1), and I have the following DSL expression where
I use "-" to have conditions on multiple lines:
[when] There is an Asset=asset:Asset()
[when]- name is empty=eval(StringUtils.isBlank(name))
[when]- tag is empty=eval(StringUtils.isBlank(tag))
Having these DSL expressions, I wanted to create a rule, but I ran into some issues.
To summarize: There seems to be a parsing error, when conditions are added in DSL using
"-". Did anybody else run into this problem? I wonder if I do something wrong,
but, re-creating the DSL to have the 2 conditions into one expression, is all working
fine. It may be a combination of "-" and eval?
Below, is the description of rules created, and error I got.
First, I created a rule using the above DSL expressions in the BRL editor. While the
rule looked ok in the editor, and it validated fine, only when I checked the source I
noticed is wrong. So, the rule source looks like this:
rule "test_dsl"
dialect "mvel"
when
asset:Asset( eval(StringUtils.isBlank(name, eval(StringUtils.isBlank(tag)) ))
)
then
asset.setStatus("INVALID")
end
It looks that the conditions are parsed incorrectly, and the second eval condition is
added as a parameter to the StringUtils.isBlank from the first eval. Also, all the right
parenthesis are added at the end of the expression. If I add one condition at a time, it
all works fine. The error is when I have more than 1 condition.
So, I created a new DSL, that contains both
conditions into one line, eliminating the hyphen between conditions:
[when] There is an asset with name empty AND tag empty
=asset:Asset(eval(StringUtils.isBlank(name)),eval(StringUtils.isBlank(tag)))
Using BRL editor, I created a second rule using the DSL above. The rule validated ok, and
the rule source looks fine:
rule "test_dsl_1"
dialect "mvel"
when
asset:Asset(eval(StringUtils.isBlank(name)),eval(StringUtils.isBlank(tag)))
then
asset.setStatus("INVALID")
end
I created a test for this rule, that ran correctly.
Thanks,
Patricia
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
--
- CTO @ http://www.plugtree.com
- MyJourney @ http://salaboy.wordpress.com
- Co-Founder @ http://www.jbug.com.ar
- Salatino "Salaboy" Mauricio -
-----Inline Attachment Follows-----
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
1:58 a.m.
New subject: Drools Guvnor: DSL with multiple fact fields conditions using "-" and eval
It seems that the initial hyphen merges the DSL definition's right hand side
into the parenthesis of the last preceding term, even if that one is an
eval, which itself is meant to go into some preceding pattern.
You could work around that by making all evals Conditional Elements rather
than Inline Eval Constraints. The disadvantage is that you'll have to use
full object qualification, e.g.,
[when]where name is empty=eval(StringUtils.isBlank( asset.getName() )
I think that your variant
[when]-name empty=name=="''"
has to be written without the apostrophes:
[when]-name empty=name==""
-W
2010/8/27 Patricia Bogoevici <patriciabogoevici(a)yahoo.com>
Thx for your answer.
I tried again the rule, removing the extra space after hyphen from DSL
expresion. No luck. So, I tried a few more cases, and the only one that
worked correctly was #3.
It seems to me that is somehow related to the parenthesis, although it
might be something else. Hope this info helps.
1) only eval:
DSL:
[when] There is an Asset=asset:Asset()
[when]-name is empty=eval(name=="''")
[when]-tag is empty=eval(tag=="''")
Rule source:
rule "test_rule"
dialect "mvel"
when
asset:Asset( eval(name=="''",
eval(tag=="''") ) )
then
end
2) no eval, but with the parenthesis:
DSL:
[when] There is an Asset=asset:Asset()
[when]-name is empty=(name=="''")
[when]-tag is empty=(tag=="''")
Rule source
rule "test_rule"
dialect "mvel"
when
asset:Asset( (name=="''", (tag=="''") )
)
then
end
3) simple case
DSL
[when] There is an Asset=asset:Asset()
[when]-name empty=name=="''"
[when]-tag empty=tag=="''"
Rule Source:
rule "test_rule"
dialect "mvel"
when
asset:Asset( name=="''", tag=="''" )
then
end
Thanks,
--- On *Thu, 8/26/10, Mauricio Salatino <salaboy(a)gmail.com>* wrote:
From: Mauricio Salatino <salaboy(a)gmail.com>
Subject: Re: [rules-users] Drools Guvnor: DSL with multiple fact fields
conditions using "-" and eval
To: "Rules Users List" <rules-users(a)lists.jboss.org>
Date: Thursday, August 26, 2010, 10:43 PM
can you try with this:
[when] There is an Asset=asset:Asset()
[when] -name is empty=eval(StringUtils.isBlank(name))
[when] -tag is empty=eval(StringUtils.isBlank(tag))
2010/8/26 Patricia Bogoevici
<patriciabogoevici@yahoo.com<http://mc/compose?to=patriciabogoevici@yahoo.com>
>
Hi all,
I am using the latest Guvnor release (5.1), and I have the following DSL
expression where I use "-" to have conditions on multiple lines:
[when] There is an Asset=asset:Asset()
[when]- name is empty=eval(StringUtils.isBlank(name))
[when]- tag is empty=eval(StringUtils.isBlank(tag))
Having these DSL expressions, I wanted to create a rule, but I ran into
some issues.
To summarize: There seems to be a parsing error, when conditions are added
in DSL using "-". Did anybody else run into this problem? I wonder if I do
something wrong, but, re-creating the DSL to have the 2 conditions into one
expression, is all working fine. It may be a combination of "-" and eval?
Below, is the description of rules created, and error I got.
First, I created a rule using the above DSL expressions in the BRL editor.
While the rule looked ok in the editor, and it validated fine, only when I
checked the source I noticed is wrong. So, the rule source looks like this:
rule "test_dsl"
dialect "mvel"
when
asset:Asset( eval(StringUtils.isBlank(name,
eval(StringUtils.isBlank(tag)) )) )
then
asset.setStatus("INVALID")
end
It looks that the conditions are parsed incorrectly, and the second eval
condition is added as a parameter to the StringUtils.isBlank from the first
eval. Also, all the right parenthesis are added at the end of the
expression. If I add one condition at a time, it all works fine. The error
is when I have more than 1 condition.
So, I created a new DSL, that contains both conditions into one line,
eliminating the hyphen between conditions:
[when] There is an asset with name empty AND tag empty
=asset:Asset(eval(StringUtils.isBlank(name)),eval(StringUtils.isBlank(tag)))
Using BRL editor, I created a second rule using the DSL above. The rule
validated ok, and the rule source looks fine:
rule "test_dsl_1"
dialect "mvel"
when
asset:Asset(eval(StringUtils.isBlank(name)),eval(StringUtils.isBlank(tag)))
then
asset.setStatus("INVALID")
end
I created a test for this rule, that ran correctly.
Thanks,
Patricia
_______________________________________________
rules-users mailing list
rules-users@lists.jboss.org<http://mc/compose?to=rules-users@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/rules-users
--
- CTO @ http://www.plugtree.com
- MyJourney @ http://salaboy.wordpress.com
- Co-Founder @ http://www.jbug.com.ar
- Salatino "Salaboy" Mauricio -
-----Inline Attachment Follows-----
_______________________________________________
rules-users mailing list
rules-users@lists.jboss.org<http://mc/compose?to=rules-users@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/rules-users
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
11:48 a.m.
New subject: Drools Guvnor: DSL with multiple fact fields conditions using "-" and eval
Thx for your answer, Wolfgang.
To be honest, when I first ran into this, I was in doubt whether that is a parsing error
in Drools (or mvel)? Or is an error that I got into because of how I constructed the DSL
expression?
It seems that it is an error in Drools and I wonder if that should be reported as an issue
in Jira.
--- On Fri, 8/27/10, Wolfgang Laun <wolfgang.laun(a)gmail.com> wrote:
From: Wolfgang Laun <wolfgang.laun(a)gmail.com>
Subject: Re: [rules-users] Drools Guvnor: DSL with multiple fact fields conditions using
"-" and eval
To: "Rules Users List" <rules-users(a)lists.jboss.org>
Date: Friday, August 27, 2010, 2:58 AM
It seems that the initial hyphen merges the DSL definition's right hand side into the
parenthesis of the last preceding term, even if that one is an eval, which itself is meant
to go into some preceding pattern.
You could work around that by making all evals Conditional Elements rather than Inline
Eval Constraints. The disadvantage is that you'll have to use full object
qualification, e.g.,
[when]where name is empty=eval(StringUtils.isBlank( asset.getName() )
Patricia:
True. But, that is a test case, and does not affect the result of what I was testing
I think that your variant
[when]-name empty=name=="''"
has to be written without the apostrophes:
[when]-name empty=name==""
-W
2010/8/27 Patricia Bogoevici <patriciabogoevici(a)yahoo.com>
Thx for your answer.
I tried again the rule, removing the extra space after hyphen from DSL expresion. No luck.
So, I tried a few more cases, and the only one that worked correctly was #3.
It seems to me that is somehow related to the parenthesis, although it might be something
else. Hope this info helps.
1) only eval:
DSL:
[when] There is an Asset=asset:Asset()
[when]-name is empty=eval(name=="''")
[when]-tag is empty=eval(tag=="''")
Rule source:
rule "test_rule"
dialect "mvel"
when
asset:Asset( eval(name=="''",
eval(tag=="''") ) )
then
end
2) no eval, but with the parenthesis:
DSL:
[when] There is an
Asset=asset:Asset()
[when]-name is empty=(name=="''")
[when]-tag is empty=(tag=="''")
Rule source
rule "test_rule"
dialect "mvel"
when
asset:Asset( (name=="''", (tag=="''") ) )
then
end
3) simple case
DSL
[when] There is an Asset=asset:Asset()
[when]-name empty=name=="''"
[when]-tag empty=tag=="''"
Rule Source:
rule "test_rule"
dialect "mvel"
when
asset:Asset( name=="''", tag=="''" )
then
end
Thanks,
--- On Thu, 8/26/10, Mauricio Salatino <salaboy(a)gmail.com>
wrote:
From: Mauricio Salatino <salaboy(a)gmail.com>
Subject: Re: [rules-users] Drools Guvnor: DSL with multiple fact fields conditions using
"-" and eval
To: "Rules Users List" <rules-users(a)lists.jboss.org>
Date: Thursday, August 26, 2010, 10:43 PM
can you try with this:
[when] There is an Asset=asset:Asset()
[when] -name is
empty=eval(StringUtils.isBlank(name))
[when] -tag is
empty=eval(StringUtils.isBlank(tag))
2010/8/26 Patricia Bogoevici <patriciabogoevici(a)yahoo.com>
Hi all,
I am using the latest Guvnor release (5.1), and I have the following DSL expression where
I use "-" to have conditions on multiple lines:
[when] There is an Asset=asset:Asset()
[when]- name is empty=eval(StringUtils.isBlank(name))
[when]- tag is empty=eval(StringUtils.isBlank(tag))
Having these DSL expressions, I wanted to create a rule, but I ran into some issues.
To summarize: There seems to be a parsing error, when conditions are added in DSL using
"-". Did anybody else run into this problem? I wonder if I do something wrong,
but, re-creating the DSL to have the 2 conditions into one expression, is all working
fine. It may be a combination of "-" and eval?
Below, is the description of rules created, and error I got.
First, I created a rule using the above DSL expressions in the BRL editor. While the
rule looked ok in the editor, and it validated fine, only when I checked the source I
noticed is wrong. So, the rule source looks like this:
rule "test_dsl"
dialect "mvel"
when
asset:Asset( eval(StringUtils.isBlank(name, eval(StringUtils.isBlank(tag)) ))
)
then
asset.setStatus("INVALID")
end
It looks that the conditions are parsed incorrectly, and the second eval condition is
added as a parameter to the StringUtils.isBlank from the first eval. Also, all the right
parenthesis are added at the end of the expression. If I add one condition at a time, it
all works fine. The error is when I have more than 1 condition.
So, I created a new DSL, that contains both
conditions into one line, eliminating the hyphen between conditions:
[when] There is an asset with name empty AND tag empty
=asset:Asset(eval(StringUtils.isBlank(name)),eval(StringUtils.isBlank(tag)))
Using BRL editor, I created a second rule using the DSL above. The rule validated ok, and
the rule source looks fine:
rule "test_dsl_1"
dialect "mvel"
when
asset:Asset(eval(StringUtils.isBlank(name)),eval(StringUtils.isBlank(tag)))
then
asset.setStatus("INVALID")
end
I created a test for this rule, that ran correctly.
Thanks,
Patricia
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
--
- CTO @ http://www.plugtree.com
- MyJourney @ http://salaboy.wordpress.com
- Co-Founder @ http://www.jbug.com.ar
- Salatino "Salaboy" Mauricio -
-----Inline Attachment Follows-----
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
-----Inline Attachment Follows-----
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
12:53 p.m.
New subject: Drools Guvnor: DSL with multiple fact fields conditions using "-" and eval
DSL uses regular expression parsing, but the LHS is recursive. (Chomsky
type-3 vs. type-2, if you want the comp. sci. background.) This means that
using DSL restricts you to a subset of the LHS language, although you may
map arbitrarily complex LHS expressions to a single DSL sentence. (In your
case, you would have to have three mappings, one for name, one for tag and
one for name and tag.)
Heuristics might be use to alleviate certain cases, but this would merely be
a band-aid on a very deep gash.
There's another trick to avoid eval as you use it: Create (what I call:)
"virtual attributes" by adding methods to your fact classes. You have
String name;
String getName(){ return name; }
and if you add
boolean isNameBlank(){ return StringUtils.isBlank( name ); }
you can use
Asset( nameBlank == true )
and define a straightforward DSL sentence which can be merged with others
into the fact pattern.
-W
2010/8/27 Patricia Bogoevici <patriciabogoevici(a)yahoo.com>
Thx for your answer, Wolfgang.
To be honest, when I first ran into this, I was in doubt whether that is a
parsing error in Drools (or mvel)? Or is an error that I got into because
of how I constructed the DSL expression?
It seems that it is an error in Drools and I wonder if that should be
reported as an issue in Jira.
--- On *Fri, 8/27/10, Wolfgang Laun <wolfgang.laun(a)gmail.com>* wrote:
From: Wolfgang Laun <wolfgang.laun(a)gmail.com>
Subject: Re: [rules-users] Drools Guvnor: DSL with multiple fact fields
conditions using "-" and eval
To: "Rules Users List" <rules-users(a)lists.jboss.org>
Date: Friday, August 27, 2010, 2:58 AM
It seems that the initial hyphen merges the DSL definition's right hand
side into the parenthesis of the last preceding term, even if that one is an
eval, which itself is meant to go into some preceding pattern.
You could work around that by making all evals Conditional Elements rather
than Inline Eval Constraints. The disadvantage is that you'll have to use
full object qualification, e.g.,
[when]where name is empty=eval(StringUtils.isBlank( asset.getName() )
Patricia:
True. But, that is a test case, and does not affect the result of what I
was testing
I think that your variant
[when]-name empty=name=="''"
has to be written without the apostrophes:
[when]-name empty=name==""
-W
2010/8/27 Patricia Bogoevici
<patriciabogoevici@yahoo.com<http://mc/compose?to=patriciabogoevici@yahoo.com>
>
Thx for your answer.
I tried again the rule, removing the extra space after hyphen from DSL
expresion. No luck. So, I tried a few more cases, and the only one that
worked correctly was #3.
It seems to me that is somehow related to the parenthesis, although it
might be something else. Hope this info helps.
1) only eval:
DSL:
[when] There is an Asset=asset:Asset()
[when]-name is empty=eval(name=="''")
[when]-tag is empty=eval(tag=="''")
Rule source:
rule "test_rule"
dialect "mvel"
when
asset:Asset( eval(name=="''",
eval(tag=="''") ) )
then
end
2) no eval, but with the parenthesis:
DSL:
[when] There is an Asset=asset:Asset()
[when]-name is empty=(name=="''")
[when]-tag is empty=(tag=="''")
Rule source
rule "test_rule"
dialect "mvel"
when
asset:Asset( (name=="''", (tag=="''") )
)
then
end
3) simple case
DSL
[when] There is an Asset=asset:Asset()
[when]-name empty=name=="''"
[when]-tag empty=tag=="''"
Rule Source:
rule "test_rule"
dialect "mvel"
when
asset:Asset( name=="''", tag=="''" )
then
end
Thanks,
--- On *Thu, 8/26/10, Mauricio Salatino
<salaboy@gmail.com<http://mc/compose?to=salaboy@gmail.com>
>* wrote:
From: Mauricio Salatino
<salaboy@gmail.com<http://mc/compose?to=salaboy@gmail.com>
>
Subject: Re: [rules-users] Drools Guvnor: DSL with multiple fact fields
conditions using "-" and eval
To: "Rules Users List"
<rules-users@lists.jboss.org<http://mc/compose?to=rules-users@lists.jboss.org>
>
Date: Thursday, August 26, 2010, 10:43 PM
can you try with this:
[when] There is an Asset=asset:Asset()
[when] -name is empty=eval(StringUtils.isBlank(name))
[when] -tag is empty=eval(StringUtils.isBlank(tag))
2010/8/26 Patricia Bogoevici
<patriciabogoevici@yahoo.com<http://mc/compose?to=patriciabogoevici@yahoo.com>
>
Hi all,
I am using the latest Guvnor release (5.1), and I have the following DSL
expression where I use "-" to have conditions on multiple lines:
[when] There is an Asset=asset:Asset()
[when]- name is empty=eval(StringUtils.isBlank(name))
[when]- tag is empty=eval(StringUtils.isBlank(tag))
Having these DSL expressions, I wanted to create a rule, but I ran into
some issues.
To summarize: There seems to be a parsing error, when conditions are added
in DSL using "-". Did anybody else run into this problem? I wonder if I do
something wrong, but, re-creating the DSL to have the 2 conditions into one
expression, is all working fine. It may be a combination of "-" and eval?
Below, is the description of rules created, and error I got.
First, I created a rule using the above DSL expressions in the BRL editor.
While the rule looked ok in the editor, and it validated fine, only when I
checked the source I noticed is wrong. So, the rule source looks like this:
rule "test_dsl"
dialect "mvel"
when
asset:Asset( eval(StringUtils.isBlank(name,
eval(StringUtils.isBlank(tag)) )) )
then
asset.setStatus("INVALID")
end
It looks that the conditions are parsed incorrectly, and the second eval
condition is added as a parameter to the StringUtils.isBlank from the first
eval. Also, all the right parenthesis are added at the end of the
expression. If I add one condition at a time, it all works fine. The error
is when I have more than 1 condition.
So, I created a new DSL, that contains both conditions into one line,
eliminating the hyphen between conditions:
[when] There is an asset with name empty AND tag empty
=asset:Asset(eval(StringUtils.isBlank(name)),eval(StringUtils.isBlank(tag)))
Using BRL editor, I created a second rule using the DSL above. The rule
validated ok, and the rule source looks fine:
rule "test_dsl_1"
dialect "mvel"
when
asset:Asset(eval(StringUtils.isBlank(name)),eval(StringUtils.isBlank(tag)))
then
asset.setStatus("INVALID")
end
I created a test for this rule, that ran correctly.
Thanks,
Patricia
_______________________________________________
rules-users mailing list
rules-users@lists.jboss.org<http://mc/compose?to=rules-users@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/rules-users
--
- CTO @ http://www.plugtree.com
- MyJourney @ http://salaboy.wordpress.com
- Co-Founder @ http://www.jbug.com.ar
- Salatino "Salaboy" Mauricio -
-----Inline Attachment Follows-----
_______________________________________________
rules-users mailing list
rules-users@lists.jboss.org<http://mc/compose?to=rules-users@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/rules-users
_______________________________________________
rules-users mailing list
rules-users@lists.jboss.org<http://mc/compose?to=rules-users@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/rules-users
-----Inline Attachment Follows-----
_______________________________________________
rules-users mailing list
rules-users@lists.jboss.org<http://mc/compose?to=rules-users@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/rules-users
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
5255
days inactive
5256
days old
10 comments
4 participants
participants (4)
-
Mauricio Salatino -
mechlife -
Patricia Bogoevici -
Wolfgang Laun