7:57 p.m.
Seam devs,
Cody is looking for some feedback on the mail module [1] before he drafts a
reference guide and puts the API on ice.
Seam mail is important because, let's face it, the Java Mail API needs a
makeover. Thankfully, the CDI programming model offers the necessary hooks
to create a modernized mail API capable of deep integration with the Java EE
platform (specifically the Java Mail API and container-managed sessions).
Seam Mail offers a fluent API that makes sending e-mail in Java a painless
experience. But an e-mail is nothing without the content. That's why Seam
Mail offers several templating options, such as Velocity, as well as an
extensible template SPI, to allow you to select your templating solution of
choice. With Seam Mail, you'll be sending e-mail from your application in no
time.
Is this how you imagined it would be?
Basic:
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private Session session;
mailMessage.get()
.from("Seam Framework", "seam(a)jboss.org")
.to("John Smith", "john.smith(a)acme.com")
.subject("Text Message from Seam Mail - " +
java.util.UUID.randomUUID().toString())
.textBody(text)
.send(session);
Velocity:
@Inject
private Instance<VelocityMailMessage> velocityMailMessage;
@Inject
private Session session;
velocityMailMessage.get().from("Seam Framework", "seam(a)jboss.org")
.to(person.getName(), person.getEmail())
.subject("HTML Message from Seam Mail - " +
java.util.UUID.randomUUID().toString())
.templateHTMLFromClassPath("template.html.vm")
.put("version", "Seam 3")
.importance(MessagePriority.HIGH)
.addAttachment(new URL("
http://www.seamframework.org/themes/sfwkorg/img/seam_icon_large.png"),
"seamLogo.png", ContentDisposition.INLINE);
.send(session);
We look forward to your feedback.
-Dan
[1] http://github.com/seam/mail
http://seamframework.org/Seam3/Mail
--
Dan Allen
Principal Software Engineer, Red Hat | Author of Seam in Action
Registered Linux User #231597
http://www.google.com/profiles/dan.j.allen#about
http://mojavelinux.com
http://mojavelinux.com/seaminaction
8:32 p.m.
Cody,
This look EXCELLENT.
I have one question/potential suggestion so far regarding:
*.subjectHTMLFromClassPath("subject.html.vm") *
*.templateHTMLFromClassPath("template.html.vm") *
and related methods.
Have you considered creating an abstraction here that alows for pluggable
template resolvers? Otherwise you have this "explosion" of methods in the
interface that may end up causing maintenance woes. However, if you replaced
this with something like:
*.template(new HtmlFromClassPath("template.html.vm"))*
*.subject(new HtmlFromClassPath("subject.html.vm"))** *
People would be empowered to implement a simple interface with limitless
extension possibilities.
Thoughts?
~Lincoln
On Mon, Feb 7, 2011 at 1:57 PM, Dan Allen <dan.j.allen(a)gmail.com> wrote:
Seam devs,
Cody is looking for some feedback on the mail module [1] before he drafts a
reference guide and puts the API on ice.
Seam mail is important because, let's face it, the Java Mail API needs a
makeover. Thankfully, the CDI programming model offers the necessary hooks
to create a modernized mail API capable of deep integration with the Java EE
platform (specifically the Java Mail API and container-managed sessions).
Seam Mail offers a fluent API that makes sending e-mail in Java a painless
experience. But an e-mail is nothing without the content. That's why Seam
Mail offers several templating options, such as Velocity, as well as an
extensible template SPI, to allow you to select your templating solution of
choice. With Seam Mail, you'll be sending e-mail from your application in no
time.
Is this how you imagined it would be?
Basic:
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private Session session;
mailMessage.get()
.from("Seam Framework", "seam(a)jboss.org")
.to("John Smith", "john.smith(a)acme.com")
.subject("Text Message from Seam Mail - " +
java.util.UUID.randomUUID().toString())
.textBody(text)
.send(session);
Velocity:
@Inject
private Instance<VelocityMailMessage> velocityMailMessage;
@Inject
private Session session;
velocityMailMessage.get().from("Seam Framework",
"seam(a)jboss.org")
.to(person.getName(), person.getEmail())
.subject("HTML Message from Seam Mail - " +
java.util.UUID.randomUUID().toString())
.templateHTMLFromClassPath("template.html.vm")
.put("version", "Seam 3")
.importance(MessagePriority.HIGH)
.addAttachment(new URL("
http://www.seamframework.org/themes/sfwkorg/img/seam_icon_large.png"),
"seamLogo.png", ContentDisposition.INLINE);
.send(session);
We look forward to your feedback.
-Dan
[1] http://github.com/seam/mail
http://seamframework.org/Seam3/Mail
--
Dan Allen
Principal Software Engineer, Red Hat | Author of Seam in Action
Registered Linux User #231597
http://www.google.com/profiles/dan.j.allen#about
http://mojavelinux.com
http://mojavelinux.com/seaminaction
_______________________________________________
seam-dev mailing list
seam-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/seam-dev
--
Lincoln Baxter, III
http://ocpsoft.com
http://scrumshark.com
"Keep it Simple"
8:36 p.m.
Random comments:
- Is the from() method overloaded with a one arg version? We don't always have a
decent name to associate an email with.
- does it make sense to support varargs for to():
to("emmanuel(a)nothingtosee.org", "dan(a)test.com")
- Make sure this API can also easily be used by people working in batches: ie pass a
collection of to(Collection<String>) emails ie .bcc((setOfEmails);
- can the builder API be made contextual: ie if I start with a template() then bodyText()
is not available (probably not going to be easy)
- is there an overloaded method send() with no arg (does that make sense?)
- does it make sense to have a typesafe template parameter injection
message
.template(ThankYouTemplate.class)
.date( new Date() )
.amount( amountInEur )
.send()
Where ThankYouTemplate is something like
@Template(file="my.template.vm", type=HTML)
interface ThankYouTemplate extends EmailTemplate< ThankYouTemplate> {
ThankYouTemplate date(Date date);
ThankYouTemplate amount(BigDecimal amount);
}
This idea is an important departure from what has been done but might be worth
prototyping. We have done stuffs vaguely similar in Hibernate Validator for the
programmatic configuration API (constraints expose their parameters in a type-safe way.
http://docs.jboss.org/hibernate/validator/4.2/reference/en-US/html_single...
Emmanuel
On 7 févr. 2011, at 19:57, Dan Allen wrote:
Seam devs,
Cody is looking for some feedback on the mail module [1] before he drafts a reference
guide and puts the API on ice.
Seam mail is important because, let's face it, the Java Mail API needs a makeover.
Thankfully, the CDI programming model offers the necessary hooks to create a modernized
mail API capable of deep integration with the Java EE platform (specifically the Java Mail
API and container-managed sessions).
Seam Mail offers a fluent API that makes sending e-mail in Java a painless experience.
But an e-mail is nothing without the content. That's why Seam Mail offers several
templating options, such as Velocity, as well as an extensible template SPI, to allow you
to select your templating solution of choice. With Seam Mail, you'll be sending e-mail
from your application in no time.
Is this how you imagined it would be?
Basic:
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private Session session;
mailMessage.get()
.from("Seam Framework", "seam(a)jboss.org")
.to("John Smith", "john.smith(a)acme.com")
.subject("Text Message from Seam Mail - " +
java.util.UUID.randomUUID().toString())
.textBody(text)
.send(session);
Velocity:
@Inject
private Instance<VelocityMailMessage> velocityMailMessage;
@Inject
private Session session;
velocityMailMessage.get().from("Seam Framework",
"seam(a)jboss.org")
.to(person.getName(), person.getEmail())
.subject("HTML Message from Seam Mail - " +
java.util.UUID.randomUUID().toString())
.templateHTMLFromClassPath("template.html.vm")
.put("version", "Seam 3")
.importance(MessagePriority.HIGH)
.addAttachment(new
URL("http://www.seamframework.org/themes/sfwkorg/img/seam_icon_large...,
"seamLogo.png", ContentDisposition.INLINE);
.send(session);
We look forward to your feedback.
-Dan
[1] http://github.com/seam/mail
http://seamframework.org/Seam3/Mail
--
Dan Allen
Principal Software Engineer, Red Hat | Author of Seam in Action
Registered Linux User #231597
http://www.google.com/profiles/dan.j.allen#about
http://mojavelinux.com
http://mojavelinux.com/seaminaction
_______________________________________________
seam-dev mailing list
seam-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/seam-dev
![URL("http://www.seamframework.org/themes/sfwkorg/img/seam_icon_large...](http://URL("http://www.seamframework.org/themes/sfwkorg/img/seam_icon_large.png%22)){kind=link}
8:41 p.m.
Also,
https://github.com/seam/mail/blob/master/api-base/src/main/java/org/jboss...
Should EmailAttachment perhaps be an interface? Encouraging again the idea
that email attachments can come from anywhere as long as the data can be
properly read and streamed into the Message itself? (Considered using
InputStreams instead of byte[] arrays?)
~Lincoln
On Mon, Feb 7, 2011 at 2:36 PM, Emmanuel Bernard <emmanuel(a)hibernate.org>wrote:
Random comments:
- Is the from() method overloaded with a one arg version? We don't always
have a decent name to associate an email with.
- does it make sense to support varargs for to(): to("
emmanuel(a)nothingtosee.org", "dan(a)test.com")
- Make sure this API can also easily be used by people working in batches:
ie pass a collection of to(Collection<String>) emails ie
.bcc((setOfEmails);
- can the builder API be made contextual: ie if I start with a template()
then bodyText() is not available (probably not going to be easy)
- is there an overloaded method send() with no arg (does that make sense?)
- does it make sense to have a typesafe template parameter injection
message
.template(ThankYouTemplate.class)
.date( new Date() )
.amount( amountInEur )
.send()
Where ThankYouTemplate is something like
@Template(file="my.template.vm", type=HTML)
interface ThankYouTemplate extends EmailTemplate< ThankYouTemplate> {
ThankYouTemplate date(Date date);
ThankYouTemplate amount(BigDecimal amount);
}
This idea is an important departure from what has been done but might be
worth prototyping. We have done stuffs vaguely similar in Hibernate
Validator for the programmatic configuration API (constraints expose their
parameters in a type-safe way.
http://docs.jboss.org/hibernate/validator/4.2/reference/en-US/html_single...
Emmanuel
On 7 févr. 2011, at 19:57, Dan Allen wrote:
Seam devs,
Cody is looking for some feedback on the mail module [1] before he drafts a
reference guide and puts the API on ice.
Seam mail is important because, let's face it, the Java Mail API needs a
makeover. Thankfully, the CDI programming model offers the necessary hooks
to create a modernized mail API capable of deep integration with the Java EE
platform (specifically the Java Mail API and container-managed sessions).
Seam Mail offers a fluent API that makes sending e-mail in Java a painless
experience. But an e-mail is nothing without the content. That's why Seam
Mail offers several templating options, such as Velocity, as well as an
extensible template SPI, to allow you to select your templating solution of
choice. With Seam Mail, you'll be sending e-mail from your application in no
time.
Is this how you imagined it would be?
Basic:
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private Session session;
mailMessage.get()
.from("Seam Framework", "seam(a)jboss.org")
.to("John Smith", "john.smith(a)acme.com")
.subject("Text Message from Seam Mail - " +
java.util.UUID.randomUUID().toString())
.textBody(text)
.send(session);
Velocity:
@Inject
private Instance<VelocityMailMessage> velocityMailMessage;
@Inject
private Session session;
velocityMailMessage.get().from("Seam Framework",
"seam(a)jboss.org")
.to(person.getName(), person.getEmail())
.subject("HTML Message from Seam Mail - " +
java.util.UUID.randomUUID().toString())
.templateHTMLFromClassPath("template.html.vm")
.put("version", "Seam 3")
.importance(MessagePriority.HIGH)
.addAttachment(new URL("
http://www.seamframework.org/themes/sfwkorg/img/seam_icon_large.png"),
"seamLogo.png", ContentDisposition.INLINE);
.send(session);
We look forward to your feedback.
-Dan
[1] http://github.com/seam/mail
http://seamframework.org/Seam3/Mail
--
Dan Allen
Principal Software Engineer, Red Hat | Author of Seam in Action
Registered Linux User #231597
http://www.google.com/profiles/dan.j.allen#about
http://mojavelinux.com
http://mojavelinux.com/seaminaction
_______________________________________________
seam-dev mailing list
seam-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/seam-dev
_______________________________________________
seam-dev mailing list
seam-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/seam-dev
--
Lincoln Baxter, III
http://ocpsoft.com
http://scrumshark.com
"Keep it Simple"
8:56 p.m.
New subject: RES: Is this the mail API you always wanted?
It Looks really nice!
If I may suggest something, maybe we can add the possibility to use just
.send() ( keeping the send(session) method ).
If theres no specific session argument, the module could handle the
injection within itself.
Best regards,
José Rodolfo Carrijo de Freitas
Analista de Sistemas
Softplan - Departamento de pesquisa e desenvolvimento
Sistema da Qualidade Certificado ISO 9001:2008
(48) 3027 8000 Ramal 8359
<http://www.softplan.com.br> http://www.softplan.com.br
De: seam-dev-bounces(a)lists.jboss.org
[mailto:seam-dev-bounces@lists.jboss.org] Em nome de Lincoln Baxter, III
Enviada em: segunda-feira, 7 de fevereiro de 2011 17:33
Para: Dan Allen
Cc: Seam Mailing List
Assunto: Re: [seam-dev] Is this the mail API you always wanted?
Cody,
This look EXCELLENT.
I have one question/potential suggestion so far regarding:
.subjectHTMLFromClassPath("subject.html.vm")
.templateHTMLFromClassPath("template.html.vm")
and related methods.
Have you considered creating an abstraction here that alows for pluggable
template resolvers? Otherwise you have this "explosion" of methods in the
interface that may end up causing maintenance woes. However, if you replaced
this with something like:
.template(new HtmlFromClassPath("template.html.vm"))
.subject(new HtmlFromClassPath("subject.html.vm"))
People would be empowered to implement a simple interface with limitless
extension possibilities.
Thoughts?
~Lincoln
On Mon, Feb 7, 2011 at 1:57 PM, Dan Allen <dan.j.allen(a)gmail.com> wrote:
Seam devs,
Cody is looking for some feedback on the mail module [1] before he drafts a
reference guide and puts the API on ice.
Seam mail is important because, let's face it, the Java Mail API needs a
makeover. Thankfully, the CDI programming model offers the necessary hooks
to create a modernized mail API capable of deep integration with the Java EE
platform (specifically the Java Mail API and container-managed sessions).
Seam Mail offers a fluent API that makes sending e-mail in Java a painless
experience. But an e-mail is nothing without the content. That's why Seam
Mail offers several templating options, such as Velocity, as well as an
extensible template SPI, to allow you to select your templating solution of
choice. With Seam Mail, you'll be sending e-mail from your application in no
time.
Is this how you imagined it would be?
Basic:
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private Session session;
mailMessage.get()
.from("Seam Framework", "seam(a)jboss.org")
.to("John Smith", "john.smith(a)acme.com")
.subject("Text Message from Seam Mail - " +
java.util.UUID.randomUUID().toString())
.textBody(text)
.send(session);
Velocity:
@Inject
private Instance<VelocityMailMessage> velocityMailMessage;
@Inject
private Session session;
velocityMailMessage.get().from("Seam Framework", "seam(a)jboss.org")
.to(person.getName(), person.getEmail())
.subject("HTML Message from Seam Mail - " +
java.util.UUID.randomUUID().toString())
.templateHTMLFromClassPath("template.html.vm")
.put("version", "Seam 3")
.importance(MessagePriority.HIGH)
.addAttachment(new
URL("http://www.seamframework.org/themes/sfwkorg/img/seam_icon_large...,
"seamLogo.png", ContentDisposition.INLINE);
.send(session);
We look forward to your feedback.
-Dan
[1] http://github.com/seam/mail
http://seamframework.org/Seam3/Mail
--
Dan Allen
Principal Software Engineer, Red Hat | Author of Seam in Action
Registered Linux User #231597
http://www.google.com/profiles/dan.j.allen#about
http://mojavelinux.com
http://mojavelinux.com/seaminaction
_______________________________________________
seam-dev mailing list
seam-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/seam-dev
--
Lincoln Baxter, III
http://ocpsoft.com
http://scrumshark.com
"Keep it Simple"
8:59 p.m.
This may be a good idea for the recipients too. That way people could
implement an EmailContact interface on their existing User entity...
On Mon, Feb 7, 2011 at 12:41 PM, Lincoln Baxter, III
<lincolnbaxter(a)gmail.com> wrote:
Also,
https://github.com/seam/mail/blob/master/api-base/src/main/java/org/jboss...
Should EmailAttachment perhaps be an interface? Encouraging again the idea
that email attachments can come from anywhere as long as the data can be
properly read and streamed into the Message itself? (Considered using
InputStreams instead of byte[] arrays?)
~Lincoln
On Mon, Feb 7, 2011 at 2:36 PM, Emmanuel Bernard <emmanuel(a)hibernate.org>
wrote:
>
> Random comments:
> - Is the from() method overloaded with a one arg version? We don't always
> have a decent name to associate an email with.
> - does it make sense to support varargs for to():
> to("emmanuel(a)nothingtosee.org", "dan(a)test.com")
> - Make sure this API can also easily be used by people working in
> batches: ie pass a collection of to(Collection<String>) emails ie
> .bcc((setOfEmails);
> - can the builder API be made contextual: ie if I start with a template()
> then bodyText() is not available (probably not going to be easy)
> - is there an overloaded method send() with no arg (does that make
> sense?)
> - does it make sense to have a typesafe template parameter injection
> message
> .template(ThankYouTemplate.class)
> .date( new Date() )
> .amount( amountInEur )
> .send()
> Where ThankYouTemplate is something like
> @Template(file="my.template.vm", type=HTML)
> interface ThankYouTemplate extends EmailTemplate< ThankYouTemplate> {
> ThankYouTemplate date(Date date);
> ThankYouTemplate amount(BigDecimal amount);
> }
>
> This idea is an important departure from what has been done but might be
> worth prototyping. We have done stuffs vaguely similar in Hibernate
> Validator for the programmatic configuration API (constraints expose their
> parameters in a type-safe way.
>
>
http://docs.jboss.org/hibernate/validator/4.2/reference/en-US/html_single...
> Emmanuel
>
> On 7 févr. 2011, at 19:57, Dan Allen wrote:
>
> Seam devs,
> Cody is looking for some feedback on the mail module [1] before he drafts
> a reference guide and puts the API on ice.
> Seam mail is important because, let's face it, the Java Mail API needs a
> makeover. Thankfully, the CDI programming model offers the necessary hooks
> to create a modernized mail API capable of deep integration with the Java EE
> platform (specifically the Java Mail API and container-managed sessions).
> Seam Mail offers a fluent API that makes sending e-mail in Java a painless
> experience. But an e-mail is nothing without the content. That's why Seam
> Mail offers several templating options, such as Velocity, as well as an
> extensible template SPI, to allow you to select your templating solution of
> choice. With Seam Mail, you'll be sending e-mail from your application in no
> time.
> Is this how you imagined it would be?
> Basic:
>
> @Inject
> private Instance<MailMessage> mailMessage;
> @Inject
> private Session session;
> mailMessage.get()
> .from("Seam Framework", "seam(a)jboss.org")
> .to("John Smith", "john.smith(a)acme.com")
> .subject("Text Message from Seam Mail - " +
> java.util.UUID.randomUUID().toString())
> .textBody(text)
> .send(session);
> Velocity:
> @Inject
> private Instance<VelocityMailMessage> velocityMailMessage;
> @Inject
> private Session session;
> velocityMailMessage.get().from("Seam Framework",
"seam(a)jboss.org")
> .to(person.getName(), person.getEmail())
> .subject("HTML Message from Seam Mail - " +
> java.util.UUID.randomUUID().toString())
> .templateHTMLFromClassPath("template.html.vm")
> .put("version", "Seam 3")
> .importance(MessagePriority.HIGH)
> .addAttachment(new
>
URL("http://www.seamframework.org/themes/sfwkorg/img/seam_icon_large...,
> "seamLogo.png", ContentDisposition.INLINE);
> .send(session);
> We look forward to your feedback.
> -Dan
> [1] http://github.com/seam/mail
> http://seamframework.org/Seam3/Mail
>
> --
> Dan Allen
> Principal Software Engineer, Red Hat | Author of Seam in Action
> Registered Linux User #231597
>
> http://www.google.com/profiles/dan.j.allen#about
> http://mojavelinux.com
> http://mojavelinux.com/seaminaction
>
> _______________________________________________
> seam-dev mailing list
> seam-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/seam-dev
>
>
> _______________________________________________
> seam-dev mailing list
> seam-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/seam-dev
>
--
Lincoln Baxter, III
http://ocpsoft.com
http://scrumshark.com
"Keep it Simple"
_______________________________________________
seam-dev mailing list
seam-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/seam-dev
9:07 p.m.
On Mon, Feb 7, 2011 at 11:57 AM, Dan Allen <dan.j.allen(a)gmail.com> wrote:
Seam devs,
Cody is looking for some feedback on the mail module [1] before he drafts a
reference guide and puts the API on ice.
Seam mail is important because, let's face it, the Java Mail API needs a
makeover. Thankfully, the CDI programming model offers the necessary hooks
to create a modernized mail API capable of deep integration with the Java EE
platform (specifically the Java Mail API and container-managed sessions).
Seam Mail offers a fluent API that makes sending e-mail in Java a painless
experience. But an e-mail is nothing without the content. That's why Seam
Mail offers several templating options, such as Velocity, as well as an
extensible template SPI, to allow you to select your templating solution of
choice. With Seam Mail, you'll be sending e-mail from your application in no
time.
Is this how you imagined it would be?
Basic:
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private Session session;
mailMessage.get()
.from("Seam Framework", "seam(a)jboss.org")
.to("John Smith", "john.smith(a)acme.com")
.subject("Text Message from Seam Mail - " +
java.util.UUID.randomUUID().toString())
.textBody(text)
.send(session);
Velocity:
@Inject
private Instance<VelocityMailMessage> velocityMailMessage;
@Inject
private Session session;
velocityMailMessage.get().from("Seam Framework",
"seam(a)jboss.org")
.to(person.getName(), person.getEmail())
.subject("HTML Message from Seam Mail - " +
java.util.UUID.randomUUID().toString())
.templateHTMLFromClassPath("template.html.vm")
.put("version", "Seam 3")
.importance(MessagePriority.HIGH)
.addAttachment(new URL("
http://www.seamframework.org/themes/sfwkorg/img/seam_icon_large.png"),
"seamLogo.png", ContentDisposition.INLINE);
.send(session);
We look forward to your feedback.
-Dan
[1] http://github.com/seam/mail
http://seamframework.org/Seam3/Mail
--
Dan Allen
Principal Software Engineer, Red Hat | Author of Seam in Action
Registered Linux User #231597
http://www.google.com/profiles/dan.j.allen#about
http://mojavelinux.com
http://mojavelinux.com/seaminaction
_______________________________________________
seam-dev mailing list
seam-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/seam-dev
Thanks, Cody.
I am user and abuser, not a contributor. But this has been a pain point for
me on 2.2.0.GA <http://2.2.0.ga/> I like this. I do have some constructive
criticisms.
1. javax.mail.Session is final and cannot be mocked. An official wrapper
would be awesome! So if I try to mock this, this would happen
@Test
public void testBasicEmail() {
Instance ins = createMock(Instance.class)
MailMessage message = createMock(Message.class)
expect(ins.get()).andReturn(
mailMessage)
Session session = createMock(Session.class); //RuntimeException ,
Session is final, and static (grrr)
}
2. The Builder pattern you have and sending should be two different things.
The reason is that as a Seam power user, I really want to mock out the
session and the message, and although it looks like you can do with this
here, it seems that I would have a hard time still. Furthermore I likely
won't use the builder like you have planned here.
I likely would use your library like this: The mailMessage being injected
would come from an outside factory that uses your builder or a mock. That
MailMessage I assume will be an interface, that way it wouldn't matter if
the source is from Velocity, JSF transformation, XSLT transformation, JSON
Transformation or some other fun stuff. ;)
@Inject @NewAccountMessage
private Instance<MailMessage> mailMessage;
@Inject
private MailSession mailSession; //MailSession is an adapter, be nice it
be an interface. This would be wrap the poorly engineered
javax.mail.Session class.
public void doIt() {
//doSomeOtherStuff
mailSession.send(mailMessage)
}
My 2c. Thanks Cody! ;)
9:11 p.m.
1. Yes the address related methods take (name, address) or just (address)
2. I can add a varargs to,from,cc,bcc. these will only be really
useful when they don't have name to go along with the address.
Otherwise you can use the collection functionality.
3. All the address fields take Collection<InternetAddress> ... though
we may want to make that an interface so people can use their existing
User entity objects easier.
4. I do like the idea of type safe template. I'll dig into that shortly.
On Mon, Feb 7, 2011 at 12:36 PM, Emmanuel Bernard
<emmanuel(a)hibernate.org> wrote:
Random comments:
- Is the from() method overloaded with a one arg version? We don't always
have a decent name to associate an email with.
- does it make sense to support varargs for to():
to("emmanuel(a)nothingtosee.org", "dan(a)test.com")
- Make sure this API can also easily be used by people working in batches:
ie pass a collection of to(Collection<String>) emails ie
.bcc((setOfEmails);
- can the builder API be made contextual: ie if I start with a template()
then bodyText() is not available (probably not going to be easy)
- is there an overloaded method send() with no arg (does that make sense?)
- does it make sense to have a typesafe template parameter injection
message
.template(ThankYouTemplate.class)
.date( new Date() )
.amount( amountInEur )
.send()
Where ThankYouTemplate is something like
@Template(file="my.template.vm", type=HTML)
interface ThankYouTemplate extends EmailTemplate< ThankYouTemplate> {
ThankYouTemplate date(Date date);
ThankYouTemplate amount(BigDecimal amount);
}
This idea is an important departure from what has been done but might be
worth prototyping. We have done stuffs vaguely similar in Hibernate
Validator for the programmatic configuration API (constraints expose their
parameters in a type-safe way.
http://docs.jboss.org/hibernate/validator/4.2/reference/en-US/html_single...
Emmanuel
On 7 févr. 2011, at 19:57, Dan Allen wrote:
Seam devs,
Cody is looking for some feedback on the mail module [1] before he drafts a
reference guide and puts the API on ice.
Seam mail is important because, let's face it, the Java Mail API needs a
makeover. Thankfully, the CDI programming model offers the necessary hooks
to create a modernized mail API capable of deep integration with the Java EE
platform (specifically the Java Mail API and container-managed sessions).
Seam Mail offers a fluent API that makes sending e-mail in Java a painless
experience. But an e-mail is nothing without the content. That's why Seam
Mail offers several templating options, such as Velocity, as well as an
extensible template SPI, to allow you to select your templating solution of
choice. With Seam Mail, you'll be sending e-mail from your application in no
time.
Is this how you imagined it would be?
Basic:
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private Session session;
mailMessage.get()
.from("Seam Framework", "seam(a)jboss.org")
.to("John Smith", "john.smith(a)acme.com")
.subject("Text Message from Seam Mail - " +
java.util.UUID.randomUUID().toString())
.textBody(text)
.send(session);
Velocity:
@Inject
private Instance<VelocityMailMessage> velocityMailMessage;
@Inject
private Session session;
velocityMailMessage.get().from("Seam Framework",
"seam(a)jboss.org")
.to(person.getName(), person.getEmail())
.subject("HTML Message from Seam Mail - " +
java.util.UUID.randomUUID().toString())
.templateHTMLFromClassPath("template.html.vm")
.put("version", "Seam 3")
.importance(MessagePriority.HIGH)
.addAttachment(new
URL("http://www.seamframework.org/themes/sfwkorg/img/seam_icon_large...,
"seamLogo.png", ContentDisposition.INLINE);
.send(session);
We look forward to your feedback.
-Dan
[1] http://github.com/seam/mail
http://seamframework.org/Seam3/Mail
--
Dan Allen
Principal Software Engineer, Red Hat | Author of Seam in Action
Registered Linux User #231597
http://www.google.com/profiles/dan.j.allen#about
http://mojavelinux.com
http://mojavelinux.com/seaminaction
_______________________________________________
seam-dev mailing list
seam-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/seam-dev
_______________________________________________
seam-dev mailing list
seam-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/seam-dev
9:11 p.m.
I like it.
I'll start down that path.
On Mon, Feb 7, 2011 at 12:32 PM, Lincoln Baxter, III
<lincolnbaxter(a)gmail.com> wrote:
Cody,
This look EXCELLENT.
I have one question/potential suggestion so far regarding:
.subjectHTMLFromClassPath("subject.html.vm")
.templateHTMLFromClassPath("template.html.vm")
and related methods.
Have you considered creating an abstraction here that alows for pluggable
template resolvers? Otherwise you have this "explosion" of methods in the
interface that may end up causing maintenance woes. However, if you replaced
this with something like:
.template(new HtmlFromClassPath("template.html.vm"))
.subject(new HtmlFromClassPath("subject.html.vm"))
People would be empowered to implement a simple interface with limitless
extension possibilities.
Thoughts?
~Lincoln
On Mon, Feb 7, 2011 at 1:57 PM, Dan Allen <dan.j.allen(a)gmail.com> wrote:
>
> Seam devs,
> Cody is looking for some feedback on the mail module [1] before he drafts
> a reference guide and puts the API on ice.
> Seam mail is important because, let's face it, the Java Mail API needs a
> makeover. Thankfully, the CDI programming model offers the necessary hooks
> to create a modernized mail API capable of deep integration with the Java EE
> platform (specifically the Java Mail API and container-managed sessions).
> Seam Mail offers a fluent API that makes sending e-mail in Java a painless
> experience. But an e-mail is nothing without the content. That's why Seam
> Mail offers several templating options, such as Velocity, as well as an
> extensible template SPI, to allow you to select your templating solution of
> choice. With Seam Mail, you'll be sending e-mail from your application in no
> time.
> Is this how you imagined it would be?
> Basic:
>
> @Inject
> private Instance<MailMessage> mailMessage;
> @Inject
> private Session session;
> mailMessage.get()
> .from("Seam Framework", "seam(a)jboss.org")
> .to("John Smith", "john.smith(a)acme.com")
> .subject("Text Message from Seam Mail - " +
> java.util.UUID.randomUUID().toString())
> .textBody(text)
> .send(session);
> Velocity:
> @Inject
> private Instance<VelocityMailMessage> velocityMailMessage;
> @Inject
> private Session session;
> velocityMailMessage.get().from("Seam Framework",
"seam(a)jboss.org")
> .to(person.getName(), person.getEmail())
> .subject("HTML Message from Seam Mail - " +
> java.util.UUID.randomUUID().toString())
> .templateHTMLFromClassPath("template.html.vm")
> .put("version", "Seam 3")
> .importance(MessagePriority.HIGH)
> .addAttachment(new
>
URL("http://www.seamframework.org/themes/sfwkorg/img/seam_icon_large...,
> "seamLogo.png", ContentDisposition.INLINE);
> .send(session);
> We look forward to your feedback.
> -Dan
> [1] http://github.com/seam/mail
> http://seamframework.org/Seam3/Mail
>
> --
> Dan Allen
> Principal Software Engineer, Red Hat | Author of Seam in Action
> Registered Linux User #231597
>
> http://www.google.com/profiles/dan.j.allen#about
> http://mojavelinux.com
> http://mojavelinux.com/seaminaction
>
>
> _______________________________________________
> seam-dev mailing list
> seam-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/seam-dev
>
--
Lincoln Baxter, III
http://ocpsoft.com
http://scrumshark.com
"Keep it Simple"
_______________________________________________
seam-dev mailing list
seam-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/seam-dev
9:16 p.m.
I'll add that at one point we were experimenting with using a type-parameter
to specify the template engine:
@Inject
private Instance<TemplateMailMessage> message;
message.select(new VelocityLiteral()).get().from(...).to(...).send();
or
@Inject @Velocity
private Instance<TemplateMailMessage> message;
message.get().from(...).to(...).send();
This is an effort to make the template engine a qualifier rather than a
secondary interface. [1]
refer to this revision tree to find the earlier prototype:
https://github.com/seam/mail/tree/fcf45f808391489cb23c848f11f052e22d70c5d3
discussion: http://echelog.matzon.dk/logs/browse/seam-dev/1280959200 (starts
at 16:28:05)
-Dan
[1]
https://github.com/seam/mail/blob/fcf45f808391489cb23c848f11f052e22d70c5d...
On Mon, Feb 7, 2011 at 13:57, Dan Allen <dan.j.allen(a)gmail.com> wrote:
Seam devs,
Cody is looking for some feedback on the mail module [1] before he drafts a
reference guide and puts the API on ice.
Seam mail is important because, let's face it, the Java Mail API needs a
makeover. Thankfully, the CDI programming model offers the necessary hooks
to create a modernized mail API capable of deep integration with the Java EE
platform (specifically the Java Mail API and container-managed sessions).
Seam Mail offers a fluent API that makes sending e-mail in Java a painless
experience. But an e-mail is nothing without the content. That's why Seam
Mail offers several templating options, such as Velocity, as well as an
extensible template SPI, to allow you to select your templating solution of
choice. With Seam Mail, you'll be sending e-mail from your application in no
time.
Is this how you imagined it would be?
Basic:
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private Session session;
mailMessage.get()
.from("Seam Framework", "seam(a)jboss.org")
.to("John Smith", "john.smith(a)acme.com")
.subject("Text Message from Seam Mail - " +
java.util.UUID.randomUUID().toString())
.textBody(text)
.send(session);
Velocity:
@Inject
private Instance<VelocityMailMessage> velocityMailMessage;
@Inject
private Session session;
velocityMailMessage.get().from("Seam Framework",
"seam(a)jboss.org")
.to(person.getName(), person.getEmail())
.subject("HTML Message from Seam Mail - " +
java.util.UUID.randomUUID().toString())
.templateHTMLFromClassPath("template.html.vm")
.put("version", "Seam 3")
.importance(MessagePriority.HIGH)
.addAttachment(new URL("
http://www.seamframework.org/themes/sfwkorg/img/seam_icon_large.png"),
"seamLogo.png", ContentDisposition.INLINE);
.send(session);
We look forward to your feedback.
-Dan
[1] http://github.com/seam/mail
http://seamframework.org/Seam3/Mail
--
Dan Allen
Principal Software Engineer, Red Hat | Author of Seam in Action
Registered Linux User #231597
http://www.google.com/profiles/dan.j.allen#about
http://mojavelinux.com
http://mojavelinux.com/seaminaction
--
Dan Allen
Principal Software Engineer, Red Hat | Author of Seam in Action
Registered Linux User #231597
http://www.google.com/profiles/dan.j.allen#about
http://mojavelinux.com
http://mojavelinux.com/seaminaction
9:17 p.m.
On Mon, Feb 7, 2011 at 15:16, Dan Allen <dan.j.allen(a)gmail.com> wrote:
I'll add that at one point we were experimenting with using a
type-parameter to specify the template engine:
oops, meant to say qualifier
@Inject
private Instance<TemplateMailMessage> message;
message.select(new VelocityLiteral()).get().from(...).to(...).send();
or
@Inject @Velocity
private Instance<TemplateMailMessage> message;
message.get().from(...).to(...).send();
This is an effort to make the template engine a qualifier rather than a
secondary interface. [1]
refer to this revision tree to find the earlier prototype:
https://github.com/seam/mail/tree/fcf45f808391489cb23c848f11f052e22d70c5d3
discussion: http://echelog.matzon.dk/logs/browse/seam-dev/1280959200(starts at 16:28:05)
-Dan
[1]
https://github.com/seam/mail/blob/fcf45f808391489cb23c848f11f052e22d70c5d...
On Mon, Feb 7, 2011 at 13:57, Dan Allen <dan.j.allen(a)gmail.com> wrote:
> Seam devs,
>
> Cody is looking for some feedback on the mail module [1] before he drafts
> a reference guide and puts the API on ice.
>
> Seam mail is important because, let's face it, the Java Mail API needs a
> makeover. Thankfully, the CDI programming model offers the necessary hooks
> to create a modernized mail API capable of deep integration with the Java EE
> platform (specifically the Java Mail API and container-managed sessions).
>
> Seam Mail offers a fluent API that makes sending e-mail in Java a painless
> experience. But an e-mail is nothing without the content. That's why Seam
> Mail offers several templating options, such as Velocity, as well as an
> extensible template SPI, to allow you to select your templating solution of
> choice. With Seam Mail, you'll be sending e-mail from your application in no
> time.
>
> Is this how you imagined it would be?
>
> Basic:
>
> @Inject
> private Instance<MailMessage> mailMessage;
>
> @Inject
> private Session session;
>
> mailMessage.get()
> .from("Seam Framework", "seam(a)jboss.org")
> .to("John Smith", "john.smith(a)acme.com")
> .subject("Text Message from Seam Mail - " +
> java.util.UUID.randomUUID().toString())
> .textBody(text)
> .send(session);
>
> Velocity:
>
> @Inject
> private Instance<VelocityMailMessage> velocityMailMessage;
>
> @Inject
> private Session session;
>
> velocityMailMessage.get().from("Seam Framework",
"seam(a)jboss.org")
> .to(person.getName(), person.getEmail())
> .subject("HTML Message from Seam Mail - " +
> java.util.UUID.randomUUID().toString())
> .templateHTMLFromClassPath("template.html.vm")
> .put("version", "Seam 3")
> .importance(MessagePriority.HIGH)
> .addAttachment(new URL("
> http://www.seamframework.org/themes/sfwkorg/img/seam_icon_large.png"),
> "seamLogo.png", ContentDisposition.INLINE);
> .send(session);
>
> We look forward to your feedback.
>
> -Dan
>
> [1] http://github.com/seam/mail
> http://seamframework.org/Seam3/Mail
>
> --
> Dan Allen
> Principal Software Engineer, Red Hat | Author of Seam in Action
> Registered Linux User #231597
>
> http://www.google.com/profiles/dan.j.allen#about
> http://mojavelinux.com
> http://mojavelinux.com/seaminaction
>
>
--
Dan Allen
Principal Software Engineer, Red Hat | Author of Seam in Action
Registered Linux User #231597
http://www.google.com/profiles/dan.j.allen#about
http://mojavelinux.com
http://mojavelinux.com/seaminaction
--
Dan Allen
Principal Software Engineer, Red Hat | Author of Seam in Action
Registered Linux User #231597
http://www.google.com/profiles/dan.j.allen#about
http://mojavelinux.com
http://mojavelinux.com/seaminaction
9:20 p.m.
On Mon, Feb 7, 2011 at 15:11, Cody Lerum <cody.lerum(a)gmail.com> wrote:
4. I do like the idea of type safe template. I'll dig into that shortly.
+1. Another area we can bring fresh ideas to the table. Thanks Emmanuel!
-Dan
--
Dan Allen
Principal Software Engineer, Red Hat | Author of Seam in Action
Registered Linux User #231597
http://www.google.com/profiles/dan.j.allen#about
http://mojavelinux.com
http://mojavelinux.com/seaminaction
9:39 p.m.
On Mon, Feb 7, 2011 at 14:36, Emmanuel Bernard <emmanuel(a)hibernate.org>wrote:
Random comments:
- Is the from() method overloaded with a one arg version? We don't always
have a decent name to associate an email with.
Along these lines, ALR points out:
I'd put the email address argument first in "from" and "to"
methods. The
Alias is optional and could be dropped in an overloaded form.
This follows one of ALR's (perhaps adopted) design rules: avoid changing
argument positions. For instance, an argument which is first should be first
in all cases (unless arguments are shifted right). If we dropped down to a
one-arg version of from(), then e-mail would shift from the second to the
first argument. Thus, reversing the order is more consistent.
...in this case, it might be irrelevant if we instead have these signatures:
from(String... address);
from(InternetAddress... address);
from(Collection<String> addresses);
from(Collection<InternetAddress> addresses);
We just don't support the two-argument form.
Btw, InternetAddress can parse an address with a personal part:
from("John Smith <john.smith(a)acme.com>")
-Dan
--
Dan Allen
Principal Software Engineer, Red Hat | Author of Seam in Action
Registered Linux User #231597
http://www.google.com/profiles/dan.j.allen#about
http://mojavelinux.com
http://mojavelinux.com/seaminaction
9:46 p.m.
ALR also asks:
1) Why "get()"?
We know that the reason is because we need a new contextual instance of the
stateful part of the MailMessage object graph. However, I agree that we may
want to figure out a way to hide this a bit more. It might just be a matter
of having another layer of indirection.
-Dan
On Mon, Feb 7, 2011 at 13:57, Dan Allen <dan.j.allen(a)gmail.com> wrote:
Seam devs,
Cody is looking for some feedback on the mail module [1] before he drafts a
reference guide and puts the API on ice.
Seam mail is important because, let's face it, the Java Mail API needs a
makeover. Thankfully, the CDI programming model offers the necessary hooks
to create a modernized mail API capable of deep integration with the Java EE
platform (specifically the Java Mail API and container-managed sessions).
Seam Mail offers a fluent API that makes sending e-mail in Java a painless
experience. But an e-mail is nothing without the content. That's why Seam
Mail offers several templating options, such as Velocity, as well as an
extensible template SPI, to allow you to select your templating solution of
choice. With Seam Mail, you'll be sending e-mail from your application in no
time.
Is this how you imagined it would be?
Basic:
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private Session session;
mailMessage.get()
.from("Seam Framework", "seam(a)jboss.org")
.to("John Smith", "john.smith(a)acme.com")
.subject("Text Message from Seam Mail - " +
java.util.UUID.randomUUID().toString())
.textBody(text)
.send(session);
Velocity:
@Inject
private Instance<VelocityMailMessage> velocityMailMessage;
@Inject
private Session session;
velocityMailMessage.get().from("Seam Framework",
"seam(a)jboss.org")
.to(person.getName(), person.getEmail())
.subject("HTML Message from Seam Mail - " +
java.util.UUID.randomUUID().toString())
.templateHTMLFromClassPath("template.html.vm")
.put("version", "Seam 3")
.importance(MessagePriority.HIGH)
.addAttachment(new URL("
http://www.seamframework.org/themes/sfwkorg/img/seam_icon_large.png"),
"seamLogo.png", ContentDisposition.INLINE);
.send(session);
We look forward to your feedback.
-Dan
[1] http://github.com/seam/mail
http://seamframework.org/Seam3/Mail
--
Dan Allen
Principal Software Engineer, Red Hat | Author of Seam in Action
Registered Linux User #231597
http://www.google.com/profiles/dan.j.allen#about
http://mojavelinux.com
http://mojavelinux.com/seaminaction
--
Dan Allen
Principal Software Engineer, Red Hat | Author of Seam in Action
Registered Linux User #231597
http://www.google.com/profiles/dan.j.allen#about
http://mojavelinux.com
http://mojavelinux.com/seaminaction
4836
days inactive
4836
days old
13 comments
6 participants
participants (6)
-
Cody Lerum -
Dan Allen -
Daniel Hinojosa -
Emmanuel Bernard -
José Rodolfo Carrijo de Freitas -
Lincoln Baxter, III