Re: [aerogear-dev] Best practice to contribute to Pull Requests ?

Hi, I was wondering what was the common/best practice when you want to contribute (with commits) to an existing PR (assuming you have no commit rights on the branch where the PR comes from) : - Commits on the PR is only the responsability of the one who created it, he has to report the fixes. - The "fixer" forks the PR branch, fix it, close the old PR and resubmit a new PR - The "fixer" forks the PR branch, fix it and submit a PR to the branch from the original PR (this way after the merge, the existing PR will be updated) - For big PRs where other team members are likely to submits commits make sure to submit a PR from the aerogear repo ? (but this just counts for team members) Thx for you input ! Seb _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev