I'm +1 on locking version as well. The very same issue is causing us
pain in Jenkins CI.
Wrt to not having any tests on admin-ui - QE needs to rewrite original
Ember.js UI tests to Angular.js tests. These test will be located
(instead of separate admin-ui repository) in
aerogear-unifiedpush-server-integration-tests and we plan to execute
them in travis as well, together with integration tests. We'll need to
build Admin UI there for sure.
Karel
On Wed, Jul 16, 2014 at 5:32 PM, Bruno Oliveira <bruno(a)abstractj.org>
wrote:
Thanks for the fix Sebi, it took me 1 day trying to figure this out.
IMO
would be nice to take some action on this, otherwise the build is
fixed
until the next bower update.
1. Lock the versions like Matthias suggested
2. Or, do not break the build only because the admin-ui can't be
installed.
The option 1 would be nice, but I can't understand why we need to
build
the admin-ui on CI if we don't have any tests on it, is pretty much
npm
install + bower install and grunt tasks copying files.
Thoughts?
On 2014-07-15, Sebastien Blanc wrote:
> Ok,
> Some extra info :
> As suggested I tried to update Bower to 1.3.8 :
> -
>
>
https://github.com/aerogear/aerogear-unifiedpush-server/commit/87dadc04ab...
> But that did not helped , maybe the maven frontend pugin overides
> the Bower
> version, looking at this now
>
> BUT, on twitter someone suggested this :
>
https://twitter.com/chrisfrancis27/status/488701380207448064
>
> Basically adding a "temp" dependencies to package.json , o_0 =>
> indeed but
> it WORKS :
>
>
>
https://travis-ci.org/aerogear/aerogear-unifiedpush-server/builds/29953927
> !
>
> So good news , with this "temp" dep we can build again and in the
> same time
> let's find out how we can update bower
>
>
> On Tue, Jul 15, 2014 at 9:21 AM, Matthias Wessendorf
> <matzew(a)apache.org>
> wrote:
>
> >
> >
> > On Tuesday, July 15, 2014, tolis emmanouilidis
> <tolisemm(a)gmail.com> wrote:
> >
> >> +1 Sebi
> >>
> >> The builds started failing 3 days ago. 3 days ago bower (
> >>
https://www.npmjs.org/package/bower) was updated to v1.3.8.
> >>
> >> The last successful Travis UPS build logs contains bower(a)1.3.7
> >> node_modules/bower.
> >> The rest failed successful Travis UPS build logs contain
> bower(a)1.3.8
> >> node_modules/bower
> >>
> >> Maybe enforcing bower version 1.3.7 will resolve the issue.
> >>
> >
> >
> > +9001
> > We should lock all versions :-)
> >
> >
> >>
> >>
> >> 2014-07-15 9:50 GMT+03:00 Sebastien Blanc <scm.blanc(a)gmail.com>:
> >>
> >>> Looks like Bower is aware of this issue :
> >>>
https://twitter.com/bower/status/487704111832252417
> >>> Let me check if I can do something
> >>>
> >>>
> >>>
> >>> On Tue, Jul 15, 2014 at 8:34 AM, Christos Vasilakis
> <cvasilak(a)gmail.com>
> >>> wrote:
> >>>
> >>>> Hi,
> >>>>
> >>>> the same failure output "[INFO] Fatal error: Arguments to
> path.join
> >>>> must be strings" have been noticed also when building liveoak
> >>>> 'master'. I suspect some change on the nodes tools broke
> builds.. :(
> >>>>
> >>>>
> >>>> [1]
https://projectodd.ci.cloudbees.com/job/liveoak/371/console
> >>>>
> >>>>
> >>>>
> >>>> On Tue, Jul 15, 2014 at 9:07 AM, Matthias Wessendorf
> <matzew(a)apache.org
> >>>> > wrote:
> >>>>
> >>>>> Hi,
> >>>>>
> >>>>> since Friday, all in a sudden, the node.js part of the build
> >>>>> (triggered by the frontend plugin inside the 'server'
module)
> is failing on
> >>>>> different ways.
> >>>>>
> >>>>> Extremely odd: the 0.11.0 tag is effected as well. The
> release (on
> >>>>> maven central) is good, but ATM we are not able to build the
> source on the
> >>>>> 0.11.0 tag :-(
> >>>>>
> >>>>> Oh, yeah, Travis-CI notice the broken build as well ;-) and
> thankfully
> >>>>> abstractj put in a PR to have a temporary fix for the build
> failure:
> >>>>>
>
https://github.com/aerogear/aerogear-unifiedpush-server/pull/293
> >>>>>
> >>>>> Thanks Bruno!
> >>>>>
> >>>>> Yesterday Bruno, Villiam and Luke looked at this already, and
> they
> >>>>> noticed a failure like this:
> >>>>>
> >>>>> [INFO] --- frontend-maven-plugin:0.0.15:npm (npm install) @
> unifiedpush-server ---
> >>>>> [INFO] Running 'npm install --color=false' in
> /home/travis/build/aerogear/aerogear-unifiedpush-server/admin-ui
> >>>>> [INFO] npm WARN package.json newadmin(a)0.0.0 No repository
> field.
> >>>>> [INFO]
> >>>>> [INFO] --- frontend-maven-plugin:0.0.15:grunt (grunt build) @
> unifiedpush-server ---
> >>>>> [INFO] Running 'grunt dist --no-color' in
> /home/travis/build/aerogear/aerogear-unifiedpush-server/admin-ui
> >>>>> [INFO] >> Local Npm module "grunt-cli" not
found. Is it
> installed?
> >>>>> [INFO]
> >>>>> [INFO] Running "bower:install" (bower) task
> >>>>> [INFO] Fatal error: Arguments to path.join must be strings
> >>>>> [INFO]
> ------------------------------------------------------------------------
> >>>>> [INFO] Reactor Summary:
> >>>>>
> >>>>> Note: "grunt-cli" *IS* installed, even globally. If I
am
> correct, at
> >>>>> the moment we are not 100% sure what the "Fatal error:
> Arguments to
> >>>>> path.join must be strings" really means...
> >>>>>
> >>>>> On my machine, I noticed the npm stuff downloads half of the
> internet,
> >>>>> but gets stuck in the middle:
> >>>>>
> >>>>> [INFO] npm http 304
https://registry.npmjs.org/oauth-sign
> >>>>> [INFO] npm http 304
https://registry.npmjs.org/aws-sign2
> >>>>> [INFO] npm http 304
https://registry.npmjs.org/hawk
> >>>>> [INFO] npm http GET
https://registry.npmjs.org/combined-stream
> >>>>> [INFO] npm http GET
https://registry.npmjs.org/async
> >>>>> [INFO] npm http GET
https://registry.npmjs.org/assert-plus
> >>>>> [INFO] npm http GET
https://registry.npmjs.org/asn1
> >>>>> [INFO] npm http GET
https://registry.npmjs.org/ctype
> >>>>> [INFO] npm http GET
https://registry.npmjs.org/punycode
> >>>>> [INFO] npm http GET
https://registry.npmjs.org/hoek
> >>>>> [INFO] npm http GET
https://registry.npmjs.org/boom
> >>>>> [INFO] npm http GET
https://registry.npmjs.org/sntp
> >>>>> [INFO] npm http GET
https://registry.npmjs.org/cryptiles
> >>>>> [INFO] npm http 304
https://registry.npmjs.org/async
> >>>>> [INFO] npm http 304
https://registry.npmjs.org/combined-stream
> >>>>> [INFO] npm http 304
https://registry.npmjs.org/assert-plus
> >>>>> [INFO] npm http 304
https://registry.npmjs.org/asn1
> >>>>> [INFO] npm http GET
https://registry.npmjs.org/delayed-stream
> >>>>> [INFO] npm http 304
https://registry.npmjs.org/ctype
> >>>>> [INFO] npm http 304
https://registry.npmjs.org/punycode
> >>>>> [INFO] npm http 304
https://registry.npmjs.org/boom
> >>>>> [INFO] npm http 304
https://registry.npmjs.org/hoek
> >>>>> [INFO] npm http 304
https://registry.npmjs.org/cryptiles
> >>>>> [INFO] npm http 304
https://registry.npmjs.org/sntp
> >>>>> [INFO] npm http 304
https://registry.npmjs.org/delayed-stream
> >>>>>
> >>>>> Now, after more than one hour of 'waiting', I cancled
the
> build,
> >>>>> resulting in:
> >>>>>
> >>>>> [INFO] > optipng-bin(a)0.3.9 postinstall
>
/Users/matzew/Work/JBoss/UPS/admin-ui/node_modules/grunt-contrib-imagemin/node_modules/imagemin/node_modules/imagemin-optipng/node_modules/optipng-bin
> >>>>> [INFO] > node index.js
> >>>>> [INFO]
> >>>>> [INFO] ✓ pre-build test passed successfully
> >>>>> [INFO] npm http 304
https://registry.npmjs.org/hoek
> >>>>> [INFO] npm http 304
https://registry.npmjs.org/boom
> >>>>> [INFO] npm http 304
https://registry.npmjs.org/cryptiles
> >>>>> [INFO] npm http 304
https://registry.npmjs.org/sntp
> >>>>> [INFO] npm http 304
https://registry.npmjs.org/delayed-stream
> >>>>> ^C[INFO]
> ------------------------------------------------------------------------
> >>>>> [INFO] Reactor Summary:
> >>>>> [INFO]
> >>>>> [INFO] AeroGear UnifiedPush Server .......................
> SUCCESS [3.884s]
> >>>>> [INFO] UnifiedPush Model Layer ...........................
> SUCCESS [0.146s]
> >>>>> [INFO] UnifiedPush Server Model API ......................
> SUCCESS [2.699s]
> >>>>> [INFO] UnifiedPush Server Model JPA implementation .......
> SUCCESS [15.036s]
> >>>>> [INFO] UnifiedPush Service Layer .........................
> SUCCESS [7.757s]
> >>>>> [INFO] UnifiedPush Push Notification Networks ............
> SUCCESS [2.009s]
> >>>>> [INFO] UnifiedPush RESTful Endpoint ......................
> SUCCESS [2.811s]
> >>>>> [INFO] UnifiedPush Server (WAR) ..........................
> FAILURE [1:30:54.769s]
> >>>>> [INFO] UnifiedPush Auth Server ...........................
> SKIPPED
> >>>>> [INFO]
> ------------------------------------------------------------------------
> >>>>> [INFO] BUILD FAILURE
> >>>>> [INFO]
> ------------------------------------------------------------------------
> >>>>> [INFO] Total time: 1:31:29.994s
> >>>>> [INFO] Finished at: Tue Jul 15 07:48:37 CEST 2014
> >>>>> [INFO] Final Memory: 80M/191M
> >>>>> [INFO]
> ------------------------------------------------------------------------
> >>>>> [ERROR] Failed to execute goal
> com.github.eirslett:frontend-maven-plugin:0.0.15:npm (npm install)
> on project unifiedpush-server: 'npm install --color=false' failed.
> (error code 130) -> [Help 1]
> >>>>> [ERROR]
> >>>>> [ERROR] To see the full stack trace of the errors, re-run
> Maven with the -e switch.
> >>>>> [ERROR] Re-run Maven using the -X switch to enable full debug
> logging.
> >>>>> [ERROR]
> >>>>> [ERROR] For more information about the errors and possible
> solutions, please read the following articles:
> >>>>> [ERROR] [Help 1]
>
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> >>>>> [ERROR]
> >>>>> [ERROR] After correcting the problems, you can resume the
> build with the command
> >>>>> [ERROR] mvn <goals> -rf :unifiedpush-server
> >>>>>
> >>>>> This is more a FYI on what's going on - I will file a JIRA
> ticket for
> >>>>> that;
> >>>>>
> >>>>> *PS:* According to yesterday's IRC discussions, a manual
> `grunt server does
> >>>>> work, so development is not*directly* effected
> >>>>>
> >>>>> -Matthias
> >>>>>
> >>>>> --
> >>>>> Matthias Wessendorf
> >>>>>
> >>>>> blog:
http://matthiaswessendorf.wordpress.com/
> >>>>> sessions:
http://www.slideshare.net/mwessendorf
> >>>>> twitter:
http://twitter.com/mwessendorf
> >>>>>
> >>>>> _______________________________________________
> >>>>> aerogear-dev mailing list
> >>>>> aerogear-dev(a)lists.jboss.org
> >>>>>
https://lists.jboss.org/mailman/listinfo/aerogear-dev
> >>>>>
> >>>>
> >>>>
> >>>> _______________________________________________
> >>>> aerogear-dev mailing list
> >>>> aerogear-dev(a)lists.jboss.org
> >>>>
https://lists.jboss.org/mailman/listinfo/aerogear-dev
> >>>>
> >>>
> >>>
> >>> _______________________________________________
> >>> aerogear-dev mailing list
> >>> aerogear-dev(a)lists.jboss.org
> >>>
https://lists.jboss.org/mailman/listinfo/aerogear-dev
> >>>
> >>
> >>
> >
> > --
> > Sent from Gmail Mobile
> >
> > _______________________________________________
> > aerogear-dev mailing list
> > aerogear-dev(a)lists.jboss.org
> >
https://lists.jboss.org/mailman/listinfo/aerogear-dev
> >
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
abstractj
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev