Re: [aerogear-dev] Safari Push notifications

On Oct 28, 2014, at 3:35 PM, Lucas Holmquist <lholmqui(a)redhat.com&gt; wrote: The branch on the main repo https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push <https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push> subsequent PR’s will target this one > On Oct 28, 2014, at 3:21 PM, Lucas Holmquist <lholmqui(a)redhat.com <mailto:lholmqui@redhat.com>> wrote: > > Here is the initial addition in one of my branches: https://github.com/lholmquist/aerogear-unified-push-server/tree/safari-push <https://github.com/lholmquist/aerogear-unified-push-server/tree/safari-pu... >> On Oct 27, 2014, at 9:42 AM, Matthias Wessendorf <matzew(a)apache.org <mailto:matzew@apache.org>> wrote: >> >> >> >> On Mon, Oct 27, 2014 at 2:28 PM, Lucas Holmquist <lholmqui(a)redhat.com <mailto:lholmqui@redhat.com>> wrote: >> >>> On Oct 27, 2014, at 9:20 AM, Erik Jan de Wit <edewit(a)redhat.com <mailto:edewit@redhat.com>> wrote: >>> >>> On 27 Oct,2014, at 14:15 , Lucas Holmquist <lholmqui(a)redhat.com <mailto:lholmqui@redhat.com>> wrote: >>> >>>> >>>> So i’ve run into a bit of a problem, I’m trying to send notifications, using https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... <https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... >>>> >>>> but i’m not sure how to also tell it to use the new SafarVariant.class that i’ve created. >>> >>> Right now a sender is configured to send notifications for one specific variant type, this mapping is configured on the top of the class: >>> https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... <https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... >>> >>> so APNsPushNotificationSender will only be use for iOSVariant variants, so either we change the way this works or you create a new Sender ( that extends this one maybe ) >> >> I think i’ll just create a new sender of now just to get something working since the SafariVariant and iOSVariant will be combined into an APNsVariant in the near future. >> >> sounds reasonable on getting this started >> >> -M >> >> >> >>> >>> Cheers, >>> Erik Jan >>> >>> >>> _______________________________________________ >>> aerogear-dev mailing list >>> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> >>> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> >> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> >> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> >> >> >> >> -- >> Matthias Wessendorf >> >> blog: http://matthiaswessendorf.wordpress.com/ <http://matthiaswessendorf.wordpress.com/> >> sessions: http://www.slideshare.net/mwessendorf <http://www.slideshare.net/mwessendorf> >> twitter: http://twitter.com/mwessendorf <http://twitter.com/mwessendorf>_______________________________________... >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> >> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev