On Tue, May 21, 2013 at 1:21 PM, Kris Borchers <kris(a)redhat.com> wrote:
On May 20, 2013, at 11:07 PM, Matthias Wessendorf <matzew(a)apache.org>
wrote:
On Mon, May 20, 2013 at 10:14 PM, Kris Borchers <kris(a)redhat.com> wrote:
> In our team meeting today, I brought up the question of whether or not
> the JavaScript clients for both SimplePush and Unified Push should live in
> folders under AeroGear.js or in their own repos. I would like to open this
> up to suggestions from the team. Please vote below.
>
> SimplePush
> Currently, this lives under AeroGear.js at
>
https://github.com/aerogear/aerogear-js/tree/Notifier/src/simple-push
> IMO, this makes sense since it also has a hard dependency on Notifier
> which lives here
>
https://github.com/aerogear/aerogear-js/tree/Notifier/src/notifier
> I would vote this remain where it is. Please vote whether or not this
> should remain in the AeroGear.js repo.
>
I *think* it would be good to have a separated repo for it.
So, folks that want to use the SimplePush, and only SimplePush, could just
add the "AG-SimplePush.js" to their project
(it could still have a dependency against Notifier, right?)
This would not make sense. This would mean instead of adding one file to
their project, they would now need to add either a full or custom build of
AeroGear with just Notifier first, then the SimplePush file. If it's in the
same repo, then they can use our online custom build tool or use grunt
themselves to build a custom version that just has SimplePush and Notifier
if that's all they need.
I mean, adding the "AG-SimplePush.js", which has all the dependencies, it
requires. Perhaps this is more a distribution issue? Not sure.... Perhaps
we just have to explictly say that "aerogear.js" implements the SimplePush
(and more)
-M
>
>
> Unified Push
> Currently, this lives under AeroGear.js at
>
https://github.com/aerogear/aerogear-js/tree/Notifier/src/unified-push
> IMO, this is not necessary since it could be used independently from the
> rest of AeroGear. I would vote that this move to a separate repo. This
> would also mean that the client object's name would change since it is
> currently namespaced under AeroGear as AeroGear.UnifiedPushClient. I would
> suggest it be renamed to AGUnifiedPushClient and be added to a repo named
> aerogear/unified-push-js. Please vote for whether or not this should move
> and if it should, an object name and repo name.
>
+1 for moving to its own repo
>
> Thanks!
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
--
Matthias Wessendorf
blog:
http://matthiaswessendorf.wordpress.com/
sessions:
http://www.slideshare.net/mwessendorf
twitter:
http://twitter.com/mwessendorf
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
Matthias Wessendorf
blog:
http://matthiaswessendorf.wordpress.com/
sessions:
http://www.slideshare.net/mwessendorf
twitter:
http://twitter.com/mwessendorf