Re: [aerogear-dev] [iOS] Auth: API for login, signup and logout

On Oct 8, 2012, at 8:02 AM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: > Quick update... I slightly changed the AuthModule protocol, by > exposing two properties: > - url (against where the auth module is mapped) Wouldn't you want to use baseURL and endpoint instead? That is what I have done for all of my rest adapters so far. > - type (e.g. REST etc) > > https://gist.github.com/3833333 > > -M > > On Mon, Oct 8, 2012 at 2:49 PM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: >> any other comments ? >> >> -M >> >> On Sun, Oct 7, 2012 at 12:16 AM, Christos Vasilakis <cvasilak(a)gmail.com&gt; wrote: >>> Hi, >>> >>> For what is worth, I prefer the current approach with the two callbacks. Kind of more familiar with that pattern. >>> >>> Regards, >>> Christos >>> >>> On 6 Οκτ 2012, at 1:51 μ.μ., Matthias Wessendorf <matzew(a)apache.org&gt; wrote: >>> >>>> Hey, >>>> >>>> I tend to continue using two callbacks: One for 'success' and one for >>>> the error case. >>>> >>>> Any objections? >>>> >>>> Greetings, >>>> Matthias >>>> >>>> On Fri, Oct 5, 2012 at 9:26 AM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: >>>>> On Fri, Oct 5, 2012 at 9:09 AM, Elmar Kretzer <elkr(a)symentis.com&gt; wrote: >>>>>> Hi Matze, =) >>>>>> >>>>>> quite fast enroll of the first API version - congratulations. >>>>> >>>>> it's the third :) >>>>> our Pipe API is already here: >>>>> https://github.com/aerogear/aerogear-ios/blob/master/API.md >>>>> >>>>> The datamanager proposal is here: >>>>> http://aerogear-dev.1069024.n5.nabble.com/aerogear-dev-iOS-DataManager-St... >>>>> >>>>>> >>>>>> I just had a quick look at your gists - and i then i stumbled upon the >>>>>> method with 2 blocks. >>>>>> >>>>>> It`s more like a personal flavor thing but sometimes methods with 2 block >>>>>> params can look quite disturbing. So i tend to use up to 3 params if >>>>>> necessary. >>>>> >>>>> I was following the pattern from the AFNetworking folks, since I used >>>>> that underneath our 'http communication' facility; >>>>> (see pipeline/pipe API) >>>>> >>>>> >>>>> I think I generally don't mind one single block - but instead of >>>>> completion, I'd prefer completionHandler :) >>>>> Not sure... >>>>> >>>>> >>>>>> I forked your gist for better explanation: https://gist.github.com/3838469 >>>>>> >>>>>> As i said - it`s really more a personal flavor thing - don`t mind. >>>>>> So keep up the work - going to have a deeper look and if i got time i will >>>>>> make a test. >>>>> >>>>> >>>>> Elmar, thanks for the feedback >>>>> >>>>> >>>>> -Matthias >>>>> >>>>> >>>>>> >>>>>> Cheers Elmar >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> View this message in context: http://aerogear-dev.1069024.n5.nabble.com/aerogear-dev-iOS-Auth-API-for-l... >>>>>> Sent from the aerogear-dev mailing list archive at Nabble.com. >>>>>> _______________________________________________ >>>>>> aerogear-dev mailing list >>>>>> aerogear-dev(a)lists.jboss.org >>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>>>> >>>>> >>>>> >>>>> -- >>>>> Matthias Wessendorf >>>>> >>>>> blog: http://matthiaswessendorf.wordpress.com/ >>>>> sessions: http://www.slideshare.net/mwessendorf >>>>> twitter: http://twitter.com/mwessendorf >>>> >>>> >>>> >>>> -- >>>> Matthias Wessendorf >>>> >>>> blog: http://matthiaswessendorf.wordpress.com/ >>>> sessions: http://www.slideshare.net/mwessendorf >>>> twitter: http://twitter.com/mwessendorf >>>> _______________________________________________ >>>> aerogear-dev mailing list >>>> aerogear-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>> >>> _______________________________________________ >>> aerogear-dev mailing list >>> aerogear-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> >> >> >> -- >> Matthias Wessendorf >> >> blog: http://matthiaswessendorf.wordpress.com/ >> sessions: http://www.slideshare.net/mwessendorf >> twitter: http://twitter.com/mwessendorf > > > > -- > Matthias Wessendorf > > blog: http://matthiaswessendorf.wordpress.com/ > sessions: http://www.slideshare.net/mwessendorf > twitter: http://twitter.com/mwessendorf > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev