On Tue, Nov 19, 2013 at 2:35 PM, Lucas Holmquist <lholmqui(a)redhat.com>wrote:
On Nov 19, 2013, at 4:21 AM, Erik Jan de Wit <edewit(a)redhat.com> wrote:
Hi,
Last tuesday the PR for the new javascript crypto api landed, because I
developed the crypto cordova plugin based on the 'old' api there is now a
discrepancy between the 'current' javascript crypto api and the cordova
one. We could change that this week as there aren't that many people that
use the crypto cordova plugin, but we have frozen so what is the point of a
freeze when we change things regardless?
If it is still in your repo and not an AeroGear one, then i think it is
fine to change.
Since the code freeze was on friday, and the change was made on the
tuesday before, i'm thinking that should've been enough time to update. I
don't believe the change was to big
I agree w/ Erik that updating the Cordova items is not on the same page of
updating a drop-in JS file, hence I think it's reasonable to change that
now and simply release the Cordova bits a bit later than all the other
items (Android, iOS and JS)
-Matthias
Anyway I think we could still change this what do you think?
Cheers,
Erik Jan
p.s.
have a look at the differences:
current javascript api
https://github.com/aerogear/aerogear-js/blob/master/tests/unit/crypto/aer...
current cordova api
https://github.com/edewit/aerogear.org/blob/f2fe8a48b2f9d9c581e62292abeaf...
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
Matthias Wessendorf
blog:
http://matthiaswessendorf.wordpress.com/
sessions:
http://www.slideshare.net/mwessendorf
twitter:
http://twitter.com/mwessendorf