4:05 a.m.
I think we should use a common strategy in the Open Source world, that in
general you need at least two LGTM thumbs up from bona fide reviewers
before being allowed to merge.
Thoughts?
--
Craig Brookes
RHMAP
@maleck13 Github
4:06 a.m.
New subject: [feedhenry-dev] When to merge a proposal
LGTM :-)
--
John Frizelle
Chief Architect, Red Hat Mobile
Consulting Engineer
mobile: *+353 87 290 1644 <//+353872901644>*
twitter:* @johnfriz*
skype: *john_frizelle*
mail: *jfrizell(a)redhat.com <jfrizell(a)redhat.com>*
On 15 December 2017 at 10:05, Craig Brookes <cbrookes(a)redhat.com> wrote:
I think we should use a common strategy in the Open Source world,
that in
general you need at least two LGTM thumbs up from bona fide reviewers
before being allowed to merge.
Thoughts?
--
Craig Brookes
RHMAP
@maleck13 Github
_______________________________________________
feedhenry-dev mailing list
feedhenry-dev(a)redhat.com
https://www.redhat.com/mailman/listinfo/feedhenry-dev
4:14 a.m.
New subject: [feedhenry-dev] When to merge a proposal
+1
On 15 December 2017 at 10:06, John Frizelle <jfrizell(a)redhat.com> wrote:
LGTM :-)
--
John Frizelle
Chief Architect, Red Hat Mobile
Consulting Engineer
mobile: *+353 87 290 1644 <//+353872901644>*
twitter:* @johnfriz*
skype: *john_frizelle*
mail: *jfrizell(a)redhat.com <jfrizell(a)redhat.com>*
On 15 December 2017 at 10:05, Craig Brookes <cbrookes(a)redhat.com> wrote:
> I think we should use a common strategy in the Open Source world, that in
> general you need at least two LGTM thumbs up from bona fide reviewers
> before being allowed to merge.
>
> Thoughts?
>
> --
> Craig Brookes
> RHMAP
> @maleck13 Github
>
> _______________________________________________
> feedhenry-dev mailing list
> feedhenry-dev(a)redhat.com
> https://www.redhat.com/mailman/listinfo/feedhenry-dev
>
>
_______________________________________________
feedhenry-dev mailing list
feedhenry-dev(a)redhat.com
https://www.redhat.com/mailman/listinfo/feedhenry-dev
--
David Martin
Red Hat Mobile
Twitter: @irldavem
IRC: @irldavem (feedhenry, mobile-internal)
5:19 a.m.
New subject: [feedhenry-dev] When to merge a proposal
At least 2 sounds about right
JOSE MIGUEL GALLAS OLMEDO
ASSOCIATE QE, mobile
Red Hat
<https://www.redhat.com/>
M: +34618488633 <http://redhatemailsignature-marketing.itos.redhat.com/>
<https://red.ht/sig>
On 15 December 2017 at 11:14, David Martin <davmarti(a)redhat.com> wrote:
+1
On 15 December 2017 at 10:06, John Frizelle <jfrizell(a)redhat.com> wrote:
> LGTM :-)
>
> --
> John Frizelle
> Chief Architect, Red Hat Mobile
> Consulting Engineer
>
> mobile: *+353 87 290 1644 <//+353872901644>*
> twitter:* @johnfriz*
> skype: *john_frizelle*
> mail: *jfrizell(a)redhat.com <jfrizell(a)redhat.com>*
>
>
>
>
> On 15 December 2017 at 10:05, Craig Brookes <cbrookes(a)redhat.com> wrote:
>
>> I think we should use a common strategy in the Open Source world, that
>> in general you need at least two LGTM thumbs up from bona fide reviewers
>> before being allowed to merge.
>>
>> Thoughts?
>>
>> --
>> Craig Brookes
>> RHMAP
>> @maleck13 Github
>>
>> _______________________________________________
>> feedhenry-dev mailing list
>> feedhenry-dev(a)redhat.com
>> https://www.redhat.com/mailman/listinfo/feedhenry-dev
>>
>>
>
> _______________________________________________
> feedhenry-dev mailing list
> feedhenry-dev(a)redhat.com
> https://www.redhat.com/mailman/listinfo/feedhenry-dev
>
>
--
David Martin
Red Hat Mobile
Twitter: @irldavem
IRC: @irldavem (feedhenry, mobile-internal)
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
2572
days inactive
2578
days old
3 comments
4 participants
participants (4)
-
Craig Brookes -
David Martin -
John Frizelle -
Jose Miguel Gallas Olmedo