Hi, Just to summarise here is what we found out when trying to create an Errai client for the TODO demo: https://github.com/aerogear/TODO/pull/29 We have our own implementation that serialises JSON from and to objects that is compliant with Jackson and that seems to 'conflict' with the server implementation, because that is receiving Longs as javascript numbers. A number in Javascript is a Double and if you execute the following javascript you'll see that this leads to strange rounding problems var test = {"id":1,"name":"tag","tags":[10000000000000001]};** console.log(test.tags[0]);** The same exists in Java https://gist.github.com/jfuerth/5372442 What I've added to the server side of the demo is the ability to receive the ids as Strings and then convert them on the server side where such a number limitation does not exists. Cheers, Erik Jan _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

Can we try to be a little more thorough in our PR review. I may have some picky issues with that PR that I will add comments about now. On May 22, 2013, at 7:37 AM, Sebastien Blanc <scm.blanc(a)gmail.com&gt; wrote: > Hi Erik, > Thanks for the explanation ! > And for everyone : this PR has already been reviewed and merged ! > Seb > > > > On Wed, May 22, 2013 at 2:28 PM, Erik Jan de Wit <edewit(a)redhat.com&gt; wrote: > Hi, > > Just to summarise here is what we found out when trying to create an Errai client for the TODO demo: > > https://github.com/aerogear/TODO/pull/29 > > We have our own implementation that serialises JSON from and to objects that is compliant with Jackson and that seems to 'conflict' with the server implementation, because that is receiving Longs as javascript numbers. A number in Javascript is a Double and if you execute the following javascript you'll see that this leads to strange rounding problems > > > > var test = {"id":1,"name":"tag","tags":[10000000000000001]}; > console.log(test.tags[0]); > > > The same exists in Java > > https://gist.github.com/jfuerth/5372442 > > What I've added to the server side of the demo is the ability to receive the ids as Strings and then convert them on the server side where such a number limitation does not exists. > > Cheers, > Erik Jan > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

Although, looking again, this seems to not have been rebased properly. Those commits from abstractj should not be in there with a proper rebase. Looks like maybe a merge was done without rebasing. On May 22, 2013, at 7:43 AM, Kris Borchers <kris(a)redhat.com <mailto:kris@redhat.com>> wrote: > Never mind, after reading a little more carefully, this looks ok. > > /me goes back to his hole > > On May 22, 2013, at 7:41 AM, Kris Borchers <kris(a)redhat.com > <mailto:kris@redhat.com>> wrote: > >> Can we try to be a little more thorough in our PR review. I may have >> some picky issues with that PR that I will add comments about now. >> >> On May 22, 2013, at 7:37 AM, Sebastien Blanc <scm.blanc(a)gmail.com >> <mailto:scm.blanc@gmail.com>> wrote: >> >>> Hi Erik, >>> Thanks for the explanation ! >>> And for everyone : this PR has already been reviewed and merged ! >>> Seb >>> >>> >>> >>> On Wed, May 22, 2013 at 2:28 PM, Erik Jan de Wit <edewit(a)redhat.com >>> <mailto:edewit@redhat.com>> wrote: >>> >>> Hi, >>> >>> Just to summarise here is what we found out when trying to >>> create an Errai client for the TODO demo: >>> >>> https://github.com/aerogear/TODO/pull/29 >>> >>> We have our own implementation that serialises JSON from and to >>> objects that is compliant with Jackson and that seems to >>> 'conflict' with the server implementation, because that is >>> receiving Longs as javascript numbers. A number in Javascript >>> is a Double and if you execute the following javascript you'll >>> see that this leads to strange rounding problems >>> >>> >>> >>> var test = {"id":1,"name":"tag","tags":[10000000000000001]}; >>> **console.log(test.tags[0]); >>> ** >>> >>> >>> >>> The same exists in Java >>> >>> https://gist.github.com/jfuerth/5372442 >>> >>> What I've added to the server side of the demo is the ability >>> to receive the ids as Strings and then convert them on the >>> server side where such a number limitation does not exists. >>> >>> Cheers, >>> Erik Jan >>> >>> _______________________________________________ >>> aerogear-dev mailing list >>> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> >>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>> >>> >>> _______________________________________________ >>> aerogear-dev mailing list >>> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> >>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> >> https://lists.jboss.org/mailman/listinfo/aerogear-dev > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

Strange created this mail long time ago… anyway On May 22, 2013, at 2:28 PM, Erik Jan de Wit <edewit(a)redhat.com&gt; wrote: Hi, Just to summarise here is what we found out when trying to create an Errai client for the TODO demo: https://github.com/aerogear/TODO/pull/29 We have our own implementation that serialises JSON from and to objects that is compliant with Jackson and that seems to 'conflict' with the server implementation, because that is receiving Longs as javascript numbers. A number in Javascript is a Double and if you execute the following javascript you'll see that this leads to strange rounding problems var test = {"id":1,"name":"tag","tags":[10000000000000001]};** console.log(test.tags[0]);** The same exists in Java https://gist.github.com/jfuerth/5372442 What I've added to the server side of the demo is the ability to receive the ids as Strings and then convert them on the server side where such a number limitation does not exists. Cheers, Erik Jan _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev