9 a.m.
Hi,
it's nice when we like to format code, however mixing that with actual
fixes, makes it VERY hard to review the real change....
Please let's not mix these things; It's IMO annoying going over 100 files,
when the real fix involves just 2 or 3 files....
-M
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
9:13 a.m.
#agreed
On 12 September 2013 09:00, Matthias Wessendorf <matzew(a)apache.org> wrote:
Hi,
it's nice when we like to format code, however mixing that with actual
fixes, makes it VERY hard to review the real change....
Please let's not mix these things; It's IMO annoying going over 100 files,
when the real fix involves just 2 or 3 files....
-M
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
2:31 p.m.
+1
On Sep 12, 2013, at 3:13 AM, Daniel Bevenius <daniel.bevenius(a)gmail.com> wrote:
#agreed
On 12 September 2013 09:00, Matthias Wessendorf <matzew(a)apache.org> wrote:
Hi,
it's nice when we like to format code, however mixing that with actual fixes, makes
it VERY hard to review the real change....
Please let's not mix these things; It's IMO annoying going over 100 files, when
the real fix involves just 2 or 3 files....
-M
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
2:38 p.m.
Guys, just run mvn java-formatter:formatbefore commit, we have it
enabled at POM parent as far as I know.
Lucas Holmquist <mailto:lholmqui@redhat.com>
September 12, 2013 9:31 AM
+1
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Daniel Bevenius <mailto:daniel.bevenius@gmail.com>
September 12, 2013 4:13 AM
#agreed
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Matthias Wessendorf <mailto:matzew@apache.org>
September 12, 2013 4:00 AM
Hi,
it's nice when we like to format code, however mixing that with actual
fixes, makes it VERY hard to review the real change....
Please let's not mix these things; It's IMO annoying going over 100
files, when the real fix involves just 2 or 3 files....
-M
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
abstractj
2:44 p.m.
On Sep 12, 2013, at 8:38 AM, Bruno Oliveira <bruno(a)abstractj.org> wrote:
Guys, just run mvn java-formatter:formatbefore commit, we have it
enabled at POM parent as far as I know.
yup, as long as we are doing it every time we do a PR.
but when it's on a mature code base that hasn't had it before and mixed with other
changes, then things get hairy
> Lucas Holmquist <mailto:lholmqui@redhat.com>
> September 12, 2013 9:31 AM
> +1
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
> Daniel Bevenius <mailto:daniel.bevenius@gmail.com>
> September 12, 2013 4:13 AM
> #agreed
>
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
> Matthias Wessendorf <mailto:matzew@apache.org>
> September 12, 2013 4:00 AM
> Hi,
>
> it's nice when we like to format code, however mixing that with actual
> fixes, makes it VERY hard to review the real change....
>
> Please let's not mix these things; It's IMO annoying going over 100
> files, when the real fix involves just 2 or 3 files....
>
> -M
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
abstractj
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
2:47 p.m.
The same will happen with eclipse, intellij formatters...etc. We should
be running that command at each pull request, just saying.
We can't solve all the IDE problems with formatting, the only way to do
it is be cautions at each pull request and also have a nice reviewer.
Lucas Holmquist <mailto:lholmqui@redhat.com>
September 12, 2013 9:44 AM
On Sep 12, 2013, at 8:38 AM, Bruno Oliveira <bruno(a)abstractj.org> wrote:
> Guys, just run mvn java-formatter:formatbefore commit, we have it
> enabled at POM parent as far as I know.
yup, as long as we are doing it every time we do a PR.
but when it's on a mature code base that hasn't had it before and mixed with
other changes, then things get hairy
>> Lucas Holmquist <mailto:lholmqui@redhat.com>
>> September 12, 2013 9:31 AM
>> +1
>>
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>> Daniel Bevenius <mailto:daniel.bevenius@gmail.com>
>> September 12, 2013 4:13 AM
>> #agreed
>>
>>
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>> Matthias Wessendorf <mailto:matzew@apache.org>
>> September 12, 2013 4:00 AM
>> Hi,
>>
>> it's nice when we like to format code, however mixing that with actual
>> fixes, makes it VERY hard to review the real change....
>>
>> Please let's not mix these things; It's IMO annoying going over 100
>> files, when the real fix involves just 2 or 3 files....
>>
>> -M
>>
>> --
>> Matthias Wessendorf
>>
>> blog: http://matthiaswessendorf.wordpress.com/
>> sessions: http://www.slideshare.net/mwessendorf
>> twitter: http://twitter.com/mwessendorf
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
> --
> abstractj
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Lucas Holmquist <mailto:lholmqui@redhat.com>
September 12, 2013 9:31 AM
+1
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Daniel Bevenius <mailto:daniel.bevenius@gmail.com>
September 12, 2013 4:13 AM
#agreed
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Matthias Wessendorf <mailto:matzew@apache.org>
September 12, 2013 4:00 AM
Hi,
it's nice when we like to format code, however mixing that with actual
fixes, makes it VERY hard to review the real change....
Please let's not mix these things; It's IMO annoying going over 100
files, when the real fix involves just 2 or 3 files....
-M
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
abstractj
2:49 p.m.
On Thu, Sep 12, 2013 at 2:44 PM, Lucas Holmquist <lholmqui(a)redhat.com>wrote:
On Sep 12, 2013, at 8:38 AM, Bruno Oliveira <bruno(a)abstractj.org> wrote:
> Guys, just run mvn java-formatter:formatbefore commit, we have it
> enabled at POM parent as far as I know.
yup, as long as we are doing it every time we do a PR.
The problem with adding a "fix formatting" commit in the _same_ PR than
"fix a real problem" is: Too much noise.
IMO it's just odd if 1000 files get formatted in one PR, which actually is
intended to include a one line (java) fix
-M
but when it's on a mature code base that hasn't had it before and mixed
with other changes, then things get hairy
>
>> Lucas Holmquist <mailto:lholmqui@redhat.com>
>> September 12, 2013 9:31 AM
>> +1
>>
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>> Daniel Bevenius <mailto:daniel.bevenius@gmail.com>
>> September 12, 2013 4:13 AM
>> #agreed
>>
>>
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>> Matthias Wessendorf <mailto:matzew@apache.org>
>> September 12, 2013 4:00 AM
>> Hi,
>>
>> it's nice when we like to format code, however mixing that with actual
>> fixes, makes it VERY hard to review the real change....
>>
>> Please let's not mix these things; It's IMO annoying going over 100
>> files, when the real fix involves just 2 or 3 files....
>>
>> -M
>>
>> --
>> Matthias Wessendorf
>>
>> blog: http://matthiaswessendorf.wordpress.com/
>> sessions: http://www.slideshare.net/mwessendorf
>> twitter: http://twitter.com/mwessendorf
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
> --
> abstractj
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
3 p.m.
From my humble perspective there are 2 alternatives:
- Be conscious about what you are doing that means (what I'm sending on
this PR, instead of git commit -a)
- Add a baby sitting service like checkstyle and make the build fail :)
Matthias Wessendorf <mailto:matzew@apache.org>
September 12, 2013 9:49 AM
On Thu, Sep 12, 2013 at 2:44 PM, Lucas Holmquist <lholmqui(a)redhat.com
<mailto:lholmqui@redhat.com>> wrote:
On Sep 12, 2013, at 8:38 AM, Bruno Oliveira <bruno(a)abstractj.org
<mailto:bruno@abstractj.org>> wrote:
> Guys, just run mvn java-formatter:formatbefore commit, we have it
> enabled at POM parent as far as I know.
yup, as long as we are doing it every time we do a PR.
The problem with adding a "fix formatting" commit in the _same_ PR
than "fix a real problem" is: Too much noise.
IMO it's just odd if 1000 files get formatted in one PR, which
actually is intended to include a one line (java) fix
-M
but when it's on a mature code base that hasn't had it before and
mixed with other changes, then things get hairy
>
>> Lucas Holmquist <mailto:lholmqui@redhat.com
<mailto:lholmqui@redhat.com>>
>> September 12, 2013 9:31 AM
>> +1
>>
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org>
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>> Daniel Bevenius <mailto:daniel.bevenius@gmail.com
<mailto:daniel.bevenius@gmail.com>>
>> September 12, 2013 4:13 AM
>> #agreed
>>
>>
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org>
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>> Matthias Wessendorf <mailto:matzew@apache.org
<mailto:matzew@apache.org>>
>> September 12, 2013 4:00 AM
>> Hi,
>>
>> it's nice when we like to format code, however mixing that with
actual
>> fixes, makes it VERY hard to review the real change....
>>
>> Please let's not mix these things; It's IMO annoying going over 100
>> files, when the real fix involves just 2 or 3 files....
>>
>> -M
>>
>> --
>> Matthias Wessendorf
>>
>> blog: http://matthiaswessendorf.wordpress.com/
>> sessions: http://www.slideshare.net/mwessendorf
>> twitter: http://twitter.com/mwessendorf
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org>
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
> --
> abstractj
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Lucas Holmquist <mailto:lholmqui@redhat.com>
September 12, 2013 9:44 AM
On Sep 12, 2013, at 8:38 AM, Bruno Oliveira <bruno(a)abstractj.org> wrote:
> Guys, just run mvn java-formatter:formatbefore commit, we have it
> enabled at POM parent as far as I know.
yup, as long as we are doing it every time we do a PR.
but when it's on a mature code base that hasn't had it before and mixed with
other changes, then things get hairy
>> Lucas Holmquist <mailto:lholmqui@redhat.com>
>> September 12, 2013 9:31 AM
>> +1
>>
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>> Daniel Bevenius <mailto:daniel.bevenius@gmail.com>
>> September 12, 2013 4:13 AM
>> #agreed
>>
>>
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>> Matthias Wessendorf <mailto:matzew@apache.org>
>> September 12, 2013 4:00 AM
>> Hi,
>>
>> it's nice when we like to format code, however mixing that with actual
>> fixes, makes it VERY hard to review the real change....
>>
>> Please let's not mix these things; It's IMO annoying going over 100
>> files, when the real fix involves just 2 or 3 files....
>>
>> -M
>>
>> --
>> Matthias Wessendorf
>>
>> blog: http://matthiaswessendorf.wordpress.com/
>> sessions: http://www.slideshare.net/mwessendorf
>> twitter: http://twitter.com/mwessendorf
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
> --
> abstractj
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Lucas Holmquist <mailto:lholmqui@redhat.com>
September 12, 2013 9:31 AM
+1
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Daniel Bevenius <mailto:daniel.bevenius@gmail.com>
September 12, 2013 4:13 AM
#agreed
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Matthias Wessendorf <mailto:matzew@apache.org>
September 12, 2013 4:00 AM
Hi,
it's nice when we like to format code, however mixing that with actual
fixes, makes it VERY hard to review the real change....
Please let's not mix these things; It's IMO annoying going over 100
files, when the real fix involves just 2 or 3 files....
-M
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
abstractj
3:11 p.m.
On Thu, Sep 12, 2013 at 3:00 PM, Bruno Oliveira <bruno(a)abstractj.org> wrote:
From my humble perspective there are 2 alternatives:
- Be conscious about what you are doing that means (what I'm sending on
this PR, instead of git commit -a)
yep, that's what I meant. formatting on file that are touched -> mostly
fine;
git commit -a and adding 100000000 unrelated files -> DOH ! :)
- Add a baby sitting service like checkstyle and make the build fail
:)
I don't mind check-style on the build
> Matthias Wessendorf <mailto:matzew@apache.org>
> September 12, 2013 9:49 AM
>
>
>
> On Thu, Sep 12, 2013 at 2:44 PM, Lucas Holmquist <lholmqui(a)redhat.com
> <mailto:lholmqui@redhat.com>> wrote:
>
>
> On Sep 12, 2013, at 8:38 AM, Bruno Oliveira <bruno(a)abstractj.org
> <mailto:bruno@abstractj.org>> wrote:
>
> > Guys, just run mvn java-formatter:formatbefore commit, we have it
> > enabled at POM parent as far as I know.
>
> yup, as long as we are doing it every time we do a PR.
>
>
> The problem with adding a "fix formatting" commit in the _same_ PR
> than "fix a real problem" is: Too much noise.
>
> IMO it's just odd if 1000 files get formatted in one PR, which
> actually is intended to include a one line (java) fix
>
> -M
>
>
>
>
> but when it's on a mature code base that hasn't had it before and
> mixed with other changes, then things get hairy
>
> >
> >> Lucas Holmquist <mailto:lholmqui@redhat.com
> <mailto:lholmqui@redhat.com>>
> >> September 12, 2013 9:31 AM
> >> +1
> >>
> >>
> >> _______________________________________________
> >> aerogear-dev mailing list
> >> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org
>
> >> https://lists.jboss.org/mailman/listinfo/aerogear-dev
> >> Daniel Bevenius <mailto:daniel.bevenius@gmail.com
> <mailto:daniel.bevenius@gmail.com>>
> >> September 12, 2013 4:13 AM
> >> #agreed
> >>
> >>
> >>
> >> _______________________________________________
> >> aerogear-dev mailing list
> >> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org
>
> >> https://lists.jboss.org/mailman/listinfo/aerogear-dev
> >> Matthias Wessendorf <mailto:matzew@apache.org
> <mailto:matzew@apache.org>>
> >> September 12, 2013 4:00 AM
> >> Hi,
> >>
> >> it's nice when we like to format code, however mixing that with
> actual
> >> fixes, makes it VERY hard to review the real change....
> >>
> >> Please let's not mix these things; It's IMO annoying going
over
100
> >> files, when the real fix involves just 2 or 3 files....
> >>
> >> -M
> >>
> >> --
> >> Matthias Wessendorf
> >>
> >> blog: http://matthiaswessendorf.wordpress.com/
> >> sessions: http://www.slideshare.net/mwessendorf
> >> twitter: http://twitter.com/mwessendorf
> >> _______________________________________________
> >> aerogear-dev mailing list
> >> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org
>
> >> https://lists.jboss.org/mailman/listinfo/aerogear-dev
> >
> > --
> > abstractj
> >
> >
> > _______________________________________________
> > aerogear-dev mailing list
> > aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org>
> > https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
>
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
> Lucas Holmquist <mailto:lholmqui@redhat.com>
> September 12, 2013 9:44 AM
> On Sep 12, 2013, at 8:38 AM, Bruno Oliveira <bruno(a)abstractj.org> wrote:
>
>> Guys, just run mvn java-formatter:formatbefore commit, we have it
>> enabled at POM parent as far as I know.
>
> yup, as long as we are doing it every time we do a PR.
>
>
> but when it's on a mature code base that hasn't had it before and mixed
with other changes, then things get hairy
>
>>> Lucas Holmquist <mailto:lholmqui@redhat.com>
>>> September 12, 2013 9:31 AM
>>> +1
>>>
>>>
>>> _______________________________________________
>>> aerogear-dev mailing list
>>> aerogear-dev(a)lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>> Daniel Bevenius <mailto:daniel.bevenius@gmail.com>
>>> September 12, 2013 4:13 AM
>>> #agreed
>>>
>>>
>>>
>>> _______________________________________________
>>> aerogear-dev mailing list
>>> aerogear-dev(a)lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>> Matthias Wessendorf <mailto:matzew@apache.org>
>>> September 12, 2013 4:00 AM
>>> Hi,
>>>
>>> it's nice when we like to format code, however mixing that with actual
>>> fixes, makes it VERY hard to review the real change....
>>>
>>> Please let's not mix these things; It's IMO annoying going over 100
>>> files, when the real fix involves just 2 or 3 files....
>>>
>>> -M
>>>
>>> --
>>> Matthias Wessendorf
>>>
>>> blog: http://matthiaswessendorf.wordpress.com/
>>> sessions: http://www.slideshare.net/mwessendorf
>>> twitter: http://twitter.com/mwessendorf
>>> _______________________________________________
>>> aerogear-dev mailing list
>>> aerogear-dev(a)lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>> --
>> abstractj
>>
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
> Lucas Holmquist <mailto:lholmqui@redhat.com>
> September 12, 2013 9:31 AM
> +1
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
> Daniel Bevenius <mailto:daniel.bevenius@gmail.com>
> September 12, 2013 4:13 AM
> #agreed
>
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
> Matthias Wessendorf <mailto:matzew@apache.org>
> September 12, 2013 4:00 AM
> Hi,
>
> it's nice when we like to format code, however mixing that with actual
> fixes, makes it VERY hard to review the real change....
>
> Please let's not mix these things; It's IMO annoying going over 100
> files, when the real fix involves just 2 or 3 files....
>
> -M
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
abstractj
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
4:14 p.m.
IMO, formatting changes should always be in their own commit. I agree that you should not
add formatting fixes in multiple files along with a real code change in the same PR. That
makes it to hard to review. If its in the same file though, I don't mind formatting
commits in the same PR and even in the history but if people don't want that noise in
history, the person that merges the PR can always squash before they merge.
On Sep 12, 2013, at 8:43, Matthias Wessendorf <matzew(a)apache.org> wrote:
On Thu, Sep 12, 2013 at 2:44 PM, Lucas Holmquist <lholmqui(a)redhat.com> wrote:
>
> On Sep 12, 2013, at 8:38 AM, Bruno Oliveira <bruno(a)abstractj.org> wrote:
>
> > Guys, just run mvn java-formatter:formatbefore commit, we have it
> > enabled at POM parent as far as I know.
>
> yup, as long as we are doing it every time we do a PR.
The problem with adding a "fix formatting" commit in the _same_ PR than
"fix a real problem" is: Too much noise.
IMO it's just odd if 1000 files get formatted in one PR, which actually is intended
to include a one line (java) fix
-M
>
>
> but when it's on a mature code base that hasn't had it before and mixed with
other changes, then things get hairy
>
> >
> >> Lucas Holmquist <mailto:lholmqui@redhat.com>
> >> September 12, 2013 9:31 AM
> >> +1
> >>
> >>
> >> _______________________________________________
> >> aerogear-dev mailing list
> >> aerogear-dev(a)lists.jboss.org
> >> https://lists.jboss.org/mailman/listinfo/aerogear-dev
> >> Daniel Bevenius <mailto:daniel.bevenius@gmail.com>
> >> September 12, 2013 4:13 AM
> >> #agreed
> >>
> >>
> >>
> >> _______________________________________________
> >> aerogear-dev mailing list
> >> aerogear-dev(a)lists.jboss.org
> >> https://lists.jboss.org/mailman/listinfo/aerogear-dev
> >> Matthias Wessendorf <mailto:matzew@apache.org>
> >> September 12, 2013 4:00 AM
> >> Hi,
> >>
> >> it's nice when we like to format code, however mixing that with actual
> >> fixes, makes it VERY hard to review the real change....
> >>
> >> Please let's not mix these things; It's IMO annoying going over 100
> >> files, when the real fix involves just 2 or 3 files....
> >>
> >> -M
> >>
> >> --
> >> Matthias Wessendorf
> >>
> >> blog: http://matthiaswessendorf.wordpress.com/
> >> sessions: http://www.slideshare.net/mwessendorf
> >> twitter: http://twitter.com/mwessendorf
> >> _______________________________________________
> >> aerogear-dev mailing list
> >> aerogear-dev(a)lists.jboss.org
> >> https://lists.jboss.org/mailman/listinfo/aerogear-dev
> >
> > --
> > abstractj
> >
> >
> > _______________________________________________
> > aerogear-dev mailing list
> > aerogear-dev(a)lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
4131
days inactive
4131
days old
9 comments
5 participants
participants (5)
-
Bruno Oliveira -
Daniel Bevenius -
Kris Borchers -
Lucas Holmquist -
Matthias Wessendorf