+1 with so many repositories, it's easy to skip it and commit mistakes. More details on pull requests, less problems.

On 2014-10-09, Erik Jan de Wit wrote: > Hi, > > As we already added new functionality to the hello world example ( windows support) there is a branch for the 1.0.x version. When you fix some issues be sure to specify in you PR that it should go to the 1.0.x branch as well as master! > > Cheers, > Erik Jan > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev -- abstractj PGP: 0x84DC9914 _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

And if the jira is mentioned in the PR (and it always should) a good way for the merger to confirm where to merge is to check the "fix version" attribute values of the ticket. And so for those creating tickets : make sure to set a fix version(s) :) On Thu, Oct 9, 2014 at 1:03 PM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: > > > On Thu, Oct 9, 2014 at 12:57 PM, Bruno Oliveira <bruno(a)abstractj.org&gt; > wrote: > >> +1 with so many repositories, it's easy to skip it and commit mistakes. >> >> More details on pull requests, less problems. >> > > Right! I think generally, we should provide a minimum of description on > each PR. Sometimes there is nothing attached (no text, no JIRA link). Hard > to do guesswork :) > > >> >> On 2014-10-09, Erik Jan de Wit wrote: >> > Hi, >> > >> > As we already added new functionality to the hello world example ( >> windows support) there is a branch for the 1.0.x version. When you fix some >> issues be sure to specify in you PR that it should go to the 1.0.x branch >> as well as master! >> > >> > Cheers, >> > Erik Jan >> > _______________________________________________ >> > aerogear-dev mailing list >> > aerogear-dev(a)lists.jboss.org >> > https://lists.jboss.org/mailman/listinfo/aerogear-dev >> >> -- >> >> abstractj >> PGP: 0x84DC9914 >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> > > > > -- > Matthias Wessendorf > > blog: http://matthiaswessendorf.wordpress.com/ > sessions: http://www.slideshare.net/mwessendorf > twitter: http://twitter.com/mwessendorf > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev > _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev