Hi Bruno,
I reviewed the bits already separately, as you can tell from my comments
:-)
I think generally it looks very good. Also I am happy to see you went
and created a separate module, based on the issues we discovered. :-)
I think, to be used in CDI, perhaps a doc (e.g. README.md) should
mention the required Producers?
Like:
@Produces
public HawkServer createHawkServer() {
HawkServerConfiguration configuration = new
HawkServerConfiguration.Builder().build();
return new
HawkServer.Builder().configuration(configuration).build();
}
@Produces
public HawkCredentialProvider createHawkCredentialProvider() {
return new HawkCredentialProvider() {
@Override
public HawkCredentials findByKey(String arg0) {
HawkCredentials credentials = new HawkCredentials.Builder()
.keyId("dh37fgj492je")
.key("werxhqb98rpaxn39848xrunpaw3489ruxnpa98w4rxn")
.algorithm(HawkCredentials.Algorithm.SHA256)
.build();
return credentials;
}
};
}
-Matthias
On Wed, Jul 17, 2013 at 6:11 PM, Bruno Oliveira <bruno(a)abstractj.org
<mailto:bruno@abstractj.org>> wrote:
Good morning all.
After some feedback on Hawk
(
http://aerogear-dev.1069024.n5.nabble.com/aerogear-dev-AeroGear-Security-...)
I asked Qmx to create a new repository for Hak and most of the commits
into AeroGear Security were reverted. The latest stable one is still
1.1.1, so if you are using it, you don't need to worry about.
The repository created is:
https://github.com/abstractj/aerogear-security-hawk, you are free to
test and provide some feedback. Also AG Sec Hawk was staged under
https://repository.jboss.org/nexus/content/repositories/jboss_releases_st....
If you want to test it, please follow the instructions here:
https://github.com/aerogear/aerogear-controller-demo/pull/66 or
https://github.com/aerogear/aerogear-security/pull/27.
Feedback is welcome.
--
abstractj
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
Matthias Wessendorf
blog:
http://matthiaswessendorf.wordpress.com/
sessions:
http://www.slideshare.net/mwessendorf
twitter:
http://twitter.com/mwessendorf
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev