https://issues.jboss.org/browse/AEROGEAR-540 i created this on monday, but now i'm thinking otherwise. The Data Manager Memory adapters filter method will only search on level of an object( at least i think). i was thinking we might need it to do a recursive search to find items not on the first level. ex: var object = { name: thing, value: { thing2: thing3 } } alreadyCreatedDataManager.filter( { name:'thing' } ) => returns object //currently this happens alreadyCreatedDataManager.filter( { thing2:'thing3' } ) => returns empty [ ] //with recursive alreadyCreatedDataManager.filter( { thing2:'thing3' } ) => returns object Now i'm not sure if thats the way to go. Thoughts against: bloat the code, developers could do this themselves when they get the data back, keeping our library leaner Thoughts for: Be nice to the developer like to hear other thoughts _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

+1 on leaving that out; I think the data sync is not the highest prio right now

On Mon, Oct 22, 2012 at 2:05 PM, Kris Borchers <kris(a)redhat.com&gt; wrote: > My vote for now would be to leave this out. > > On Oct 19, 2012, at 7:09 AM, Lucas Holmquist <lholmqui(a)redhat.com&gt; wrote: > > https://issues.jboss.org/browse/AEROGEAR-540 > > i created this on monday, but now i'm thinking otherwise. > > The Data Manager Memory adapters filter method will only search on level of > an object( at least i think). i was thinking we might need it to do a > recursive search to find items not on the first level. > > ex: > > var object = { > name: thing, > value: { > thing2: thing3 > } > } > > alreadyCreatedDataManager.filter( { name:'thing' } ) => returns object > > //currently this happens > alreadyCreatedDataManager.filter( { thing2:'thing3' } ) => returns > empty [ ] > > //with recursive > alreadyCreatedDataManager.filter( { thing2:'thing3' } ) => returns > object > > Now i'm not sure if thats the way to go. > > Thoughts against: > > bloat the code, developers could do this themselves when they get the data > back, keeping our library leaner > > Thoughts for: > > Be nice to the developer > > like to hear other thoughts > > > > > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev > > > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On Oct 22, 2012, at 9:17 AM, Lucas Holmquist <lholmqui(a)redhat.com&gt; wrote: > yea thats what i've been thinking too, > On Oct 22, 2012, at 10:16 AM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: > >> +1 on leaving that out; I think the data sync is not the highest prio right now >> > > did you mean to say that the "data sync is the highest prio right now", not "not"? Same question from me. Did you mean it is the highest prio? > >> On Mon, Oct 22, 2012 at 2:05 PM, Kris Borchers <kris(a)redhat.com&gt; wrote: >>> My vote for now would be to leave this out. >>> >>> On Oct 19, 2012, at 7:09 AM, Lucas Holmquist <lholmqui(a)redhat.com&gt; wrote: >>> >>> https://issues.jboss.org/browse/AEROGEAR-540 >>> >>> i created this on monday, but now i'm thinking otherwise. >>> >>> The Data Manager Memory adapters filter method will only search on level of >>> an object( at least i think). i was thinking we might need it to do a >>> recursive search to find items not on the first level. >>> >>> ex: >>> >>> var object = { >>> name: thing, >>> value: { >>> thing2: thing3 >>> } >>> } >>> >>> alreadyCreatedDataManager.filter( { name:'thing' } ) => returns object >>> >>> //currently this happens >>> alreadyCreatedDataManager.filter( { thing2:'thing3' } ) => returns >>> empty [ ] >>> >>> //with recursive >>> alreadyCreatedDataManager.filter( { thing2:'thing3' } ) => returns >>> object >>> >>> Now i'm not sure if thats the way to go. >>> >>> Thoughts against: >>> >>> bloat the code, developers could do this themselves when they get the data >>> back, keeping our library leaner >>> >>> Thoughts for: >>> >>> Be nice to the developer >>> >>> like to hear other thoughts >>> >>> >>> >>> >>> >>> _______________________________________________ >>> aerogear-dev mailing list >>> aerogear-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>> >>> >>> >>> _______________________________________________ >>> aerogear-dev mailing list >>> aerogear-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>> >> >> >> >> -- >> Matthias Wessendorf >> >> blog: http://matthiaswessendorf.wordpress.com/ >> sessions: http://www.slideshare.net/mwessendorf >> twitter: http://twitter.com/mwessendorf >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev > > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev