4:24 p.m.
Hey guys!
I'd like to hear your opinions on one decision I'm about to make. I've been
working on implementation of logcat into arquillian-droidium and now I'm trying to
decide, which kind of logging should be enabled by default. Whether it should be logging
though Logger or through System.out (or disabled completely by default). These two logs
are here: https://gist.github.com/TadeasKriz/e7c91f3e7e230e596f20
4:29 p.m.
It's a better practice to log with a logger rather than system.out.
Logger are configurable.
Indent looks better on second output though
++
Corinne
On Jul 11, 2013, at 4:24 PM, TadeasKriz <tkriz(a)redhat.com> wrote:
Hey guys!
I'd like to hear your opinions on one decision I'm about to make. I've been
working on implementation of logcat into arquillian-droidium and now I'm trying to
decide, which kind of logging should be enabled by default. Whether it should be logging
though Logger or through System.out (or disabled completely by default). These two logs
are here: https://gist.github.com/TadeasKriz/e7c91f3e7e230e596f20
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
4:40 p.m.
As you said, second looks better. So I was thinking that if you'll need to configure
logger you'll enable it, but otherwise it's just very confusing for a newcomer.
On Jul 11, 2013, at 4:29 PM, Corinne Krych <corinnekrych(a)gmail.com> wrote:
It's a better practice to log with a logger rather than
system.out.
Logger are configurable.
Indent looks better on second output though
++
Corinne
On Jul 11, 2013, at 4:24 PM, TadeasKriz <tkriz(a)redhat.com> wrote:
> Hey guys!
>
> I'd like to hear your opinions on one decision I'm about to make. I've
been working on implementation of logcat into arquillian-droidium and now I'm trying
to decide, which kind of logging should be enabled by default. Whether it should be
logging though Logger or through System.out (or disabled completely by default). These two
logs are here: https://gist.github.com/TadeasKriz/e7c91f3e7e230e596f20
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
4:51 p.m.
By default could you display Error level only?
avoid warning level which clutter your log
On Jul 11, 2013, at 4:40 PM, TadeasKriz <tkriz(a)redhat.com> wrote:
As you said, second looks better. So I was thinking that if
you'll need to configure logger you'll enable it, but otherwise it's just very
confusing for a newcomer.
On Jul 11, 2013, at 4:29 PM, Corinne Krych <corinnekrych(a)gmail.com> wrote:
> It's a better practice to log with a logger rather than system.out.
> Logger are configurable.
> Indent looks better on second output though
>
> ++
> Corinne
> On Jul 11, 2013, at 4:24 PM, TadeasKriz <tkriz(a)redhat.com> wrote:
>
>> Hey guys!
>>
>> I'd like to hear your opinions on one decision I'm about to make.
I've been working on implementation of logcat into arquillian-droidium and now I'm
trying to decide, which kind of logging should be enabled by default. Whether it should be
logging though Logger or through System.out (or disabled completely by default). These two
logs are here: https://gist.github.com/TadeasKriz/e7c91f3e7e230e596f20
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
5:05 p.m.
That wouldn't make much a difference. The problem is not warnings but the thing that
Logger prints two lines. If there will be a stack-trace (often for error logs in logcat)
it won't be readable. I was thinking that by default, the System.out would be better.
It can be easily changed in the arquillian.xml with one property so those who would need
the Logger's features would switch it.
On Jul 11, 2013, at 4:51 PM, Corinne Krych <corinnekrych(a)gmail.com> wrote:
By default could you display Error level only?
avoid warning level which clutter your log
On Jul 11, 2013, at 4:40 PM, TadeasKriz <tkriz(a)redhat.com> wrote:
> As you said, second looks better. So I was thinking that if you'll need to
configure logger you'll enable it, but otherwise it's just very confusing for a
newcomer.
>
> On Jul 11, 2013, at 4:29 PM, Corinne Krych <corinnekrych(a)gmail.com> wrote:
>
>> It's a better practice to log with a logger rather than system.out.
>> Logger are configurable.
>> Indent looks better on second output though
>>
>> ++
>> Corinne
>> On Jul 11, 2013, at 4:24 PM, TadeasKriz <tkriz(a)redhat.com> wrote:
>>
>>> Hey guys!
>>>
>>> I'd like to hear your opinions on one decision I'm about to make.
I've been working on implementation of logcat into arquillian-droidium and now I'm
trying to decide, which kind of logging should be enabled by default. Whether it should be
logging though Logger or through System.out (or disabled completely by default). These two
logs are here: https://gist.github.com/TadeasKriz/e7c91f3e7e230e596f20
>>> _______________________________________________
>>> aerogear-dev mailing list
>>> aerogear-dev(a)lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
8:59 p.m.
Logging through the Logger is generally better practice.
Though I am wondering why the Logger output is so ugly.
On 07/11/2013 10:24 AM, TadeasKriz wrote:
Hey guys!
I'd like to hear your opinions on one decision I'm about to make. I've
been working on implementation of logcat into arquillian-droidium and
now I'm trying to decide, which kind of logging should be enabled by
default. Whether it should be logging though Logger or through
System.out (or disabled completely by default). These two logs are
here: https://gist.github.com/TadeasKriz/e7c91f3e7e230e596f20
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
10:19 a.m.
On Thu, 11 Jul 2013 14:59:59 -0400
Summers Pittman <supittma(a)redhat.com> wrote:
Logging through the Logger is generally better practice.
Though I am wondering why the Logger output is so ugly.
I'd say that the reason is that logcat is external process consumed by Drodium,
so the logger logs per line, not per logcat message. Moreover, default JUL
settings logs tons of unnecessary stuff for process redirect purposes like
logger name, timestamp, etc.
On 07/11/2013 10:24 AM, TadeasKriz wrote:
> Hey guys!
>
> I'd like to hear your opinions on one decision I'm about to make. I've
> been working on implementation of logcat into arquillian-droidium and
> now I'm trying to decide, which kind of logging should be enabled by
> default. Whether it should be logging though Logger or through
> System.out (or disabled completely by default). These two logs are
> here: https://gist.github.com/TadeasKriz/e7c91f3e7e230e596f20
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
3941
days inactive
3942
days old
6 comments
4 participants
participants (4)
-
Corinne Krych -
Karel Piwko -
Summers Pittman -
TadeasKriz