I would like to turn the Android maven project into three separate projects. aerogear-android: The core library with everything you need to get going on modern (4.0+) Android devices aerogear-android-support: Library shims for older (Android 2.3) devices. This project will also require the android-support-library. aerogear-android-tests: This will house all of the Aerogear tests for Android. Currently we use Robolectric for testing, but it doesn't accurately support some things (Android threading comes to mind) and doesn't support others at all (Loaders). A solution is to use a project which runs the tests on a emulator/device. This can also be the integration test project which we want to make anyway. wdyt? Summers _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On 28/02/2013, at 20:07, Summers Pittman <supittma(a)redhat.com&gt; wrote: > aerogear-android-tests: This will house all of the Aerogear tests for > Android. You mean moving all the tests? Can't this be only for integration tests, and the unit tests stay on the aerogear-android project?

-- qmx _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On Fri, Mar 1, 2013 at 2:02 AM, Douglas Campos <qmx(a)qmx.me&gt; wrote: > > On 28/02/2013, at 20:07, Summers Pittman <supittma(a)redhat.com&gt; wrote: > >> aerogear-android-tests: This will house all of the Aerogear tests for >> Android. > > You mean moving all the tests? Can't this be only for integration tests, and the unit tests stay on the aerogear-android project? I'd also prefer to have the unit tests for each of the libs (aerogear-android + aerogear-android-support) being in there.

Only integration tests should be a totally independent project, consuming the other libs (aerogear-android + aerogear-android-support) and having tests against em. -M > > -- qmx > > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On Fri, Mar 1, 2013 at 12:59 PM, Kris Borchers <kris(a)redhat.com&gt; wrote: > > On Mar 1, 2013, at 12:38 AM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: > >> On Fri, Mar 1, 2013 at 2:02 AM, Douglas Campos <qmx(a)qmx.me&gt; wrote: >>> >>> On 28/02/2013, at 20:07, Summers Pittman <supittma(a)redhat.com&gt; wrote: >>> >>>> aerogear-android-tests: This will house all of the Aerogear tests for >>>> Android. >>> >>> You mean moving all the tests? Can't this be only for integration tests, and the unit tests stay on the aerogear-android project? >> >> I'd also prefer to have the unit tests for each of the libs >> (aerogear-android + aerogear-android-support) being in there. > > I can see one reason to have the unit tests in a separate project. I assume both aerogear-android and aerogear-android-support would have pretty much identical tests since their functionality should > be the same, right? It would be a pain to have to maintain multiple sets of the same tests across projects. >> Not sure about the details, BUT... you misread. Unit tests belong to the library. I am -1000 on having a 'unit test' only broject. Integration tests are different, they _should_ be separated -M >> Only integration tests should be a totally independent project, >> consuming the other libs (aerogear-android + aerogear-android-support) >> and having tests against em. >> >> -M >> >> >>> >>> -- qmx >>> >>> >>> _______________________________________________ >>> aerogear-dev mailing list >>> aerogear-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> >> >> >> -- >> Matthias Wessendorf >> >> blog: http://matthiaswessendorf.wordpress.com/ >> sessions: http://www.slideshare.net/mwessendorf >> twitter: http://twitter.com/mwessendorf >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev > > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On Mar 1, 2013, at 7:16 AM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: > On Fri, Mar 1, 2013 at 12:59 PM, Kris Borchers <kris(a)redhat.com&gt; wrote: >> >> On Mar 1, 2013, at 12:38 AM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: >> >>> On Fri, Mar 1, 2013 at 2:02 AM, Douglas Campos <qmx(a)qmx.me&gt; wrote: >>>> >>>> On 28/02/2013, at 20:07, Summers Pittman <supittma(a)redhat.com&gt; wrote: >>>> >>>>> aerogear-android-tests: This will house all of the Aerogear tests for >>>>> Android. >>>> >>>> You mean moving all the tests? Can't this be only for integration tests, and the unit tests stay on the aerogear-android project? >>> >>> I'd also prefer to have the unit tests for each of the libs >>> (aerogear-android + aerogear-android-support) being in there. >> >> I can see one reason to have the unit tests in a separate project. I assume both aerogear-android and aerogear-android-support would have pretty much identical tests since their functionality should >> be the same, right? It would be a pain to have to maintain multiple sets of the same tests across projects. >>> > > Not sure about the details, BUT... you misread. I don't think I did. > > Unit tests belong to the library. I am -1000 on having a 'unit test' > only broject. Normally I would agree with this but what I'm saying is that this is a unique situation. These libraries will have the same functionality unless I'm misunderstanding the point of separating aerogear-android and aerogear-android-support. I'm mostly just pointing out the fact that these projects will likely have identical unit test suites so maintaining them will be a pain.

That is all. If Summers and any other Android folks don't mind maintaining two identical test suites in different projects, fine by me. > > Integration tests are different, they _should_ be separated Agree > > -M > >>> Only integration tests should be a totally independent project, >>> consuming the other libs (aerogear-android + aerogear-android-support) >>> and having tests against em. >>> >>> -M >>> >>> >>>> >>>> -- qmx >>>> >>>> >>>> _______________________________________________ >>>> aerogear-dev mailing list >>>> aerogear-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>> >>> >>> >>> -- >>> Matthias Wessendorf >>> >>> blog: http://matthiaswessendorf.wordpress.com/ >>> sessions: http://www.slideshare.net/mwessendorf >>> twitter: http://twitter.com/mwessendorf >>> _______________________________________________ >>> aerogear-dev mailing list >>> aerogear-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> >> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev > > > > -- > Matthias Wessendorf > > blog: http://matthiaswessendorf.wordpress.com/ > sessions: http://www.slideshare.net/mwessendorf > twitter: http://twitter.com/mwessendorf > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On Mar 1, 2013, at 7:44 AM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: > On Fri, Mar 1, 2013 at 1:40 PM, Kris Borchers <kris(a)redhat.com&gt; wrote: >> >> On Mar 1, 2013, at 7:16 AM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: >> >>> On Fri, Mar 1, 2013 at 12:59 PM, Kris Borchers <kris(a)redhat.com&gt; wrote: >>>> >>>> On Mar 1, 2013, at 12:38 AM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: >>>> >>>>> On Fri, Mar 1, 2013 at 2:02 AM, Douglas Campos <qmx(a)qmx.me&gt; wrote: >>>>>> >>>>>> On 28/02/2013, at 20:07, Summers Pittman <supittma(a)redhat.com&gt; wrote: >>>>>> >>>>>>> aerogear-android-tests: This will house all of the Aerogear tests for >>>>>>> Android. >>>>>> >>>>>> You mean moving all the tests? Can't this be only for integration tests, and the unit tests stay on the aerogear-android project? >>>>> >>>>> I'd also prefer to have the unit tests for each of the libs >>>>> (aerogear-android + aerogear-android-support) being in there. >>>> >>>> I can see one reason to have the unit tests in a separate project. I assume both aerogear-android and aerogear-android-support would have pretty much identical tests since their functionality should >>>> be the same, right? It would be a pain to have to maintain multiple sets of the same tests across projects. >>>>> >>> >>> Not sure about the details, BUT... you misread. >> >> I don't think I did. >>> >>> Unit tests belong to the library. I am -1000 on having a 'unit test' >>> only broject. >> >> Normally I would agree with this but what I'm saying is that this is a unique situation. These libraries will have the same functionality unless I'm misunderstanding the point of separating aerogear-android and aerogear-android-support. I'm mostly just pointing out the fact that these projects will likely have identical unit test suites so maintaining them will be a pain. > > not sure, if they are similar :) But... moving the unit tests into a > separate project, increases the fact that they are not executed, when > doing work on the library Agree. Again, just being devil's advocate on the mailing list as I tend to do. :) Just want to make sure we look at all points of view and really think things through before implementation.

> >> That is all. If Summers and any other Android folks don't mind maintaining two identical test suites in different projects, fine by me. >>> >>> Integration tests are different, they _should_ be separated >> >> Agree >>> >>> -M >>> >>>>> Only integration tests should be a totally independent project, >>>>> consuming the other libs (aerogear-android + aerogear-android-support) >>>>> and having tests against em. >>>>> >>>>> -M >>>>> >>>>> >>>>>> >>>>>> -- qmx >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> aerogear-dev mailing list >>>>>> aerogear-dev(a)lists.jboss.org >>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>>>> >>>>> >>>>> >>>>> -- >>>>> Matthias Wessendorf >>>>> >>>>> blog: http://matthiaswessendorf.wordpress.com/ >>>>> sessions: http://www.slideshare.net/mwessendorf >>>>> twitter: http://twitter.com/mwessendorf >>>>> _______________________________________________ >>>>> aerogear-dev mailing list >>>>> aerogear-dev(a)lists.jboss.org >>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>>> >>>> >>>> _______________________________________________ >>>> aerogear-dev mailing list >>>> aerogear-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>> >>> >>> >>> -- >>> Matthias Wessendorf >>> >>> blog: http://matthiaswessendorf.wordpress.com/ >>> sessions: http://www.slideshare.net/mwessendorf >>> twitter: http://twitter.com/mwessendorf >>> _______________________________________________ >>> aerogear-dev mailing list >>> aerogear-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> >> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev > > > > -- > Matthias Wessendorf > > blog: http://matthiaswessendorf.wordpress.com/ > sessions: http://www.slideshare.net/mwessendorf > twitter: http://twitter.com/mwessendorf > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On 03/01/2013 07:16 AM, Matthias Wessendorf wrote: > On Fri, Mar 1, 2013 at 12:59 PM, Kris Borchers <kris(a)redhat.com&gt; wrote: >> On Mar 1, 2013, at 12:38 AM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: >> >>> On Fri, Mar 1, 2013 at 2:02 AM, Douglas Campos <qmx(a)qmx.me&gt; wrote: >>>> On 28/02/2013, at 20:07, Summers Pittman <supittma(a)redhat.com&gt; wrote: >>>> >>>>> aerogear-android-tests: This will house all of the Aerogear tests for >>>>> Android. >>>> You mean moving all the tests? Can't this be only for integration tests, and the unit tests stay on the aerogear-android project? >>> I'd also prefer to have the unit tests for each of the libs >>> (aerogear-android + aerogear-android-support) being in there. >> I can see one reason to have the unit tests in a separate project. I assume both aerogear-android and aerogear-android-support would have pretty much identical tests since their functionality should >> be the same, right? It would be a pain to have to maintain multiple sets of the same tests across projects. > Not sure about the details, BUT... you misread. > > Unit tests belong to the library. I am -1000 on having a 'unit test' > only broject. > > Integration tests are different, they _should_ be separated Integration tests also test on the underlying platform (IE the Android device).

The unit tests for AG Android can stay with the project,

but the number of tests in the project will go way down.

> > -M > >>> Only integration tests should be a totally independent project, >>> consuming the other libs (aerogear-android + aerogear-android-support) >>> and having tests against em. >>> >>> -M >>> >>> >>>> -- qmx >>>> >>>> >>>> _______________________________________________ >>>> aerogear-dev mailing list >>>> aerogear-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>> >>> >>> -- >>> Matthias Wessendorf >>> >>> blog: http://matthiaswessendorf.wordpress.com/ >>> sessions: http://www.slideshare.net/mwessendorf >>> twitter: http://twitter.com/mwessendorf >>> _______________________________________________ >>> aerogear-dev mailing list >>> aerogear-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev > > _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On 03/01/2013 09:23 AM, Matthias Wessendorf wrote: > On Fri, Mar 1, 2013 at 3:16 PM, Summers Pittman <supittma(a)redhat.com&gt; wrote: >> On 03/01/2013 07:16 AM, Matthias Wessendorf wrote: >>> On Fri, Mar 1, 2013 at 12:59 PM, Kris Borchers <kris(a)redhat.com&gt; wrote: >>>> On Mar 1, 2013, at 12:38 AM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: >>>> >>>>> On Fri, Mar 1, 2013 at 2:02 AM, Douglas Campos <qmx(a)qmx.me&gt; wrote: >>>>>> On 28/02/2013, at 20:07, Summers Pittman <supittma(a)redhat.com&gt; wrote: >>>>>> >>>>>>> aerogear-android-tests: This will house all of the Aerogear tests for >>>>>>> Android. >>>>>> You mean moving all the tests? Can't this be only for integration tests, and the unit tests stay on the aerogear-android project? >>>>> I'd also prefer to have the unit tests for each of the libs >>>>> (aerogear-android + aerogear-android-support) being in there. >>>> I can see one reason to have the unit tests in a separate project. I assume both aerogear-android and aerogear-android-support would have pretty much identical tests since their functionality should >>>> be the same, right? It would be a pain to have to maintain multiple sets of the same tests across projects. >>> Not sure about the details, BUT... you misread. >>> >>> Unit tests belong to the library. I am -1000 on having a 'unit test' >>> only broject. >>> >>> Integration tests are different, they _should_ be separated >> Integration tests also test on the underlying platform (IE the Android >> device). > of course :) never said anything against that :) > But... running them from an emulator, against a REAL server, is a > start for an integration test suite. > >> The unit tests for AG Android can stay with the project, > ok > >> but the number of tests in the project will go way down. > So you remove them ? Not sure I get that... (half) sentence; The project, aerogear-android will have fewer tests because only the unit ("pure java") tests will stay in it. Tests which use the integration server or the emulator (say anything with Loaders) will go in the ag-and-test project.

> >>> -M >>> >>>>> Only integration tests should be a totally independent project, >>>>> consuming the other libs (aerogear-android + aerogear-android-support) >>>>> and having tests against em. >>>>> >>>>> -M >>>>> >>>>> >>>>>> -- qmx >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> aerogear-dev mailing list >>>>>> aerogear-dev(a)lists.jboss.org >>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>>>> >>>>> -- >>>>> Matthias Wessendorf >>>>> >>>>> blog: http://matthiaswessendorf.wordpress.com/ >>>>> sessions: http://www.slideshare.net/mwessendorf >>>>> twitter: http://twitter.com/mwessendorf >>>>> _______________________________________________ >>>>> aerogear-dev mailing list >>>>> aerogear-dev(a)lists.jboss.org >>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>>> _______________________________________________ >>>> aerogear-dev mailing list >>>> aerogear-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev > > _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On 03/01/2013 06:59 AM, Kris Borchers wrote: > On Mar 1, 2013, at 12:38 AM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: > >> On Fri, Mar 1, 2013 at 2:02 AM, Douglas Campos <qmx(a)qmx.me&gt; wrote: >>> On 28/02/2013, at 20:07, Summers Pittman <supittma(a)redhat.com&gt; wrote: >>> >>>> aerogear-android-tests: This will house all of the Aerogear tests for >>>> Android. >>> You mean moving all the tests? Can't this be only for integration tests, and the unit tests stay on the aerogear-android project? >> I'd also prefer to have the unit tests for each of the libs >> (aerogear-android + aerogear-android-support) being in there. > I can see one reason to have the unit tests in a separate project. I assume both aerogear-android and aerogear-android-support would have pretty much identical tests since their functionality should be the same, right? It would be a pain to have to maintain multiple sets of the same tests across projects. This would be a benefit, yes.

>> Only integration tests should be a totally independent project, >> consuming the other libs (aerogear-android + aerogear-android-support) >> and having tests against em. >> >> -M >> >> >>> -- qmx >>> >>> >>> _______________________________________________ >>> aerogear-dev mailing list >>> aerogear-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> >> >> -- >> Matthias Wessendorf >> >> blog: http://matthiaswessendorf.wordpress.com/ >> sessions: http://www.slideshare.net/mwessendorf >> twitter: http://twitter.com/mwessendorf >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On 03/01/2013 09:24 AM, Matthias Wessendorf wrote: > On Fri, Mar 1, 2013 at 3:17 PM, Summers Pittman <supittma(a)redhat.com&gt; wrote: >> On 03/01/2013 06:59 AM, Kris Borchers wrote: >>> On Mar 1, 2013, at 12:38 AM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: >>> >>>> On Fri, Mar 1, 2013 at 2:02 AM, Douglas Campos <qmx(a)qmx.me&gt; wrote: >>>>> On 28/02/2013, at 20:07, Summers Pittman <supittma(a)redhat.com&gt; wrote: >>>>> >>>>>> aerogear-android-tests: This will house all of the Aerogear tests for >>>>>> Android. >>>>> You mean moving all the tests? Can't this be only for integration tests, and the unit tests stay on the aerogear-android project? >>>> I'd also prefer to have the unit tests for each of the libs >>>> (aerogear-android + aerogear-android-support) being in there. >>> I can see one reason to have the unit tests in a separate project. I assume both aerogear-android and aerogear-android-support would have pretty much identical tests since their functionality should be the same, right? It would be a pain to have to maintain multiple sets of the same tests across projects. >> This would be a benefit, yes. > ... ok - but I guess we have to be disciplined to exec. the tests... > It's too easy to forget that :) Not really, any decent build tool/IDE can be configured to run the test project with your code.

> > > -M > > > >>>> Only integration tests should be a totally independent project, >>>> consuming the other libs (aerogear-android + aerogear-android-support) >>>> and having tests against em. >>>> >>>> -M >>>> >>>> >>>>> -- qmx >>>>> >>>>> >>>>> _______________________________________________ >>>>> aerogear-dev mailing list >>>>> aerogear-dev(a)lists.jboss.org >>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>>> >>>> -- >>>> Matthias Wessendorf >>>> >>>> blog: http://matthiaswessendorf.wordpress.com/ >>>> sessions: http://www.slideshare.net/mwessendorf >>>> twitter: http://twitter.com/mwessendorf >>>> _______________________________________________ >>>> aerogear-dev mailing list >>>> aerogear-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>> _______________________________________________ >>> aerogear-dev mailing list >>> aerogear-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev > > _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On 28/02/2013, at 20:07, Summers Pittman <supittma(a)redhat.com&gt; wrote: > aerogear-android-tests: This will house all of the Aerogear tests for > Android. You mean moving all the tests? Can't this be only for integration tests, and the unit tests stay on the aerogear-android project?

-- qmx _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev