9:41 a.m.
https://hibernate.onjira.com/browse/HHH-6677
I don't find a elegant way to fix this….
one option is in org.hibernate.testing.junit4.CustomRunner#withBeforeClasses, we check if
the test class has @Skip (and @RequiresDialect etc.), and if it does, then return
super.withBeforeClasses directly (i know this is not a good way to do that)
any suggestions?
-----------
Strong Liu <stliu(a)hibernate.org>
http://hibernate.org
http://github.com/stliu
10:47 a.m.
Essentially you want to skip processing @BeforeClassOnce /
@AfterClassOnce if there are no test methods to execute for said class
being processed.
I think you should be able to call
org.hibernate.testing.junit4.CustomRunner#computeTestMethods to
accomplish this. If computeTestMethods returns no methods, there are
no test methods to be performed.
On Mon 26 Sep 2011 09:41:07 AM CDT, Strong Liu wrote:
https://hibernate.onjira.com/browse/HHH-6677
I don't find a elegant way to fix this….
one option is in org.hibernate.testing.junit4.CustomRunner#withBeforeClasses, we check if
the test class has @Skip (and @RequiresDialect etc.), and if it does, then return
super.withBeforeClasses directly (i know this is not a good way to do that)
any suggestions?
-----------
Strong Liu<stliu(a)hibernate.org>
http://hibernate.org
http://github.com/stliu
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
--
steve(a)hibernate.org
http://hibernate.org
11:05 a.m.
On Sep 26, 2011, at 11:47 PM, Steve Ebersole wrote:
Essentially you want to skip processing @BeforeClassOnce /
@AfterClassOnce if there are no test methods to execute for said class being processed.
Ideally, we should skip processing @BeforeClassOnce / @AfterClassOnce and @BeforeClass /
@AfterClass but for now skipping these two Once annotations should be fine, since all our
tests use those two in favor of junit ones.
I think you should be able to call
org.hibernate.testing.junit4.CustomRunner#computeTestMethods to accomplish this. If
computeTestMethods returns no methods, there are no test methods to be performed.
where should I call this method ? CustomRunner#withBeforeClasses?
as said in the jira comment , it would really great if we can plug into a custom
IgnoredBuilder into org.junit.internal.builders.AllDefaultPossibilitiesBuilder
On Mon 26 Sep 2011 09:41:07 AM CDT, Strong Liu wrote:
> https://hibernate.onjira.com/browse/HHH-6677
>
> I don't find a elegant way to fix this….
> one option is in org.hibernate.testing.junit4.CustomRunner#withBeforeClasses, we
check if the test class has @Skip (and @RequiresDialect etc.), and if it does, then return
super.withBeforeClasses directly (i know this is not a good way to do that)
>
> any suggestions?
>
> -----------
> Strong Liu<stliu(a)hibernate.org>
> http://hibernate.org
> http://github.com/stliu
>
>
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
--
steve(a)hibernate.org
http://hibernate.org
11:36 a.m.
> Essentially you want to skip processing @BeforeClassOnce /
@AfterClassOnce if there are no test methods to execute for said class being processed.
>
Ideally, we should skip processing @BeforeClassOnce / @AfterClassOnce and @BeforeClass /
@AfterClass but for now skipping these two Once annotations should be fine, since all our
tests use those two in favor of junit ones.
Understood, but I literally just copied that from your subject line ;)
> I think you should be able to call
org.hibernate.testing.junit4.CustomRunner#computeTestMethods to accomplish this. If
computeTestMethods returns no methods, there are no test methods to be performed.
where should I call this method ? CustomRunner#withBeforeClasses?
as said in the jira comment , it would really great if we can plug into a custom
IgnoredBuilder into org.junit.internal.builders.AllDefaultPossibilitiesBuilder
No idea about this AllDefaultPossibilitiesBuilder. Sounds more like a
question for the JUnit crowd. But in terms of calling
computeTestMethods, yes it would be done in withBeforeClasses *as well
as* in withAfterClasses. I was simply pointing out that that is better
than writing the skip-condition-detection logic again.
--
steve(a)hibernate.org
http://hibernate.org
4859
days inactive
4859
days old
3 comments
2 participants
participants (2)
-
Steve Ebersole -
Strong Liu