ORM release process feedback
by Guillaume Smet
Hi,
So I did an ORM release for the first time today. All in all, the process
is very clear and precise, thanks for taking the time to document it and
scripting it.
Here are the issues I had. Thought you should be aware of the changes I
made (I haven't fixed issue 2/ as I'm not sure it's legit).
== 1/ Bintray Gradle plugin issue
I had a few issues with Bintray though. The first run failed with:
> Could not upload to '
https://api.bintray.com/content/hibernate/artifacts/hibernate-orm/5.3.2.F...:
org/hibernate/value: hibernate-agroal/value: 5.3.2.Final/value:
hibernate-agroal-value: 5.3.2.Final.pom': HTTP/1.1 400 Bad Request
[message:Unable to upload files: Maven group, artifact or version defined
in the pom file do not match the file path 'value: org/hibernate/value:
hibernate-agroal/value: 5.3.2.Final/value: hibernate-agroal-value:
5.3.2.Final.pom']
I found https://github.com/bintray/gradle-bintray-plugin/issues/88 advising
to update the Bintray Gradle plugin so that's what I did.
It fixed the issue but apparently, the first attemps uploaded a weird
artifact named "value: org/hibernate/value: hibernate-agroal/value:
5.3.2.Final/value: hibernate-agroal-value: 5.3.2.Final.pom". Sanne removed
it.
== 2/ Tests running
As the first attempt was messy, I ran the second attempt with:
./gradlew clean release
It did the following:
- build the artifacts
- push them to Bintray
- run the tests
This is weird IMHO. Running the tests before pushing to Bintray could be
understandable but I find it weird they are run after the push.
Not very familiar with the build so just reporting it in case it would be
considered an issue.
== 3/ Super huge SourceForge archives
The archives on SourceForge were 350MB+ (thanks to Andrea for noticing it):
apparently, when working with Eclipse, some files end up in **/bin/
folders. While it's present in the .gitignore, it wasn't present in the
exclusions of the distribution. I added them.
I also had a ./build folder containing old WildFly releases. As it's added
to the .gitignore, I also excluded it from the build.
--
Guillaume
7 years, 8 months
ORM progress: tricky branch state
by Sanne Grinovero
On Hibernate ORM we're currently having "master" branch essentially
being a maintenance branch, aka master today is what's planned to be
version 5.3.2.Final in some days, 5.3.3 later, etc..
This is quite unusual, and it begs some extra attention: normally we'd
start a new minor in master, so that PRs of any kind could be welcome
in master, while specific, cherry-picked fixes are backported to the
last maintained minors.
This is not the case now and until we move on to a new minor or major
we'll need to be particularly careful about what is allowed to be
merged.
I'm not pointing fingers to any specific commit, my concern is just
raised by the high volume of changes being merged. They all look great
individually but changes are not good at this point :)
Not sure what to suggest to people wanting to contribute new features
today; maybe hold as we assume the 6.0 work will be merged in master
soon? Will be hard to say no to many reasonable requests though.
Steve, do you think that the 6.0 merge could happen soon enough to not
need any process changes in how we deal with master?
Thanks,
Sanne
7 years, 8 months
5.3 cache issues [Requires Steve]
by Guillaume Smet
Hi all,
So following our off-list discussions , I wanted to share a document we
wrote with Yoann with some details about the usability/compatibility of the
new cache implementation in 5.3:
https://docs.google.com/document/d/19xmsWlYOkXeAnZlEjcxFy6SUitxmT1JywoDyX...
(The document should be public and everyone should be able to comment)
We tried to be as detailed as possible. What we need to decide is in
bold/red as Actions.
The idea is to act on it for 5.3.2 so before Thursday. The PR for the first
issue is mostly ready but will require some tuning depending on our
decisions, we still need to work on the second one depending on the outcome.
Everyone interested/concerned, please step in so that we can reach a
consensus quickly and merge what is appropriate.
Thanks!
--
Guillaume
7 years, 8 months
