Hi,
Are we using Asciidoc javadoc in the current tree (i.e. not 6)?
With JDK 11, when ./gradlew :hibernate-core:javadoc is executed and this
doclet is enabled, I have the following error:
javadoc: error - invalid flag: -Xdoclint:none
In the javadoc -X help, it says that doclint is "Provided by the Standard
doclet".
Removing the asciidoclet declaration fixes the issue.
As asciidoclet is not enabled in the aggregateJavadocs task, I'm under the
impression that it is not used.
Could someone confirm this?
Thanks!
--
Guillaume
Hi,
So due to the issue with Asciidoclet I exposed in my previous email, I
thought for some time that they had removed the -XDoclint flag in Java 11.
Thus I started cleaning up all the Javadoc errors we have in the ORM source
code...
This led to the following changes:
https://github.com/hibernate/hibernate-orm/compare/master...gsmet:HHH-128...
.
It's kinda huge and while it's only trivial changes, I'm a bit worried
about what will happen when you will try to merge this in your 6 branch.
All the errors are fixed except:
- 3 reference not found errors for which I need advice
- the errors in the generated sources that are thrown in the
aggregateJavadocs task: the exclude rules are not taken into account by
Gradle in this task, probably a Gradle bug, I saw an old forum post of
Steve in the Gradle forum about this issue.
Note: I don't have any issue if we consider it's not the right time to do
that and we should only do that on 6. That's why I ask the question. I have
no idea of what the 6 branch look like so I don't know how much of an issue
it can be. Cherry-picking these changes on top of 6, once it's stabilized
is a possibility.
Thoughts?
--
Guillaume
I had a talk with Luis this morning with regard to the performance
benchmarks for 6 versus 5. He is working from 2 different benchmarks - one
simply compares parsing HQL (without executing it) and the other compares
certain operations (save/persist, load, etc). Luis, correct me if I am
wrong, but what I took away from the conversation is this:
1. For the operations benchmark the numbers for 6 were better than 5,
but within the error margin - so 6 is better-than-or-equal-to 5 here.
2. 6 was generally faster at parsing queries except for when it came to
interpreting paths. We need to address the paths problem, for sure, but
honestly I was not expecting any performance improvements in query parsing
- at least not initially and the primary focus of the work is in making the
executions more performant. Any improvements on query parsing performance
is cake at this point, though certainly something we want to look at.
I asked Luis to compare the numbers specifically for load operations in
that operations benchmark. That is really the only operations case where I
would expect perf improvements at this time - it should piggy-back on the
overall JDBC execution performance improvements.
Luis, I'd also like to get some simple HQL queries into that operations
benchmark if we could to verify that this ^^ happens there as well. I can
help with that if you want - let me know.
Barring any crazy outcomes from these new benchmark results, I feel
comfortable starting to plan an initial Alpha release schedule. We
currently have a fairly aggressive set of items to complete on our Alpha1
checklist[1][2]. I think we ought to consider paring that down in the
interest of release early, release often - having releases would help OGM,
etc integrate early and often as well. My proposal is to just implement
basic support for plural attributes in Alpha1 and push the rest to later
Alphas. E.g.:
1. Alpha1
1. plural attribute suppport
2. Alpha2
1. Any / ManyToAny support
2. Cascading
3. Alpha3
1. Metamodel fetching
2. JDBC batching
4. We'll see where we are...
IMO each Alpha ought to be 2 weeks, though I could live with 3 or
depending one everyone else's opinion.
Thoughts? Opinions?
[1]
https://github.com/sebersole/hibernate-core/blob/wip/6.0/design/6.0-todo....
[2] That list is somewhat out of date anyway as quite a few things listed
there are already implemented
She held suggestions to turn better the Hibernate documentation.
________________________________
From: Antônio Diego da Luz Silva <diego-luz(a)live.com>
Sent: Tuesday, July 10, 2018 5:33:20 PM
To: Vlad Mihalcea
Subject: Re: [hibernate-dev] Test
Thanks for the answer.
I sended one message before that and I haven't received answers.
________________________________
From: Vlad Mihalcea <mihalcea.vlad(a)gmail.com>
Sent: Tuesday, July 10, 2018 5:28:53 PM
To: Antônio Diego da Luz Silva
Subject: Re: [hibernate-dev] Test
Yes, we got your email.
Vlad
On Tue, 10 Jul 2018, 23:22 Antônio Diego da Luz Silva, <diego-luz(a)live.com<mailto:diego-luz@live.com>> wrote:
Are someone receiving my messages?
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org<mailto:hibernate-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/hibernate-dev
We would like to update WildFly (14) to Javassist 3.23.1, has anyone
tried using Javassist 3.23.1 with Hibernate ORM 5.3? I'd like to know
that we at least can pass the Javassist tests with the ORM testsuite,
preferably on JDK11 (since that is why we want to upgrade Javassist on
WildFly).
Thanks,
Scott
Hi,
When HHH-12054 was fixed (see
https://github.com/hibernate/hibernate-orm/pull/2042/files), we took into
account the fact that original and target could be set to
LazyPropertyInitializer.UNFETCHED_PROPERTY in the
AbstractStandardBasicType#getReplacement() method whereas we haven't
changed the prototype of the method.
Meaning we expect for instance LazyPropertyInitializer.UNFETCHED_PROPERTY
to be a T, which is not the case.
This led to ClassCastException such as in
https://hibernate.atlassian.net/browse/HHH-12555 . To be honest, I'm
wondering why we don't have more of them.
We have 2 ways of fixing this issue:
1- change the getReplacement() prototype to take Object parameters and
return an Object as the originating replace() method
2- move the LazyPropertyInitializer.UNFETCHED_PROPERTY logic up to
replace() and make getReplacement() a "I'm sure everything is OK, now get
me a clone of my original object" thing.
1- will obviously break compatibility with any user type extending
AbstractStandardBasicType#getReplacement(). 2- will slightly change the
meaning of replace() and getReplacement() and might lead to subtle behavior
changes in user applications.
2- also means that we would have to override both replace() and
getReplacement() in BlobType and allegates.
I pushed a commit for 1- at
https://github.com/gsmet/hibernate-orm/commit/73e66e40f3438794375451145af...
so that you can fully grasp the issue.
Not saying it's the path we should take.
Thoughts?
--
Guillaume
I think that will be good if it haves the advise of the need of put the cascade parameter on associations to cause the saving cascade effects on the child entitys.
Also, I think that will be good if it haves too the advise of the need of maps the entities which are subclasses of entities to use them.
Also, the orphanRemoval parameter not worked without the parent entity update operation with Hibernate native apis. This seems to be unlike that that is on Documentation.