Re: HHH-6221 foreign keys with shared columns
by Jason Pyeron
Has there been any thoughts on this issue?
The mitigation(below email) does not work for a more fringe case discovered today:
Class A
{
@Id
@ManyToOne
B src
@Id
@ManyToOne
B target
String data
}
Class B
{
@Id
@ManyToOne
C c
@Id
Long id
}
create table A
(
b_id_c_1 bigint not null,
b_id_c_2 bigint not null,
b_id_src bigint not null,
b_id_target bigint not null,
data varchar(max) null,
primary key (b_id_c_1, b_id_c_2,b_id_src,b_id_target),
foreign key (b_id_c_1, b_id_c_2,b_id_src) references B(b_id_c_1, b_id_c_2, b_id),
foreign key (b_id_c_1, b_id_c_2,b_id_target) references B(b_id_c_1, b_id_c_2, b_id)
);
Also worth mentioning that the mitigation below requires manual re-setting of the ManyToOne properties after the referenced object is persisted.
From: Jason Pyeron [mailto:jpyeron@pdinc.us]
Sent: Sunday, May 24, 2020 1:09 PM
To: INTERNAL
Subject: RE: HHH-6221 foreign keys with shared columns
@ManyToOne
@JoinColumns
({
@JoinColumn(name = "request_id", referencedColumnName = "request_id", insertable = false, updatable = false),
@JoinColumn(name = "parent", referencedColumnName = "id"/*, insertable = false, updatable = false*/)
})
public Signature getParent()
{
return this.parent;
}
And
public static void checkPropertyConsistency(Ejb3Column[] columns, String propertyName) {
int nbrOfColumns = columns.length;
if ( nbrOfColumns > 1 ) {
for (int currentIndex = 1; currentIndex < nbrOfColumns; currentIndex++) {
if (columns[currentIndex].isFormula() || columns[currentIndex - 1].isFormula()) {
continue;
}
/* if ( columns[currentIndex].isInsertable() != columns[currentIndex - 1].isInsertable() ) {
throw new AnnotationException(
"Mixing insertable and non insertable columns in a property is not allowed: " + propertyName
);
}*/
if ( columns[currentIndex].isNullable() != columns[currentIndex - 1].isNullable() ) {
throw new AnnotationException(
"Mixing nullable and non nullable columns in a property is not allowed: " + propertyName
);
}
/* if ( columns[currentIndex].isUpdatable() != columns[currentIndex - 1].isUpdatable() ) {
throw new AnnotationException(
"Mixing updatable and non updatable columns in a property is not allowed: " + propertyName
);
}*/
if ( !columns[currentIndex].getTable().equals( columns[currentIndex - 1].getTable() ) ) {
throw new AnnotationException(
"Mixing different tables in a property is not allowed: " + propertyName
);
}
}
}
}
Does not work…
Hibernate:
insert
into
REDACTED
(a, b, c, d, e, f, g, h, i, j, id, request_id)
values
(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
Where as
@ManyToOne
@JoinColumns
({
@JoinColumn(name = "request_id", referencedColumnName = "request_id", insertable = false, updatable = false),
@JoinColumn(name = "parent", referencedColumnName = "id", insertable = false, updatable = false)
})
public Signature getParent()
{
return this.parent;
}
public void setParent(final Signature parent)
{
this.parent = parent;
setParent2115(parent == null ? null : parent.getId());
}
Hibernate:
insert
into
REDACTED
(a, b, c, d, parent, e, f, g, h, i, j, id, request_id)
values
(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
Works.
From: Jason Pyeron [mailto:jpyeron@pdinc.us]
Sent: Friday, May 22, 2020 12:49 PM
To: 'Hibernate Dev' <hibernate-dev(a)lists.jboss.org>
Subject: HHH-6221 foreign keys with shared columns
I have been hunting around this morning trying to mitigate some issues of our schema and JPA mapping and https://hibernate.atlassian.net/browse/HHH-6221 seems most related.
This is a specific case following on §2.4.1 and the other bugs I have worked with recently.
Is there any more history on this bug than is in the comments of it and the related tickets? We are going to have to dive in and fix and was hoping to have a good survey of the landscape first.
We will make test case(s) along with some patches.
--- BREAK ---
Tracking internally as https://projects.pdinc.us/show_bug.cgi?id=2115 .
In our codebase we got here because of (edited for clarity)
@ManyToOne
@JoinColumns
({
@JoinColumn(name = "id", referencedColumnName = "request_id", insertable = false, updatable = false),
@JoinColumn(name = "head", referencedColumnName = "id")
})
Signature head;
@Id
@GeneratedValue(strategy = GenerationType.SEQUENCE)
Long id;
Repeated column in mapping for entity: Entity column: column (should be mapped with insert="false" update="false")
Which then leads to
Mixing insertable and non insertable columns in a property is not allowed: Entity.column
at org.hibernate.cfg.Ejb3Column.checkPropertyConsistency(Ejb3Column.java:718)
At this moment, using the following workaround:
@ManyToOne
@JoinColumns
({
@JoinColumn(name = "id", referencedColumnName = "request_id", insertable = false, updatable = false),
@JoinColumn(name = "head", referencedColumnName = "id", insertable = false, updatable = false)
})
Signature head;
public void setHead(Signature head)
{
this.head = head;
// https://stackoverflow.com/a/49019669/58794
head2115 = head == null ? null : head.getId();
}
private Long head2115;
@Column(name = "head")
private Long getHead2115()
{
return head2115;
}
Note: JoinFormula workaround is doubly not acceptable – 1. Nonstandard, 2. org.hibernate.mapping.Formula cannot be cast to org.hibernate.mapping.Column
3 years, 11 months
- 1
- 0
JDK 16 is in Rampdown Phase One
by Rory O'Donnell
Hi Sanne & Yoann,
*Per the JDK 16 schedule , we are in Rampdown Phase One* *[1] .
*
*Please advise if you find any issues while testing the latest Early
Access builds.*
* Schedule for JDK 16
o *2020/12/10 Rampdown Phase One*
o 2021/01/14 Rampdown Phase Two
o 2021/02/04 Initial Release Candidate
o 2021/02/18 Final Release Candidate
o 2021/03/16 General Availability
* Release Notes [2]
OpenJDK 16 Early Access build 28**is now available at
http://jdk.java.net/16
* Features - the overall feature set is frozen. No further JEPs will
be targeted to this release.
* Significant Integrations in b28:
o *Integrated JEP 396: **Strongly Encapsulate JDK Internals by
Default <https://openjdk.java.net/jeps/396>**
*
+ Strongly encapsulate all internal elements of the JDK by
default, except for critical internal APIs
<https://openjdk.java.net/jeps/260#Description> such as
|sun.misc.Unsafe|.
+ Allow end users to choose the relaxed strong encapsulation
that has been the default since JDK 9.
o Integrated JEP 397: Sealed Classes (Second Preview)
<https://openjdk.java.net/jeps/397> with this release.
+ Enhance the Java programming language with sealed classes
and interfaces
<https://cr.openjdk.java.net/~briangoetz/amber/datum.html>.
+ Refines JEP 360 <https://openjdk.java.net/jeps/360> which
was delivered in JDK 15 as a preview feature.
* These early-access , open-source builds are provided under the GNU
General Public License, version 2, with the Classpath Exception
<http://openjdk.java.net/legal/gplv2+ce.html>.
* Changes in recent builds that maybe of interest:
o Build 28
+ JDK-8256299: JEP 396: Strongly Encapsulate JDK Internals by
Default
+ JDK-8166596: TLS support for the EdDSA signature algorithm
+ JDK-8256718: Old tracing flags are now obsolete and must be
replaced with unified logging
o Build 27
+ JDK-8159746: (proxy) Support for default methods
+ JDK-8254631: Better support ALPN byte wire values in SunJSSE
Project Loom Early-Access: *Build 16-loom+9-316
<http://jdk.java.net/loom/>* (2020/11/30) - based on JDK-16+25
<https://github.com/openjdk/jdk/releases/tag/jdk-16%2B25>
* These early-access builds are provided under the GNU General Public
License, version 2, with the Classpath Exception
<http://openjdk.java.net/legal/gplv2+ce.html>
* These builds are intended for developers looking to "kick the tyres"
and provide feedback on using the API or by sending bug reports.
* Please send feedback via e-mail to loom-dev(a)openjdk.java.net
<mailto:loom-dev@openjdk.java.net>. To send e-mail to this address
you must first subscribe to the mailing list
<http://mail.openjdk.java.net/mailman/listinfo/loom-dev>.
Rgds, Rory
[1]
https://mail.openjdk.java.net/pipermail/jdk-dev/2020-December/004991.html
[2] https://jdk.java.net/16/release-notes
3 years, 11 months
- 2
- 2
Hibernate Search 6.0.0.Final is out!
by Yoann Rodiere
Hello,
We just published the first stable release of Hibernate Search 6: version
6.0.0.Final.
With more than 900 tickets addressed
<https://hibernate.atlassian.net/issues/?jql=project%20%3D%20HSEARCH%20AND...>
over the course of 20 alphas and betas, Hibernate Search 6 really is a
major release, and it shows.
The most obvious changes: an overhauled API better suited to working with
Elasticsearch (but that still works perfectly with embedded Lucene), and
upgrades from Lucene 5 to 8 and from Elasticsearch 5.6 to 7.
But it doesn’t stop there: a safer and more concise Search DSL, easier
mapping, more powerful bridges, smarter automatic indexing, nested
documents, …
For more information (what's new, getting started, migrating, ...), see our
blog:
https://in.relation.to/2020/12/11/hibernate-search-6-0-0-Final/
Yoann Rodière
Hibernate Team
yoann(a)hibernate.org
3 years, 11 months
- 4
- 3
Hibernate ORM 5.4.25.Final released
by Jan Schatteman
Hi all,
Hibernate ORM version 5.4.25.Final has been released!
For details, check out
https://in.relation.to/2020/12/01/hibernate-orm-5425-final-release/
Thanks!
Jan Schatteman
"Stay calm and Hibernate"
Red Hat <https://www.redhat.com/>
<https://red.ht/sig>
3 years, 11 months
- 1
- 0
- ← Newer
- 1
- Older →