Re: [hibernate-dev] CDI / ORM / WildFly / Search integration plumbing
Hi Sanne,
Do you have a WFLY issue for this?
I've tentatively created a branch and pushed a commit to my fork that
reproduces this issue. [1]
It reproduces using Hibernate 5.1.11-SNAPSHOT and 5.2.11-SNAPSHOT.
In 5.1, org.hibernate.jpa.test.cdi.ExtendedBeanManagerCdiTest uses an
implementation, ExtendedBeanManagerImpl [2], that implements both
BeanManager, ExtendedBeanManager.
I don't see this test in 5.2, and I don't see any implementation of
ExtendedBeanManager in 5.2. I do see tests
in org.hibernate.jpa.test.cdi.extended, but have not had a chance to look
at those yet.
I suspect that org.jboss.as.jpa.hibernate5.HibernateExtendedBeanManager
should implement javax.enterprise.inject.spi.BeanManager as well. I tried
making this change, and having BeanManager methods delegate to
HibernateExtendedBeanManager#beanManager,
but it looks like a dependency is missing, because javax.el.ELResolver
and javax.el.ExpressionFactory are unresolved.
Please let me know if I'm on the right (or wrong) track. I'll pick this up
tomorrow.
Regards,
Gail
[1] https://github.com/gbadner/wildfly/tree/WFLY-CCE-bug
[2]
https://github.com/hibernate/hibernate-orm/blob/5.1/hibernate-entitymanag...
On Tue, Aug 29, 2017 at 8:18 AM, Sanne Grinovero <sanne(a)hibernate.org>
wrote:
Hi all,
In Hibernate Search we have a snippet of code doing:
private static BeanManager getBeanManager(Map<?, ?> configurationValues) {
return (BeanManager) configurationValues.get(
AvailableSettings.CDI_BEAN_MANAGER );
}
This used to work on WildFly 10 - even if we were to override the
Hibernate ORM version to 5.2.
By runnning the same integration test on WildFly 11 I'm now getting a
ClassCastException as the returned instance is of type
`org.jboss.as.jpa.hibernate5.HibernateExtendedBeanManager`, which does
implement `org.hibernate.jpa.event.spi.jpa.ExtendedBeanManager` but
does not implement the standard
`javax.enterprise.inject.spi.BeanManager` interface.
I'm unsure if this is a bug in the Search code or a misunderstanding
between the WildFly / ORM integration?
This javadoc seems relevant:
/**
* Used to pass along the CDI BeanManager, if any, to be used.
*/
String CDI_BEAN_MANAGER = "javax.persistence.bean.manager";
or should I interpret this property as meant only for "write" purposes
into the ORM configuration? I suppose it's unexpected that we attempt
to retrieve this as well.
Thanks,
Sanne
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev