1:44 p.m.
I think the BoostStrategy interface is not right.
You can't adjust the boost strategy according to the field name and I
think that's important (assuming dynamic boosting is used).
We probably should rework it to do
interface BoostStrategy {
void defineBoost(String fieldName, Object value);
}
WDYT?
3:04 p.m.
Is that possible?
I couldn't find the method in Lucene to boost per field, I've only
looked briefly into 2.9.1.
The BoostStrategy we had defined is only considered at indexing time,
are you thinking about a query time boosting?
Would be nice to consider this for the QueryBuilder.
Regards,
Sanne
2009/12/4 Emmanuel Bernard <emmanuel(a)hibernate.org>:
I think the BoostStrategy interface is not right.
You can't adjust the boost strategy according to the field name and I
think that's important (assuming dynamic boosting is used).
We probably should rework it to do
interface BoostStrategy {
void defineBoost(String fieldName, Object value);
}
WDYT?
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
4:33 p.m.
I'm pretty sure you can, we do dynamic boosting like a regular @Boost
On 4 déc. 09, at 15:04, Sanne Grinovero wrote:
Is that possible?
I couldn't find the method in Lucene to boost per field, I've only
looked briefly into 2.9.1.
The BoostStrategy we had defined is only considered at indexing time,
are you thinking about a query time boosting?
Would be nice to consider this for the QueryBuilder.
Regards,
Sanne
2009/12/4 Emmanuel Bernard <emmanuel(a)hibernate.org>:
> I think the BoostStrategy interface is not right.
> You can't adjust the boost strategy according to the field name and I
> think that's important (assuming dynamic boosting is used).
>
> We probably should rework it to do
>
> interface BoostStrategy {
> void defineBoost(String fieldName, Object value);
> }
>
> WDYT?
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
4:23 p.m.
Hi,
I am not quite sure I follow. Why fieldname? And do you mean Lucene
Document field name or
a entity field name?
I think originally we discussed defineBoost(String fieldName, Object
value), but decided that
the fieldName parameter was not needed.
You can place the @DynamicBoost annotation on class or field level. On
class level you define a
dynamic boost for the whole entity and on field level just for this field.
Do you want to be able
to place a @DynamicBoost on class level and call for each indexed field
defineBoost(String fieldName, Object value),
where fieldName would be the current index field name and value the
indexed entity?
One thing we have not done though is to add @DynamicBoost to @Field. Right
now you can only
specify @DynamicBoost directly on a field and the dynamic boost will apply
to all @Field annotations defined
on this field.
--Hardy
On Fri, 04 Dec 2009 09:44:30 -0300, Emmanuel Bernard
<emmanuel(a)hibernate.org> wrote:
I think the BoostStrategy interface is not right.
You can't adjust the boost strategy according to the field name and I
think that's important (assuming dynamic boosting is used).
We probably should rework it to do
interface BoostStrategy {
void defineBoost(String fieldName, Object value);
}
WDYT?
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
4:33 p.m.
On 4 déc. 09, at 16:23, Hardy Ferentschik wrote:
One thing we have not done though is to add @DynamicBoost to @Field.
Right now you can only
specify @DynamicBoost directly on a field and the dynamic boost will
apply to all @Field annotations defined
on this field.
Yes that would solve the problem too.
4:35 p.m.
On 4 déc. 09, at 16:33, Emmanuel Bernard wrote:
On 4 déc. 09, at 16:23, Hardy Ferentschik wrote:
> One thing we have not done though is to add @DynamicBoost to @Field.
> Right now you can only
> specify @DynamicBoost directly on a field and the dynamic boost will
> apply to all @Field annotations defined
> on this field.
Yes that would solve the problem too.
But then, would it make sense to reuse @Boost instead of a separated
annotation as it is today?
4:51 p.m.
On Fri, 04 Dec 2009 12:35:51 -0300, Emmanuel Bernard
<emmanuel(a)hibernate.org> wrote:
But then, would it make sense to reuse @Boost instead of a separated
annotation as it is today?
The main reason for using an explicit @Dynamic boost was to be more
explicit.
Using @Boost means we need to add another parameter 'boostStrategyImpl'
which would
default to DefaultBoostStrategy.
The question is then what you do if someone specifies a boost value, eg
2.0f together
with a CustomBoostStrategy? Throw an exception, print a warning, apply
both? I guess
we would have to apply both, so effectively you define two boost values
with the same
annotation.
Both solutions - standalone @DynamicBoost or dynamic boosting rolled into
@Boost - have
their pro and cons. Personally I lean towards @DynamicBoost at the moment.
--Hardy
5:20 p.m.
On 4 déc. 09, at 16:51, Hardy Ferentschik wrote:
On Fri, 04 Dec 2009 12:35:51 -0300, Emmanuel Bernard
<emmanuel(a)hibernate.org> wrote:
> But then, would it make sense to reuse @Boost instead of a separated
> annotation as it is today?
The main reason for using an explicit @Dynamic boost was to be more
explicit.
Using @Boost means we need to add another parameter
'boostStrategyImpl'
which would
default to DefaultBoostStrategy.
The question is then what you do if someone specifies a boost value,
eg
2.0f together
with a CustomBoostStrategy? Throw an exception, print a warning, apply
both? I guess
we would have to apply both, so effectively you define two boost
values
with the same
annotation.
Both solutions - standalone @DynamicBoost or dynamic boosting rolled
into
@Boost - have
their pro and cons. Personally I lean towards @DynamicBoost at the
moment.
Right good summary,
But adding @DynamicBoost in @Field will be fugly and raises the same
problems.
4:36 p.m.
Hardy,
I don't think setting @DynamicBoost on a field will affect the score
of that field, but rather receive that object as a parameter for the
function and affect the whole document scoring.
That's about the current implementation; I'm still unsure that's
possible to do differently.
2009/12/4 Hardy Ferentschik <hibernate(a)ferentschik.de>:
Hi,
I am not quite sure I follow. Why fieldname? And do you mean Lucene
Document field name or
a entity field name?
I think originally we discussed defineBoost(String fieldName, Object
value), but decided that
the fieldName parameter was not needed.
You can place the @DynamicBoost annotation on class or field level. On
class level you define a
dynamic boost for the whole entity and on field level just for this field.
Do you want to be able
to place a @DynamicBoost on class level and call for each indexed field
defineBoost(String fieldName, Object value),
where fieldName would be the current index field name and value the
indexed entity?
One thing we have not done though is to add @DynamicBoost to @Field. Right
now you can only
specify @DynamicBoost directly on a field and the dynamic boost will apply
to all @Field annotations defined
on this field.
--Hardy
On Fri, 04 Dec 2009 09:44:30 -0300, Emmanuel Bernard
<emmanuel(a)hibernate.org> wrote:
> I think the BoostStrategy interface is not right.
> You can't adjust the boost strategy according to the field name and I
> think that's important (assuming dynamic boosting is used).
>
> We probably should rework it to do
>
> interface BoostStrategy {
> void defineBoost(String fieldName, Object value);
> }
>
> WDYT?
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
4:40 p.m.
The altered boost is passed to the bridge as one of the LuceneOptions.
On 4 déc. 09, at 16:36, Sanne Grinovero wrote:
Hardy,
I don't think setting @DynamicBoost on a field will affect the score
of that field, but rather receive that object as a parameter for the
function and affect the whole document scoring.
That's about the current implementation; I'm still unsure that's
possible to do differently.
2009/12/4 Hardy Ferentschik <hibernate(a)ferentschik.de>:
> Hi,
>
> I am not quite sure I follow. Why fieldname? And do you mean Lucene
> Document field name or
> a entity field name?
>
> I think originally we discussed defineBoost(String fieldName, Object
> value), but decided that
> the fieldName parameter was not needed.
>
> You can place the @DynamicBoost annotation on class or field level.
> On
> class level you define a
> dynamic boost for the whole entity and on field level just for this
> field.
> Do you want to be able
> to place a @DynamicBoost on class level and call for each indexed
> field
> defineBoost(String fieldName, Object value),
> where fieldName would be the current index field name and value the
> indexed entity?
>
> One thing we have not done though is to add @DynamicBoost to
> @Field. Right
> now you can only
> specify @DynamicBoost directly on a field and the dynamic boost
> will apply
> to all @Field annotations defined
> on this field.
>
> --Hardy
>
> On Fri, 04 Dec 2009 09:44:30 -0300, Emmanuel Bernard
> <emmanuel(a)hibernate.org> wrote:
>
>> I think the BoostStrategy interface is not right.
>> You can't adjust the boost strategy according to the field name
>> and I
>> think that's important (assuming dynamic boosting is used).
>>
>> We probably should rework it to do
>>
>> interface BoostStrategy {
>> void defineBoost(String fieldName, Object value);
>> }
>>
>> WDYT?
>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
4:46 p.m.
Ah yes thanks I found it.
It's only being used by the String2FieldBridgeAdaptor ? So boosting on
other types is ignored?
Yes embedding the functonality in existing @Boost was something we had
proposed on mailing list, but it probably didn't got much attention.
What I recall is something like this:
@Boost(float staticBoost, BoostStrategy dynamicStrategy)
and have a default implementation for dynamicStrategy to say "return 1".
should also be backwards compatible that way.
WDYT?
2009/12/4 Emmanuel Bernard <emmanuel(a)hibernate.org>:
The altered boost is passed to the bridge as one of the
LuceneOptions.
On 4 déc. 09, at 16:36, Sanne Grinovero wrote:
> Hardy,
> I don't think setting @DynamicBoost on a field will affect the score
> of that field, but rather receive that object as a parameter for the
> function and affect the whole document scoring.
> That's about the current implementation; I'm still unsure that's
> possible to do differently.
>
> 2009/12/4 Hardy Ferentschik <hibernate(a)ferentschik.de>:
>>
>> Hi,
>>
>> I am not quite sure I follow. Why fieldname? And do you mean Lucene
>> Document field name or
>> a entity field name?
>>
>> I think originally we discussed defineBoost(String fieldName, Object
>> value), but decided that
>> the fieldName parameter was not needed.
>>
>> You can place the @DynamicBoost annotation on class or field level. On
>> class level you define a
>> dynamic boost for the whole entity and on field level just for this
>> field.
>> Do you want to be able
>> to place a @DynamicBoost on class level and call for each indexed field
>> defineBoost(String fieldName, Object value),
>> where fieldName would be the current index field name and value the
>> indexed entity?
>>
>> One thing we have not done though is to add @DynamicBoost to @Field.
>> Right
>> now you can only
>> specify @DynamicBoost directly on a field and the dynamic boost will
>> apply
>> to all @Field annotations defined
>> on this field.
>>
>> --Hardy
>>
>> On Fri, 04 Dec 2009 09:44:30 -0300, Emmanuel Bernard
>> <emmanuel(a)hibernate.org> wrote:
>>
>>> I think the BoostStrategy interface is not right.
>>> You can't adjust the boost strategy according to the field name and I
>>> think that's important (assuming dynamic boosting is used).
>>>
>>> We probably should rework it to do
>>>
>>> interface BoostStrategy {
>>> void defineBoost(String fieldName, Object value);
>>> }
>>>
>>> WDYT?
>>> _______________________________________________
>>> hibernate-dev mailing list
>>> hibernate-dev(a)lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>
>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>
5534
days inactive
5534
days old
11 comments
3 participants
participants (3)
-
Emmanuel Bernard -
Hardy Ferentschik -
Sanne Grinovero