1:01 p.m.
Hi all,
I was looking in the ApplyDeltaCommand code and I found something
strange. Why is the method getAffectedKeys() returning a singleton
collection with a null key inside?
Shouldn't be supposed to return a singleton collection with
deltaAwareValueKey or the keys collection?
Thanks!
Cheers
Pedro Ruivo
2:07 p.m.
Hi Pedro,
I found this odd too a few months ago while working on state transfer
and added a TODO in the constructor (which should pass the
deltaAwareValueKey to super) planning to ask and fix it later, but this
never happened. Maybe Vladimir knows more about this?
Cheers!
On 01/23/2013 09:01 PM, Pedro Ruivo wrote:
Hi all,
I was looking in the ApplyDeltaCommand code and I found something
strange. Why is the method getAffectedKeys() returning a singleton
collection with a null key inside?
Shouldn't be supposed to return a singleton collection with
deltaAwareValueKey or the keys collection?
Thanks!
Cheers
Pedro Ruivo
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
2:36 p.m.
speaking of ApplyDeltaCommand - where does it actually perform the delta
operation? perform() simply returns null. Any pointers?
Thanks,
On Wed, Jan 23, 2013 at 12:07 PM, Adrian Nistor <anistor(a)redhat.com> wrote:
Hi Pedro,
I found this odd too a few months ago while working on state transfer
and added a TODO in the constructor (which should pass the
deltaAwareValueKey to super) planning to ask and fix it later, but this
never happened. Maybe Vladimir knows more about this?
Cheers!
On 01/23/2013 09:01 PM, Pedro Ruivo wrote:
> Hi all,
>
> I was looking in the ApplyDeltaCommand code and I found something
> strange. Why is the method getAffectedKeys() returning a singleton
> collection with a null key inside?
>
> Shouldn't be supposed to return a singleton collection with
> deltaAwareValueKey or the keys collection?
>
> Thanks!
>
> Cheers
> Pedro Ruivo
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
3:02 p.m.
On 13-01-23 3:36 PM, Ray Tsang wrote:
speaking of ApplyDeltaCommand - where does it actually perform the
delta operation? perform() simply returns null. Any pointers?
Thanks,
Look for use of ApplyDeltaCommand class in IDE (in Eclipse highlight
class name + right click + References->Workspace)
Current uses I found are in EntryWrappingInterceptor,
OptimisticLockingInterceptor and so on....
Regards,
Vladimir
6:01 a.m.
I believe this is what you guys are looking for.
https://github.com/infinispan/infinispan/blob/master/core/src/main/java/o...
On 23 Jan 2013, at 21:02, Vladimir Blagojevic <vblagoje(a)redhat.com> wrote:
On 13-01-23 3:36 PM, Ray Tsang wrote:
> speaking of ApplyDeltaCommand - where does it actually perform the
> delta operation? perform() simply returns null. Any pointers?
>
> Thanks,
Look for use of ApplyDeltaCommand class in IDE (in Eclipse highlight
class name + right click + References->Workspace)
Current uses I found are in EntryWrappingInterceptor,
OptimisticLockingInterceptor and so on....
Regards,
Vladimir
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Manik Surtani
manik(a)jboss.org
twitter.com/maniksurtani
Platform Architect, JBoss Data Grid
http://red.ht/data-grid
6:04 a.m.
Sorry, I misread the question - the link below shows how Deltas are applied when a delta
is shipped around as a part of a put(). If you are explicitly using the
ApplyDeltaCommand, this is Vlad's code and he should know.
I could trace through usage in my IDE but then so could anybody - Vlad, do you have any
specific insight to add here?
Cheers
Manik
On 24 Jan 2013, at 12:01, Manik Surtani <manik(a)jboss.org> wrote:
I believe this is what you guys are looking for.
https://github.com/infinispan/infinispan/blob/master/core/src/main/java/o...
On 23 Jan 2013, at 21:02, Vladimir Blagojevic <vblagoje(a)redhat.com> wrote:
> On 13-01-23 3:36 PM, Ray Tsang wrote:
>> speaking of ApplyDeltaCommand - where does it actually perform the
>> delta operation? perform() simply returns null. Any pointers?
>>
>> Thanks,
> Look for use of ApplyDeltaCommand class in IDE (in Eclipse highlight
> class name + right click + References->Workspace)
> Current uses I found are in EntryWrappingInterceptor,
> OptimisticLockingInterceptor and so on....
>
> Regards,
> Vladimir
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Manik Surtani
manik(a)jboss.org
twitter.com/maniksurtani
Platform Architect, JBoss Data Grid
http://red.ht/data-grid
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Manik Surtani
manik(a)jboss.org
twitter.com/maniksurtani
Platform Architect, JBoss Data Grid
http://red.ht/data-grid
11:19 a.m.
Ah that explains it!
Btw - after the delta, in replicated/distributed cache, does it send over
the whole object or just the deltas? I'm assuming the former.
Thanks!
On Thu, Jan 24, 2013 at 4:04 AM, Manik Surtani <manik(a)jboss.org> wrote:
Sorry, I misread the question - the link below shows how Deltas are
applied when a delta is shipped around as a part of a put(). If you are
explicitly using the ApplyDeltaCommand, this is Vlad's code and he should
know.
I could trace through usage in my IDE but then so could anybody - Vlad, do
you have any specific insight to add here?
Cheers
Manik
On 24 Jan 2013, at 12:01, Manik Surtani <manik(a)jboss.org> wrote:
> I believe this is what you guys are looking for.
>
>
https://github.com/infinispan/infinispan/blob/master/core/src/main/java/o...
>
>
> On 23 Jan 2013, at 21:02, Vladimir Blagojevic <vblagoje(a)redhat.com>
wrote:
>
>> On 13-01-23 3:36 PM, Ray Tsang wrote:
>>> speaking of ApplyDeltaCommand - where does it actually perform the
>>> delta operation? perform() simply returns null. Any pointers?
>>>
>>> Thanks,
>> Look for use of ApplyDeltaCommand class in IDE (in Eclipse highlight
>> class name + right click + References->Workspace)
>> Current uses I found are in EntryWrappingInterceptor,
>> OptimisticLockingInterceptor and so on....
>>
>> Regards,
>> Vladimir
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
> --
> Manik Surtani
> manik(a)jboss.org
> twitter.com/maniksurtani
>
> Platform Architect, JBoss Data Grid
> http://red.ht/data-grid
>
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Manik Surtani
manik(a)jboss.org
twitter.com/maniksurtani
Platform Architect, JBoss Data Grid
http://red.ht/data-grid
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
11:42 a.m.
Should be just the deltas. That was the whole point after all :-)
Regards,
Vladimir
On 13-01-24 12:19 PM, Ray Tsang wrote:
Ah that explains it!
Btw - after the delta, in replicated/distributed cache, does it send
over the whole object or just the deltas? I'm assuming the former.
Thanks!
On Thu, Jan 24, 2013 at 4:04 AM, Manik Surtani <manik(a)jboss.org
<mailto:manik@jboss.org>> wrote:
Sorry, I misread the question - the link below shows how Deltas
are applied when a delta is shipped around as a part of a put().
If you are explicitly using the ApplyDeltaCommand, this is Vlad's
code and he should know.
I could trace through usage in my IDE but then so could anybody -
Vlad, do you have any specific insight to add here?
Cheers
Manik
On 24 Jan 2013, at 12:01, Manik Surtani <manik(a)jboss.org
<mailto:manik@jboss.org>> wrote:
> I believe this is what you guys are looking for.
>
>
https://github.com/infinispan/infinispan/blob/master/core/src/main/java/o...
>
>
> On 23 Jan 2013, at 21:02, Vladimir Blagojevic
<vblagoje(a)redhat.com <mailto:vblagoje@redhat.com>> wrote:
>
>> On 13-01-23 3:36 PM, Ray Tsang wrote:
>>> speaking of ApplyDeltaCommand - where does it actually perform the
>>> delta operation? perform() simply returns null. Any pointers?
>>>
>>> Thanks,
>> Look for use of ApplyDeltaCommand class in IDE (in Eclipse
highlight
>> class name + right click + References->Workspace)
>> Current uses I found are in EntryWrappingInterceptor,
>> OptimisticLockingInterceptor and so on....
>>
>> Regards,
>> Vladimir
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev(a)lists.jboss.org
<mailto:infinispan-dev@lists.jboss.org>
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
> --
> Manik Surtani
> manik(a)jboss.org <mailto:manik@jboss.org>
> twitter.com/maniksurtani <http://twitter.com/maniksurtani>
>
> Platform Architect, JBoss Data Grid
> http://red.ht/data-grid
>
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev(a)lists.jboss.org
<mailto:infinispan-dev@lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Manik Surtani
manik(a)jboss.org <mailto:manik@jboss.org>
twitter.com/maniksurtani <http://twitter.com/maniksurtani>
Platform Architect, JBoss Data Grid
http://red.ht/data-grid
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org <mailto:infinispan-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/infinispan-dev
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
11:52 a.m.
Actually, it is both, depending upon the situation.
When a new process is started and joins the cluster, the new process will via state
transfer receive its entries as externalized whole values, not deltas. However, from that
point forward, I believe that all changes to a DeltaAware entry will be sent to other
processes in the cluster via the delta.
This is fairly obvious if you think about it.
On Jan 24, 2013, at 11:42 AM, Vladimir Blagojevic <vblagoje(a)redhat.com> wrote:
Should be just the deltas. That was the whole point after all :-)
Regards,
Vladimir
On 13-01-24 12:19 PM, Ray Tsang wrote:
> Ah that explains it!
>
> Btw - after the delta, in replicated/distributed cache, does it send over the whole
object or just the deltas? I'm assuming the former.
>
> Thanks!
>
> On Thu, Jan 24, 2013 at 4:04 AM, Manik Surtani <manik(a)jboss.org> wrote:
> Sorry, I misread the question - the link below shows how Deltas are applied when a
delta is shipped around as a part of a put(). If you are explicitly using the
ApplyDeltaCommand, this is Vlad's code and he should know.
>
> I could trace through usage in my IDE but then so could anybody - Vlad, do you have
any specific insight to add here?
>
> Cheers
> Manik
>
> On 24 Jan 2013, at 12:01, Manik Surtani <manik(a)jboss.org> wrote:
>
> > I believe this is what you guys are looking for.
> >
> >
https://github.com/infinispan/infinispan/blob/master/core/src/main/java/o...
> >
> >
> > On 23 Jan 2013, at 21:02, Vladimir Blagojevic <vblagoje(a)redhat.com>
wrote:
> >
> >> On 13-01-23 3:36 PM, Ray Tsang wrote:
> >>> speaking of ApplyDeltaCommand - where does it actually perform the
> >>> delta operation? perform() simply returns null. Any pointers?
> >>>
> >>> Thanks,
> >> Look for use of ApplyDeltaCommand class in IDE (in Eclipse highlight
> >> class name + right click + References->Workspace)
> >> Current uses I found are in EntryWrappingInterceptor,
> >> OptimisticLockingInterceptor and so on....
> >>
> >> Regards,
> >> Vladimir
> >> _______________________________________________
> >> infinispan-dev mailing list
> >> infinispan-dev(a)lists.jboss.org
> >> https://lists.jboss.org/mailman/listinfo/infinispan-dev
> >
> > --
> > Manik Surtani
> > manik(a)jboss.org
> > twitter.com/maniksurtani
> >
> > Platform Architect, JBoss Data Grid
> > http://red.ht/data-grid
> >
> >
> > _______________________________________________
> > infinispan-dev mailing list
> > infinispan-dev(a)lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
> --
> Manik Surtani
> manik(a)jboss.org
> twitter.com/maniksurtani
>
> Platform Architect, JBoss Data Grid
> http://red.ht/data-grid
>
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
>
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
11:57 a.m.
On 13-01-24 12:52 PM, Randall Hauch wrote:
Actually, it is both, depending upon the situation.
When a new process is started and joins the cluster, the new process
will via state transfer receive its entries as externalized whole
values, not deltas. However, from that point forward, I believe that
all changes to a DeltaAware entry will be sent to other processes in
the cluster via the delta.
This is fairly obvious if you think about it.
Yeah, correct, I believe Randall is
right.
Regards,
Vladimir
5:09 a.m.
Hi Vladimir,
I think Pedro's initial question remained unanswered. Would be good to
clarify this so we can fix the TODO in ApplyDeltaCommand constructor.
Thanks,
Adrian
On 01/24/2013 07:57 PM, Vladimir Blagojevic wrote:
On 13-01-24 12:52 PM, Randall Hauch wrote:
> Actually, it is both, depending upon the situation.
>
> When a new process is started and joins the cluster, the new process
> will via state transfer receive its entries as externalized whole
> values, not deltas. However, from that point forward, I believe that
> all changes to a DeltaAware entry will be sent to other processes in
> the cluster via the delta.
>
> This is fairly obvious if you think about it.
Yeah, correct, I believe Randall is right.
Regards,
Vladimir
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
8:24 a.m.
On 13-01-25 6:09 AM, Adrian Nistor wrote:
Hi Vladimir,
I think Pedro's initial question remained unanswered. Would be good to
clarify this so we can fix the TODO in ApplyDeltaCommand constructor.
Thanks,
Adrian
Adrian&Pedro,
Yes, good catch. It should be passed to super as you noted. But also
note that we then might not need deltaAwareValueKey field and should be
carefully removed, if possible, without affecting codebase.
Regards,
Vladimir
8:20 a.m.
On 13-01-23 2:01 PM, Pedro Ruivo wrote:
Hi all,
I was looking in the ApplyDeltaCommand code and I found something
strange. Why is the method getAffectedKeys() returning a singleton
collection with a null key inside?
Yes, this is a bug. It should return s single key where delta map is stored.
Shouldn't be supposed to return a singleton collection with
deltaAwareValueKey or the keys collection?
It should return deltaAwareKey which is equal to key.
Regards,
Vladimir
Thanks!
Cheers
Pedro Ruivo
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
4672
days inactive
4677
days old
infinispan-dev@lists.jboss.org
12 comments
6 participants
participants (6)
-
Adrian Nistor -
Manik Surtani -
Pedro Ruivo -
Randall Hauch -
Ray Tsang -
Vladimir Blagojevic