[JBoss JIRA] Closed: (JBRULES-208) Improved DSL Organization
by Mark Proctor (JIRA)
[ http://jira.jboss.com/jira/browse/JBRULES-208?page=all ]
Mark Proctor closed JBRULES-208.
--------------------------------
Resolution: Out of Date
> Improved DSL Organization
> -------------------------
>
> Key: JBRULES-208
> URL: http://jira.jboss.com/jira/browse/JBRULES-208
> Project: JBoss Rules
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: Drl Parser/Builder
> Affects Versions: 3.0-beta1
> Reporter: Jeff Brown
> Assigned To: Michael Neale
> Fix For: 4.0.0.MR2
>
> Attachments: DSL-contribs-mahen.zip
>
>
> When using DSL, right now import statements are added to the DRL file. The statements that those import statements affect are in the DSL file. It may make more sense to get the import statements into the file that explicitely uses the classes being imported. As it is right now, if the DSL implementation changes in a way that doesn't change the DSL syntax, the DRL file may still have to be updated just to include new imports. That is an implementation detail that should be transparent to the DRL author.
> To take that a bit further, it may make sense to move the function definitions so the DRL file includes just the expander and the rules. This separation would be cleaner and would probably make more sense from the perspective of the DRL author.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
19 years, 2 months
[JBoss JIRA] Closed: (JBRULES-208) Improved DSL Organization
by Mark Proctor (JIRA)
[ http://jira.jboss.com/jira/browse/JBRULES-208?page=all ]
Mark Proctor closed JBRULES-208.
--------------------------------
Fix Version/s: 4.0.0.MR2
(was: 4.0.0.MR3)
Resolution: Done
> Improved DSL Organization
> -------------------------
>
> Key: JBRULES-208
> URL: http://jira.jboss.com/jira/browse/JBRULES-208
> Project: JBoss Rules
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: Drl Parser/Builder
> Affects Versions: 3.0-beta1
> Reporter: Jeff Brown
> Assigned To: Michael Neale
> Fix For: 4.0.0.MR2
>
> Attachments: DSL-contribs-mahen.zip
>
>
> When using DSL, right now import statements are added to the DRL file. The statements that those import statements affect are in the DSL file. It may make more sense to get the import statements into the file that explicitely uses the classes being imported. As it is right now, if the DSL implementation changes in a way that doesn't change the DSL syntax, the DRL file may still have to be updated just to include new imports. That is an implementation detail that should be transparent to the DRL author.
> To take that a bit further, it may make sense to move the function definitions so the DRL file includes just the expander and the rules. This separation would be cleaner and would probably make more sense from the perspective of the DRL author.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
19 years, 2 months
[JBoss JIRA] Reopened: (JBRULES-208) Improved DSL Organization
by Mark Proctor (JIRA)
[ http://jira.jboss.com/jira/browse/JBRULES-208?page=all ]
Mark Proctor reopened JBRULES-208:
----------------------------------
> Improved DSL Organization
> -------------------------
>
> Key: JBRULES-208
> URL: http://jira.jboss.com/jira/browse/JBRULES-208
> Project: JBoss Rules
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: Drl Parser/Builder
> Affects Versions: 3.0-beta1
> Reporter: Jeff Brown
> Assigned To: Michael Neale
> Fix For: 4.0.0.MR3
>
> Attachments: DSL-contribs-mahen.zip
>
>
> When using DSL, right now import statements are added to the DRL file. The statements that those import statements affect are in the DSL file. It may make more sense to get the import statements into the file that explicitely uses the classes being imported. As it is right now, if the DSL implementation changes in a way that doesn't change the DSL syntax, the DRL file may still have to be updated just to include new imports. That is an implementation detail that should be transparent to the DRL author.
> To take that a bit further, it may make sense to move the function definitions so the DRL file includes just the expander and the rules. This separation would be cleaner and would probably make more sense from the perspective of the DRL author.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
19 years, 2 months
[JBoss JIRA] Created: (JBRULES-837) Collect keyword matches two conflicting rules
by Viktor Nordling (JIRA)
Collect keyword matches two conflicting rules
---------------------------------------------
Key: JBRULES-837
URL: http://jira.jboss.com/jira/browse/JBRULES-837
Project: JBoss Rules
Issue Type: Bug
Security Level: Public (Everyone can see)
Affects Versions: 3.1-m1
Environment: java 1.5
Reporter: Viktor Nordling
Assigned To: Mark Proctor
If you have two rules:
rule "A"
when
$a : ArrayList( size:size == 2 ) from collect (Car())
then
System.out.println("A: size = " + size);
end
rule "B"
when
$b : ArrayList( size:size == 3 ) from collect (Car())
then
System.out.println("B: size = " + size);
end
And you put two Cars in working memory, both A and B will be fired. Since there are two cars in working memory, only rule A should be fired.
If you change the order of the rules, or make rule A match size == 3 and rule B match size == 2, no rules will be fired instead.
The only workaround found is to add some criteria for the Car, in ONE of the rules. If rule A for example is:
rule "A"
when
$a : ArrayList( size:size == 2 ) from collect (Car(color == "RED"))
then
System.out.println("A: size = " + size);
end
Then only rule A will be fired. If the same criteria is also added in rule B, both rules will be fired again.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
19 years, 2 months
[JBoss JIRA] Created: (JBRULES-613) Can't use dollar ($) char in Rule Name with Janino compiler
by Bree VanOss (JIRA)
Can't use dollar ($) char in Rule Name with Janino compiler
-----------------------------------------------------------
Key: JBRULES-613
URL: http://jira.jboss.com/jira/browse/JBRULES-613
Project: JBoss Rules
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Drl Parser/Builder
Affects Versions: 3.0.5
Environment: Verified on WinXP and OS X
Reporter: Bree VanOss
Assigned To: Mark Proctor
Priority: Minor
Essentially it appears that any rule using the U.S. Dollar character ($) in the
rule name fails when compiled with Janino. I was able to reproduce the issue
using the "default" new JBoss-rules project wizard in Eclipse.
The stack trace follows, though it may not be much help. I tried tracking it
down and it looks like the problem is actually caused in the parse/compilation
step (i.e. builder.addPackageFromDrl( source );). After this step the rule in
question has a null "consequence", which causes the
"AbstractRuleBase.addRule(...)" method to fail when it does the isValid() check.
<code>
java.lang.IllegalArgumentException: The rule called Show me da $ is not valid.
Check for compile errors reported.
at org.drools.common.AbstractRuleBase.addRule(Unknown Source)
at org.drools.reteoo.ReteooRuleBase.addRule(Unknown Source)
at org.drools.common.AbstractRuleBase.addPackage(Unknown Source)
at com.sample.DroolsTest.readRule(DroolsTest.java:89)
at com.sample.DroolsTest.main(DroolsTest.java:29)
</code>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
19 years, 2 months