[JBoss JIRA] (ELY-1449) Coverity: Dead local store in DigestUtil.java
by Darran Lofthouse (JIRA)
[ https://issues.jboss.org/browse/ELY-1449?page=com.atlassian.jira.plugin.s... ]
Darran Lofthouse commented on ELY-1449:
---------------------------------------
I think issues like this may be going a step too far unless some verification has been undertaken to confirm this is an actual issue before raising the bug report.
There are PRs in the queue at the moment with various refactorings around the Digest mechanism anyway, ideally as an engineer works on the code their IDE should already be set up to flag situations like this one and if they are working in the code correct it - but I would not really expect someone to proactively divert time to this. Add to that a trivial / unscheduled issue is not like to get attention anyway so we end up with redundant issues that in the end will just need to be cleaned up rather than being actioned.
> Coverity: Dead local store in DigestUtil.java
> ---------------------------------------------
>
> Key: ELY-1449
> URL: https://issues.jboss.org/browse/ELY-1449
> Project: WildFly Elytron
> Issue Type: Bug
> Components: Utils
> Affects Versions: 1.2.0.Beta10
> Reporter: Martin Choma
> Priority: Trivial
>
> In org.wildfly.security.mechanism.digest.DigestUtil.parseResponse(byte[], java.nio.charset.Charset, boolean, org.wildfly.security._private.ElytronMessages): This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction
> https://scan7.coverity.com/reports.htm#v23632/p11778/fileInstanceId=40661...
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 7 months
[JBoss JIRA] (ELY-1449) Coverity: Dead local store in DigestUtil.java
by Martin Choma (JIRA)
Martin Choma created ELY-1449:
---------------------------------
Summary: Coverity: Dead local store in DigestUtil.java
Key: ELY-1449
URL: https://issues.jboss.org/browse/ELY-1449
Project: WildFly Elytron
Issue Type: Bug
Components: Utils
Affects Versions: 1.2.0.Beta10
Reporter: Martin Choma
Priority: Trivial
In org.wildfly.security.mechanism.digest.DigestUtil.parseResponse(byte[], java.nio.charset.Charset, boolean, org.wildfly.security._private.ElytronMessages): This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 7 months
[JBoss JIRA] (ELY-1449) Coverity: Dead local store in DigestUtil.java
by Martin Choma (JIRA)
[ https://issues.jboss.org/browse/ELY-1449?page=com.atlassian.jira.plugin.s... ]
Martin Choma updated ELY-1449:
------------------------------
Description:
In org.wildfly.security.mechanism.digest.DigestUtil.parseResponse(byte[], java.nio.charset.Charset, boolean, org.wildfly.security._private.ElytronMessages): This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction
https://scan7.coverity.com/reports.htm#v23632/p11778/fileInstanceId=40661...
was:
In org.wildfly.security.mechanism.digest.DigestUtil.parseResponse(byte[], java.nio.charset.Charset, boolean, org.wildfly.security._private.ElytronMessages): This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction
> Coverity: Dead local store in DigestUtil.java
> ---------------------------------------------
>
> Key: ELY-1449
> URL: https://issues.jboss.org/browse/ELY-1449
> Project: WildFly Elytron
> Issue Type: Bug
> Components: Utils
> Affects Versions: 1.2.0.Beta10
> Reporter: Martin Choma
> Priority: Trivial
>
> In org.wildfly.security.mechanism.digest.DigestUtil.parseResponse(byte[], java.nio.charset.Charset, boolean, org.wildfly.security._private.ElytronMessages): This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction
> https://scan7.coverity.com/reports.htm#v23632/p11778/fileInstanceId=40661...
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 7 months
[JBoss JIRA] (WFLY-9073) Thread Leak in jboss-client on JMX remoting authentication failure
by Yeray Borges (JIRA)
[ https://issues.jboss.org/browse/WFLY-9073?page=com.atlassian.jira.plugin.... ]
Yeray Borges resolved WFLY-9073.
--------------------------------
Fix Version/s: 11.0.0.Final
Resolution: Done
The issue was solved in Wildfly 11.0.0.Final. In that version, the number of active threads reaches a maximum value and doesn't grow indefinitely.
> Thread Leak in jboss-client on JMX remoting authentication failure
> ------------------------------------------------------------------
>
> Key: WFLY-9073
> URL: https://issues.jboss.org/browse/WFLY-9073
> Project: WildFly
> Issue Type: Bug
> Components: JMX
> Affects Versions: 10.1.0.Final
> Reporter: Piotr Krokowski
> Assignee: Yeray Borges
> Fix For: 11.0.0.Final
>
> Attachments: JbossClientThreadLeakDemo.java, close.png
>
>
> I've observed, that authentication failure, while connecting with jboss-client implementation of JMX remoting (remote+http) causes a thread leak.
> Please find the attached code snippet to reproduce the faulty behavior.
> The attached code produces following output in my case :
> Thread count before starting: 2
> Active threads AFTER start: 2
> Connection failed.
> Active threads AFTER after success: 7
> Connection failed.
> Active threads AFTER after failure: 12
> Possible cause.
> After an initial analisys I've observed that RemotingConnector.internalConnect throws an Exception, while having state set to UNUSED, while I'd actually expect it being set to OPEN, as connection and endpoint fields are already initialized.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 7 months
[JBoss JIRA] (WFLY-9073) Thread Leak in jboss-client on JMX remoting authentication failure
by Yeray Borges (JIRA)
[ https://issues.jboss.org/browse/WFLY-9073?page=com.atlassian.jira.plugin.... ]
Yeray Borges reassigned WFLY-9073:
----------------------------------
Assignee: Yeray Borges
> Thread Leak in jboss-client on JMX remoting authentication failure
> ------------------------------------------------------------------
>
> Key: WFLY-9073
> URL: https://issues.jboss.org/browse/WFLY-9073
> Project: WildFly
> Issue Type: Bug
> Components: JMX
> Affects Versions: 10.1.0.Final
> Reporter: Piotr Krokowski
> Assignee: Yeray Borges
> Attachments: JbossClientThreadLeakDemo.java, close.png
>
>
> I've observed, that authentication failure, while connecting with jboss-client implementation of JMX remoting (remote+http) causes a thread leak.
> Please find the attached code snippet to reproduce the faulty behavior.
> The attached code produces following output in my case :
> Thread count before starting: 2
> Active threads AFTER start: 2
> Connection failed.
> Active threads AFTER after success: 7
> Connection failed.
> Active threads AFTER after failure: 12
> Possible cause.
> After an initial analisys I've observed that RemotingConnector.internalConnect throws an Exception, while having state set to UNUSED, while I'd actually expect it being set to OPEN, as connection and endpoint fields are already initialized.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 7 months